{"thread":{"id":"58852","subject":"[BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","startedAt":"2022-11-24T18:00:00Z","lastAt":"2022-11-24T22:22:28Z","messageCount":6,"participants":["rsbecker@nexbridge.com","Ævar Arnfjörð Bjarmason"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"467948","messageId":"010201d9002e$8e2f9940$aa8ecbc0$@nexbridge.com","threadId":"58852","inReplyTo":null,"subject":"[BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-11-24T17:59:48Z","receivedAt":"2022-11-24T18:00:00Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition\nwhere:\n\n<snip>\n+ test_when_finished rm trace.perf actual\n+ test_config_global trace2.perfBrief 1\n+ pwd\n+ test_config_global trace2.perfTarget\n/home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\ndirectory.t0211-trace2-perf/trace.perf\n+ test-tool trace2 101timer 5 10 3\nfatal: failed to create thread[0]\n\nwas encountered, causing the test to fail. Pointers on resolving this would\nbe helpful.\n\nThanks,\nRandall\n\n--\nBrief whoami: NonStop&UNIX developer since approximately\nUNIX(421664400)\nNonStop(211288444200000000)\n-- In real life, I talk too much.\n\n\n\n"},{"id":"467949","messageId":"221124.86o7swnqc1.gmgdl@evledraar.gmail.com","threadId":"58852","inReplyTo":"010201d9002e$8e2f9940$aa8ecbc0$@nexbridge.com","subject":"Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-11-24T18:40:45Z","receivedAt":"2022-11-24T18:47:38Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\n[CC-ing Jeff, this is from the \"stopwatch timers\" topic]\n\nOn Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n\n> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition\n> where:\n\nDon't you mean t0211-trace2-perf.sh?\n\n> <snip>\n> + test_when_finished rm trace.perf actual\n> + test_config_global trace2.perfBrief 1\n> + pwd\n> + test_config_global trace2.perfTarget\n> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\n> directory.t0211-trace2-perf/trace.perf\n> + test-tool trace2 101timer 5 10 3\n> fatal: failed to create thread[0]\n>\n> was encountered, causing the test to fail. Pointers on resolving this would\n> be helpful.\n\nApparently we really could use a NO_PTHREADS=Y CI setup, because that's\nall that's needed to reproduce this on linux & elsewhere. Running the\ntest with that:\n\t\n\t+ test-tool trace2 101timer 5 10 3\n\tfatal: failed to create thread[0]\n\terror: last command exited with $?=128\n\nFor that all that's needed is this:\n\t\n\tdiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n\tindex 0b3436e8cac..cfba6861322 100755\n\t--- a/t/t0211-trace2-perf.sh\n\t+++ b/t/t0211-trace2-perf.sh\n\t@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n\t \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n\t '\n\t \n\t-test_expect_success 'stopwatch timer test/test2' '\n\t+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n\t \ttest_when_finished \"rm trace.perf actual\" &&\n\t \ttest_config_global trace2.perfBrief 1 &&\n\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n\t@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n\t \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n\t '\n\t \n\t-test_expect_success 'global counter test/test2' '\n\t+test_expect_success PTHREADS 'global counter test/test2' '\n\t \ttest_when_finished \"rm trace.perf actual\" &&\n\t \ttest_config_global trace2.perfBrief 1 &&\n\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n\nI think that's the correct fix here, and it should go into rc1.\n"},{"id":"467950","messageId":"010c01d90039$938568b0$ba903a10$@nexbridge.com","threadId":"58852","inReplyTo":"221124.86o7swnqc1.gmgdl@evledraar.gmail.com","subject":"RE: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-11-24T19:18:41Z","receivedAt":"2022-11-24T19:18:55Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On November 24, 2022 1:41 PM, Ævar Arnfjörð Bjarmason wrote:\n>[CC-ing Jeff, this is from the \"stopwatch timers\" topic]\n>\n>On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n>\n>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a\n>> condition\n>> where:\n>\n>Don't you mean t0211-trace2-perf.sh?\n>\n>> <snip>\n>> + test_when_finished rm trace.perf actual test_config_global\n>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget\n>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\n>> directory.t0211-trace2-perf/trace.perf\n>> + test-tool trace2 101timer 5 10 3\n>> fatal: failed to create thread[0]\n>>\n>> was encountered, causing the test to fail. Pointers on resolving this\n>> would be helpful.\n>\n>Apparently we really could use a NO_PTHREADS=Y CI setup, because that's all\n>that's needed to reproduce this on linux & elsewhere. Running the test with that:\n>\n>\t+ test-tool trace2 101timer 5 10 3\n>\tfatal: failed to create thread[0]\n>\terror: last command exited with $?=128\n>\n>For that all that's needed is this:\n>\n>\tdiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n>\tindex 0b3436e8cac..cfba6861322 100755\n>\t--- a/t/t0211-trace2-perf.sh\n>\t+++ b/t/t0211-trace2-perf.sh\n>\t@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n>\t \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n>\t '\n>\n>\t-test_expect_success 'stopwatch timer test/test2' '\n>\t+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n>\t \ttest_when_finished \"rm trace.perf actual\" &&\n>\t \ttest_config_global trace2.perfBrief 1 &&\n>\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>\t@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n>\t \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n>\t '\n>\n>\t-test_expect_success 'global counter test/test2' '\n>\t+test_expect_success PTHREADS 'global counter test/test2' '\n>\t \ttest_when_finished \"rm trace.perf actual\" &&\n>\t \ttest_config_global trace2.perfBrief 1 &&\n>\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>\n>I think that's the correct fix here, and it should go into rc1.\n\nI assume we do not have to modify the platform's entry in config.mak.uname, which already has NO_PTHREADS=UnfortunatelyYes.\n\nThanks,\nRandall\n\n"},{"id":"467955","messageId":"221124.86fse8nig6.gmgdl@evledraar.gmail.com","threadId":"58852","inReplyTo":"010c01d90039$938568b0$ba903a10$@nexbridge.com","subject":"Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-11-24T21:35:49Z","receivedAt":"2022-11-24T21:36:32Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n\n> On November 24, 2022 1:41 PM, Ævar Arnfjörð Bjarmason wrote:\n>>[CC-ing Jeff, this is from the \"stopwatch timers\" topic]\n>>\n>>On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n>>\n>>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a\n>>> condition\n>>> where:\n>>\n>>Don't you mean t0211-trace2-perf.sh?\n>>\n>>> <snip>\n>>> + test_when_finished rm trace.perf actual test_config_global\n>>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget\n>>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\n>>> directory.t0211-trace2-perf/trace.perf\n>>> + test-tool trace2 101timer 5 10 3\n>>> fatal: failed to create thread[0]\n>>>\n>>> was encountered, causing the test to fail. Pointers on resolving this\n>>> would be helpful.\n>>\n>>Apparently we really could use a NO_PTHREADS=Y CI setup, because that's all\n>>that's needed to reproduce this on linux & elsewhere. Running the test with that:\n>>\n>>\t+ test-tool trace2 101timer 5 10 3\n>>\tfatal: failed to create thread[0]\n>>\terror: last command exited with $?=128\n>>\n>>For that all that's needed is this:\n>>\n>>\tdiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n>>\tindex 0b3436e8cac..cfba6861322 100755\n>>\t--- a/t/t0211-trace2-perf.sh\n>>\t+++ b/t/t0211-trace2-perf.sh\n>>\t@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n>>\t \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n>>\t '\n>>\n>>\t-test_expect_success 'stopwatch timer test/test2' '\n>>\t+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n>>\t \ttest_when_finished \"rm trace.perf actual\" &&\n>>\t \ttest_config_global trace2.perfBrief 1 &&\n>>\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>>\t@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n>>\t \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n>>\t '\n>>\n>>\t-test_expect_success 'global counter test/test2' '\n>>\t+test_expect_success PTHREADS 'global counter test/test2' '\n>>\t \ttest_when_finished \"rm trace.perf actual\" &&\n>>\t \ttest_config_global trace2.perfBrief 1 &&\n>>\t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>>\n>>I think that's the correct fix here, and it should go into rc1.\n>\n> I assume we do not have to modify the platform's entry in config.mak.uname, which already has NO_PTHREADS=UnfortunatelyYes.\n\nYes, that's the part where you declare that the platform doesn't have\nthreading, this is where the tests are then guarded using that setting.\n"},{"id":"467957","messageId":"221124.86bkownhqd.gmgdl@evledraar.gmail.com","threadId":"58852","inReplyTo":"221124.86o7swnqc1.gmgdl@evledraar.gmail.com","subject":"Re: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-11-24T21:51:17Z","receivedAt":"2022-11-24T21:52:08Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Thu, Nov 24 2022, Ævar Arnfjörð Bjarmason wrote:\n\n> [CC-ing Jeff, this is from the \"stopwatch timers\" topic]\n>\n> On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n>\n>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a condition\n>> where:\n>\n> Don't you mean t0211-trace2-perf.sh?\n>\n>> <snip>\n>> + test_when_finished rm trace.perf actual\n>> + test_config_global trace2.perfBrief 1\n>> + pwd\n>> + test_config_global trace2.perfTarget\n>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\n>> directory.t0211-trace2-perf/trace.perf\n>> + test-tool trace2 101timer 5 10 3\n>> fatal: failed to create thread[0]\n>>\n>> was encountered, causing the test to fail. Pointers on resolving this would\n>> be helpful.\n>\n> Apparently we really could use a NO_PTHREADS=Y CI setup, because that's\n> all that's needed to reproduce this on linux & elsewhere. Running the\n> test with that:\n> \t\n> \t+ test-tool trace2 101timer 5 10 3\n> \tfatal: failed to create thread[0]\n> \terror: last command exited with $?=128\n>\n> For that all that's needed is this:\n> \t\n> \tdiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n> \tindex 0b3436e8cac..cfba6861322 100755\n> \t--- a/t/t0211-trace2-perf.sh\n> \t+++ b/t/t0211-trace2-perf.sh\n> \t@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n> \t \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n> \t '\n> \t \n> \t-test_expect_success 'stopwatch timer test/test2' '\n> \t+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n> \t \ttest_when_finished \"rm trace.perf actual\" &&\n> \t \ttest_config_global trace2.perfBrief 1 &&\n> \t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n> \t@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n> \t \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n> \t '\n> \t \n> \t-test_expect_success 'global counter test/test2' '\n> \t+test_expect_success PTHREADS 'global counter test/test2' '\n> \t \ttest_when_finished \"rm trace.perf actual\" &&\n> \t \ttest_config_global trace2.perfBrief 1 &&\n> \t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>\n> I think that's the correct fix here, and it should go into rc1.\n\nI submitted a fix at\nhttps://lore.kernel.org/git/patch-1.1-f7f21c94a6c-20221124T214813Z-avarab@gmail.com/;\nbut I see that since your message-id's contain \"$\" I got the In-Reply-To\nwrong, sorry :)\n"},{"id":"467958","messageId":"011c01d90053$38e50900$aaaf1b00$@nexbridge.com","threadId":"58852","inReplyTo":"221124.86bkownhqd.gmgdl@evledraar.gmail.com","subject":"RE: [BUG} t2201.7+ Failure to Create Thread in 2.39.0-rc0","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-11-24T22:22:16Z","receivedAt":"2022-11-24T22:22:28Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On November 24, 2022 4:51 PM, Ævar Arnfjörð Bjarmason wrote:\n>On Thu, Nov 24 2022, Ævar Arnfjörð Bjarmason wrote:\n>\n>> [CC-ing Jeff, this is from the \"stopwatch timers\" topic]\n>>\n>> On Thu, Nov 24 2022, rsbecker@nexbridge.com wrote:\n>>\n>>> While running t2201.7 (and subsequent) for 2.39.0-rc0, I hit a\n>>> condition\n>>> where:\n>>\n>> Don't you mean t0211-trace2-perf.sh?\n>>\n>>> <snip>\n>>> + test_when_finished rm trace.perf actual test_config_global\n>>> + trace2.perfBrief 1 pwd test_config_global trace2.perfTarget\n>>> /home/ituglib/randall/jenkins/.jenkins/workspace/Git_Pipeline/t/trash\n>>> directory.t0211-trace2-perf/trace.perf\n>>> + test-tool trace2 101timer 5 10 3\n>>> fatal: failed to create thread[0]\n>>>\n>>> was encountered, causing the test to fail. Pointers on resolving this\n>>> would be helpful.\n>>\n>> Apparently we really could use a NO_PTHREADS=Y CI setup, because\n>> that's all that's needed to reproduce this on linux & elsewhere.\n>> Running the test with that:\n>>\n>> \t+ test-tool trace2 101timer 5 10 3\n>> \tfatal: failed to create thread[0]\n>> \terror: last command exited with $?=128\n>>\n>> For that all that's needed is this:\n>>\n>> \tdiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n>> \tindex 0b3436e8cac..cfba6861322 100755\n>> \t--- a/t/t0211-trace2-perf.sh\n>> \t+++ b/t/t0211-trace2-perf.sh\n>> \t@@ -203,7 +203,7 @@ test_expect_success 'stopwatch timer test/test1' '\n>> \t \thave_timer_event \"main\" \"timer\" \"test\" \"test1\" 5 actual\n>> \t '\n>>\n>> \t-test_expect_success 'stopwatch timer test/test2' '\n>> \t+test_expect_success PTHREADS 'stopwatch timer test/test2' '\n>> \t \ttest_when_finished \"rm trace.perf actual\" &&\n>> \t \ttest_config_global trace2.perfBrief 1 &&\n>> \t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>> \t@@ -249,7 +249,7 @@ test_expect_success 'global counter test/test1' '\n>> \t \thave_counter_event \"main\" \"counter\" \"test\" \"test1\" 15 actual\n>> \t '\n>>\n>> \t-test_expect_success 'global counter test/test2' '\n>> \t+test_expect_success PTHREADS 'global counter test/test2' '\n>> \t \ttest_when_finished \"rm trace.perf actual\" &&\n>> \t \ttest_config_global trace2.perfBrief 1 &&\n>> \t \ttest_config_global trace2.perfTarget \"$(pwd)/trace.perf\" &&\n>>\n>> I think that's the correct fix here, and it should go into rc1.\n>\n>I submitted a fix at\n>https://lore.kernel.org/git/patch-1.1-f7f21c94a6c-20221124T214813Z-\n>avarab@gmail.com/;\n>but I see that since your message-id's contain \"$\" I got the In-Reply-To wrong,\n>sorry :)\n\nThanks\n\n\n"}]}