{"thread":{"id":"58824","subject":"[PATCH] list-objects-filter: plug combine_filter_data leak","startedAt":"2022-11-20T11:01:04Z","lastAt":"2022-11-20T11:01:04Z","messageCount":1,"participants":["René Scharfe"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"467617","messageId":"bc25ac8c-ce9a-2385-be0d-0c72798d319d@web.de","threadId":"58824","inReplyTo":null,"subject":"[PATCH] list-objects-filter: plug combine_filter_data leak","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2022-11-20T11:00:52Z","receivedAt":"2022-11-20T11:01:04Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"filter_combine__init() allocates a struct combine_filter_data object and\nassigns it to the filter_data member of struct filter_options.  Release\nit in the complementing filter_combine__free().\n\nReported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\nSigned-off-by: René Scharfe <l.s.r@web.de>\n---\nReported in https://lore.kernel.org/git/221112.86bkpcmm6i.gmgdl@evledraar.gmail.com/\n\n list-objects-filter.c | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/list-objects-filter.c b/list-objects-filter.c\nindex 1c1ee3d1bb..b9543545ca 100644\n--- a/list-objects-filter.c\n+++ b/list-objects-filter.c\n@@ -709,6 +709,7 @@ static void filter_combine__free(void *filter_data)\n \t\t\tBUG(\"expected oidset to be cleared already\");\n \t}\n \tfree(d->sub);\n+\tfree(d);\n }\n\n static void add_all(struct oidset *dest, struct oidset *src) {\n--\n2.38.1\n"}]}