{"thread":{"id":"5881","subject":"[PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2","startedAt":"2006-10-11T02:09:03Z","lastAt":"2006-10-11T07:21:26Z","messageCount":3,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28574","messageId":"20061011020903.63831.qmail@web31812.mail.mud.yahoo.com","threadId":"5881","inReplyTo":null,"subject":"[PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-11T02:09:03Z","receivedAt":"2006-10-11T02:09:03Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Commit eeef88cd2 introduced $group_size which\ninverted the meaning of $current_color.\n\nNormally we start with white (same as background) color\nfor the zebra coloring, and flip to dark shade only when\nanother commit changed some lines of the file.  (Thus\nif there are no changes, the file appears black on white.)\n\nSigned-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 173f521..77063f0 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2583,7 +2583,7 @@ sub git_blame2 {\n \tgit_print_page_path($file_name, $ftype, $hash_base);\n \tmy @rev_color = (qw(light2 dark2));\n \tmy $num_colors = scalar(@rev_color);\n-\tmy $current_color = 0;\n+\tmy $current_color = 1;\n \tmy $last_rev;\n \tprint <<HTML;\n <div class=\"page_body\">\n-- \n1.4.3.rc2.gd2a59\n"},{"id":"28576","messageId":"7vk637xxxr.fsf@assigned-by-dhcp.cox.net","threadId":"5881","inReplyTo":"20061011020903.63831.qmail@web31812.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-11T04:45:36Z","receivedAt":"2006-10-11T04:45:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> Commit eeef88cd2 introduced $group_size which\n> inverted the meaning of $current_color.\n>\n> Normally we start with white (same as background) color\n> for the zebra coloring, and flip to dark shade only when\n> another commit changed some lines of the file.  (Thus\n> if there are no changes, the file appears black on white.)\n\nI do not have much preference either way, but it was done more\nor less deliberately to match what you did with 6dd36ac.\n"},{"id":"28580","messageId":"20061011072126.12959.qmail@web31805.mail.mud.yahoo.com","threadId":"5881","inReplyTo":"7vk637xxxr.fsf@assigned-by-dhcp.cox.net","subject":"Re: [PATCH] gitweb: Fix zebra coloring flip introduced by eeef88cd2","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-11T07:21:26Z","receivedAt":"2006-10-11T07:21:26Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Junio C Hamano <junkio@cox.net> wrote:\n> I do not have much preference either way, but it was done more\n> or less deliberately to match what you did with 6dd36ac.\n\nSorry, I didn't mean to introduce the apparent inconsisteny.\nThe 6dd36ac touches alternate \"active\" shading, and blame\nonly shows the contents, albeit with the commit-8 and block\ncoloring.\n\n    Luben\n"}]}