{"thread":{"id":"58801","subject":"[PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","startedAt":"2022-11-15T09:32:51Z","lastAt":"2022-11-16T20:14:31Z","messageCount":5,"participants":["Ævar Arnfjörð Bjarmason","Jeff King","Taylor Blau","Đoàn Trần Công Danh"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"467303","messageId":"patch-1.1-7be23b6faa0-20221115T093130Z-avarab@gmail.com","threadId":"58801","inReplyTo":null,"subject":"[PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-11-15T09:32:42Z","receivedAt":"2022-11-15T09:32:51Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,\n2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to\nimplement the \"bisect\" command. Let's remove the unused leftover\nscript, and the \".gitignore\" entry for the \"git-bisect--helper\", which\nalso hasn't been built since fc304fb52f9.\n\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\nThis goes on top of \"dd/git-bisect-builtin\", which just landed in\n\"next\".\n\n .gitignore    |  1 -\n git-bisect.sh | 63 ---------------------------------------------------\n 2 files changed, 64 deletions(-)\n delete mode 100755 git-bisect.sh\n\ndiff --git a/.gitignore b/.gitignore\nindex cb0231fb401..fe234cfa19a 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -20,7 +20,6 @@\n /git-archimport\n /git-archive\n /git-bisect\n-/git-bisect--helper\n /git-blame\n /git-branch\n /git-bugreport\ndiff --git a/git-bisect.sh b/git-bisect.sh\ndeleted file mode 100755\nindex f95b8103a9e..00000000000\n--- a/git-bisect.sh\n+++ /dev/null\n@@ -1,63 +0,0 @@\n-#!/bin/sh\n-\n-USAGE='[help|start|bad|good|new|old|terms|skip|next|reset|visualize|view|replay|log|run]'\n-LONG_USAGE='git bisect help\n-\tprint this long help message.\n-git bisect start [--term-{new,bad}=<term> --term-{old,good}=<term>]\n-\t\t [--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<pathspec>...]\n-\treset bisect state and start bisection.\n-git bisect (bad|new) [<rev>]\n-\tmark <rev> a known-bad revision/\n-\t\ta revision after change in a given property.\n-git bisect (good|old) [<rev>...]\n-\tmark <rev>... known-good revisions/\n-\t\trevisions before change in a given property.\n-git bisect terms [--term-good | --term-bad]\n-\tshow the terms used for old and new commits (default: bad, good)\n-git bisect skip [(<rev>|<range>)...]\n-\tmark <rev>... untestable revisions.\n-git bisect next\n-\tfind next bisection to test and check it out.\n-git bisect reset [<commit>]\n-\tfinish bisection search and go back to commit.\n-git bisect (visualize|view)\n-\tshow bisect status in gitk.\n-git bisect replay <logfile>\n-\treplay bisection log.\n-git bisect log\n-\tshow bisect log.\n-git bisect run <cmd>...\n-\tuse <cmd>... to automatically bisect.\n-\n-Please use \"git help bisect\" to get the full man page.'\n-\n-OPTIONS_SPEC=\n-. git-sh-setup\n-\n-TERM_BAD=bad\n-TERM_GOOD=good\n-\n-get_terms () {\n-\tif test -s \"$GIT_DIR/BISECT_TERMS\"\n-\tthen\n-\t\t{\n-\t\tread TERM_BAD\n-\t\tread TERM_GOOD\n-\t\t} <\"$GIT_DIR/BISECT_TERMS\"\n-\tfi\n-}\n-\n-case \"$#\" in\n-0)\n-\tusage ;;\n-*)\n-\tcmd=\"$1\"\n-\tget_terms\n-\tshift\n-\tcase \"$cmd\" in\n-\thelp)\n-\t\tgit bisect -h ;;\n-\t*)\n-\t\tgit bisect--helper \"$cmd\" \"$@\" ;;\n-\tesac\n-esac\n-- \n2.38.0.1473.g172bcc0511c\n\n"},{"id":"467315","messageId":"Y3PHOpIqMC9ZT4pg@coredump.intra.peff.net","threadId":"58801","inReplyTo":"patch-1.1-7be23b6faa0-20221115T093130Z-avarab@gmail.com","subject":"Re: [PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2022-11-15T17:07:06Z","receivedAt":"2022-11-15T17:07:14Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote:\n\n> Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,\n> 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to\n> implement the \"bisect\" command. Let's remove the unused leftover\n> script, and the \".gitignore\" entry for the \"git-bisect--helper\", which\n> also hasn't been built since fc304fb52f9.\n\nA small nit, but it's probably not a good idea to refer to merge commits\nfrom 'next'. They may be meaningful now, but they aren't part of the\nlong-term history, and will get gc'd eventually when Junio rewinds next\nafter a release. Which will leave this reference useless for people\nlooking at \"git log\" a year from now.\n\nA better reference is probably 73fce29427 (Turn `git bisect` into a full\nbuilt-in, 2022-11-10), which will remain stable as it gets merged\neventually into master.\n\n>  .gitignore    |  1 -\n>  git-bisect.sh | 63 ---------------------------------------------------\n\nThe patch itself looks like an obviously correct thing to do.\n\n-Peff\n"},{"id":"467334","messageId":"Y3PrCX7W7gL1Z0CI@nand.local","threadId":"58801","inReplyTo":"Y3PHOpIqMC9ZT4pg@coredump.intra.peff.net","subject":"Re: [PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-15T19:39:53Z","receivedAt":"2022-11-15T19:40:01Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 12:07:06PM -0500, Jeff King wrote:\n> On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote:\n>\n> > Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,\n> > 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to\n> > implement the \"bisect\" command. Let's remove the unused leftover\n> > script, and the \".gitignore\" entry for the \"git-bisect--helper\", which\n> > also hasn't been built since fc304fb52f9.\n>\n> A small nit, but it's probably not a good idea to refer to merge commits\n> from 'next'. They may be meaningful now, but they aren't part of the\n> long-term history, and will get gc'd eventually when Junio rewinds next\n> after a release. Which will leave this reference useless for people\n> looking at \"git log\" a year from now.\n>\n> A better reference is probably 73fce29427 (Turn `git bisect` into a full\n> built-in, 2022-11-10), which will remain stable as it gets merged\n> eventually into master.\n\nThanks, I updated the reference to point at 73fce29427 while queueing.\n\nAs an aside, I am a little disappointed by the quality of what has\nrecently been hitting 'next'. There was no chance for me to find the\nissues with t7610 without a Windows machine, but this should have been\ncaught during testing.\n\nThanks,\nTaylor\n"},{"id":"467370","messageId":"Y3T5PQmrIHrV9m46@danh.dev","threadId":"58801","inReplyTo":"patch-1.1-7be23b6faa0-20221115T093130Z-avarab@gmail.com","subject":"Re: [PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","fromName":"Đoàn Trần Công Danh","fromEmail":"congdanhqx@gmail.com","sentAt":"2022-11-16T14:52:45Z","receivedAt":"2022-11-16T14:54:02Z","isPatch":true,"sender":{"key":"congdanhqx@gmail.com","avatar":"https://avatars.githubusercontent.com/u/42673067?v=4"},"body":"On 2022-11-15 10:32:42+0100, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:\n> Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,\n> 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to\n> implement the \"bisect\" command. Let's remove the unused leftover\n> script, and the \".gitignore\" entry for the \"git-bisect--helper\", which\n> also hasn't been built since fc304fb52f9.\n> \n> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> ---\n> This goes on top of \"dd/git-bisect-builtin\", which just landed in\n> \"next\".\n\nAck,\nSorry, I forgot to remove it :(\nOther than the reference for commit, looking good.\n\n-- \nDanh\n"},{"id":"467392","messageId":"Y3VEoWSH0PihWI8l@nand.local","threadId":"58801","inReplyTo":"Y3T5PQmrIHrV9m46@danh.dev","subject":"Re: [PATCH] bisect; remove unused \"git-bisect.sh\" and \".gitignore\" entry","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-16T20:14:25Z","receivedAt":"2022-11-16T20:14:31Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Nov 16, 2022 at 09:52:45PM +0700, Đoàn Trần Công Danh wrote:\n> On 2022-11-15 10:32:42+0100, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:\n> > Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next,\n> > 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to\n> > implement the \"bisect\" command. Let's remove the unused leftover\n> > script, and the \".gitignore\" entry for the \"git-bisect--helper\", which\n> > also hasn't been built since fc304fb52f9.\n> >\n> > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n> > ---\n> > This goes on top of \"dd/git-bisect-builtin\", which just landed in\n> > \"next\".\n>\n> Ack,\n> Sorry, I forgot to remove it :(\n> Other than the reference for commit, looking good.\n\nThanks for the ACK.\n\nThanks,\nTaylor\n"}]}