{"thread":{"id":"58799","subject":"What's cooking in git.git (Nov 2022, #03; Mon, 14)","startedAt":"2022-11-15T04:50:30Z","lastAt":"2022-11-18T23:52:39Z","messageCount":17,"participants":["Taylor Blau","Eric Sunshine","Patrick Steinhardt","Ævar Arnfjörð Bjarmason","Johannes Schindelin","Jeff King","Elijah Newren","Strawbridge, Michael","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"467296","messageId":"Y3Mag8qG2D3qjlmg@nand.local","threadId":"58799","inReplyTo":null,"subject":"What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-15T04:50:11Z","receivedAt":"2022-11-15T04:50:30Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Here are the topics that have been cooking in my tree. Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a future\nrelease). Commits prefixed with '-' are only in 'seen', and aren't\nconsidered \"accepted\" at all. A topic without enough support may be\ndiscarded after a long period of no activity.\n\nThere are still a large-ish number of topics in 'seen' that are\nwaiting for review. Otherwise, the remaining topics are graduating at\na reasonable pace, and the queue for 'next' has returned to a normal\nlevel.\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors. Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\thttps://github.com/git/git/\n\nThe following mirrors are currently out-of-date while the usual\nmaintainer is offline.\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://gitlab.com/git-vcs/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/ttaylorr/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are typically published in these repositories\nfor convenience (replace \"htmldocs\" with \"manpages\" for the manual\n pages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\n...but these and the release tarballs below are similarly out-of-date:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* ab/rev-info-init (2022-11-08) 1 commit\n (merged to 'next' on 2022-11-08 at 909ad9ed3a)\n + revisions API: extend the nascent REV_INFO_INIT macro\n\n Progress on being able to initialize a rev_info struct with a macro.\n source: \n\n\n* al/trace2-clearing-skip-worktree (2022-11-04) 2 commits\n (merged to 'next' on 2022-11-08 at 567aeb8d83)\n + index: raise a bug if the index is materialised more than once\n + index: add trace2 region for clear skip worktree\n\n Add trace2 counters to the region to clear skip worktree bits in a\n sparse checkout.\n source: \n\n\n* do/modernize-t7001 (2022-11-04) 1 commit\n (merged to 'next' on 2022-11-08 at dfc9c80e73)\n + t7001-mv.sh: modernizing test script using functions\n\n Modernize test script to avoid \"test -f\" and friends.\n source: \n\n\n* js/ci-set-output (2022-11-08) 1 commit\n (merged to 'next' on 2022-11-08 at 553062428c)\n + ci: use a newer `github-script` version\n\n Update the actions/github-script dependency in CI to avoid a\n deprecation warning.\n source: \n\n\n* mh/password-can-be-pat (2022-11-08) 1 commit\n (merged to 'next' on 2022-11-08 at 3135ade2a6)\n + Documentation/gitcredentials.txt: mention password alternatives\n\n Documentation update to git-credential(1).\n source: \n\n--------------------------------------------------\n[New Topics]\n\n* ab/remove--super-prefix (2022-11-14) 12 commits\n - fetch: rename \"--submodule-prefix\" to \"--super-prefix\"\n - read-tree: add \"--super-prefix\" option, eliminate global\n - submodule tests: test \"git branch -t\" output and stderr\n - submodule--helper: convert \"{update,clone}\" to their own \"--super-prefix\"\n - submodule--helper: convert \"status\" to its own \"--super-prefix\"\n - submodule--helper: convert \"sync\" to its own \"--super-prefix\"\n - submodule--helper: convert \"foreach\" to its own \"--super-prefix\"\n - submodule--helper: \"deinit\" has never used \"--super-prefix\"\n - submodule--helper: don't use global --super-prefix in \"absorbgitdirs\"\n - read-tree + fetch tests: test failing \"--super-prefix\" interaction\n - Merge branch 'ab/submodule-no-abspath' into ab/remove--super-prefix\n - Merge branch 'ab/submodule-helper-prep-only' into ab/remove--super-prefix\n (this branch uses ab/submodule-helper-prep-only and ab/submodule-no-abspath.)\n\n Remove the top-level `--super-prefix` option.\n\n Expecting a reroll?\n source: \n\n\n* ab/submodule-no-abspath (2022-11-09) 1 commit\n - submodule--helper absorbgitdirs: no abspaths in \"Migrating git...\"\n (this branch is used by ab/remove--super-prefix.)\n\n Remove an absolute path in the \"Migrating git directory\" message.\n\n Will merge to 'next'.\n source: \n\n\n* ab/t7610-timeout (2022-11-09) 1 commit\n (merged to 'next' on 2022-11-14 at 82a4abdb1d)\n + t7610: fix flaky timeout issue, don't clone from example.com\n\n Fix a source of flakiness in CI when compiling with SANITIZE=leak.\n\n Will cook in 'next'.\n source: \n\n\n* es/chainlint-lineno (2022-11-11) 4 commits\n - chainlint: prefix annotated test definition with line numbers\n - chainlint: latch line numbers at which each token starts and ends\n - chainlint: sidestep impoverished macOS \"terminfo\"\n - Merge branch 'es/chainlint-output' into es/chainlint-lineno\n (this branch uses es/chainlint-output.)\n\n Teach chainlint.pl to annotate the original test definition instead\n of the token stream.\n\n Will merge to 'next'.\n source: \n\n\n* ew/format-patch-mboxrd (2022-11-14) 1 commit\n - format-patch: add --mboxrd alias for --pretty=mboxrd\n\n Teach `format-patch` a convenient alias for `--pretty=mboxrd`.\n\n Waiting for discussion to settle.\n source: <20221114094114.18986-1-e@80x24.org>\n\n\n* gc/redact-h2h3-headers (2022-11-14) 2 commits\n (merged to 'next' on 2022-11-14 at 34157d24e9)\n + http: redact curl h2h3 headers in info\n + t: run t5551 tests with both HTTP and HTTP/2\n\n Redact headers from cURL's h2h3 module in GIT_CURL_VERBOSE and\n others.\n\n Will merge to 'master'.\n source: \n\n\n* jk/branch-delete-detached (2022-11-10) 1 commit\n (merged to 'next' on 2022-11-14 at b185797ec0)\n + branch: gracefully handle '-d' on orphan HEAD\n\n Fix a bug where `git branch -d` did not work on an orphaned HEAD.\n source: \n\n\n* js/drop-mingw-test-cmp (2022-11-14) 2 commits\n - tests(mingw): avoid very slow `mingw_test_cmp`\n - t0021: use Windows-friendly `pwd`\n\n Use `git diff --no-index` as a test_cmp on Windows.\n\n Expecting a reroll.\n source: \n\n\n* mc/switch-advice (2022-11-09) 1 commit\n - po: use `switch` over `checkout` in error message\n\n Use 'switch' instead of 'checkout' in an error message.\n\n Waiting for review response.\n source: \n\n\n* mh/credential-unrecognized-attrs (2022-11-12) 1 commit\n (merged to 'next' on 2022-11-14 at 8170443d0a)\n + docs: clarify that credential discards unrecognised attributes\n\n Docfix.\n\n Will merge to 'master'.\n source: \n\n\n* mh/gitcredentials-generate (2022-11-14) 1 commit\n - Docs: describe how a credential-generating helper works\n\n Doc update.\n\n Waiting for review.\n source: \n\n\n* mh/increase-credential-cache-timeout (2022-11-09) 1 commit\n (merged to 'next' on 2022-11-14 at afe54db0f1)\n + Documentation: increase example cache timeout to 1 hour\n\n Update the credential-cache documentation to provide a more realistic\n example.\n\n Will merge to 'master'.\n source: \n\n\n* ms/sendemail-validate-headers (2022-11-11) 1 commit\n - Expose header information to git-send-email's sendemail-validate hook\n\n Expecting a reroll.\n source: <20221111194223.644845-2-michael.strawbridge@amd.com>\n\n\n* pw/strict-label-lookups (2022-11-10) 2 commits\n (merged to 'next' on 2022-11-14 at 7db4398d23)\n + sequencer: tighten label lookups\n + sequencer: unify label lookup\n\n Correct an error where `git rebase` would mistakenly use a branch or\n tag named \"refs/rewritten/xyz\" when missing a rebase label.\n\n Will cook in 'next'.\n source: \n\n\n* rs/multi-filter-args (2022-11-12) 3 commits\n - list-objects-filter: remove OPT_PARSE_LIST_OBJECTS_FILTER_INIT()\n - pack-object: simplify --filter handling\n - pack-objects: fix handling of multiple --filter options\n\n Fix a bug where `pack-objects` would not respect multiple `--filter`\n arguments when invoked directly.\n\n Expecting a reroll?\n source: \n\n\n* vd/skip-cache-tree-update (2022-11-10) 5 commits\n (merged to 'next' on 2022-11-14 at 06b2da01ff)\n + rebase: use 'skip_cache_tree_update' option\n + read-tree: use 'skip_cache_tree_update' option\n + reset: use 'skip_cache_tree_update' option\n + unpack-trees: add 'skip_cache_tree_update' option\n + cache-tree: add perf test comparing update and prime\n\n Avoid calling 'cache_tree_update()' when doing so would be redundant.\n\n Will merge to 'master'.\n source: \n\n--------------------------------------------------\n[Stalled]\n\n* cw/submodule-status-in-parallel (2022-11-08) 6 commits\n - diff-lib: parallelize run_diff_files for submodules\n - diff-lib: refactor match_stat_with_submodule\n - submodule: move status parsing into function\n - submodule: strbuf variable rename\n - run-command: add duplicate_output_fn to run_processes_parallel_opts\n - Merge branch 'ab/run-hook-api-cleanup' into cw/submodule-status-in-parallel\n\n Allow the internal \"diff-files\" engine to run \"how has this\n submodule changed?\" in parallel to speed up \"git status\".\n\n Waiting for review.\n source: <20221020232532.1128326-1-calvinwan@google.com>\n\n\n* js/bisect-in-c (2022-08-30) 17 commits\n . bisect: no longer try to clean up left-over `.git/head-name` files\n . bisect: remove Cogito-related code\n . Turn `git bisect` into a full built-in\n . bisect: move even the command-line parsing to `bisect--helper`\n . bisect--helper: make `state` optional\n . bisect--helper: calling `bisect_state()` without an argument is a bug\n . bisect: avoid double-quoting when printing the failed command\n . bisect run: fix the error message\n . bisect: verify that a bogus option won't try to start a bisection\n . bisect--helper: migrate to OPT_SUBCOMMAND()\n . bisect--helper: make the order consistently `argc, argv`\n . bisect--helper: make `terms` an explicit singleton\n . bisect--helper: simplify exit code computation\n . bisect--helper: really retire `--bisect-autostart`\n . bisect--helper: really retire --bisect-next-check\n . bisect--helper: retire the --no-log option\n . Merge branch 'sg/parse-options-subcommand' into js/bisect-in-c\n\n Final bits of \"git bisect.sh\" have been rewritten in C.\n\n Needs review.\n cf. \n source: \n\n\n* od/ci-use-checkout-v3-when-applicable (2022-10-10) 2 commits\n . ci(main): linux32 uses actions/checkout@v2\n . ci(main): upgrade actions/checkout to v3\n\n Attempt to update GitHub CI to use actions/checkout@v3\n\n Expecting a reroll.\n Seems to break the CI completely.\n source: \n\n\n* ed/fsmonitor-inotify (2022-10-14) 7 commits\n . fsmonitor: update doc for Linux\n . fsmonitor: test updates\n . fsmonitor: enable fsmonitor for Linux\n . fsmonitor: implement filesystem change listener for Linux\n . fsmonitor: determine if filesystem is local or remote\n . fsmonitor: prepare to share code between Mac OS and Linux\n . Merge branch 'ed/fsmonitor-on-networked-macos' into ed/fsmonitor-inotify\n\n Bundled fsmonitor for Linux using inotify API.\n\n Needs review.\n Occasional breakages of t7527.16?\n source: \n\n\n* ag/merge-strategies-in-c (2022-08-10) 14 commits\n . sequencer: use the \"octopus\" strategy without forking\n . sequencer: use the \"resolve\" strategy without forking\n . merge: use the \"octopus\" strategy without forking\n . merge: use the \"resolve\" strategy without forking\n . merge-octopus: rewrite in C\n . merge-recursive: move better_branch_name() to merge.c\n . merge-resolve: rewrite in C\n . merge-one-file: rewrite in C\n . update-index: move add_cacheinfo() to read-cache.c\n . merge-index: add a new way to invoke `git-merge-one-file'\n . merge-index: drop the index\n . merge-index: libify merge_one_path() and merge_all()\n . t6060: add tests for removed files\n . t6060: modify multiple files to expose a possible issue with merge-index\n\n An attempt to rewrite remaining merge strategies from shell to C.\n\n Needs more work.\n At the minimum, we should lose 11/14 and possibly 08/14.\n cf. \n source: <20220809185429.20098-1-alban.gruin@gmail.com>\n\n\n* es/doc-creation-factor-fix (2022-07-28) 2 commits\n . range-diff: clarify --creation-factor=\n . format-patch: clarify --creation-factor=\n\n Expecting a reroll by somebody more familiar with the logic\n cf. \n source: <7229p500-p2r4-on87-6802-8o90s36rr3s4@tzk.qr>\n\n\n* cw/remote-object-info (2022-08-13) 7 commits\n . SQUASH???\n . cat-file: add remote-object-info to batch-command\n . transport: add client support for object-info\n . serve: advertise object-info feature\n . protocol-caps: initialization bug fix\n . fetch-pack: move fetch initialization\n . fetch-pack: refactor packet writing\n\n A client component to talk with the object-info endpoint.\n\n Expecting a reroll.\n Under SANITIZE=address, t1006-cat-file.sh finds a breakage.\n cf. <20220728230210.2952731-1-calvinwan@google.com>\n cf. \n source: <20220728230210.2952731-1-calvinwan@google.com>\n\n--------------------------------------------------\n[Cooking]\n\n* ab/various-leak-fixes (2022-11-08) 18 commits\n - built-ins: use free() not UNLEAK() if trivial, rm dead code\n - revert: fix parse_options_concat() leak\n - cherry-pick: free \"struct replay_opts\" members\n - rebase: don't leak on \"--abort\"\n - connected.c: free the \"struct packed_git\"\n - sequencer.c: fix \"opts->strategy\" leak in read_strategy_opts()\n - ls-files: fix a --with-tree memory leak\n - revision API: call graph_clear() in release_revisions()\n - unpack-file: fix ancient leak in create_temp_file()\n - built-ins & libs & helpers: add/move destructors, fix leaks\n - dir.c: free \"ident\" and \"exclude_per_dir\" in \"struct untracked_cache\"\n - read-cache.c: clear and free \"sparse_checkout_patterns\"\n - commit: discard partial cache before (re-)reading it\n - {reset,merge}: call discard_index() before returning\n - tests: mark tests as passing with SANITIZE=leak\n - Merge branch 'pw/rebase-no-reflog-action' into ab/various-leak-fixes\n - rebase: stop exporting GIT_REFLOG_ACTION\n - sequencer: stop exporting GIT_REFLOG_ACTION\n\n Various leak fixes.\n\n Will merge to 'next'.\n source: \n\n\n* aw/complete-case-insensitive (2022-11-07) 2 commits\n - completion: add case-insensitive match of pseudorefs\n - completion: add optional ignore-case when matching refs\n\n Introduce a case insensitive mode to the Bash completion helpers.\n\n Waiting for review.\n source: \n\n\n* dd/bisect-helper-subcommand (2022-11-11) 3 commits\n (merged to 'next' on 2022-11-14 at 066f19c4fe)\n + bisect--helper: parse subcommand with OPT_SUBCOMMAND\n + bisect--helper: move all subcommands into their own functions\n + bisect--helper: remove unused options\n (this branch is used by dd/git-bisect-builtin.)\n\n Fix a regression in the bisect-helper which mistakenly treats\n arguments to the command given to 'git bisect run' as arguments to\n the helper.\n\n Will cook in 'next'.\n source: \n\n\n* dd/git-bisect-builtin (2022-11-11) 12 commits\n (merged to 'next' on 2022-11-14 at fc304fb52f)\n + Turn `git bisect` into a full built-in\n + bisect--helper: log: allow arbitrary number of arguments\n + bisect--helper: handle states directly\n + bisect--helper: emit usage for \"git bisect\"\n + bisect test: test exit codes on bad usage\n + bisect--helper: identify as bisect when report error\n + bisect-run: verify_good: account for non-negative exit status\n + bisect run: keep some of the post-v2.30.0 output\n + bisect: fix output regressions in v2.30.0\n + bisect: refactor bisect_run() to match CodingGuidelines\n + bisect tests: test for v2.30.0 \"bisect run\" regressions\n + Merge branch 'dd/bisect-helper-subcommand' into dd/git-bisect-builtin\n (this branch uses dd/bisect-helper-subcommand.)\n\n `git bisect` becomes a builtin.\n\n Will cook in 'next'.\n source: \n\n\n* ds/packed-refs-v2 (2022-11-07) 30 commits\n - refs: skip hashing when writing packed-refs v2\n - p1401: create performance test for ref operations\n - ci: run GIT_TEST_PACKED_REFS_VERSION=2 in some builds\n - t*: skip packed-refs v2 over http tests\n - t3210: require packed-refs v1 for some tests\n - t5502: add PACKED_REFS_V1 prerequisite\n - t5312: allow packed-refs v2 format\n - t1409: test with packed-refs v2\n - packed-backend: create GIT_TEST_PACKED_REFS_VERSION\n - packed-refs: write prefix chunks\n - packed-refs: read optional prefix chunks\n - packed-refs: read file format v2\n - packed-refs: write file format version 2\n - packed-backend: create shell of v2 writes\n - config: add config values for packed-refs v2\n - packed-backend: create abstraction for writing refs\n - packed-backend: extract iterator/updates merge\n - packed-backend: extract add_write_error()\n - refs: extract packfile format to new file\n - chunk-format: parse trailing table of contents\n - chunk-format: allow trailing table of contents\n - chunk-format: store chunk offset during write\n - chunk-format: document trailing table of contents\n - chunk-format: number of chunks is optional\n - refs: allow loose files without packed-refs\n - repository: wire ref extensions to ref backends\n - config: fix multi-level bulleted list\n - extensions: add refFormat extension\n - read-cache: add index.computeHash config option\n - hashfile: allow skipping the hash function\n\n Waiting for review.\n source: \n\n\n* es/chainlint-output (2022-11-08) 4 commits\n (merged to 'next' on 2022-11-14 at 9cd7d30183)\n + chainlint: annotate original test definition rather than token stream\n + chainlint: latch start/end position of each token\n + chainlint: tighten accuracy when consuming input stream\n + chainlint: add explanatory comments\n (this branch is used by es/chainlint-lineno.)\n\n Teach chainlint.pl to annotate the original test definition instead\n of the token stream.\n\n Will cook in 'next'.\n source: \n\n\n* ja/worktree-orphan (2022-11-10) 2 commits\n - worktree add: add --orphan flag\n - worktree add: Include -B in usage docs\n\n 'git worktree add' learned how to create a worktree based on an\n orphaned branch with `--orphan`.\n\n Waiting for review discussion to settle, but leaning negative.\n source: <20221110233137.10414-1-jacobabel@nullpo.dev>\n\n\n* js/remove-stale-scalar-repos (2022-11-11) 2 commits\n (merged to 'next' on 2022-11-14 at e1c86051c4)\n + tests(scalar): tighten the stale `scalar.repo` test some\n (merged to 'next' on 2022-11-08 at 6d598a3b80)\n + scalar reconfigure -a: remove stale `scalar.repo` entries\n\n 'scalar reconfigure -a' is taught to automatically remove\n scalar.repo entires which no longer exist.\n\n Will cook in 'next'.\n source: \n\n\n* jt/submodule-on-demand (2022-11-14) 1 commit\n - Doc: document push.recurseSubmodules=only\n\n Push all submodules recursively with\n '--recurse-submodules=on-demand'.\n\n Expecting a reroll?\n source: <20221114213713.2341945-1-jonathantanmy@google.com>\n\n\n* pw/rebase-no-reflog-action (2022-11-09) 2 commits\n (merged to 'next' on 2022-11-14 at 790dadc8d3)\n + rebase: stop exporting GIT_REFLOG_ACTION\n + sequencer: stop exporting GIT_REFLOG_ACTION\n\n Avoid setting GIT_REFLOG_ACTION to improve readability of the\n sequencer internals.\n\n Expecting a (final?) reroll.\n source: <31df037eafede799c2ef27df66c6da309b719b1b.1668003719.git.gitgitgadget@gmail.com>\n\n\n* rp/maintenance-qol (2022-11-14) 2 commits\n (merged to 'next' on 2022-11-14 at 17db40bf26)\n + maintenance: add option to register in a specific config\n + for-each-repo: interpolate repo path arguments\n\n 'git maintenance register' is taught to write configuration to an\n arbitrary path, and 'git for-each-repo' is taught to expand tilde\n characters in paths.\n\n Will cook in 'next'.\n source: <20221109190708.22725-1-ronan@rjp.ie>\n\n\n* sa/cat-file-mailmap--batch-check (2022-11-14) 3 commits\n - doc/cat-file: allow --use-mailmap for --batch options\n - cat-file: add mailmap support to --batch-check option\n - cat-file: add mailmap support to -s option\n\n 'cat-file' gains mailmap support for its '--batch-check' and '-s'\n options.\n\n Will merge to 'next'.\n source: <20221113212830.92609-1-siddharthasthana31@gmail.com>\n\n\n* sz/macos-fsmonitor-symlinks (2022-11-08) 1 commit\n - fsmonitor--daemon: on macOS support symlink\n\n Fix an issue where core.fsmonitor on macOS would not notice created\n or modified symbolic links.\n\n Waiting for review.\n source: \n\n\n* tb/ci-concurrency (2022-11-08) 1 commit\n - ci: avoid unnecessary builds\n\n Avoid unnecessary builds in CI, with settings configured in\n ci-config.\n\n Waiting for review.\n source: \n\n\n* tl/notes--blankline (2022-11-09) 5 commits\n - notes.c: introduce \"--no-blank-line\" option\n - notes.c: provide tips when target and append note are both empty\n - notes.c: drop unreachable code in 'append_edit()'\n - notes.c: cleanup for \"designated init\" and \"char ptr init\"\n - notes.c: cleanup 'strbuf_grow' call in 'append_edit'\n\n 'git notes append' was taught '--[no-]blank-line' to conditionally\n add a LF between a new and existing note.\n\n Expecting a reroll.\n source: \n\n\n* vd/update-refs-delete (2022-11-07) 1 commit\n (merged to 'next' on 2022-11-08 at 2866156953)\n + rebase --update-refs: avoid unintended ref deletion\n\n Will merge to 'master'.\n source: <20221107174752.91186-1-vdye@github.com>\n\n\n* ab/submodule-helper-prep-only (2022-11-08) 9 commits\n (merged to 'next' on 2022-11-08 at c0c4f4d1c3)\n + submodule--helper: use OPT_SUBCOMMAND() API\n + submodule--helper: drop \"update --prefix \" for \"-C update\"\n + submodule--helper: remove --prefix from \"absorbgitdirs\"\n + submodule API & \"absorbgitdirs\": remove \"----recursive\" option\n + submodule.c: refactor recursive block out of absorb function\n + submodule tests: test for a \"foreach\" blind-spot\n + submodule--helper: fix a memory leak in \"status\"\n + submodule tests: add tests for top-level flag output\n + submodule--helper: move \"config\" to a test-tool\n (this branch is used by ab/remove--super-prefix.)\n\n Preparation to remove git-submodule.sh and replace it with a builtin.\n\n Will cook in 'next'.\n source: \n\n\n* ds/bundle-uri-4 (2022-10-31) 9 commits\n - clone: unbundle the advertised bundles\n - bundle-uri: download bundles from an advertised list\n - bundle-uri: allow relative URLs in bundle lists\n - strbuf: reintroduce strbuf_parent_directory()\n - bundle-uri client: add boolean transfer.bundleURI setting\n - bundle-uri: serve bundle.* keys from config\n - bundle-uri client: add helper for testing server\n - bundle-uri client: add minimal NOOP client\n - protocol v2: add server-side \"bundle-uri\" skeleton\n\n Bundle URIs part 4.\n\n Waiting for review.\n source: \n\n\n* sg/plug-line-log-leaks (2022-11-02) 3 commits\n - diff.c: use diff_free_queue()\n - line-log: free the diff queues' arrays when processing merge commits\n - line-log: free diff queue when processing non-merge commits\n\n A handful of leaks in the line-log machinery have been plugged.\n\n Expecting a reroll.\n source: <20221102220142.574890-1-szeder.dev@gmail.com>\n\n\n* tb/howto-maintain-git-fixes (2022-10-31) 2 commits\n - Documentation: build redo-seen.sh from jch..seen\n - Documentation: build redo-jch.sh from master..jch\n\n A pair of bugfixes to the Documentation/howto/maintain-git.txt guide.\n\n Will merge to 'next'.\n source: \n\n\n* tl/pack-bitmap-absolute-paths (2022-11-14) 2 commits\n (merged to 'next' on 2022-11-14 at 34eb0ea05a)\n + pack-bitmap.c: avoid exposing absolute paths\n + pack-bitmap.c: remove unnecessary \"open_pack_index()\" calls\n\n The pack-bitmap machinery is taught to log the paths of redundant\n bitmap(s) to trace2 instead of stderr.\n\n Will merge to 'master'.\n source: \n\n\n* ab/cmake-nix-and-ci (2022-11-04) 14 commits\n (merged to 'next' on 2022-11-08 at 6ef4e93b36)\n + CI: add a \"linux-cmake-test\" to run cmake & ctest on linux\n + cmake: copy over git-p4.py for t983[56] perforce test\n + cmake: only look for \"sh\" in \"C:/Program Files\" on Windows\n + cmake: increase test timeout on Windows only\n + cmake: support GIT_TEST_OPTS, abstract away WIN32 defaults\n + Makefile + cmake: use environment, not GIT-BUILD-DIR\n + test-lib.sh: support a \"GIT_TEST_BUILD_DIR\"\n + cmake: set \"USE_LIBPCRE2\" in \"GIT-BUILD-OPTIONS\" for test-lib.sh\n + cmake & test-lib.sh: add a $GIT_SOURCE_DIR variable\n + cmake: chmod +x the bin-wrappers/* & SCRIPT_{SH,PERL} & git-p4\n + cmake: don't copy chainlint.pl to build directory\n + cmake: update instructions for portable CMakeLists.txt\n + cmake: use \"-S\" and \"-B\" to specify source and build directories\n + cmake: don't invoke msgfmt with --statistics\n\n Fix assorted issues with CTest on *nix machines.\n\n Will cook in 'next'.\n source: \n\n\n* ab/make-bin-wrappers (2022-10-31) 4 commits\n - Makefile: simplify $(test_bindir_programs) rule by splitting it up\n - Makefile: rename \"test_bindir_programs\" variable, pre-declare\n - Makefile: define \"TEST_{PROGRAM,OBJS}\" variables earlier\n - Makefile: factor sed-powered '#!/bin/sh' munging into a variable\n\n Resolve issues with the bin-wrappers/% rules where \"make\n bin-wrappers/git\" would generate the script but not \"git\" itself.\n\n Waiting for review discussion to settle, but leaning negative.\n source: \n\n\n* ab/misc-hook-submodule-run-command (2022-10-31) 3 commits\n (merged to 'next' on 2022-11-03 at 0f01b25561)\n + run-command tests: test stdout of run_command_parallel()\n + submodule tests: reset \"trace.out\" between \"grep\" invocations\n + hook tests: fix redirection logic error in 96e7225b310\n\n Various test updates.\n\n Will merge to 'master'?\n source: \n\n\n* kz/merge-tree-merge-base (2022-11-12) 2 commits\n (merged to 'next' on 2022-11-14 at 76d48ae21f)\n + merge-tree.c: allow specifying the merge-base when --stdin is passed\n + merge-tree.c: add --merge-base= option\n\n \"merge-tree\" learns a new `--merge-base` option.\n\n Will cook in 'next'.\n source: \n\n\n* po/pretty-hard-trunc (2022-11-13) 1 commit\n - pretty-formats: add hard truncation, without ellipsis, options\n\n Add a new pretty format which truncates without ellipsis.\n\n Waiting for review.\n source: <20221112143616.1429-1-philipoakley@iee.email>\n\n\n* rr/long-status-advice (2022-11-10) 1 commit\n - status: long status advice adapted to recent capabilities\n\n The advice message emitted by a slow \"status\" run is amended to\n mention fsmonitor.\n\n Waiting for reviewer feedback on the updated round.\n source: \n\n\n* ab/config-multi-and-nonbool (2022-11-02) 9 commits\n . for-each-repo: with bad config, don't conflate and \n . config API: add \"string\" version of *_value_multi(), fix segfaults\n . config API users: test for *_get_value_multi() segfaults\n . for-each-repo: error on bad --config\n . config API: have *_multi() return an \"int\" and take a \"dest\"\n . versioncmp.c: refactor config reading next commit\n . config tests: add \"NULL\" tests for *_get_value_multi()\n . config tests: cover blind spots in git_die_config() tests\n . for-each-repo tests: test bad --config keys\n\n A mixed bag of config API updates.\n\n Waiting for review.\n cf. <221026.86pmeebcj9.gmgdl@evledraar.gmail.com>\n source: \n\n\n* ab/sha-makefile-doc (2022-11-07) 10 commits\n (merged to 'next' on 2022-11-08 at 6d3068d7cd)\n + Makefile: discuss SHAttered in *_SHA{1,256} discussion\n + Makefile: document default SHA-1 backend on OSX\n + Makefile & test-tool: replace \"DC_SHA1\" variable with a \"define\"\n + Makefile: document SHA-1 and SHA-256 default and selection order\n + Makefile: document default SHA-256 backend\n + Makefile: rephrase the discussion of *_SHA1 knobs\n + Makefile: create and use sections for \"define\" flag listing\n + Makefile: correct DC_SHA1 documentation\n + INSTALL: remove discussion of SHA-1 backends\n + Makefile: always (re)set DC_SHA1 on fallback\n\n Makefile comments updates and reordering to clarify knobs used to\n choose SHA implementations.\n\n Will merge to 'master'?\n source: \n\n\n* ps/receive-use-only-advertised (2022-11-11) 7 commits\n - receive-pack: only use visible refs for connectivity check\n - rev-parse: add `--exclude-hidden=` option\n - revision: add new parameter to exclude hidden refs\n - revision: introduce struct to handle exclusions\n - revision: move together exclusion-related functions\n - refs: get rid of global list of hidden refs\n - refs: fix memory leak when parsing hideRefs config\n\n \"git receive-pack\" used to use all the local refs as the boundary\n for checking connectivity of the data \"git push\" sent, but now it\n uses only the refs that it advertised to the pusher. In a\n repository with the .hideRefs configuration, this reduces the\n resource needed to perform the check, and also forces the pusher to\n prove they have all objects that are necessary to complete the\n history on top of only the history available to them.\n\n Expecting a (final?) reroll.\n cf. <221028.86bkpw805n.gmgdl@evledraar.gmail.com>\n cf. \n source: \n\n\n* gc/submodule-clone-update-with-branches (2022-10-30) 8 commits\n - clone, submodule update: create and check out branches\n - submodule--helper: remove update_data.suboid\n - submodule update: refactor update targets\n - submodule: return target of submodule symref\n - t5617: drop references to remote-tracking branches\n - submodule--helper clone: create named branch\n - repo-settings: add submodule_propagate_branches\n - clone: teach --detach option\n\n \"git clone --recurse-submodules\" and \"git submodule update\" learns\n to honor the \"propagete branches\" option.\n\n Waiting for review on the updated round.\n source: \n\n\n* pw/config-int-parse-fixes (2022-11-09) 3 commits\n - git_parse_signed(): avoid integer overflow\n - config: require at least one digit when parsing numbers\n - git_parse_unsigned: reject negative values\n\n Assorted fixes of parsing end-user input as integers.\n\n Will merge to 'next'?\n cf. \n source: \n\n\n* tb/repack-expire-to (2022-10-24) 4 commits\n (merged to 'next' on 2022-11-08 at 496ce3c62d)\n + builtin/repack.c: implement `--expire-to` for storing pruned objects\n + builtin/repack.c: write cruft packs to arbitrary locations\n + builtin/repack.c: pass \"cruft_expiration\" to `write_cruft_pack`\n + builtin/repack.c: pass \"out\" to `prepare_pack_objects`\n\n \"git repack\" learns to send cruft objects out of the way into\n packfiles outside the repository.\n\n Will merge to 'master'.\n source: \n\n\n* cc/filtered-repack (2022-10-25) 2 commits\n - repack: add --filter= option\n - pack-objects: allow --filter without --stdout\n\n \"git repack\" learns to discard objects that ought to be retrievable\n again from the promissor remote.\n\n Needs review.\n source: <20221025122856.20204-1-christian.couder@gmail.com>\n\n\n* mc/credential-helper-auth-headers (2022-11-02) 11 commits\n - t5556: add HTTP authentication tests\n - test-http-server: add simple authentication\n - test-http-server: pass Git requests to http-backend\n - test-http-server: add HTTP request parsing\n - test-http-server: add HTTP error response function\n - test-http-server: add stub HTTP server test helper\n - http: set specific auth scheme depending on credential\n - http: move proactive auth to first slot creation\n - http: store all request headers on active_request_slot\n - credential: add WWW-Authenticate header to cred requests\n - http: read HTTP WWW-Authenticate response headers\n\n Extending credential helper protocol.\n\n Needs review.\n source: \n\n\n* hl/archive-recursive (2022-10-19) 10 commits\n . fixup! archive: add tests for git archive --recurse-submodules\n . archive: add tests for git archive --recurse-submodules\n . archive: add --recurse-submodules to git-archive command\n . archive: remove global repository from archive_args\n . archive: pass repo objects to write_archive handlers\n . tree: add repository parameter to read_tree_fn_t\n . tree: handle submodule case for read_tree_at properly\n . tree: increase test coverage for tree.c\n . tree: update cases to use repo_ tree methods\n . tree: do not use the_repository for tree traversal methods.\n\n \"git archive\" has been taught \"--recurse-submodules\" option to\n create a tarball that includes contents from submodules.\n\n Expecting a reroll.\n Seems to break win+VS test(8).\n cf. https://github.com/git/git/actions/runs/3293333066 whose only\n difference from https://github.com/git/git/actions/runs/3293553109\n is the inclusion of this topic.\n source: \n\n\n* en/sparse-checkout-design (2022-11-07) 1 commit\n (merged to 'next' on 2022-11-08 at 42e164b490)\n + sparse-checkout.txt: new document with sparse-checkout directions\n\n Design doc.\n\n Needs review.\n source: \n\n\n* pw/test-todo (2022-10-06) 3 commits\n . test_todo: allow [verbose] test as the command\n . test_todo: allow [!] grep as the command\n . tests: add test_todo() to mark known breakages\n\n RFC for test framework improvement.\n\n Needs review.\n source: \n\n\n* ab/coccicheck-incremental (2022-11-11) 14 commits\n (merged to 'next' on 2022-11-14 at 8a70133571)\n + Makefile: don't create a \".build/.build/\" for cocci, fix output\n (merged to 'next' on 2022-11-08 at 0f3c55d4c2)\n + spatchcache: add a ccache-alike for \"spatch\"\n + cocci: run against a generated ALL.cocci\n + cocci rules: remove 's from rules that don't need them\n + Makefile: copy contrib/coccinelle/*.cocci to build/\n + cocci: optimistically use COMPUTE_HEADER_DEPENDENCIES\n + cocci: make \"coccicheck\" rule incremental\n + cocci: split off \"--all-includes\" from SPATCH_FLAGS\n + cocci: split off include-less \"tests\" from SPATCH_FLAGS\n + Makefile: split off SPATCH_BATCH_SIZE comment from \"cocci\" heading\n + Makefile: have \"coccicheck\" re-run if flags change\n + Makefile: add ability to TAB-complete cocci *.patch rules\n + cocci rules: remove unused \"F\" metavariable from pending rule\n + Makefile + shared.mak: rename and indent $(QUIET_SPATCH_T)\n\n \"make coccicheck\" is time consuming. It has been made to run more\n incrementally.\n\n Will cook in 'next'.\n source: <221109.86tu38p1x8.gmgdl@evledraar.gmail.com>\n source: \n"},{"id":"467297","messageId":"CAPig+cT-QhG+7phOYsq5WQvg9tLu3zsJrajgL=+53bEZ9ZiBNg@mail.gmail.com","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-11-15T04:59:28Z","receivedAt":"2022-11-15T04:59:44Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Nov 14, 2022 at 11:53 PM Taylor Blau wrote:\n> * es/chainlint-lineno (2022-11-11) 4 commits\n> - chainlint: prefix annotated test definition with line numbers\n> - chainlint: latch line numbers at which each token starts and ends\n> - chainlint: sidestep impoverished macOS \"terminfo\"\n> - Merge branch 'es/chainlint-output' into es/chainlint-lineno\n> (this branch uses es/chainlint-output.)\n>\n> Teach chainlint.pl to annotate the original test definition instead\n> of the token stream.\n>\n> * es/chainlint-output (2022-11-08) 4 commits\n> (merged to 'next' on 2022-11-14 at 9cd7d30183)\n> + chainlint: annotate original test definition rather than token stream\n> + chainlint: latch start/end position of each token\n> + chainlint: tighten accuracy when consuming input stream\n> + chainlint: add explanatory comments\n> (this branch is used by es/chainlint-lineno.)\n>\n> Teach chainlint.pl to annotate the original test definition instead\n> of the token stream.\n\nThese two topics have the same description. Perhaps the\nes/chainlint-lineno topic should be described as:\n\n Teach chainlint.pl to decorate output with line numbers.\n\nor something.\n"},{"id":"467298","messageId":"Y3MdJ1VDmbkP+T/D@nand.local","threadId":"58799","inReplyTo":"CAPig+cT-QhG+7phOYsq5WQvg9tLu3zsJrajgL=+53bEZ9ZiBNg@mail.gmail.com","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-15T05:01:27Z","receivedAt":"2022-11-15T05:01:34Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Nov 14, 2022 at 11:59:28PM -0500, Eric Sunshine wrote:\n> On Mon, Nov 14, 2022 at 11:53 PM Taylor Blau wrote:\n> > * es/chainlint-lineno (2022-11-11) 4 commits\n> > - chainlint: prefix annotated test definition with line numbers\n> > - chainlint: latch line numbers at which each token starts and ends\n> > - chainlint: sidestep impoverished macOS \"terminfo\"\n> > - Merge branch 'es/chainlint-output' into es/chainlint-lineno\n> > (this branch uses es/chainlint-output.)\n> >\n> > Teach chainlint.pl to annotate the original test definition instead\n> > of the token stream.\n> >\n> > * es/chainlint-output (2022-11-08) 4 commits\n> > (merged to 'next' on 2022-11-14 at 9cd7d30183)\n> > + chainlint: annotate original test definition rather than token stream\n> > + chainlint: latch start/end position of each token\n> > + chainlint: tighten accuracy when consuming input stream\n> > + chainlint: add explanatory comments\n> > (this branch is used by es/chainlint-lineno.)\n> >\n> > Teach chainlint.pl to annotate the original test definition instead\n> > of the token stream.\n>\n> These two topics have the same description. Perhaps the\n> es/chainlint-lineno topic should be described as:\n>\n> Teach chainlint.pl to decorate output with line numbers.\n>\n> or something.\n\nOops, thanks for spotting. Luckily since es/chainlint-lineno hasn't been\nmerged into 'next' yet, this isn't yet memorialized. I'll make a note of\nit for when I push out the next integration cycle.\n\nThanks,\nTaylor\n"},{"id":"467299","messageId":"Y3MxmzestKm9iMTU@ncase","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"Re: ps/receive-use-only-advertised","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2022-11-15T06:28:43Z","receivedAt":"2022-11-15T06:28:57Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Nov 14, 2022 at 11:50:11PM -0500, Taylor Blau wrote:\n[snip]\n> * ps/receive-use-only-advertised (2022-11-11) 7 commits\n> - receive-pack: only use visible refs for connectivity check\n> - rev-parse: add `--exclude-hidden=` option\n> - revision: add new parameter to exclude hidden refs\n> - revision: introduce struct to handle exclusions\n> - revision: move together exclusion-related functions\n> - refs: get rid of global list of hidden refs\n> - refs: fix memory leak when parsing hideRefs config\n> \n> \"git receive-pack\" used to use all the local refs as the boundary\n> for checking connectivity of the data \"git push\" sent, but now it\n> uses only the refs that it advertised to the pusher. In a\n> repository with the .hideRefs configuration, this reduces the\n> resource needed to perform the check, and also forces the pusher to\n> prove they have all objects that are necessary to complete the\n> history on top of only the history available to them.\n\nWe have at a later point established that this is not true: the pusher\ndoes not have to prove they have all objects. As the `--not --all` part\nin git-rev-list(1) is merely an optimization the semantics aren't\nchanged at all\n\n> Expecting a (final?) reroll.\n\nI think this is stale, right? There was no further feedback until now,\nand in your [1] you say that things look good to you, but that you\nintend to wait a few days for further feedback.\n\nThanks!\n\nPatrick\n\n[1]: \n\n> cf. <221028.86bkpw805n.gmgdl@evledraar.gmail.com>\n> cf. \n> source: \n"},{"id":"467300","messageId":"Y3M2Fq7pZk4lNY9G@nand.local","threadId":"58799","inReplyTo":"Y3MxmzestKm9iMTU@ncase","subject":"Re: ps/receive-use-only-advertised","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-15T06:47:50Z","receivedAt":"2022-11-15T06:47:56Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 07:28:43AM +0100, Patrick Steinhardt wrote:\n> On Mon, Nov 14, 2022 at 11:50:11PM -0500, Taylor Blau wrote:\n> [snip]\n> > * ps/receive-use-only-advertised (2022-11-11) 7 commits\n> > - receive-pack: only use visible refs for connectivity check\n> > - rev-parse: add `--exclude-hidden=` option\n> > - revision: add new parameter to exclude hidden refs\n> > - revision: introduce struct to handle exclusions\n> > - revision: move together exclusion-related functions\n> > - refs: get rid of global list of hidden refs\n> > - refs: fix memory leak when parsing hideRefs config\n> >\n> > \"git receive-pack\" used to use all the local refs as the boundary\n> > for checking connectivity of the data \"git push\" sent, but now it\n> > uses only the refs that it advertised to the pusher. In a\n> > repository with the .hideRefs configuration, this reduces the\n> > resource needed to perform the check, and also forces the pusher to\n> > prove they have all objects that are necessary to complete the\n> > history on top of only the history available to them.\n>\n> We have at a later point established that this is not true: the pusher\n> does not have to prove they have all objects. As the `--not --all` part\n> in git-rev-list(1) is merely an optimization the semantics aren't\n> changed at all\n\nThanks; this is Junio's description from when he picked up the topic\nback in WC #08 from October. I'll need to update before graduating it\ndown.\n\n> > Expecting a (final?) reroll.\n>\n> I think this is stale, right? There was no further feedback until now,\n> and in your [1] you say that things look good to you, but that you\n> intend to wait a few days for further feedback.\n>\n> Thanks!\n\nYes, that is indeed stale, thanks for catching. I'm just waiting for a\nreview from somebody that isn't you or me ;-).\n\n\nThanks,\nTaylor\n"},{"id":"467302","messageId":"221115.86zgcsk5bw.gmgdl@evledraar.gmail.com","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"rp/maintenance-qol with 'make DEVELOPER=1' (was: What's cooking in git.git (Nov 2022, #03; Mon, 14))","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-11-15T08:06:16Z","receivedAt":"2022-11-15T08:08:43Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Mon, Nov 14 2022, Taylor Blau wrote:\n\n> * rp/maintenance-qol (2022-11-14) 2 commits\n> (merged to 'next' on 2022-11-14 at 17db40bf26)\n> + maintenance: add option to register in a specific config\n> + for-each-repo: interpolate repo path arguments\n>\n> 'git maintenance register' is taught to write configuration to an\n> arbitrary path, and 'git for-each-repo' is taught to expand tilde\n> characters in paths.\n>\n> Will cook in 'next'.\n> source: <20221109190708.22725-1-ronan@rjp.ie>\n\n$subject is broken in 'next', here's a hot-fix on top:\nhttps://lore.kernel.org/git/patch-1.1-54d405f15f1-20221115T080212Z-avarab@gmail.com/\n"},{"id":"467307","messageId":"4p90qnq3-580o-9n59-34n0-rs3pp635908o@tzk.qr","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-11-15T14:04:29Z","receivedAt":"2022-11-15T14:04:48Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Taylor,\n\nOn Mon, 14 Nov 2022, Taylor Blau wrote:\n\n> * ms/sendemail-validate-headers (2022-11-11) 1 commit\n> - Expose header information to git-send-email's sendemail-validate hook\n>\n> Expecting a reroll.\n> source: <20221111194223.644845-2-michael.strawbridge@amd.com>\n\nI see this mail, but no replies. Is it really appropriate to label this as\n\"Expecting a reroll\"?\n\nA more appropriate label would be \"Breaks t9001\", I would think, and the\nreference should probable be <36s0r4s9-n21r-pop9-o7rn-q0qrq487p831@tzk.qr>\ninstead (but I sent that out only a couple of minutes ago, so I would\nstill be curious why it was marked as \"Expecting a reroll\").\n\nCiao,\nJohannes\n"},{"id":"467318","messageId":"Y3PMLFuvR6hlIzbq@coredump.intra.peff.net","threadId":"58799","inReplyTo":"Y3M2Fq7pZk4lNY9G@nand.local","subject":"Re: ps/receive-use-only-advertised","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2022-11-15T17:28:12Z","receivedAt":"2022-11-15T17:28:16Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Nov 15, 2022 at 01:47:50AM -0500, Taylor Blau wrote:\n\n> > > \"git receive-pack\" used to use all the local refs as the boundary\n> > > for checking connectivity of the data \"git push\" sent, but now it\n> > > uses only the refs that it advertised to the pusher. In a\n> > > repository with the .hideRefs configuration, this reduces the\n> > > resource needed to perform the check, and also forces the pusher to\n> > > prove they have all objects that are necessary to complete the\n> > > history on top of only the history available to them.\n> >\n> > We have at a later point established that this is not true: the pusher\n> > does not have to prove they have all objects. As the `--not --all` part\n> > in git-rev-list(1) is merely an optimization the semantics aren't\n> > changed at all\n> \n> Thanks; this is Junio's description from when he picked up the topic\n> back in WC #08 from October. I'll need to update before graduating it\n> down.\n\nYeah, I think you can probably just remove everything from \"and also\nforces...\" on.\n\n> > I think this is stale, right? There was no further feedback until now,\n> > and in your [1] you say that things look good to you, but that you\n> > intend to wait a few days for further feedback.\n> >\n> > Thanks!\n> \n> Yes, that is indeed stale, thanks for catching. I'm just waiting for a\n> review from somebody that isn't you or me ;-).\n\nI just left a review. It looks good to me to hit 'next'.\n\n-Peff\n"},{"id":"467340","messageId":"CAPig+cSKaW0ejeVgS7XEphMibdmExxO_T+xjMo6My5SAfwou_Q@mail.gmail.com","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-11-15T20:58:02Z","receivedAt":"2022-11-15T20:58:17Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Nov 14, 2022 at 11:53 PM Taylor Blau wrote:\n> * ja/worktree-orphan (2022-11-10) 2 commits\n> - worktree add: add --orphan flag\n> - worktree add: Include -B in usage docs\n>\n> 'git worktree add' learned how to create a worktree based on an\n> orphaned branch with `--orphan`.\n>\n> Waiting for review discussion to settle, but leaning negative.\n> source: <20221110233137.10414-1-jacobabel@nullpo.dev>\n\nI haven't had a chance yet to look at Jacob's v3, but this series does\nclose a gap in worktree usability[*], and v3 addresses a stated\nconcern of mine against earlier iterations, so I think a \"negative\nlean\" may not be warranted.\n\n[*] In particular, it is currently impossible to create a worktree\nfrom a brand new bare repository:\n\n % git init --bare foo.git\n % git -C foo.git worktree add -b main bar\n Preparing worktree (new branch 'main')\n fatal: not a valid object name: 'HEAD'\n %\n\nwhereas, with this patch series:\n\n % git init --bare foo.git\n % git -C foo.git worktree add --orphan main bar\n Preparing worktree (new branch 'main')\n %\n\n(The commit message can probably be improved to spell this out since\nit wasn't obvious to me, simply from reading the commit message, that\nthis problem existed.)\n"},{"id":"467351","messageId":"Y3Q69UlrmyCXLCsY@nand.local","threadId":"58799","inReplyTo":"4p90qnq3-580o-9n59-34n0-rs3pp635908o@tzk.qr","subject":"Re: ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-16T01:20:53Z","receivedAt":"2022-11-16T01:20:58Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 03:04:29PM +0100, Johannes Schindelin wrote:\n> Hi Taylor,\n>\n> On Mon, 14 Nov 2022, Taylor Blau wrote:\n>\n> > * ms/sendemail-validate-headers (2022-11-11) 1 commit\n> > - Expose header information to git-send-email's sendemail-validate hook\n> >\n> > Expecting a reroll.\n> > source: <20221111194223.644845-2-michael.strawbridge@amd.com>\n>\n> I see this mail, but no replies. Is it really appropriate to label this as\n> \"Expecting a reroll\"?\n\nThanks for spotting. I wrote this one from memory, but in retrospect I\nthink I was thinking of a different thread [1] between the patch author\nand brian where there was some discussion (but no patches).\n\n> A more appropriate label would be \"Breaks t9001\", I would think, and the\n> reference should probable be <36s0r4s9-n21r-pop9-o7rn-q0qrq487p831@tzk.qr>\n> instead (but I sent that out only a couple of minutes ago, so I would\n> still be curious why it was marked as \"Expecting a reroll\").\n\nYes, let's keep this out of 'seen' since it has seen no review and\nbreaks t9001. I'll update my notes accordingly, thanks.\n\nThanks,\nTaylor\n\n[1]: https://lore.kernel.org/git/87czcm7maf.fsf@amd.com/#t\n"},{"id":"467352","messageId":"Y3RE0bq91a0XFKRW@nand.local","threadId":"58799","inReplyTo":"Y3PMLFuvR6hlIzbq@coredump.intra.peff.net","subject":"Re: ps/receive-use-only-advertised","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-16T02:02:57Z","receivedAt":"2022-11-16T02:03:03Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 12:28:12PM -0500, Jeff King wrote:\n> > > I think this is stale, right? There was no further feedback until now,\n> > > and in your [1] you say that things look good to you, but that you\n> > > intend to wait a few days for further feedback.\n> > >\n> > > Thanks!\n> >\n> > Yes, that is indeed stale, thanks for catching. I'm just waiting for a\n> > review from somebody that isn't you or me ;-).\n>\n> I just left a review. It looks good to me to hit 'next'.\n\nThanks, let's start merging this one down.\n\nThanks,\nTaylor\n"},{"id":"467353","messageId":"Y3RFMrhgVYLR6nZ4@nand.local","threadId":"58799","inReplyTo":"CAPig+cSKaW0ejeVgS7XEphMibdmExxO_T+xjMo6My5SAfwou_Q@mail.gmail.com","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-16T02:04:34Z","receivedAt":"2022-11-16T02:04:39Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 03:58:02PM -0500, Eric Sunshine wrote:\n> On Mon, Nov 14, 2022 at 11:53 PM Taylor Blau wrote:\n> > * ja/worktree-orphan (2022-11-10) 2 commits\n> > - worktree add: add --orphan flag\n> > - worktree add: Include -B in usage docs\n> >\n> > 'git worktree add' learned how to create a worktree based on an\n> > orphaned branch with `--orphan`.\n> >\n> > Waiting for review discussion to settle, but leaning negative.\n> > source: <20221110233137.10414-1-jacobabel@nullpo.dev>\n>\n> I haven't had a chance yet to look at Jacob's v3, but this series does\n> close a gap in worktree usability[*], and v3 addresses a stated\n> concern of mine against earlier iterations, so I think a \"negative\n> lean\" may not be warranted.\n\nThanks for saying so, I dropped this from my notes, so the \"leaning\nnegative\" designation will be gone in the next WC.\n\nThanks,\nTaylor\n"},{"id":"467358","messageId":"CABPp-BFJDYpOyAz1XGjqu3p9NVwQjFLta6HCux2y26TvLw5kjQ@mail.gmail.com","threadId":"58799","inReplyTo":"Y3Mag8qG2D3qjlmg@nand.local","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-11-16T06:07:37Z","receivedAt":"2022-11-16T06:07:53Z","isPatch":false,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Mon, Nov 14, 2022 at 9:26 PM Taylor Blau wrote:\n> * en/sparse-checkout-design (2022-11-07) 1 commit\n> (merged to 'next' on 2022-11-08 at 42e164b490)\n> + sparse-checkout.txt: new document with sparse-checkout directions\n>\n> Design doc.\n>\n> Needs review.\n> source: \n\nLabelled as \"Needs review\", but you merged it to next...is the label stale?\n\nIf not, Stolee reviewed and said he thinks it's ready to merge\ndown[*]. I suspect we'll still have some discussions (and I just\nresponded to some comments from both him and ZheNing), but none appear\nto be things that necessitate changes to the document. And I suspect\ndiscussions are naturally going to continue until we have everything\nimplemented, and the design doc is a pretty decent starting point as\nit is.\n\n[*] https://lore.kernel.org/git/f3345a9e-e7f1-4230-d30a-0608eb69513d@github.com/\n"},{"id":"467363","messageId":"874juzglx8.fsf@amd.com","threadId":"58799","inReplyTo":"Y3Q69UlrmyCXLCsY@nand.local","subject":"Re: ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Strawbridge, Michael","fromEmail":"michael.strawbridge@amd.com","sentAt":"2022-11-16T11:48:21Z","receivedAt":"2022-11-16T11:57:29Z","isPatch":false,"sender":{"key":"michael.strawbridge@amd.com","avatar":null},"body":"\nFor ms/sendemail-validate-headers (2022-11-11) 1 commit:\n\nMy apologies. I think not having the patches chained in the same email\nis causing confusion. I did have some review on these emails:\n\nv0 - https://public-inbox.org/git/20221109182254.71967-1-michael.strawbridge@amd.com/T/#u \n + replies: Brian M Carlson, Taylor Blau\nv1 - https://public-inbox.org/git/20221111021502.449662-1-michael.strawbridge@amd.com/T/#t\n + replies: Luben Tuikov, Ævar Arnfjörð Bjarmason\nv2 - https://public-inbox.org/git/20221111193042.641898-1-michael.strawbridge@amd.com/T/#t\nv3 - https://public-inbox.org/git/20221111194223.644845-1-michael.strawbridge@amd.com/T/#t\n + replies: Johannes Schindelin\n\nI'm currently in the process of trying to run the T9001 tests. I am\ngetting: error: test_bool_env requires bool values both for\n$GIT_TEST_PASSING_SANITIZE_LEAK and for the default fallback. I do\nwonder if the change in validation location (as Brian mentioned) is\nchanging output (even though the new location is needed to have all\ninformation for headers). I'll keep looking into it.\n\nThanks,\nMichael Strawbridge\n\nTaylor Blau writes:\n\n> On Tue, Nov 15, 2022 at 03:04:29PM +0100, Johannes Schindelin wrote:\n>> Hi Taylor,\n>>\n>> On Mon, 14 Nov 2022, Taylor Blau wrote:\n>>\n>> > * ms/sendemail-validate-headers (2022-11-11) 1 commit\n>> > - Expose header information to git-send-email's sendemail-validate hook\n>> >\n>> > Expecting a reroll.\n>> > source: <20221111194223.644845-2-michael.strawbridge@amd.com>\n>>\n>> I see this mail, but no replies. Is it really appropriate to label this as\n>> \"Expecting a reroll\"?\n>\n> Thanks for spotting. I wrote this one from memory, but in retrospect I\n> think I was thinking of a different thread [1] between the patch author\n> and brian where there was some discussion (but no patches).\n>\n>> A more appropriate label would be \"Breaks t9001\", I would think, and the\n>> reference should probable be <36s0r4s9-n21r-pop9-o7rn-q0qrq487p831@tzk.qr>\n>> instead (but I sent that out only a couple of minutes ago, so I would\n>> still be curious why it was marked as \"Expecting a reroll\").\n>\n> Yes, let's keep this out of 'seen' since it has seen no review and\n> breaks t9001. I'll update my notes accordingly, thanks.\n>\n> Thanks,\n> Taylor\n>\n> [1]:\n> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fgit%2F87czcm7maf.fsf%40amd.com%2F%23t&data=05%7C01%7CMichael.Strawbridge%40amd.com%7C98afeac929ac4109f7c808dac770cfce%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C638041584581298848%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=hLt0PCAOHlOPOUO3WTny8P5I3LMX17r%2FW5J%2FqX5uFfs%3D&reserved=0\n"},{"id":"467393","messageId":"Y3VFH/vupnRoE2zI@nand.local","threadId":"58799","inReplyTo":"CABPp-BFJDYpOyAz1XGjqu3p9NVwQjFLta6HCux2y26TvLw5kjQ@mail.gmail.com","subject":"Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-16T20:16:31Z","receivedAt":"2022-11-16T20:16:37Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Nov 15, 2022 at 10:07:37PM -0800, Elijah Newren wrote:\n> On Mon, Nov 14, 2022 at 9:26 PM Taylor Blau wrote:\n> > * en/sparse-checkout-design (2022-11-07) 1 commit\n> > (merged to 'next' on 2022-11-08 at 42e164b490)\n> > + sparse-checkout.txt: new document with sparse-checkout directions\n> >\n> > Design doc.\n> >\n> > Needs review.\n> > source: \n>\n> Labelled as \"Needs review\", but you merged it to next...is the label stale?\n\nThank for noticing. Yes, the label is stale.\n\nI intentionally merged this to next back in 42e164b490 (Merge branch\n'en/sparse-checkout-design' into next, 2022-11-08), because it seemed\nlike the document was stable, and that any future substantial changes\nwould only happen after we started seeing some patches.\n\nI'll make sure to update the label when I send out the next WC.\n\nThanks,\nTaylor\n"},{"id":"467518","messageId":"40q20nq9-4qsq-8130-3783-8o97o06824qq@tzk.qr","threadId":"58799","inReplyTo":"874juzglx8.fsf@amd.com","subject":"Re: ms/sendemail-validate-headers, was Re: What's cooking in git.git (Nov 2022, #03; Mon, 14)","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-11-18T13:24:51Z","receivedAt":"2022-11-18T13:25:03Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Michael,\n\nOn Wed, 16 Nov 2022, Strawbridge, Michael wrote:\n\n> For ms/sendemail-validate-headers (2022-11-11) 1 commit:\n>\n> My apologies. I think not having the patches chained in the same email\n> is causing confusion.\n\nPlease do not apologize for something that is not at all your fault. It is\nan unstructured mailing list, after all.\n\n> I did have some review on these emails:\n>\n> v0 - https://public-inbox.org/git/20221109182254.71967-1-michael.strawbridge@amd.com/T/#u\n> + replies: Brian M Carlson, Taylor Blau\n> v1 - https://public-inbox.org/git/20221111021502.449662-1-michael.strawbridge@amd.com/T/#t\n> + replies: Luben Tuikov, Ævar Arnfjörð Bjarmason\n> v2 - https://public-inbox.org/git/20221111193042.641898-1-michael.strawbridge@amd.com/T/#t\n> v3 - https://public-inbox.org/git/20221111194223.644845-1-michael.strawbridge@amd.com/T/#t\n> + replies: Johannes Schindelin\n>\n> I'm currently in the process of trying to run the T9001 tests. I am\n> getting: error: test_bool_env requires bool values both for\n> $GIT_TEST_PASSING_SANITIZE_LEAK and for the default fallback. I do\n> wonder if the change in validation location (as Brian mentioned) is\n> changing output (even though the new location is needed to have all\n> information for headers). I'll keep looking into it.\n\nThank you!\nDscho\n"},{"id":"467542","messageId":"xmqqmt8nkfmx.fsf@gitster.g","threadId":"58799","inReplyTo":"Y3PMLFuvR6hlIzbq@coredump.intra.peff.net","subject":"Re: ps/receive-use-only-advertised","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-11-18T23:27:18Z","receivedAt":"2022-11-18T23:52:39Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n>> > > \"git receive-pack\" used to use all the local refs as the boundary\n>> > > for checking connectivity of the data \"git push\" sent, but now it\n>> > > uses only the refs that it advertised to the pusher. In a\n>> > > repository with the .hideRefs configuration, this reduces the\n>> > > resource needed to perform the check, and also forces the pusher to\n>> > > prove they have all objects that are necessary to complete the\n>> > > history on top of only the history available to them.\n>> >\n>> > We have at a later point established that this is not true: the pusher\n>> > does not have to prove they have all objects. As the `--not --all` part\n>> > in git-rev-list(1) is merely an optimization the semantics aren't\n>> > changed at all\n>> \n>> Thanks; this is Junio's description from when he picked up the topic\n>> back in WC #08 from October. I'll need to update before graduating it\n>> down.\n>\n> Yeah, I think you can probably just remove everything from \"and also\n> forces...\" on.\n\nHmph, --not --all is a way to make the rev-list error out if the\nproposed new tips are not connected with existing objects to the\n\"existing\" refs, and I thought that removing \"hidden\" ones from\n\"--all\" means that the pusher is now forced to push objects all\nneeded. But you are right. Excluding the hidden refs from \"--all\"\nwhile doing the \"rev-list new-tip --not --all\" traversal does not\nexclude pre-existing objects that are only reachable from these\nhidden refs in the object store, so it does not help ensure that the\npusher has to prove they have these objects.\n"}]}