{"thread":{"id":"58793","subject":"[PATCH] Docs: describe how a credential-generating helper works","startedAt":"2022-11-12T01:44:37Z","lastAt":"2022-11-17T21:55:42Z","messageCount":4,"participants":["M Hickford via GitGitGadget","Taylor Blau","Matthew John Cheetham"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"467185","messageId":"pull.1379.git.git.1668217470500.gitgitgadget@gmail.com","threadId":"58793","inReplyTo":null,"subject":"[PATCH] Docs: describe how a credential-generating helper works","fromName":"M Hickford via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-11-12T01:44:30Z","receivedAt":"2022-11-12T01:44:37Z","isPatch":true,"sender":{"key":"mirth.hickford@gmail.com","avatar":"https://avatars.githubusercontent.com/u/105314?v=4"},"body":"From: M Hickford <mirth.hickford@gmail.com>\n\nPreviously the docs only described storage helpers.\n\nA concrete example: Git Credential Manager can generate credentials\nfor GitHub and GitLab via OAuth.\nhttps://github.com/GitCredentialManager/git-credential-manager\n\nSigned-off-by: M Hickford <mirth.hickford@gmail.com>\n---\n    Docs: describe how a credential-generating helper works\n    \n    Previously the docs only described storage helpers.\n    \n    A concrete example: Git Credential Manager can generate credentials for\n    GitHub and GitLab via OAuth.\n    https://github.com/GitCredentialManager/git-credential-manager\n    \n    Signed-off-by: M Hickford mirth.hickford@gmail.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1379%2Fhickford%2Fcredential-generator-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1379/hickford/credential-generator-v1\nPull-Request: https://github.com/git/git/pull/1379\n\n Documentation/gitcredentials.txt | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/gitcredentials.txt b/Documentation/gitcredentials.txt\nindex 80517b4eb2c..72888402e73 100644\n--- a/Documentation/gitcredentials.txt\n+++ b/Documentation/gitcredentials.txt\n@@ -61,7 +61,9 @@ for a password. It is generally configured by adding this to your config:\n \n Credential helpers, on the other hand, are external programs from which Git can\n request both usernames and passwords; they typically interface with secure\n-storage provided by the OS or other programs.\n+storage provided by the OS or other programs. Alternatively, a\n+credential-generating helper might generate credentials for certain servers via\n+some API.\n \n To use a helper, you must first select one to use. Git currently\n includes the following helpers:\n@@ -286,8 +288,8 @@ For a `store` or `erase` operation, the helper's output is ignored.\n If a helper fails to perform the requested operation or needs to notify\n the user of a potential issue, it may write to stderr.\n \n-If it does not support the requested operation (e.g., a read-only store),\n-it should silently ignore the request.\n+If it does not support the requested operation (e.g., a read-only store\n+or generator), it should silently ignore the request.\n \n If a helper receives any other operation, it should silently ignore the\n request. This leaves room for future operations to be added (older\n\nbase-commit: 319605f8f00e402f3ea758a02c63534ff800a711\n-- \ngitgitgadget\n"},{"id":"467286","messageId":"Y3LMybivz12lj9Gu@nand.local","threadId":"58793","inReplyTo":"pull.1379.git.git.1668217470500.gitgitgadget@gmail.com","subject":"Re: [PATCH] Docs: describe how a credential-generating helper works","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-14T23:18:33Z","receivedAt":"2022-11-14T23:18:40Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sat, Nov 12, 2022 at 01:44:30AM +0000, M Hickford via GitGitGadget wrote:\n> From: M Hickford <mirth.hickford@gmail.com>\n>\n> Previously the docs only described storage helpers.\n>\n> A concrete example: Git Credential Manager can generate credentials\n> for GitHub and GitLab via OAuth.\n> https://github.com/GitCredentialManager/git-credential-manager\n\nThanks. I'm tagging Matthew Cheetham (cc'd) as a potential reviewer.\n\nThanks,\nTaylor\n"},{"id":"467452","messageId":"AS2PR03MB9815DCB5C310C4AC7B82D3A6C0069@AS2PR03MB9815.eurprd03.prod.outlook.com","threadId":"58793","inReplyTo":"pull.1379.git.git.1668217470500.gitgitgadget@gmail.com","subject":"Re: [PATCH] Docs: describe how a credential-generating helper works","fromName":"Matthew John Cheetham","fromEmail":"mjcheetham@outlook.com","sentAt":"2022-11-17T17:28:53Z","receivedAt":"2022-11-17T17:29:07Z","isPatch":true,"sender":{"key":"mjcheetham@outlook.com","avatar":"https://avatars.githubusercontent.com/u/5658207?v=4"},"body":"On 2022-11-11 17:44, M Hickford via GitGitGadget wrote:\n\n> From: M Hickford <mirth.hickford@gmail.com>\n> \n> Previously the docs only described storage helpers.\n> \n> A concrete example: Git Credential Manager can generate credentials\n> for GitHub and GitLab via OAuth.\n> https://github.com/GitCredentialManager/git-credential-manager\n> \n> Signed-off-by: M Hickford <mirth.hickford@gmail.com>\n> ---\n>     Docs: describe how a credential-generating helper works\n>     \n>     Previously the docs only described storage helpers.\n>     \n>     A concrete example: Git Credential Manager can generate credentials for\n>     GitHub and GitLab via OAuth.\n>     https://github.com/GitCredentialManager/git-credential-manager\n>     \n>     Signed-off-by: M Hickford mirth.hickford@gmail.com\n> \n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1379%2Fhickford%2Fcredential-generator-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1379/hickford/credential-generator-v1\n> Pull-Request: https://github.com/git/git/pull/1379\n> \n>  Documentation/gitcredentials.txt | 8 +++++---\n>  1 file changed, 5 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/gitcredentials.txt b/Documentation/gitcredentials.txt\n> index 80517b4eb2c..72888402e73 100644\n> --- a/Documentation/gitcredentials.txt\n> +++ b/Documentation/gitcredentials.txt\n> @@ -61,7 +61,9 @@ for a password. It is generally configured by adding this to your config:\n>  \n>  Credential helpers, on the other hand, are external programs from which Git can\n>  request both usernames and passwords; they typically interface with secure\n> -storage provided by the OS or other programs.\n> +storage provided by the OS or other programs. Alternatively, a\n> +credential-generating helper might generate credentials for certain servers via\n> +some API.\n>  \n>  To use a helper, you must first select one to use. Git currently\n>  includes the following helpers:\n> @@ -286,8 +288,8 @@ For a `store` or `erase` operation, the helper's output is ignored.\n>  If a helper fails to perform the requested operation or needs to notify\n>  the user of a potential issue, it may write to stderr.\n>  \n> -If it does not support the requested operation (e.g., a read-only store),\n> -it should silently ignore the request.\n> +If it does not support the requested operation (e.g., a read-only store\n> +or generator), it should silently ignore the request.\n>  \n>  If a helper receives any other operation, it should silently ignore the\n>  request. This leaves room for future operations to be added (older\n> \n> base-commit: 319605f8f00e402f3ea758a02c63534ff800a711\n\nThis looks like a good, clarifying addition to the docs!\n\nThanks,\nMatthew\n"},{"id":"467466","messageId":"Y3at2UY6OzFiMlNZ@nand.local","threadId":"58793","inReplyTo":"AS2PR03MB9815DCB5C310C4AC7B82D3A6C0069@AS2PR03MB9815.eurprd03.prod.outlook.com","subject":"Re: [PATCH] Docs: describe how a credential-generating helper works","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-17T21:55:37Z","receivedAt":"2022-11-17T21:55:42Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Nov 17, 2022 at 09:28:53AM -0800, Matthew John Cheetham wrote:\n> This looks like a good, clarifying addition to the docs!\n\nThanks, both. Will queue.\n\nThanks,\nTaylor\n"}]}