{"thread":{"id":"58782","subject":"[PATCH] tests(scalar): tighten the stale `scalar.repo` test some","startedAt":"2022-11-10T07:28:57Z","lastAt":"2022-11-11T22:25:45Z","messageCount":3,"participants":["Johannes Schindelin via GitGitGadget","Derrick Stolee","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"467039","messageId":"pull.1415.git.1668065327120.gitgitgadget@gmail.com","threadId":"58782","inReplyTo":null,"subject":"[PATCH] tests(scalar): tighten the stale `scalar.repo` test some","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-11-10T07:28:47Z","receivedAt":"2022-11-10T07:28:57Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nAs pointed out by Stolee, the previous incarnation of this test case was\nnot stringent enough: we want to verify that _only_ the stale entries\nare removed (previously, the test case would have succeeded even if all\nentries had been removed).\n\nLet's rectify this and verify that the other entries are left intact.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    tests(scalar): tighten the stale scalar.repo test some\n    \n    A follow-up for a topic already in next.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1415%2Fdscho%2Ftighten-stale-scalar.repos-test-case-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1415/dscho/tighten-stale-scalar.repos-test-case-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1415\n\n t/t9210-scalar.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t9210-scalar.sh b/t/t9210-scalar.sh\nindex c7f8a379108..25f500cf682 100755\n--- a/t/t9210-scalar.sh\n+++ b/t/t9210-scalar.sh\n@@ -171,10 +171,13 @@ test_expect_success '`reconfigure -a` removes stale config entries' '\n \tscalar register stale &&\n \tscalar list >scalar.repos &&\n \tgrep stale scalar.repos &&\n+\n+\tgrep -v stale scalar.repos >expect &&\n+\n \trm -rf stale &&\n \tscalar reconfigure -a &&\n \tscalar list >scalar.repos &&\n-\t! grep stale scalar.repos\n+\ttest_cmp expect scalar.repos\n '\n \n test_expect_success 'scalar delete without enlistment shows a usage' '\n\nbase-commit: c90db53d203d7ade1dc7abe63857cfb5616fe34f\n-- \ngitgitgadget\n"},{"id":"467045","messageId":"83b9ff0b-a655-714e-a8f9-44b0d1ac3177@github.com","threadId":"58782","inReplyTo":"pull.1415.git.1668065327120.gitgitgadget@gmail.com","subject":"Re: [PATCH] tests(scalar): tighten the stale `scalar.repo` test some","fromName":"Derrick Stolee","fromEmail":"derrickstolee@github.com","sentAt":"2022-11-10T13:56:41Z","receivedAt":"2022-11-10T13:56:47Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 11/10/2022 2:28 AM, Johannes Schindelin via GitGitGadget wrote:\n> From: Johannes Schindelin <johannes.schindelin@gmx.de>\n> \n> As pointed out by Stolee, the previous incarnation of this test case was\n> not stringent enough: we want to verify that _only_ the stale entries\n> are removed (previously, the test case would have succeeded even if all\n> entries had been removed).\n\nThanks for tightening the test!\n\nLGTM.\n-Stolee\n"},{"id":"467168","messageId":"Y27L1+tS8yvGlMSZ@nand.local","threadId":"58782","inReplyTo":"83b9ff0b-a655-714e-a8f9-44b0d1ac3177@github.com","subject":"Re: [PATCH] tests(scalar): tighten the stale `scalar.repo` test some","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-11-11T22:25:27Z","receivedAt":"2022-11-11T22:25:45Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Nov 10, 2022 at 08:56:41AM -0500, Derrick Stolee wrote:\n> On 11/10/2022 2:28 AM, Johannes Schindelin via GitGitGadget wrote:\n> > From: Johannes Schindelin <johannes.schindelin@gmx.de>\n> >\n> > As pointed out by Stolee, the previous incarnation of this test case was\n> > not stringent enough: we want to verify that _only_ the stale entries\n> > are removed (previously, the test case would have succeeded even if all\n> > entries had been removed).\n>\n> Thanks for tightening the test!\n\nThanks, both. I merged this back into 'js/remove-stale-scalar-repos' and\nwill re-merge it back into 'next' during the next push-out (probably on\nMonday or Tuesday of next week).\n\nThanks,\nTaylor\n"}]}