{"thread":{"id":"58755","subject":"Re: git can not be built for s390x since update to git-2.38.0","startedAt":"2022-11-06T18:32:28Z","lastAt":"2022-11-22T18:21:53Z","messageCount":6,"participants":["Sarah Julia Kriesch","Eric Sunshine","Todd Zullinger"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"466633","messageId":"64b10e7e-2807-8ae5-88c7-3df7f6f1f3bd@opensuse.org","threadId":"58755","inReplyTo":null,"subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Sarah Julia Kriesch","fromEmail":"sarah.kriesch@opensuse.org","sentAt":"2022-11-06T18:32:14Z","receivedAt":"2022-11-06T18:32:28Z","isPatch":false,"sender":{"key":"sarah.kriesch@opensuse.org","avatar":null},"body":"\n\n > Gesendet: Mittwoch, 02. November 2022 um 19:49 Uhr\n > Von: \"Todd Zullinger\" \n > An: \"Sarah Julia Kriesch\" \n > Cc: git@vger.kernel.org, andreas.stieger@gmx.de\n > Betreff: Re: git can not be built for s390x since update to git-2.38.0\n >\n > Sarah Julia Kriesch wrote:\n > > I am one of the zsystems Maintainers (s390x architecture) at \nopenSUSE and\n > > git can not be built any more since the update from 2.37.3 to \n2.38.0, and\n > > with 2.38.1 afterwards. We have tried to debug it.\n >\n > I don't know if it's of much help, but for what it's worth\n > 2.38.0 and 2.38.1 been built in Fedora for s390x without\n > issue. Build logs and artifacts for 2.38.1 can be found\n > here:\n >\n > https://koji.fedoraproject.org/koji/buildinfo?buildID=2077983\n >\nThank you for the hint, that it is working for Fedora!\nI have compared your spec file with ours and found, that you have got a \nBuildRequires for jgit only for s390x.\n\nThat has solved the problem. Is there any special reason, that s390x \nneeds jgit for git builds?\n\nBest regards,\nSarah\n > --\n > Todd\n >\n-- \nSarah Julia Kriesch\nopenSUSE\n"},{"id":"466634","messageId":"15a2baf8-53f6-de75-a6bf-ecb4a83d78c4@opensuse.org","threadId":"58755","inReplyTo":"64b10e7e-2807-8ae5-88c7-3df7f6f1f3bd@opensuse.org","subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Sarah Julia Kriesch","fromEmail":"sarah.kriesch@opensuse.org","sentAt":"2022-11-06T19:15:43Z","receivedAt":"2022-11-06T19:15:56Z","isPatch":false,"sender":{"key":"sarah.kriesch@opensuse.org","avatar":null},"body":"It seems, that I did a mistake.\nI thought, that I have tested it based on openSUSE Factory without \nexcluding the tests.\nIt is failing continuously with adding the tests.\n\nI have seen, that Fedora is excluding many tests additionnally for \ns390x. That is another difference in the spec file:\nhttps://src.fedoraproject.org/rpms/git/blob/rawhide/f/git.spec\n\nWe have also identified this week, that chainlint.pl --stats says \"0 \ntests\". That can explain the empty output.\n\n~/rpmbuild/BUILD/git-2.38.1/t> /usr/bin/perl chainlint.pl --stats \n--emit-all chainlinttmp/tests\ntotal: 0 workers, 0 scripts, 0 tests, 0 errors, 0.01s/0.01s (wall/user)\n\nBest regards,\nSarah\n\nAm 06.11.22 um 19:32 schrieb Sarah Julia Kriesch:\n> > Gesendet: Mittwoch, 02. November 2022 um 19:49 Uhr\n> > Von: \"Todd Zullinger\" \n> > An: \"Sarah Julia Kriesch\" \n> > Cc: git@vger.kernel.org, andreas.stieger@gmx.de\n> > Betreff: Re: git can not be built for s390x since update to git-2.38.0\n> >\n> > Sarah Julia Kriesch wrote:\n> > > I am one of the zsystems Maintainers (s390x architecture) at \n> openSUSE and\n> > > git can not be built any more since the update from 2.37.3 to \n> 2.38.0, and\n> > > with 2.38.1 afterwards. We have tried to debug it.\n> >\n> > I don't know if it's of much help, but for what it's worth\n> > 2.38.0 and 2.38.1 been built in Fedora for s390x without\n> > issue.  Build logs and artifacts for 2.38.1 can be found\n> > here:\n> >\n> > https://koji.fedoraproject.org/koji/buildinfo?buildID=2077983\n> >\n>\n>\n> Best regards,\n> Sarah\n> > --\n> > Todd\n> >\n\n-- \nSarah Julia Kriesch\nopenSUSE\n\n"},{"id":"466635","messageId":"CAPig+cQYL4wSwVLKGFW5fATDh8uw87EmZGZ-k_uJdmxBiaSsQg@mail.gmail.com","threadId":"58755","inReplyTo":"15a2baf8-53f6-de75-a6bf-ecb4a83d78c4@opensuse.org","subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-11-06T20:42:36Z","receivedAt":"2022-11-06T20:43:02Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Nov 6, 2022 at 2:18 PM Sarah Julia Kriesch\n wrote:\n> We have also identified this week, that chainlint.pl --stats says \"0\n> tests\". That can explain the empty output.\n>\n> ~/rpmbuild/BUILD/git-2.38.1/t> /usr/bin/perl chainlint.pl --stats\n> --emit-all chainlinttmp/tests\n> total: 0 workers, 0 scripts, 0 tests, 0 errors, 0.01s/0.01s (wall/user)\n\nWas `--stats` added for debugging this issue, or is that somehow part\nof your build process?\n\nWhat is the content of the \"chainlinttmp/tests\" file? Is it empty?\n\nIt is quite curious that it reports 0 scripts. It should report 1\nscript even if chainlinttmp/file is empty. This might point a finger\nat File::Glob::bsd_glob() returning an empty list for some reason, or\nthe problem could be a failure with Perl \"ithreads\".\n"},{"id":"466638","messageId":"Y2hUXlnKX9QAMjNV@pobox.com","threadId":"58755","inReplyTo":"15a2baf8-53f6-de75-a6bf-ecb4a83d78c4@opensuse.org","subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-11-07T00:42:06Z","receivedAt":"2022-11-07T00:47:49Z","isPatch":false,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Sarah Julia Kriesch wrote:\n> I have seen, that Fedora is excluding many tests additionnally for s390x.\n\nFWIW, those tests are only excluded when building on RHEL-8,\nwhere they fail. The same tests work fine on Fedora and\nRHEL-9, so I have presumed that the issue is due to some\nquirk(s) in RHEL-8 on s390x.\n\nThe Fedora git package supports building for RHEL largely as\na convenience. I've got no vested interest in s390x, so I\ndisabled the tests on that OS/hardware combination rather\nthan trying to get access to it in order to debug. :)\n\n-- \nTodd\n"},{"id":"466639","messageId":"Y2hUSDlW/mChgotU@pobox.com","threadId":"58755","inReplyTo":"64b10e7e-2807-8ae5-88c7-3df7f6f1f3bd@opensuse.org","subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-11-07T00:41:44Z","receivedAt":"2022-11-07T00:47:49Z","isPatch":false,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Sarah Julia Kriesch wrote:\n> Thank you for the hint, that it is working for Fedora!\n> I have compared your spec file with ours and found, that you have got a\n> BuildRequires for jgit only for s390x.\n> \n> That has solved the problem. Is there any special reason, that s390x needs\n> jgit for git builds?\n\nIt's the opposite -- but the rpm conditional is quite long\nand ugly though, so it's not as clear it could be. It\nexcludes jgit for the test suite entirely on Fedora 35 and\nnewer¹.\n\nOn prior releases, it was excluded for x86 and s390x\narchitectures. For s390x, the issue was that the jgit\ndaemon frequently hung on during builds and was painful to\ntry and debug without access to the architecture. (For the\nfew tests which use jgit, it was simpler to just not test on\ns390x).\n\n¹ Every few releases (it seems), some part of the java\n dependency chain gets close to being dropped from the\n distribution. After disabling and enalbing jgit several\n times, I've left it disabled, even though jgit has managed\n to remain in Fedora. As much as I'd like to run the\n compatibilty tests, I don't like the \"OMG, git will be\n removed from Fedora because some dependency of jgit is\n going away!\" every couple of releases. :)\n\n-- \nTodd\n"},{"id":"467790","messageId":"CAPig+cQMqwzGvzr-+6KH00QLY67Dj4qsKniLuPMrXf6pt-zmSg@mail.gmail.com","threadId":"58755","inReplyTo":"15a2baf8-53f6-de75-a6bf-ecb4a83d78c4@opensuse.org","subject":"Re: git can not be built for s390x since update to git-2.38.0","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-11-22T18:21:37Z","receivedAt":"2022-11-22T18:21:53Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Nov 6, 2022 at 2:18 PM Sarah Julia Kriesch\n wrote:\n> I have seen, that Fedora is excluding many tests additionnally for\n> s390x. That is another difference in the spec file:\n> https://src.fedoraproject.org/rpms/git/blob/rawhide/f/git.spec\n>\n> We have also identified this week, that chainlint.pl --stats says \"0\n> tests\". That can explain the empty output.\n>\n> ~/rpmbuild/BUILD/git-2.38.1/t> /usr/bin/perl chainlint.pl --stats\n> --emit-all chainlinttmp/tests\n> total: 0 workers, 0 scripts, 0 tests, 0 errors, 0.01s/0.01s (wall/user)\n\nThis sounds like the same issue as reported here[1].\n\n[1]: https://lore.kernel.org/git/CANYNYEHXU8ivgAOa8EO5e9kOcbu6XF7rj+9EcSrbDQE+Rvyw_Q@mail.gmail.com/\n"}]}