{"thread":{"id":"58702","subject":"[OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","startedAt":"2022-10-27T11:58:46Z","lastAt":"2022-10-31T14:42:01Z","messageCount":7,"participants":["NSENGIYUMVA WILBERFORCE","Hariom verma","ZheNing Hu","Christian Couder"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"465867","messageId":"CA+PPyiE=baAoVkrghE5GQMt984AcaL=XBAQRsVRbN8w7jQA+ig@mail.gmail.com","threadId":"58702","inReplyTo":null,"subject":"[OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"NSENGIYUMVA WILBERFORCE","fromEmail":"nsengiyumvawilberforce@gmail.com","sentAt":"2022-10-27T11:58:27Z","receivedAt":"2022-10-27T11:58:46Z","isPatch":false,"sender":{"key":"nsengiyumvawilberforce@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65920105?v=4"},"body":"Hi team,\nI am super excited and eagerly waiting for your comments on my second\nversion of the proposal. I have addressed all the comments that I was\ngiven in the first version.\n\nGoogle docs link:\nhttps://docs.google.com/document/d/1Kdx8DVWF3c5pwV5-A8Z4n-SoRHlMDncI1gNeGCiLNsE/edit#\n\nName:Nsengiyumva Wilberforce\n\nMajor:Software engineering\n\nMobile no.:+256 785065399\n\nEmail:nsengiyumvawilberforce@gmail.com\n\nIRC:wilber4c\n\nGithub:nsengiyumva-wilberforce\n\nLinkedin:https://www.linkedin.com/in/nsengiyumva-wilberforce-623664192/\n\nTime Zone:EAT (UTC + 03:00)\n\n\n##About me\n\nI am doing a Bachelor of Science in software engineering at Makerere\nuniversity in my 4th year(final). I spend most of my time writing PHP\napplications. I am also interested in Java and embedded systems\ndevelopment and I have participated in embedded systems development\nprojects like .\n\n##Microproject\n\nWhen I was browsing the outreachy projects on outreachy website, I was\nsuper excited about Git because I use it in most of my college work.\nAt first, it was intimidating for me to introduce myself to the\ncommunity. But I am glad I took a step. I am glad that I completed my\nmicroproject and the whole process gave me confidence on how to submit\npatches, communicate with the community members and interestingly, it\nwas a big learning process for me. The following are the details\nabout my microproject with public-inbox links to different versions.\n\n\nMailing List for the microproject:\n\n\nGithub: \n\nStatus: next\n\n\n##Proposed Project\n\nAbstract\n\nGit has an old problem of duplicated implementations of some logic.\nFor example, Git had at least 4 different implementations to format\ncommand output for different commands. The foremost aim of this\nproject is to simplify codebase by getting rid of duplication of a\nsimilar logic and, as a result, simplify adding new functionality.\nThe current task is to reuse ref-filter formatting logic to minimize\ncode duplication and to have one unified interface to extract all\nneeded data from the object and to print it properly.\n\n##Previous Work\n\nJayDeep Das(GSoC) tried to “add a new atom ‘signature’”. However, I\nhave not been able to find his complete work in the public box, it\nseems his work was not complete. According to\n\nwhich was suggested at the outreachy website, it looks like he did not\ncomplete writing the tests for the signature atom he was unifying.\nMaybe with the help of the mentors, I could plan to start from where\nhe stopped from.\n\nHariom Verma contributed(https://harry-hov.github.io/blogs/posts/the-final-report)\ntremendously towards “Unifying Git’s format languages” during his 2020\nGSoC internship. Hariom finished most of the formatting options and\nthis will help me build on his work. His work looks smart and\nunderstandable thus adding on his work will be easy. And also his blog\nis very fabulous, it’s a shooting point for me to start understanding\nthe codebase very well. Hariom mentions in his report that 30 % of the\nlog related tests are failing, he also mentions that the cause of\ntests failure is because of the missing mailmap logic and mbox/email\ncommit format. Hariom also says it does not handle unknown formatting\noptions. I plan to start with his advice about the cause of the\nfailure of these tests and then intuitively refactor them into\nsomething cool.\n\n##Summary of remaining tasks by Hariom\n\n-Around 30% log related tests are failing\n\n-Teach pretty-lib.{c,h} to handle incorrect formatting option\n\n-Email/MBoxed commit format needs work\n\n##Some useful mailing lists links from Hariom\n\n- https://public-inbox.org/git/pull.684.v4.git.1598046110.gitgitgadget@gmail.com/\n\n- https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n\n- https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n\n\nOlga has done great work in “Unifying Git’s\nformat languages” during Outreachy Round 15 and continued even after\nthat [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n`cat-file` and `ref-filter`.\n\nShe already did a pretty nice job in preparing ref-filter for more\ngeneral usage of its formatting logic. It will give me the possibility\nto make the migration of pretty.c easier.\n\n##The Plan\n\nMy task is to look at how pretty formats are different from ref-filter\nformats. When some format is supported by the pretty formats but not\nby the ref-filter formats, and should prepare some patches to support\nthe ref-filter format. I will basically build on Hariom’s previous\nwork\n\nStep 1:List down all the formats supported by the pretty format but\nare not supported by the ref-filter format e.g\n\nUser formats like %ah, %ch, %d, %D, %(describe[:options]), %S,\n%GG,%G?, %GS, %GK, %GF, %GP, %GT, %gD, %gd, %gn, %gN, %ge, %gE, %gs.\nPS: I am not pretty sure if this list is exhaustive.\n\nStep 2:Maybe s/related/related to/ formats submitted by different\ncontributors to get a solid and a thorough understanding of the pretty\nand ref-filter formats.\n\nStep 3:s/Understanding/Understand/, and then look at how it was\nimplemented in ref-filter format. This is going to give me direction\nto refactor the remaining pretty formats\n\nStep 4(possible approach): Pick one format option at a time and\nconvert it to use ref-filter option format\n\n\n#Estimated Timeline\n\n\nperiod: December 5,2022 - January 2, 2023\nCommunity bonding\ntasks\n-understanding all the logic of pretty.* and ref-filter.*\n\n(what functions are used and how all formatting process is going)\n\n-Working with mentors and identifying the best candidates to be converted first.\n\n-Converting a couple of formatting options to reuse ref-filter\nformatting logic and update the documentation\n\n\nperiod: December 25, 2022\n\nChristmas celebrations: Join my parents for celebrations\n\nperiod: January 1, 2023:\nNew year’s day holiday:Join my parents for celebrations\n\nperiod: January 3 - February 3, 2023\nCoding Phase 1\ntasks\n\n-Add on Hariom’s work:Converting more formatting options to reuse\nref-filter formatting logic.\n\n-Finish his incomplete work\n\n-Update Documentation.\n\n-Possibly look at Olga’s work\n\nperiod: January 18, 2023: Cake cutting with my friends\nMy Birthday:cake cutting\n\nperiod:From January 6 - January 18, 2023:\nSemester Exams: I will be working for a few hours per day and always\nbe available to reply to any communication\n\nperiod:February 3 - March 3, 2023\nCoding Phase 2\ntasks\n-Final touch-ups and bug fixes(if any)\n\n-Update Documentation\n\n-Wrapping up.\nBlogging about Git\n\nI do love writing a lot however much I have not taken time to put out\nmy personal opinions and thinking. Being an avid reader, I think it’s\nnow my time to start letting other people read what I write, to let\npeople know what I think, what I am doing with my life. And guess\nwhat, I am super excited to start with Git.\n\nAvailability\n\nI can easily devote 30-40 hours per week since my college just\nrequires 15 hours per week. I plan even to work more extra hours for\nmy internship tasks when time allows.\n\n\nPost Outreachy\n\nApart from being an Outreachy intern, I plan to remain a member of git\ncommunity even after my internship, because I believe there is more to\ndo even after the Outreachy internship\n\nHere are some other things I’d like to do beyond Outreachy\n\nMentor other students\n\nDoing code reviews for other contributors\n\nMay be complete the work that I will have left pending after my internship\n\nKeep learning from all of you...\n\nExperience with Open Source\n\nI have little experience with open source, so I hope to learn a lot\nthrough my internship with Git from you all.\n\n\nMotivation\n\nGit being a world’s best developer version control system, I feel\noverjoyed that even my little first patch was accepted. The community\nis very welcoming, the people there answer questions very first and\nthis turns everything overwhelming to a simple process\n\n\nClosing remarks (Optional)\n\nI am a consistent and passionate learner. Even if solving a problem\nmay look tricky to me, I just give it all my 100% time and think of\n1000s of ways to approach it. I know I do not have the required\nexpertise to begin working with a skilled team like Git but I believe\nin learning slowly by slowly until I will make it to the peak.\n\n\nI hope you consider and give me a chance to work with git. It’s a\ngreat hope I have that this opportunity is bringing me closer to my\ndreams. Thanks for your consideration.\n\n\nBest Regards\n\n\nNsengiyumva wilberforce\n"},{"id":"465933","messageId":"CA+CkUQ_pqQomaA=MO78PsC0oA8GcE0dJ415fpjcLx6k5HNaDiw@mail.gmail.com","threadId":"58702","inReplyTo":"CA+PPyiE=baAoVkrghE5GQMt984AcaL=XBAQRsVRbN8w7jQA+ig@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"Hariom verma","fromEmail":"hariom18599@gmail.com","sentAt":"2022-10-28T08:05:44Z","receivedAt":"2022-10-28T08:06:01Z","isPatch":false,"sender":{"key":"hariom18599@gmail.com","avatar":"https://avatars.githubusercontent.com/u/37576387?v=4"},"body":"Hi,\n\nOn Thu, Oct 27, 2022 at 5:28 PM NSENGIYUMVA WILBERFORCE\n wrote:\n>\n> ##Proposed Project\n>\n> Abstract\n>\n> Git has an old problem of duplicated implementations of some logic.\n> For example, Git had at least 4 different implementations to format\n> command output for different commands. The foremost aim of this\n> project is to simplify codebase by getting rid of duplication of a\n> similar logic and, as a result, simplify adding new functionality.\n> The current task is to reuse ref-filter formatting logic to minimize\n> code duplication and to have one unified interface to extract all\n> needed data from the object and to print it properly.\n>\n> ##Previous Work\n>\n> JayDeep Das(GSoC) tried to “add a new atom ‘signature’”. However, I\n> have not been able to find his complete work in the public box, it\n> seems his work was not complete. According to\n> \n> which was suggested at the outreachy website, it looks like he did not\n> complete writing the tests for the signature atom he was unifying.\n> Maybe with the help of the mentors, I could plan to start from where\n> he stopped from.\n\nmaybe s/stopped from/stopped/\n\nYou can elaborate a bit more on Jaydeep's work.\nLike,\n- What tests are missing?\n- Any dificulties he faced during writing tests?\n\nAlso, in my final report, I mentioned refactoring the signature logic\naccording to Junio's comment\n(https://public-inbox.org/git/xmqqzh7jcqv7.fsf@gitster.c.googlers.com/).\nDoes Jaydeep's patch respect Junio's comment? I think you can include\na bit about this too,\n\n> Hariom Verma contributed(https://harry-hov.github.io/blogs/posts/the-final-report)\n> tremendously towards “Unifying Git’s format languages” during his 2020\n> GSoC internship.\n\ns/Unifying Git’s format languages/Unifying ref-filter formats with\nother --pretty formats/\ns/during his 2020 GSoC internship/during GSoC'20/\n\n> Hariom finished most of the formatting options and\n> this will help me build on his work. His work looks smart and\n> understandable thus adding on his work will be easy. And also his blog\n> is very fabulous, it’s a shooting point for me to start understanding\n> the codebase very well.\n\nIt looks more like praise to me. I'm glad you like my work and blogs.\nBut I would like to see some details here.\nLike work is almost 2+ years old. What changed in pretty.* and\nref-filter.* since then?\nIs my work still compatible with the latest changes?\n\n> Hariom mentions in his report that 30 % of the\n> log related tests are failing, he also mentions that the cause of\n> tests failure is because of the missing mailmap logic and mbox/email\n> commit format.\n\nOkay. But see if you can gather more details about failing tests and\nremaining work.\n\n> Hariom also says it does not handle unknown formatting\n> options.\n\nwhat do you mean by \"it\" here?\n\n> I plan to start with his advice about the cause of the\n> failure of these tests and then intuitively refactor them into\n> something cool.\n\nI didn’t get the line \"intuitively refactor them into something cool\".\n\n> ##Summary of remaining tasks by Hariom\n>\n> -Around 30% log related tests are failing\n>\n> -Teach pretty-lib.{c,h} to handle incorrect formatting option\n>\n> -Email/MBoxed commit format needs work\n>\n> ##Some useful mailing lists links from Hariom\n>\n> - https://public-inbox.org/git/pull.684.v4.git.1598046110.gitgitgadget@gmail.com/\n>\n> - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n>\n> - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n>\n\nOkay\n\n> Olga has done great work in “Unifying Git’s\n> format languages” during Outreachy Round 15 and continued even after\n> that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n> `cat-file` and `ref-filter`.\n>\n> She already did a pretty nice job in preparing ref-filter for more\n> general usage of its formatting logic. It will give me the possibility\n> to make the migration of pretty.c easier.\n\nZheNing Hu continued the Olga's work during GSoC'21. You can tell a\nbit more about that too.\n\n-- \n\nI would review the rest later.\n\nIt seems like you used my proposal as a template. Just want to let you\nknow, you are not restricted to using any particular template. Feel\nfree to add or remove any section you find relevant.\n\nThanks,\nHariom\n"},{"id":"466043","messageId":"CA+PPyiHQgkaN66DWOuO9UaGqhx4Gcyou_hdMnVrD9AVFmreqpA@mail.gmail.com","threadId":"58702","inReplyTo":"CA+CkUQ_pqQomaA=MO78PsC0oA8GcE0dJ415fpjcLx6k5HNaDiw@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"NSENGIYUMVA WILBERFORCE","fromEmail":"nsengiyumvawilberforce@gmail.com","sentAt":"2022-10-30T10:13:40Z","receivedAt":"2022-10-30T10:13:56Z","isPatch":false,"sender":{"key":"nsengiyumvawilberforce@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65920105?v=4"},"body":"Thanks Hariom for your comments.\n\n> I would review the rest later.\n\nOk, thank you\n\n> It seems like you used my proposal as a template\n\nI used your template. Yeah in case there are things to add or remove,\nI will do so.\n\nThank you so much for your comments, I am working on all of them. i\nhope by the end of today I will finish\n\n\nOn Fri, Oct 28, 2022 at 11:05 AM Hariom verma wrote:\n>\n> Hi,\n>\n> On Thu, Oct 27, 2022 at 5:28 PM NSENGIYUMVA WILBERFORCE\n> wrote:\n> >\n> > ##Proposed Project\n> >\n> > Abstract\n> >\n> > Git has an old problem of duplicated implementations of some logic.\n> > For example, Git had at least 4 different implementations to format\n> > command output for different commands. The foremost aim of this\n> > project is to simplify codebase by getting rid of duplication of a\n> > similar logic and, as a result, simplify adding new functionality.\n> > The current task is to reuse ref-filter formatting logic to minimize\n> > code duplication and to have one unified interface to extract all\n> > needed data from the object and to print it properly.\n> >\n> > ##Previous Work\n> >\n> > JayDeep Das(GSoC) tried to “add a new atom ‘signature’”. However, I\n> > have not been able to find his complete work in the public box, it\n> > seems his work was not complete. According to\n> > \n> > which was suggested at the outreachy website, it looks like he did not\n> > complete writing the tests for the signature atom he was unifying.\n> > Maybe with the help of the mentors, I could plan to start from where\n> > he stopped from.\n>\n> maybe s/stopped from/stopped/\n>\n> You can elaborate a bit more on Jaydeep's work.\n> Like,\n> - What tests are missing?\n> - Any dificulties he faced during writing tests?\n>\n> Also, in my final report, I mentioned refactoring the signature logic\n> according to Junio's comment\n> (https://public-inbox.org/git/xmqqzh7jcqv7.fsf@gitster.c.googlers.com/).\n> Does Jaydeep's patch respect Junio's comment? I think you can include\n> a bit about this too,\n>\n> > Hariom Verma contributed(https://harry-hov.github.io/blogs/posts/the-final-report)\n> > tremendously towards “Unifying Git’s format languages” during his 2020\n> > GSoC internship.\n>\n> s/Unifying Git’s format languages/Unifying ref-filter formats with\n> other --pretty formats/\n> s/during his 2020 GSoC internship/during GSoC'20/\n>\n> > Hariom finished most of the formatting options and\n> > this will help me build on his work. His work looks smart and\n> > understandable thus adding on his work will be easy. And also his blog\n> > is very fabulous, it’s a shooting point for me to start understanding\n> > the codebase very well.\n>\n> It looks more like praise to me. I'm glad you like my work and blogs.\n> But I would like to see some details here.\n> Like work is almost 2+ years old. What changed in pretty.* and\n> ref-filter.* since then?\n> Is my work still compatible with the latest changes?\n>\n> > Hariom mentions in his report that 30 % of the\n> > log related tests are failing, he also mentions that the cause of\n> > tests failure is because of the missing mailmap logic and mbox/email\n> > commit format.\n>\n> Okay. But see if you can gather more details about failing tests and\n> remaining work.\n>\n> > Hariom also says it does not handle unknown formatting\n> > options.\n>\n> what do you mean by \"it\" here?\n>\n> > I plan to start with his advice about the cause of the\n> > failure of these tests and then intuitively refactor them into\n> > something cool.\n>\n> I didn’t get the line \"intuitively refactor them into something cool\".\n>\n> > ##Summary of remaining tasks by Hariom\n> >\n> > -Around 30% log related tests are failing\n> >\n> > -Teach pretty-lib.{c,h} to handle incorrect formatting option\n> >\n> > -Email/MBoxed commit format needs work\n> >\n> > ##Some useful mailing lists links from Hariom\n> >\n> > - https://public-inbox.org/git/pull.684.v4.git.1598046110.gitgitgadget@gmail.com/\n> >\n> > - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n> >\n> > - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n> >\n>\n> Okay\n>\n> > Olga has done great work in “Unifying Git’s\n> > format languages” during Outreachy Round 15 and continued even after\n> > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n> > `cat-file` and `ref-filter`.\n> >\n> > She already did a pretty nice job in preparing ref-filter for more\n> > general usage of its formatting logic. It will give me the possibility\n> > to make the migration of pretty.c easier.\n>\n> ZheNing Hu continued the Olga's work during GSoC'21. You can tell a\n> bit more about that too.\n>\n> --\n>\n> I would review the rest later.\n>\n> It seems like you used my proposal as a template. Just want to let you\n> know, you are not restricted to using any particular template. Feel\n> free to add or remove any section you find relevant.\n>\n> Thanks,\n> Hariom\n"},{"id":"466089","messageId":"CA+PPyiGvrmXoeZkaQKwwNU3SV+jZHatsC=FMhb9wX5-s0tNjTQ@mail.gmail.com","threadId":"58702","inReplyTo":"CA+PPyiHQgkaN66DWOuO9UaGqhx4Gcyou_hdMnVrD9AVFmreqpA@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"NSENGIYUMVA WILBERFORCE","fromEmail":"nsengiyumvawilberforce@gmail.com","sentAt":"2022-10-31T13:37:24Z","receivedAt":"2022-10-31T13:37:39Z","isPatch":false,"sender":{"key":"nsengiyumvawilberforce@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65920105?v=4"},"body":"> maybe s/stopped from/stopped/\n\nCan I know about how this format of writing works? I have similar\ncomments in the previous proposal, but I do not understand how this\nworks.\n\nThanks,\nWilberforce\n\n\nOn Sun, Oct 30, 2022 at 1:13 PM NSENGIYUMVA WILBERFORCE\n wrote:\n>\n> Thanks Hariom for your comments.\n>\n> > I would review the rest later.\n>\n> Ok, thank you\n>\n> > It seems like you used my proposal as a template\n>\n> I used your template. Yeah in case there are things to add or remove,\n> I will do so.\n>\n> Thank you so much for your comments, I am working on all of them. i\n> hope by the end of today I will finish\n>\n>\n> On Fri, Oct 28, 2022 at 11:05 AM Hariom verma wrote:\n> >\n> > Hi,\n> >\n> > On Thu, Oct 27, 2022 at 5:28 PM NSENGIYUMVA WILBERFORCE\n> > wrote:\n> > >\n> > > ##Proposed Project\n> > >\n> > > Abstract\n> > >\n> > > Git has an old problem of duplicated implementations of some logic.\n> > > For example, Git had at least 4 different implementations to format\n> > > command output for different commands. The foremost aim of this\n> > > project is to simplify codebase by getting rid of duplication of a\n> > > similar logic and, as a result, simplify adding new functionality.\n> > > The current task is to reuse ref-filter formatting logic to minimize\n> > > code duplication and to have one unified interface to extract all\n> > > needed data from the object and to print it properly.\n> > >\n> > > ##Previous Work\n> > >\n> > > JayDeep Das(GSoC) tried to “add a new atom ‘signature’”. However, I\n> > > have not been able to find his complete work in the public box, it\n> > > seems his work was not complete. According to\n> > > \n> > > which was suggested at the outreachy website, it looks like he did not\n> > > complete writing the tests for the signature atom he was unifying.\n> > > Maybe with the help of the mentors, I could plan to start from where\n> > > he stopped from.\n> >\n> > maybe s/stopped from/stopped/\n> >\n> > You can elaborate a bit more on Jaydeep's work.\n> > Like,\n> > - What tests are missing?\n> > - Any dificulties he faced during writing tests?\n> >\n> > Also, in my final report, I mentioned refactoring the signature logic\n> > according to Junio's comment\n> > (https://public-inbox.org/git/xmqqzh7jcqv7.fsf@gitster.c.googlers.com/).\n> > Does Jaydeep's patch respect Junio's comment? I think you can include\n> > a bit about this too,\n> >\n> > > Hariom Verma contributed(https://harry-hov.github.io/blogs/posts/the-final-report)\n> > > tremendously towards “Unifying Git’s format languages” during his 2020\n> > > GSoC internship.\n> >\n> > s/Unifying Git’s format languages/Unifying ref-filter formats with\n> > other --pretty formats/\n> > s/during his 2020 GSoC internship/during GSoC'20/\n> >\n> > > Hariom finished most of the formatting options and\n> > > this will help me build on his work. His work looks smart and\n> > > understandable thus adding on his work will be easy. And also his blog\n> > > is very fabulous, it’s a shooting point for me to start understanding\n> > > the codebase very well.\n> >\n> > It looks more like praise to me. I'm glad you like my work and blogs.\n> > But I would like to see some details here.\n> > Like work is almost 2+ years old. What changed in pretty.* and\n> > ref-filter.* since then?\n> > Is my work still compatible with the latest changes?\n> >\n> > > Hariom mentions in his report that 30 % of the\n> > > log related tests are failing, he also mentions that the cause of\n> > > tests failure is because of the missing mailmap logic and mbox/email\n> > > commit format.\n> >\n> > Okay. But see if you can gather more details about failing tests and\n> > remaining work.\n> >\n> > > Hariom also says it does not handle unknown formatting\n> > > options.\n> >\n> > what do you mean by \"it\" here?\n> >\n> > > I plan to start with his advice about the cause of the\n> > > failure of these tests and then intuitively refactor them into\n> > > something cool.\n> >\n> > I didn’t get the line \"intuitively refactor them into something cool\".\n> >\n> > > ##Summary of remaining tasks by Hariom\n> > >\n> > > -Around 30% log related tests are failing\n> > >\n> > > -Teach pretty-lib.{c,h} to handle incorrect formatting option\n> > >\n> > > -Email/MBoxed commit format needs work\n> > >\n> > > ##Some useful mailing lists links from Hariom\n> > >\n> > > - https://public-inbox.org/git/pull.684.v4.git.1598046110.gitgitgadget@gmail.com/\n> > >\n> > > - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n> > >\n> > > - https://public-inbox.org/git/pull.707.git.1597841551.gitgitgadget@gmail.com/\n> > >\n> >\n> > Okay\n> >\n> > > Olga has done great work in “Unifying Git’s\n> > > format languages” during Outreachy Round 15 and continued even after\n> > > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n> > > `cat-file` and `ref-filter`.\n> > >\n> > > She already did a pretty nice job in preparing ref-filter for more\n> > > general usage of its formatting logic. It will give me the possibility\n> > > to make the migration of pretty.c easier.\n> >\n> > ZheNing Hu continued the Olga's work during GSoC'21. You can tell a\n> > bit more about that too.\n> >\n> > --\n> >\n> > I would review the rest later.\n> >\n> > It seems like you used my proposal as a template. Just want to let you\n> > know, you are not restricted to using any particular template. Feel\n> > free to add or remove any section you find relevant.\n> >\n> > Thanks,\n> > Hariom\n"},{"id":"466090","messageId":"CA+CkUQ81nDvKOYiMQXC_jJkVF+-t1+jyWmdEWfR6L2jyfQnziQ@mail.gmail.com","threadId":"58702","inReplyTo":"CA+PPyiGvrmXoeZkaQKwwNU3SV+jZHatsC=FMhb9wX5-s0tNjTQ@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"Hariom verma","fromEmail":"hariom18599@gmail.com","sentAt":"2022-10-31T13:59:47Z","receivedAt":"2022-10-31T13:59:52Z","isPatch":false,"sender":{"key":"hariom18599@gmail.com","avatar":"https://avatars.githubusercontent.com/u/37576387?v=4"},"body":"Hi,\n\nOn 10/31/22, NSENGIYUMVA WILBERFORCE wrote:\n>> maybe s/stopped from/stopped/\n>\n> Can I know about how this format of writing works? I have similar\n> comments in the previous proposal, but I do not understand how this\n> works.\n\nIn simple word, s/xyz/abc/ means:\nReplace ‘xyz’ with ‘abc’ in the sentence.\n\nYou can read more about ‘sed’ command on the Internet.\n\nThanks,\nHariom Verma\n"},{"id":"466092","messageId":"CAOLTT8QygkMyjFqxsOo8fqh3yWE3najwv+Y8ekr8MP9d_+dotg@mail.gmail.com","threadId":"58702","inReplyTo":"CA+CkUQ_pqQomaA=MO78PsC0oA8GcE0dJ415fpjcLx6k5HNaDiw@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"ZheNing Hu","fromEmail":"adlternative@gmail.com","sentAt":"2022-10-31T14:26:36Z","receivedAt":"2022-10-31T14:26:53Z","isPatch":false,"sender":{"key":"adlternative@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58138461?v=4"},"body":"Hi, Hariom and NSENGIYUMVA,\n\nHariom verma 于2022年10月28日周五 16:08写道：\n>\n> Hi,\n>\n> > Olga has done great work in “Unifying Git’s\n> > format languages” during Outreachy Round 15 and continued even after\n> > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n> > `cat-file` and `ref-filter`.\n> >\n> > She already did a pretty nice job in preparing ref-filter for more\n> > general usage of its formatting logic. It will give me the possibility\n> > to make the migration of pretty.c easier.\n>\n> ZheNing Hu continued the Olga's work during GSoC'21. You can tell a\n> bit more about that too.\n>\n\nI'm afraid I'm skeptical about the progress of this project. Yes, this\nproject has\nbeen going on for too long, probably 3 years, and it is long overdue\nto be merged\ninto master. Maybe we all need to rethink the nature of this project instead of\nrushing to start writing code.\n\nAs far as I know, these unified format refactor are easy to implement, but as we\nuse more complex parsing logic, there will be a lot of performance degradation.\n\nI recommend new contributors to perform performance analysis and performance\noptimization directly based on the original developer's patches.\n\n> --\n>\n> I would review the rest later.\n>\n> It seems like you used my proposal as a template. Just want to let you\n> know, you are not restricted to using any particular template. Feel\n> free to add or remove any section you find relevant.\n>\n> Thanks,\n> Hariom\n\nI will pay close attention to this issue.\n\nThanks,\n--\nZheNing Hu\n"},{"id":"466094","messageId":"CAP8UFD2skja6kE+w1vPewueQ2wzEck61wiZMftUyA+q=JZ+SMA@mail.gmail.com","threadId":"58702","inReplyTo":"CAOLTT8QygkMyjFqxsOo8fqh3yWE3najwv+Y8ekr8MP9d_+dotg@mail.gmail.com","subject":"Re: [OUTREACHY V2] Unify ref-filter formats with other --pretty formats[proposal]","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2022-10-31T14:41:45Z","receivedAt":"2022-10-31T14:42:01Z","isPatch":false,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi ZheNing and Wilberforce,\n\nOn Mon, Oct 31, 2022 at 3:26 PM ZheNing Hu wrote:\n> Hariom verma 于2022年10月28日周五 16:08写道：\n\n> > > Olga has done great work in “Unifying Git’s\n> > > format languages” during Outreachy Round 15 and continued even after\n> > > that [from 28-09-2017 to 04-04-2019]. Her work is mostly related to\n> > > `cat-file` and `ref-filter`.\n> > >\n> > > She already did a pretty nice job in preparing ref-filter for more\n> > > general usage of its formatting logic. It will give me the possibility\n> > > to make the migration of pretty.c easier.\n> >\n> > ZheNing Hu continued the Olga's work during GSoC'21. You can tell a\n> > bit more about that too.\n>\n> I'm afraid I'm skeptical about the progress of this project. Yes, this\n> project has\n> been going on for too long, probably 3 years, and it is long overdue\n> to be merged\n> into master. Maybe we all need to rethink the nature of this project instead of\n> rushing to start writing code.\n>\n> As far as I know, these unified format refactor are easy to implement, but as we\n> use more complex parsing logic, there will be a lot of performance degradation.\n>\n> I recommend new contributors to perform performance analysis and performance\n> optimization directly based on the original developer's patches.\n\nYeah, I agree that the project to use ref-filter formats in cat-file\nis very hard due to performance issues, and I think we shouldn't\nsuggest it anymore as a project to GSoC or Outreachy applicants.\n\nThe project we are proposing for Outreachy, and that Wilberforce is\nwriting a proposal for, is about unifying \"ref-filter formats\" with\n\"pretty formats\" though. So there is no need to touch cat-file code as\n\"pretty formats\" are not used there. Actually it might not even be\nneeded to mention using ref-filter formats in cat-file (and the\nrelated work made by Olga and ZheNing on this). It could perhaps help\nwith understanding the big picture, but that's it.\n\nThanks,\nChristian.\n"}]}