{"thread":{"id":"5865","subject":"Re: git-revert in branch next","startedAt":"2006-10-10T01:11:34Z","lastAt":"2006-10-10T02:21:20Z","messageCount":2,"participants":["Luben Tuikov","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"28475","messageId":"20061010011134.58584.qmail@web31809.mail.mud.yahoo.com","threadId":"5865","inReplyTo":null,"subject":"Re: git-revert in branch next","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-10T01:11:34Z","receivedAt":"2006-10-10T01:11:34Z","isPatch":false,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Luben Tuikov <ltuikov@yahoo.com> wrote:\n> Has anyone successfully used \"git-revert\" from branch next, lately?\n> It seems to print USAGE no matter what arguments are given to it.\n\nLine 50:\n\ntest \"$me,$replay\" = \"revert,t\" && usage\n\nis suspicious after commit abd6970a.\n\n   Luben\n"},{"id":"28479","messageId":"7vu02c9ahr.fsf@assigned-by-dhcp.cox.net","threadId":"5865","inReplyTo":"20061010011134.58584.qmail@web31809.mail.mud.yahoo.com","subject":"Re: git-revert in branch next","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-10T02:21:20Z","receivedAt":"2006-10-10T02:21:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Luben Tuikov <ltuikov@yahoo.com> writes:\n\n> --- Luben Tuikov <ltuikov@yahoo.com> wrote:\n>> Has anyone successfully used \"git-revert\" from branch next, lately?\n\nYes, and it is actually in \"master\".  Thanks for noticing before\nI declared -rc2.\n\n-- >8 --\nFix git-revert\n\nDefaulting to $replay for the sake of fixing cherry-pick was not\ndone conditionally, which broke git-revert.\n\nNoticed by Luben.\n\nSigned-off-by: Junio C Hamano <junkio@cox.net>\n---\n git-revert.sh |    4 +++-\n 1 files changed, 3 insertions(+), 1 deletions(-)\n\ndiff --git a/git-revert.sh b/git-revert.sh\nindex 0784f74..4fd81b6 100755\n--- a/git-revert.sh\n+++ b/git-revert.sh\n@@ -7,9 +7,11 @@ #\n case \"$0\" in\n *-revert* )\n \ttest -t 0 && edit=-e\n+\treplay=\n \tme=revert\n \tUSAGE='[--edit | --no-edit] [-n] <commit-ish>' ;;\n *-cherry-pick* )\n+\treplay=t\n \tedit=\n \tme=cherry-pick\n \tUSAGE='[--edit] [-n] [-r] [-x] <commit-ish>'  ;;\n@@ -18,7 +20,7 @@ case \"$0\" in\n esac\n . git-sh-setup\n \n-no_commit= replay=t\n+no_commit=\n while case \"$#\" in 0) break ;; esac\n do\n \tcase \"$1\" in\n-- \n1.4.2.3.g2c59\n"}]}