{"thread":{"id":"58624","subject":"[outreachy] sent in my first patch","startedAt":"2022-10-13T21:41:45Z","lastAt":"2022-10-14T00:08:17Z","messageCount":2,"participants":["NSENGIYUMVA WILBERFORCE","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"464898","messageId":"CA+PPyiH0VqXdO1LfXP7CaM=HnBPWqvHd4DTE5EOMEcb58DCPCA@mail.gmail.com","threadId":"58624","inReplyTo":null,"subject":"[outreachy] sent in my first patch","fromName":"NSENGIYUMVA WILBERFORCE","fromEmail":"nsengiyumvawilberforce@gmail.com","sentAt":"2022-10-13T21:41:29Z","receivedAt":"2022-10-13T21:41:45Z","isPatch":false,"sender":{"key":"nsengiyumvawilberforce@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65920105?v=4"},"body":"Hi team,\nI have been able to submit a patch for a microproject. Many thanks\nJohannes Schindelin for /allow. My CI tests were failing and I had no\nidea why they were failing.\n\nI am an outreachy applicant and I will be happy to have your reviews\nand advice. thanks\nThe PR is https://github.com/git/git/pull/1362\nwilberforce\n"},{"id":"464903","messageId":"CAPig+cQxuWfibPR9O5qZrU4mkuOL48gftRtJ86gzvH0hgJBMOg@mail.gmail.com","threadId":"58624","inReplyTo":"CA+PPyiH0VqXdO1LfXP7CaM=HnBPWqvHd4DTE5EOMEcb58DCPCA@mail.gmail.com","subject":"Re: [outreachy] sent in my first patch","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-10-14T00:08:02Z","receivedAt":"2022-10-14T00:08:17Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Oct 13, 2022 at 5:46 PM NSENGIYUMVA WILBERFORCE\n<nsengiyumvawilberforce@gmail.com> wrote:\n> I have been able to submit a patch for a microproject. Many thanks\n> Johannes Schindelin for /allow. My CI tests were failing and I had no\n> idea why they were failing.\n>\n> The PR is https://github.com/git/git/pull/1362\n\nIt appears that your patch did not get sent to the mailing list\nbecause the patch's commit message failed GitGitGadget's validation\ncheck. In particular, the commit message should start with a summary\nline, followed by one blank line, and then the more detailed\ndescription of the change. The summary line should be formatted as\n\"<area>: <short-description>\", where <area> is the bit of code you are\ntouching. The project also prefers the commit message to be written in\nimperative mood, as if the commit message is telling the code in the\nproject how to change itself. So, you might rewrite the commit message\n(by amending the commit) to read something like this:\n\n    [OUTREACHY] t1002: modernize outdated conditional\n\n    Tests in this script use an unusual and hard-to-reason-about\n    conditional construct:\n\n        if <condition>; then false; else :; fi\n\n    Change them to use the more idiomatic construct:\n\n        ! <condition>\n\n    to make them easier to understand at a glance.\n\nThen \"force push\" the revised patch to GitHub. Since this is a\nsingle-patch pull request, you probably also want to edit the\npull-request's description on GitHub to remove all the text except for\nthe \"Cc:\" entry or entries.\n\nGitGitGadget also complained that you don't have a public email\naddress registered with GitHub, so you should address that problem,\ntoo, if you haven't already.\n\nFinally, re-\"/submit\" the pull request and observe the comments\nGitGitGadet adds to the pull request to see if it discovers any\nadditional issues.\n"}]}