{"thread":{"id":"58621","subject":"[Outreachy] Microproject selection","startedAt":"2022-10-13T06:26:57Z","lastAt":"2022-10-13T07:33:43Z","messageCount":2,"participants":["NSENGIYUMVA WILBERFORCE","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"464797","messageId":"CA+PPyiGHwupxZ=XrmL-1Y=tZyO5JCshD+ss9t9b5pZihM7vFug@mail.gmail.com","threadId":"58621","inReplyTo":null,"subject":"[Outreachy] Microproject selection","fromName":"NSENGIYUMVA WILBERFORCE","fromEmail":"nsengiyumvawilberforce@gmail.com","sentAt":"2022-10-13T06:26:38Z","receivedAt":"2022-10-13T06:26:57Z","isPatch":false,"sender":{"key":"nsengiyumvawilberforce@gmail.com","avatar":"https://avatars.githubusercontent.com/u/65920105?v=4"},"body":"Hi Team,\nI am reading through https://git.github.io/SoC-2022-Microprojects/ and\nand I found an interesting task I could do which is to \"Modernize a\ntest script\".\n\nWhen I looked through the code, I found I could clean up t1002 as\nmentioned in https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/\n.\n\nLet me know if I should go ahead\n\nThanks,\nWilberforce\n"},{"id":"464801","messageId":"CAPig+cSq3fZ+L9Q6O3iYqFpf-BVCG4b1TQkYqOtNGPj_zZkX7A@mail.gmail.com","threadId":"58621","inReplyTo":"CA+PPyiGHwupxZ=XrmL-1Y=tZyO5JCshD+ss9t9b5pZihM7vFug@mail.gmail.com","subject":"Re: [Outreachy] Microproject selection","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2022-10-13T07:33:28Z","receivedAt":"2022-10-13T07:33:43Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Oct 13, 2022 at 2:29 AM NSENGIYUMVA WILBERFORCE\n<nsengiyumvawilberforce@gmail.com> wrote:\n> I am reading through https://git.github.io/SoC-2022-Microprojects/ and\n> and I found an interesting task I could do which is to \"Modernize a\n> test script\".\n>\n> When I looked through the code, I found I could clean up t1002 as\n> mentioned in https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/\n>\n> Let me know if I should go ahead\n\nt1002 might indeed be a reasonable microproject since it could use a\nfew of the same cleanups as mentioned in the email you cited. For a\nmicroproject, we usually don't want you to take on a large task since\nthe aim of a microproject is for you to experience the patch\nsubmission and review process, however, the cleanups t1002 needs are\neach quite simple, so a multi-patch series would be appropriate. I\nforesee a series consisting of two to four patches:\n\n(1) reformat tests from:\n\n    test_expect_success \\\n        'title' \\\n        'body1\n        boy2'\n\nto the modern form:\n\n    test_expect_success 'title' '\n        body1\n        body2\n    '\n\n(2) fix indentation to use TABs rather than spaces\n\n(3) optional: move the:\n\n    cat >expected <<EOF\n    -100644 X 0 nitfol\n    +100644 X 0 nitfol\n    EOF\n\ninto the tests (14 & 15) which need it rather than creating \"expected\"\nin the global scope; at the same time, you might change `EOF` to\n`\\EOF`, but be sure to mention that change in the commit message if\nyou do so and explain why `\\EOF` is preferred (see the \"Recommended\nstyle\" section of t/README for details)\n\n(4) optional: many tests use the unusual construct:\n\n    if read_tree_u_must_succeed -m -u $treeH $treeM; then false; else :; fi\n\nwhich would be expressed more naturally these days as:\n\n    ! read_tree_u_must_succeed -m -u $treeH $treeM\n\nIn fact, if you want a smaller microproject, the optional item listed\nlast might be a decent microproject on its own without the other\nchanges.\n"}]}