{"thread":{"id":"58610","subject":"[PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","startedAt":"2022-10-12T15:07:21Z","lastAt":"2022-10-13T10:54:39Z","messageCount":5,"participants":["sndanailov@wired4ever.net","Philip Oakley","brian m. carlson","Junio C Hamano","Sotir Danailov"],"isPatch":true,"patchVersion":3,"patchTotal":null},"messages":[{"id":"464719","messageId":"20221012150619.12877-1-sndanailov@wired4ever.net","threadId":"58610","inReplyTo":null,"subject":"[PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","fromName":"","fromEmail":"sndanailov@wired4ever.net","sentAt":"2022-10-12T15:06:19Z","receivedAt":"2022-10-12T15:07:21Z","isPatch":true,"sender":{"key":"sndanailov@wired4ever.net","avatar":null},"body":"From: Sotir Danailov \n\nNew explanation for the difference between these values.\nIt's hard to understand what they do based only on the names.\nNew description of used default ports.\n\nSigned-off-by: Sotir Danailov \n---\nChanges since v1: Expanded explanation, covering more terms.\nLink to v1: https://public-inbox.org/git/20221010172859.13832-1-sndanailov@wired4ever.net/\n\nChanges since v2: Added a description of what the option actually does.\nLink to v2: https://public-inbox.org/git/20221011164927.1516-1-sndanailov@wired4ever.net/\n\n Documentation/git-send-email.txt | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 3290043053..765b2df853 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -178,9 +178,18 @@ Sending\n \tfor `sendmail` in `/usr/sbin`, `/usr/lib` and $PATH.\n \n --smtp-encryption=::\n-\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n-\tvalue reverts to plain SMTP. Default is the value of\n-\t`sendemail.smtpEncryption`.\n+\tSpecify in what way encrypting begins for the SMTP connection.\n+\tValid values are 'ssl' and 'tls'. Any other value reverts to plain\n+\t(unencrypted) SMTP, which defaults to port 25.\n+\tDespite the names, both values will use the same newer version of TLS,\n+\tbut for historic reasons have these names. 'ssl' refers to \"implicit\"\n+\tencryption (sometimes called SMTPS), that uses port 465 by default.\n+\t'tls' refers to \"explicit\" encryption (often known as STARTTLS),\n+\tthat uses port 25 by default. Other ports might be used by the SMTP\n+\tserver, which are not the default. Commonly found alternative port for\n+\t'tls' and unencrypted is 587. You need to check your provider's\n+\tdocumentation or your server configuration to make sure\n+\tfor your own case. Default is the value of `sendemail.smtpEncryption`.\n \n --smtp-domain=::\n \tSpecifies the Fully Qualified Domain Name (FQDN) used in the\n-- \n2.37.3\n\n"},{"id":"464730","messageId":"19e5b678-6014-d783-347f-9169371aaa09@iee.email","threadId":"58610","inReplyTo":"20221012150619.12877-1-sndanailov@wired4ever.net","subject":"Re: [PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-10-12T16:49:53Z","receivedAt":"2022-10-12T16:50:02Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"Hi Sotir,\n\nOn 12/10/2022 16:06, sndanailov@wired4ever.net wrote:\n> From: Sotir Danailov \n>\n> New explanation for the difference between these values.\n> It's hard to understand what they do based only on the names.\n> New description of used default ports.\n>\n> Signed-off-by: Sotir Danailov \n> ---\n> Changes since v1: Expanded explanation, covering more terms.\n> Link to v1: https://public-inbox.org/git/20221010172859.13832-1-sndanailov@wired4ever.net/\n>\n> Changes since v2: Added a description of what the option actually does.\n> Link to v2: https://public-inbox.org/git/20221011164927.1516-1-sndanailov@wired4ever.net/\n>\n> Documentation/git-send-email.txt | 15 ++++++++++++---\n> 1 file changed, 12 insertions(+), 3 deletions(-)\n>\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 3290043053..765b2df853 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -178,9 +178,18 @@ Sending\n> \tfor `sendmail` in `/usr/sbin`, `/usr/lib` and $PATH.\n> \n> --smtp-encryption=::\n> -\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n> -\tvalue reverts to plain SMTP. Default is the value of\n> -\t`sendemail.smtpEncryption`.\n> +\tSpecify in what way encrypting begins for the SMTP connection.\n> +\tValid values are 'ssl' and 'tls'. Any other value reverts to plain\n> +\t(unencrypted) SMTP, which defaults to port 25.\n> +\tDespite the names, both values will use the same newer version of TLS,\n> +\tbut for historic reasons have these names. 'ssl' refers to \"implicit\"\n> +\tencryption (sometimes called SMTPS), that uses port 465 by default.\n> +\t'tls' refers to \"explicit\" encryption (often known as STARTTLS),\n> +\tthat uses port 25 by default. Other ports might be used by the SMTP\n> +\tserver, which are not the default. Commonly found alternative port for\n> +\t'tls' and unencrypted is 587.\n\nCan we insert a sentence something like \"Use the `--smtp-server-port`\noption to set non-default ports.\" to direct users that need it?\n\n\n> You need to check your provider's\n> +\tdocumentation or your server configuration to make sure\n> +\tfor your own case. Default is the value of `sendemail.smtpEncryption`.\n> \n> --smtp-domain=::\n> \tSpecifies the Fully Qualified Domain Name (FQDN) used in the\n--\nPhilip\n"},{"id":"464774","messageId":"Y0cxPHNZjTqZR5XE@tapette.crustytoothpaste.net","threadId":"58610","inReplyTo":"20221012150619.12877-1-sndanailov@wired4ever.net","subject":"Re: [PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2022-10-12T21:27:24Z","receivedAt":"2022-10-12T21:27:30Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2022-10-12 at 15:06:19, sndanailov@wired4ever.net wrote:\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 3290043053..765b2df853 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -178,9 +178,18 @@ Sending\n> \tfor `sendmail` in `/usr/sbin`, `/usr/lib` and $PATH.\n> \n> --smtp-encryption=::\n> -\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n> -\tvalue reverts to plain SMTP. Default is the value of\n> -\t`sendemail.smtpEncryption`.\n> +\tSpecify in what way encrypting begins for the SMTP connection.\n> +\tValid values are 'ssl' and 'tls'. Any other value reverts to plain\n> +\t(unencrypted) SMTP, which defaults to port 25.\n> +\tDespite the names, both values will use the same newer version of TLS,\n> +\tbut for historic reasons have these names. 'ssl' refers to \"implicit\"\n> +\tencryption (sometimes called SMTPS), that uses port 465 by default.\n> +\t'tls' refers to \"explicit\" encryption (often known as STARTTLS),\n> +\tthat uses port 25 by default. Other ports might be used by the SMTP\n> +\tserver, which are not the default. Commonly found alternative port for\n> +\t'tls' and unencrypted is 587. You need to check your provider's\n> +\tdocumentation or your server configuration to make sure\n> +\tfor your own case. Default is the value of `sendemail.smtpEncryption`.\n\nI'm happy with this as it stands. Thanks for taking my suggestions and\nsending a patch to improve the docs.\n-- \nbrian m. carlson (he/him or they/them)\nToronto, Ontario, CA\n"},{"id":"464778","messageId":"xmqqy1tkiuye.fsf@gitster.g","threadId":"58610","inReplyTo":"Y0cxPHNZjTqZR5XE@tapette.crustytoothpaste.net","subject":"Re: [PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-10-12T21:38:17Z","receivedAt":"2022-10-12T21:38:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"brian m. carlson\" writes:\n\n> On 2022-10-12 at 15:06:19, sndanailov@wired4ever.net wrote:\n>> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n>> index 3290043053..765b2df853 100644\n>> --- a/Documentation/git-send-email.txt\n>> +++ b/Documentation/git-send-email.txt\n>> @@ -178,9 +178,18 @@ Sending\n>> \tfor `sendmail` in `/usr/sbin`, `/usr/lib` and $PATH.\n>> \n>> --smtp-encryption=::\n>> -\tSpecify the encryption to use, either 'ssl' or 'tls'. Any other\n>> -\tvalue reverts to plain SMTP. Default is the value of\n>> -\t`sendemail.smtpEncryption`.\n>> +\tSpecify in what way encrypting begins for the SMTP connection.\n>> +\tValid values are 'ssl' and 'tls'. Any other value reverts to plain\n>> +\t(unencrypted) SMTP, which defaults to port 25.\n>> +\tDespite the names, both values will use the same newer version of TLS,\n>> +\tbut for historic reasons have these names. 'ssl' refers to \"implicit\"\n>> +\tencryption (sometimes called SMTPS), that uses port 465 by default.\n>> +\t'tls' refers to \"explicit\" encryption (often known as STARTTLS),\n>> +\tthat uses port 25 by default. Other ports might be used by the SMTP\n>> +\tserver, which are not the default. Commonly found alternative port for\n>> +\t'tls' and unencrypted is 587. You need to check your provider's\n>> +\tdocumentation or your server configuration to make sure\n>> +\tfor your own case. Default is the value of `sendemail.smtpEncryption`.\n>\n> I'm happy with this as it stands. Thanks for taking my suggestions and\n> sending a patch to improve the docs.\n\nI marked it as \"Expecting a reroll\" in the latest issue of \"What's\ncooking\" report, but I do not mind taking it to 'next' as-is,\nwithout adding an extra reference to --smtp-server-port. The\nreference to port numbers here are there to help readers identify\nwhich one is which, not because it is common to use randomly\nnumbered ports.\n\nThanks.\n"},{"id":"464819","messageId":"543353ff-981d-9804-3abb-d29caa8300ba@wired4ever.net","threadId":"58610","inReplyTo":"xmqqy1tkiuye.fsf@gitster.g","subject":"Re: [PATCH v3] docs: git-send-email: difference between ssl and tls smtp-encryption","fromName":"Sotir Danailov","fromEmail":"sndanailov@wired4ever.net","sentAt":"2022-10-13T10:54:26Z","receivedAt":"2022-10-13T10:54:39Z","isPatch":true,"sender":{"key":"sndanailov@wired4ever.net","avatar":null},"body":"On Wed 12 Oct 2022 23:38, Junio C Hamano wrote:\n> not because it is common to use randomly numbered ports.\n\nYes, good point! Also I feel the description might become\na bit too bloated if we squeeze in the reference.\nAlthough I'm not against adding it as well, it will make\nthings a lot clearer for sure.\n\nThere's also the issue with the commonly found alternative\nport 587, which I feel might be better fixed by making the\nscript test for it as well if the first default fails.\n\nI don't mind making a v4, but from the responses it seems\nthere's no need?\n\nThanks everybody for the input, helping me with the\npatches and for the fast responses, I really appreciate it!\n"}]}