{"thread":{"id":"58591","subject":"[PATCH] t3435: remove redundant test case","startedAt":"2022-10-10T09:45:16Z","lastAt":"2022-10-11T15:47:27Z","messageCount":3,"participants":["Phillip Wood via GitGitGadget","Junio C Hamano","Phillip Wood"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"464475","messageId":"pull.1379.git.1665395106351.gitgitgadget@gmail.com","threadId":"58591","inReplyTo":null,"subject":"[PATCH] t3435: remove redundant test case","fromName":"Phillip Wood via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-10-10T09:45:06Z","receivedAt":"2022-10-10T09:45:16Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"From: Phillip Wood <phillip.wood@dunelm.org.uk>\n\nrebase --preserve-merges no longer exists so there is no point in\ncarrying this failing test case.\n\nSigned-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>\n---\n    t3435: remove redundant test case\n    \n    test_expect_failure was covering up an unexpected failure.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1379%2Fphillipwood%2Fwip%2Frebase-remove-redundant-test-case-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1379/phillipwood/wip/rebase-remove-redundant-test-case-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1379\n\n t/t3435-rebase-gpg-sign.sh | 8 --------\n 1 file changed, 8 deletions(-)\n\ndiff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh\nindex 5f8ba2c7399..6aa2aeb628d 100755\n--- a/t/t3435-rebase-gpg-sign.sh\n+++ b/t/t3435-rebase-gpg-sign.sh\n@@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true  -i --no-gpg-sign\n test_rebase_gpg_sign ! true  -i --gpg-sign --no-gpg-sign\n test_rebase_gpg_sign   false -i --no-gpg-sign --gpg-sign\n \n-test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' '\n-\ttest_when_finished \"git clean -f\" &&\n-\tgit reset --hard merged &&\n-\tgit config commit.gpgsign true &&\n-\tgit rebase -p --no-gpg-sign --onto=one fork-point main &&\n-\ttest_must_fail git verify-commit HEAD\n-'\n-\n test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' '\n \tgit reset --hard merged &&\n \ttest_unconfig commit.gpgsign &&\n\nbase-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164\n-- \ngitgitgadget\n"},{"id":"464501","messageId":"xmqqpmez4no5.fsf@gitster.g","threadId":"58591","inReplyTo":"pull.1379.git.1665395106351.gitgitgadget@gmail.com","subject":"Re: [PATCH] t3435: remove redundant test case","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-10-10T17:02:34Z","receivedAt":"2022-10-10T17:02:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Phillip Wood via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Phillip Wood <phillip.wood@dunelm.org.uk>\n>\n> rebase --preserve-merges no longer exists so there is no point in\n> carrying this failing test case.\n\nLooks good.\n\nI can imagine that you noticed that it was failing for a wrong\nreason, perhaps as part of your test-todo topic?\n\n> diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh\n> index 5f8ba2c7399..6aa2aeb628d 100755\n> --- a/t/t3435-rebase-gpg-sign.sh\n> +++ b/t/t3435-rebase-gpg-sign.sh\n> @@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true  -i --no-gpg-sign\n>  test_rebase_gpg_sign ! true  -i --gpg-sign --no-gpg-sign\n>  test_rebase_gpg_sign   false -i --no-gpg-sign --gpg-sign\n>  \n> -test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' '\n> -\ttest_when_finished \"git clean -f\" &&\n> -\tgit reset --hard merged &&\n> -\tgit config commit.gpgsign true &&\n> -\tgit rebase -p --no-gpg-sign --onto=one fork-point main &&\n> -\ttest_must_fail git verify-commit HEAD\n> -'\n> -\n>  test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' '\n>  \tgit reset --hard merged &&\n>  \ttest_unconfig commit.gpgsign &&\n>\n> base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164\n"},{"id":"464617","messageId":"a7d32371-4224-aa2a-4b7c-5631798ff710@dunelm.org.uk","threadId":"58591","inReplyTo":"xmqqpmez4no5.fsf@gitster.g","subject":"Re: [PATCH] t3435: remove redundant test case","fromName":"Phillip Wood","fromEmail":"phillip.wood123@gmail.com","sentAt":"2022-10-11T15:38:55Z","receivedAt":"2022-10-11T15:47:27Z","isPatch":true,"sender":{"key":"phillip.wood@dunelm.org.uk","avatar":null},"body":"Hi Junio\n\nOn 10/10/2022 18:02, Junio C Hamano wrote:\n> \"Phillip Wood via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n> \n>> From: Phillip Wood <phillip.wood@dunelm.org.uk>\n>>\n>> rebase --preserve-merges no longer exists so there is no point in\n>> carrying this failing test case.\n> \n> Looks good.\n> \n> I can imagine that you noticed that it was failing for a wrong\n> reason, perhaps as part of your test-todo topic?\n\nYes I noticed it when I was looking for tests to convert to test-todo.\n\nBest Wishes\n\nPhillip\n\n>> diff --git a/t/t3435-rebase-gpg-sign.sh b/t/t3435-rebase-gpg-sign.sh\n>> index 5f8ba2c7399..6aa2aeb628d 100755\n>> --- a/t/t3435-rebase-gpg-sign.sh\n>> +++ b/t/t3435-rebase-gpg-sign.sh\n>> @@ -64,14 +64,6 @@ test_rebase_gpg_sign ! true  -i --no-gpg-sign\n>>   test_rebase_gpg_sign ! true  -i --gpg-sign --no-gpg-sign\n>>   test_rebase_gpg_sign   false -i --no-gpg-sign --gpg-sign\n>>   \n>> -test_expect_failure 'rebase -p --no-gpg-sign override commit.gpgsign' '\n>> -\ttest_when_finished \"git clean -f\" &&\n>> -\tgit reset --hard merged &&\n>> -\tgit config commit.gpgsign true &&\n>> -\tgit rebase -p --no-gpg-sign --onto=one fork-point main &&\n>> -\ttest_must_fail git verify-commit HEAD\n>> -'\n>> -\n>>   test_expect_success 'rebase -r, merge strategy, --gpg-sign will sign commit' '\n>>   \tgit reset --hard merged &&\n>>   \ttest_unconfig commit.gpgsign &&\n>>\n>> base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164\n"}]}