{"thread":{"id":"58590","subject":"[PATCH 0/2] ci(main): upgrade actions/checkout to v3","startedAt":"2022-10-10T07:50:54Z","lastAt":"2022-12-07T12:34:16Z","messageCount":13,"participants":["Oscar Dominguez via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"464470","messageId":"pull.1354.git.git.1665388136.gitgitgadget@gmail.com","threadId":"58590","inReplyTo":null,"subject":"[PATCH 0/2] ci(main): upgrade actions/checkout to v3","fromName":"Oscar Dominguez via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-10-10T07:48:54Z","receivedAt":"2022-10-10T07:50:54Z","isPatch":true,"sender":{"key":"name:Oscar Dominguez","avatar":null},"body":"\nDescription\n===========\n\nUpgrades actions/checkout to v3 in .github/workflows/main.yml\n\nOscar Dominguez (2):\n  ci(main): upgrade actions/checkout to v3\n  ci(main): linux32 uses actions/checkout@v2\n\n .github/workflows/main.yml | 19 +++++++++++--------\n 1 file changed, 11 insertions(+), 8 deletions(-)\n\n\nbase-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v1\nPull-Request: https://github.com/git/git/pull/1354\n-- \ngitgitgadget\n"},{"id":"464471","messageId":"4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com","threadId":"58590","inReplyTo":"pull.1354.git.git.1665388136.gitgitgadget@gmail.com","subject":"[PATCH 2/2] ci(main): linux32 uses actions/checkout@v2","fromName":"Oscar Dominguez via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-10-10T07:48:56Z","receivedAt":"2022-10-10T07:50:56Z","isPatch":true,"sender":{"key":"name:Oscar Dominguez","avatar":null},"body":"From: Oscar Dominguez <dominguez.celada@gmail.com>\n\nto prevent issue tracked in https://github.com/actions/checkout/issues/560\n\nSigned-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\n---\n .github/workflows/main.yml | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 8dc9d938159..4eb5042f0d6 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -281,17 +281,20 @@ jobs:\n         vector:\n         - jobname: linux-musl\n           image: alpine\n+          checkout_version: 3\n         - jobname: linux32\n           os: ubuntu32\n           image: daald/ubuntu32:xenial\n+          checkout_version: 2\n         - jobname: pedantic\n           image: fedora\n+          checkout_version: 3\n     env:\n       jobname: ${{matrix.vector.jobname}}\n     runs-on: ubuntu-latest\n     container: ${{matrix.vector.image}}\n     steps:\n-    - uses: actions/checkout@v3\n+    - uses: actions/checkout@${{matrix.vector.checkout_version}}\n     - run: ci/install-docker-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n-- \ngitgitgadget\n"},{"id":"464472","messageId":"2dbb779f7fde175a8acd8e9de7c81db32fdf3e81.1665388136.git.gitgitgadget@gmail.com","threadId":"58590","inReplyTo":"pull.1354.git.git.1665388136.gitgitgadget@gmail.com","subject":"[PATCH 1/2] ci(main): upgrade actions/checkout to v3","fromName":"Oscar Dominguez via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-10-10T07:48:55Z","receivedAt":"2022-10-10T07:50:59Z","isPatch":true,"sender":{"key":"name:Oscar Dominguez","avatar":null},"body":"From: Oscar Dominguez <dominguez.celada@gmail.com>\n\nto be up to date with actions/checkout opens the door to use the latest\nfeatures if necessary and get the latest security patches.\n\nSigned-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>\n---\n .github/workflows/main.yml | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 831f4df56c5..8dc9d938159 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -83,7 +83,7 @@ jobs:\n     if: needs.ci-config.outputs.enabled == 'yes'\n     runs-on: windows-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: build\n       shell: bash\n@@ -138,10 +138,10 @@ jobs:\n       GIT_CONFIG_PARAMETERS: \"'user.name=CI' 'user.email=ci@git'\"\n     runs-on: windows-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: initialize vcpkg\n-      uses: actions/checkout@v2\n+      uses: actions/checkout@v3\n       with:\n         repository: 'microsoft/vcpkg'\n         path: 'compat/vcbuild/vcpkg'\n@@ -258,7 +258,7 @@ jobs:\n       runs_on_pool: ${{matrix.vector.pool}}\n     runs-on: ${{matrix.vector.pool}}\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n@@ -291,7 +291,7 @@ jobs:\n     runs-on: ubuntu-latest\n     container: ${{matrix.vector.image}}\n     steps:\n-    - uses: actions/checkout@v1\n+    - uses: actions/checkout@v3\n     - run: ci/install-docker-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n@@ -311,7 +311,7 @@ jobs:\n       jobname: StaticAnalysis\n     runs-on: ubuntu-22.04\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/run-static-analysis.sh\n     - run: ci/check-directional-formatting.bash\n@@ -331,7 +331,7 @@ jobs:\n         artifact: sparse-20.04\n     - name: Install the current `sparse` package\n       run: sudo dpkg -i sparse-20.04/sparse_*.deb\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - name: Install other dependencies\n       run: ci/install-dependencies.sh\n     - run: make sparse\n@@ -343,6 +343,6 @@ jobs:\n       jobname: Documentation\n     runs-on: ubuntu-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/test-documentation.sh\n-- \ngitgitgadget\n\n"},{"id":"464536","messageId":"xmqqtu4b1jqg.fsf@gitster.g","threadId":"58590","inReplyTo":"2dbb779f7fde175a8acd8e9de7c81db32fdf3e81.1665388136.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/2] ci(main): upgrade actions/checkout to v3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-10-10T20:55:51Z","receivedAt":"2022-10-10T20:56:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Oscar Dominguez via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Oscar Dominguez <dominguez.celada@gmail.com>\n>\n> to be up to date with actions/checkout opens the door to use the latest\n> features if necessary and get the latest security patches.\n>\n> Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>\n> ---\n>  .github/workflows/main.yml | 16 ++++++++--------\n>  1 file changed, 8 insertions(+), 8 deletions(-)\n\nHmph.  When 0dc787a9 (ci: accelerate the checkout, 2021-07-04)\nupdated us from actions/checkout@v1 to actions/checkout@v2 it listed\na lot more concrete \"what we gain by doing this change\", than the\nhand-wavy \"opens the door\" argument.\n\nAnd it left container jobs at @v1 with an explanation that @v2\nseemed to be incompatible.  If the issue has that been resolved in\n@v3, it would be necessary to say that the issue has been resolved\nand it is safe to use @v3 there in the proposed log message.\n\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 831f4df56c5..8dc9d938159 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> ...\n> @@ -291,7 +291,7 @@ jobs:\n>      runs-on: ubuntu-latest\n>      container: ${{matrix.vector.image}}\n>      steps:\n> -    - uses: actions/checkout@v1\n> +    - uses: actions/checkout@v3\n>      - run: ci/install-docker-dependencies.sh\n>      - run: ci/run-build-and-tests.sh\n>      - name: print test failures\n"},{"id":"464537","messageId":"xmqqo7uj1jj3.fsf@gitster.g","threadId":"58590","inReplyTo":"4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-10-10T21:00:16Z","receivedAt":"2022-10-10T21:02:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Oscar Dominguez via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Oscar Dominguez <dominguez.celada@gmail.com>\n>\n> to prevent issue tracked in https://github.com/actions/checkout/issues/560\n>\n> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\n> ---\n>  .github/workflows/main.yml | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n\nSo, this is \"[Patch 1/2] broke the musl job by blindly updating them\nto v3 and here is a fix-up\" patch?  Can we rearrange so that we have\nno such \"oops here is a fix\" that breaks bisection easily?\n\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 8dc9d938159..4eb5042f0d6 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> @@ -281,17 +281,20 @@ jobs:\n>          vector:\n>          - jobname: linux-musl\n>            image: alpine\n> +          checkout_version: 3\n>          - jobname: linux32\n>            os: ubuntu32\n>            image: daald/ubuntu32:xenial\n> +          checkout_version: 2\n>          - jobname: pedantic\n>            image: fedora\n> +          checkout_version: 3\n>      env:\n>        jobname: ${{matrix.vector.jobname}}\n>      runs-on: ubuntu-latest\n>      container: ${{matrix.vector.image}}\n>      steps:\n> -    - uses: actions/checkout@v3\n> +    - uses: actions/checkout@${{matrix.vector.checkout_version}}\n>      - run: ci/install-docker-dependencies.sh\n>      - run: ci/run-build-and-tests.sh\n>      - name: print test failures\n"},{"id":"464539","messageId":"xmqq7d171hjp.fsf@gitster.g","threadId":"58590","inReplyTo":"4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 2/2] ci(main): linux32 uses actions/checkout@v2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-10-10T21:43:06Z","receivedAt":"2022-10-10T21:43:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Oscar Dominguez via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Oscar Dominguez <dominguez.celada@gmail.com>\n>\n> to prevent issue tracked in https://github.com/actions/checkout/issues/560\n>\n> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\n> ---\n>  .github/workflows/main.yml | 5 ++++-\n>  1 file changed, 4 insertions(+), 1 deletion(-)\n>\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 8dc9d938159..4eb5042f0d6 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> @@ -281,17 +281,20 @@ jobs:\n> ...\n>      steps:\n> -    - uses: actions/checkout@v3\n> +    - uses: actions/checkout@${{matrix.vector.checkout_version}}\n>      - run: ci/install-docker-dependencies.sh\n>      - run: ci/run-build-and-tests.sh\n>      - name: print test failures\n\nI think the breakage we see in\n\n    https://github.com/git/git/actions/runs/3222517697\n\nis due to this change.\n"},{"id":"468512","messageId":"pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com","threadId":"58590","inReplyTo":"pull.1354.git.git.1665388136.gitgitgadget@gmail.com","subject":"[PATCH v2] ci(main): upgrade actions/checkout to v3","fromName":"Oscar Dominguez via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-12-05T10:01:14Z","receivedAt":"2022-12-05T10:01:21Z","isPatch":true,"sender":{"key":"name:Oscar Dominguez","avatar":null},"body":"From: Oscar Dominguez <dominguez.celada@gmail.com>\n\nTo be up to date with actions/checkout opens the door to use the latest\nfeatures if necessary and get the latest security patches.\n\nThis also avoids a couple of deprecation warnings in the CI runs.\n\nNote: The `actions/checkout` Action has been known to be broken in i686\ncontainers as of v2, therefore we keep forcing it to v1 there. See\nactions/runner#2115 for more details.\n\nSigned-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    ci(main): upgrade actions/checkout to v3\n    \n    \n    Description\n    ===========\n    \n    Upgrades actions/checkout to v3 in .github/workflows/main.yml\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v2\nPull-Request: https://github.com/git/git/pull/1354\n\nRange-diff vs v1:\n\n 1:  2dbb779f7fd ! 1:  26fad15f97a ci(main): upgrade actions/checkout to v3\n     @@ Metadata\n       ## Commit message ##\n          ci(main): upgrade actions/checkout to v3\n      \n     -    to be up to date with actions/checkout opens the door to use the latest\n     +    To be up to date with actions/checkout opens the door to use the latest\n          features if necessary and get the latest security patches.\n      \n     -    Signed-off-by: Oscar Dominguez Celada <dominguez.celada@gmail.com>\n     +    This also avoids a couple of deprecation warnings in the CI runs.\n     +\n     +    Note: The `actions/checkout` Action has been known to be broken in i686\n     +    containers as of v2, therefore we keep forcing it to v1 there. See\n     +    actions/runner#2115 for more details.\n     +\n     +    Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\n     +    Signed-off-by: Junio C Hamano <gitster@pobox.com>\n     +    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n      \n       ## .github/workflows/main.yml ##\n      @@ .github/workflows/main.yml: jobs:\n     @@ .github/workflows/main.yml: jobs:\n           runs-on: ubuntu-latest\n           container: ${{matrix.vector.image}}\n           steps:\n     --    - uses: actions/checkout@v1\n      +    - uses: actions/checkout@v3\n     ++      if: matrix.vector.jobname != 'linux32'\n     +     - uses: actions/checkout@v1\n     ++      if: matrix.vector.jobname == 'linux32'\n           - run: ci/install-docker-dependencies.sh\n           - run: ci/run-build-and-tests.sh\n           - name: print test failures\n 2:  4ee163b9a2c < -:  ----------- ci(main): linux32 uses actions/checkout@v2\n\n\n .github/workflows/main.yml | 17 ++++++++++-------\n 1 file changed, 10 insertions(+), 7 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 831f4df56c5..5262823eb1c 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -83,7 +83,7 @@ jobs:\n     if: needs.ci-config.outputs.enabled == 'yes'\n     runs-on: windows-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: build\n       shell: bash\n@@ -138,10 +138,10 @@ jobs:\n       GIT_CONFIG_PARAMETERS: \"'user.name=CI' 'user.email=ci@git'\"\n     runs-on: windows-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: initialize vcpkg\n-      uses: actions/checkout@v2\n+      uses: actions/checkout@v3\n       with:\n         repository: 'microsoft/vcpkg'\n         path: 'compat/vcbuild/vcpkg'\n@@ -258,7 +258,7 @@ jobs:\n       runs_on_pool: ${{matrix.vector.pool}}\n     runs-on: ${{matrix.vector.pool}}\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n@@ -291,7 +291,10 @@ jobs:\n     runs-on: ubuntu-latest\n     container: ${{matrix.vector.image}}\n     steps:\n+    - uses: actions/checkout@v3\n+      if: matrix.vector.jobname != 'linux32'\n     - uses: actions/checkout@v1\n+      if: matrix.vector.jobname == 'linux32'\n     - run: ci/install-docker-dependencies.sh\n     - run: ci/run-build-and-tests.sh\n     - name: print test failures\n@@ -311,7 +314,7 @@ jobs:\n       jobname: StaticAnalysis\n     runs-on: ubuntu-22.04\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/run-static-analysis.sh\n     - run: ci/check-directional-formatting.bash\n@@ -331,7 +334,7 @@ jobs:\n         artifact: sparse-20.04\n     - name: Install the current `sparse` package\n       run: sudo dpkg -i sparse-20.04/sparse_*.deb\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - name: Install other dependencies\n       run: ci/install-dependencies.sh\n     - run: make sparse\n@@ -343,6 +346,6 @@ jobs:\n       jobname: Documentation\n     runs-on: ubuntu-latest\n     steps:\n-    - uses: actions/checkout@v2\n+    - uses: actions/checkout@v3\n     - run: ci/install-dependencies.sh\n     - run: ci/test-documentation.sh\n\nbase-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb\n-- \ngitgitgadget\n"},{"id":"468553","messageId":"xmqqmt81ph0u.fsf@gitster.g","threadId":"58590","inReplyTo":"pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] ci(main): upgrade actions/checkout to v3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-05T23:28:17Z","receivedAt":"2022-12-05T23:28:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Oscar Dominguez via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Oscar Dominguez <dominguez.celada@gmail.com>\n>\n> To be up to date with actions/checkout opens the door to use the latest\n> features if necessary and get the latest security patches.\n>\n> This also avoids a couple of deprecation warnings in the CI runs.\n>\n> Note: The `actions/checkout` Action has been known to be broken in i686\n> containers as of v2, therefore we keep forcing it to v1 there. See\n> actions/runner#2115 for more details.\n>\n> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n> ---\n\nI do not know about Johannes, but the latter two S-o-b by others are\nvery questionable, as this is the first time I see this iteration of\nthe patch.  The chain of S-o-b is used to record that the author\nhanded the patch to somebody else who forwarded it to another\n(i.e. the order of custody), and the above makes it look as if I\npicked this iteration of your patch up, passed it to Johannes, and\nhe gave it to the mailing list readers with this message.\n\nIf you wanted to say \"Input from Johannes helped me greatly while I\npolished the earlier work to produce this version\", it is more\nappropriate to end the proposed log message with:\n\n\tHelped-by: Johannes Schindelin <...>\n\tSigned-off-by: Oscar Dominguez <...>\n\nin chronological order.\n\nIn any case, I've been disturbed by the \"Node 12 is going away, use\nthe one that works with Node 16\" warning at GitHub CI for the past\nfew weeks and it is very welcome to see this topic moving forward.\n\nThanks for working on it.\n"},{"id":"468607","messageId":"xmqq1qpd9bys.fsf@gitster.g","threadId":"58590","inReplyTo":"pull.1354.v2.git.git.1670234474721.gitgitgadget@gmail.com","subject":"[PATCH] ci: use actions/{upload,download}-artifact@v3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-06T08:24:11Z","receivedAt":"2022-12-06T08:24:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"GitHub CI jobs stopped complaining about use of deprecated actions\nthat requires deprecated Node.js 12 for some steps, thanks to a\nrecent work by Oscar Dominguez to upgrade actions/checkout from v2\n(which required Node.js 12) to v3 (which runs with recommended\nNode.js 16).\n\nUpgrade actions/upload-artifact and actions/download-artifact from\nv2 to v3, following suit.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n * The CI run hasn't finished, but it seems to be doing well\n   https://github.com/git/git/actions/runs/3627513480\n\n   We are also getting complaint about our use of set-output command\n   that is deprecated, which will need to be addressed, too.\n\n .github/workflows/main.yml | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 5262823eb1..7a24c6613e 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -94,7 +94,7 @@ jobs:\n     - name: zip up tracked files\n       run: git archive -o artifacts/tracked.tar.gz HEAD\n     - name: upload tracked files and build artifacts\n-      uses: actions/upload-artifact@v2\n+      uses: actions/upload-artifact@v3\n       with:\n         name: windows-artifacts\n         path: artifacts\n@@ -108,7 +108,7 @@ jobs:\n         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]\n     steps:\n     - name: download tracked files and build artifacts\n-      uses: actions/download-artifact@v2\n+      uses: actions/download-artifact@v3\n       with:\n         name: windows-artifacts\n         path: ${{github.workspace}}\n@@ -125,7 +125,7 @@ jobs:\n       run: ci/print-test-failures.sh\n     - name: Upload failed tests' directories\n       if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n-      uses: actions/upload-artifact@v2\n+      uses: actions/upload-artifact@v3\n       with:\n         name: failed-tests-windows\n         path: ${{env.FAILED_TEST_ARTIFACTS}}\n@@ -177,7 +177,7 @@ jobs:\n     - name: zip up tracked files\n       run: git archive -o artifacts/tracked.tar.gz HEAD\n     - name: upload tracked files and build artifacts\n-      uses: actions/upload-artifact@v2\n+      uses: actions/upload-artifact@v3\n       with:\n         name: vs-artifacts\n         path: artifacts\n@@ -192,7 +192,7 @@ jobs:\n     steps:\n     - uses: git-for-windows/setup-git-for-windows-sdk@v1\n     - name: download tracked files and build artifacts\n-      uses: actions/download-artifact@v2\n+      uses: actions/download-artifact@v3\n       with:\n         name: vs-artifacts\n         path: ${{github.workspace}}\n@@ -210,7 +210,7 @@ jobs:\n       run: ci/print-test-failures.sh\n     - name: Upload failed tests' directories\n       if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n-      uses: actions/upload-artifact@v2\n+      uses: actions/upload-artifact@v3\n       with:\n         name: failed-tests-windows\n         path: ${{env.FAILED_TEST_ARTIFACTS}}\n@@ -267,7 +267,7 @@ jobs:\n       run: ci/print-test-failures.sh\n     - name: Upload failed tests' directories\n       if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n-      uses: actions/upload-artifact@v2\n+      uses: actions/upload-artifact@v3\n       with:\n         name: failed-tests-${{matrix.vector.jobname}}\n         path: ${{env.FAILED_TEST_ARTIFACTS}}\n-- \n2.39.0-rc2\n\n"},{"id":"468642","messageId":"2s9ppo74-r654-231r-7ss7-o08464s2so6p@tzk.qr","threadId":"58590","inReplyTo":"xmqq1qpd9bys.fsf@gitster.g","subject":"Re: [PATCH] ci: use actions/{upload,download}-artifact@v3","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-12-06T21:21:23Z","receivedAt":"2022-12-06T21:21:36Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Tue, 6 Dec 2022, Junio C Hamano wrote:\n\n> GitHub CI jobs stopped complaining about use of deprecated actions\n> that requires deprecated Node.js 12 for some steps, thanks to a\n> recent work by Oscar Dominguez to upgrade actions/checkout from v2\n> (which required Node.js 12) to v3 (which runs with recommended\n> Node.js 16).\n>\n> Upgrade actions/upload-artifact and actions/download-artifact from\n> v2 to v3, following suit.\n>\n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n>  * The CI run hasn't finished, but it seems to be doing well\n>    https://github.com/git/git/actions/runs/3627513480\n>\n>    We are also getting complaint about our use of set-output command\n>    that is deprecated, which will need to be addressed, too.\n\nSee below.\n\n>  .github/workflows/main.yml | 14 +++++++-------\n>  1 file changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\n> index 5262823eb1..7a24c6613e 100644\n> --- a/.github/workflows/main.yml\n> +++ b/.github/workflows/main.yml\n> @@ -94,7 +94,7 @@ jobs:\n>      - name: zip up tracked files\n>        run: git archive -o artifacts/tracked.tar.gz HEAD\n>      - name: upload tracked files and build artifacts\n> -      uses: actions/upload-artifact@v2\n> +      uses: actions/upload-artifact@v3\n>        with:\n>          name: windows-artifacts\n>          path: artifacts\n> @@ -108,7 +108,7 @@ jobs:\n>          nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]\n>      steps:\n>      - name: download tracked files and build artifacts\n> -      uses: actions/download-artifact@v2\n> +      uses: actions/download-artifact@v3\n>        with:\n>          name: windows-artifacts\n>          path: ${{github.workspace}}\n> @@ -125,7 +125,7 @@ jobs:\n>        run: ci/print-test-failures.sh\n>      - name: Upload failed tests' directories\n>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n> -      uses: actions/upload-artifact@v2\n> +      uses: actions/upload-artifact@v3\n>        with:\n>          name: failed-tests-windows\n>          path: ${{env.FAILED_TEST_ARTIFACTS}}\n> @@ -177,7 +177,7 @@ jobs:\n>      - name: zip up tracked files\n>        run: git archive -o artifacts/tracked.tar.gz HEAD\n>      - name: upload tracked files and build artifacts\n> -      uses: actions/upload-artifact@v2\n> +      uses: actions/upload-artifact@v3\n>        with:\n>          name: vs-artifacts\n>          path: artifacts\n> @@ -192,7 +192,7 @@ jobs:\n>      steps:\n>      - uses: git-for-windows/setup-git-for-windows-sdk@v1\n>      - name: download tracked files and build artifacts\n> -      uses: actions/download-artifact@v2\n> +      uses: actions/download-artifact@v3\n>        with:\n>          name: vs-artifacts\n>          path: ${{github.workspace}}\n> @@ -210,7 +210,7 @@ jobs:\n>        run: ci/print-test-failures.sh\n>      - name: Upload failed tests' directories\n>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n> -      uses: actions/upload-artifact@v2\n> +      uses: actions/upload-artifact@v3\n\nThis is probably incorrect, but you wouldn't know until something failed\nin the `linux32` job.\n\nI already have a correct fix in\nhttps://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c\nand was only waiting for the patch at the root of this here mail thread to\nadvance further so I could contribute that fix, along with other\nreplacements for deprecated operations.\n\nMaybe we can move these changes forward in a more orderly manner, with\nOscar's patch advancing to `next` once it is done, and the other patches\nfollowing after that?\n\nCiao,\nJohannes\n\n>        with:\n>          name: failed-tests-windows\n>          path: ${{env.FAILED_TEST_ARTIFACTS}}\n> @@ -267,7 +267,7 @@ jobs:\n>        run: ci/print-test-failures.sh\n>      - name: Upload failed tests' directories\n>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n> -      uses: actions/upload-artifact@v2\n> +      uses: actions/upload-artifact@v3\n>        with:\n>          name: failed-tests-${{matrix.vector.jobname}}\n>          path: ${{env.FAILED_TEST_ARTIFACTS}}\n> --\n> 2.39.0-rc2\n>\n>\n>\n"},{"id":"468650","messageId":"xmqqmt8085i6.fsf@gitster.g","threadId":"58590","inReplyTo":"2s9ppo74-r654-231r-7ss7-o08464s2so6p@tzk.qr","subject":"Re: [PATCH] ci: use actions/{upload,download}-artifact@v3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-06T23:41:21Z","receivedAt":"2022-12-06T23:41:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n>> @@ -210,7 +210,7 @@ jobs:\n>>        run: ci/print-test-failures.sh\n>>      - name: Upload failed tests' directories\n>>        if: failure() && env.FAILED_TEST_ARTIFACTS != ''\n>> -      uses: actions/upload-artifact@v2\n>> +      uses: actions/upload-artifact@v3\n>\n> This is probably incorrect, but you wouldn't know until something failed\n> in the `linux32` job.\n\nYeah, that was what I was afraid to see.\n\n> I already have a correct fix in\n> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c\n> and was only waiting for the patch at the root of this here mail thread to\n> advance further so I could contribute that fix, along with other\n> replacements for deprecated operations.\n\nWonderful.\n\n> Maybe we can move these changes forward in a more orderly manner, with\n> Oscar's patch advancing to `next` once it is done, and the other patches\n> following after that?\n\nThat was what I was planning to do anyway.  Thanks.\n"},{"id":"468654","messageId":"xmqqa640830q.fsf@gitster.g","threadId":"58590","inReplyTo":"xmqqmt8085i6.fsf@gitster.g","subject":"Re: [PATCH] ci: use actions/{upload,download}-artifact@v3","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-12-07T00:35:01Z","receivedAt":"2022-12-07T00:35:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano <gitster@pobox.com> writes:\n\n>> This is probably incorrect, but you wouldn't know until something failed\n>> in the `linux32` job.\n>\n> Yeah, that was what I was afraid to see.\n>\n>> I already have a correct fix in\n>> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c\n>> and was only waiting for the patch at the root of this here mail thread to\n>> advance further so I could contribute that fix, along with other\n>> replacements for deprecated operations.\n>\n> Wonderful.\n>\n>> Maybe we can move these changes forward in a more orderly manner, with\n>> Oscar's patch advancing to `next` once it is done, and the other patches\n>> following after that?\n>\n> That was what I was planning to do anyway.  Thanks.\n\nEh, I should have made my intention clear.  I'll drop this one (as I\nposted it primarily to fish out those who are interested in and more\ncapable than I am at clearing the deprecation warnings from the CI),\nwill mark Oscar's for 'next' (if I haven't done so already), wait for\nyour updates and queue them on a topic forked from Oscar's (or on\nthe same Oscar's topic), and cook them for the first or the second\nbatch of the next cycle.\n\nThanks.\n"},{"id":"468710","messageId":"s984sqs4-s134-q7q9-0260-o485683302o8@tzk.qr","threadId":"58590","inReplyTo":"xmqqa640830q.fsf@gitster.g","subject":"Re: [PATCH] ci: use actions/{upload,download}-artifact@v3","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-12-07T12:33:37Z","receivedAt":"2022-12-07T12:34:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Wed, 7 Dec 2022, Junio C Hamano wrote:\n\n> Junio C Hamano <gitster@pobox.com> writes:\n>\n> >> This is probably incorrect, but you wouldn't know until something failed\n> >> in the `linux32` job.\n> >\n> > Yeah, that was what I was afraid to see.\n> >\n> >> I already have a correct fix in\n> >> https://github.com/git-for-windows/git/pull/4112/commits/b59c1e33fa62029f8d5dca801a8afb480514140c\n> >> and was only waiting for the patch at the root of this here mail thread to\n> >> advance further so I could contribute that fix, along with other\n> >> replacements for deprecated operations.\n> >\n> > Wonderful.\n> >\n> >> Maybe we can move these changes forward in a more orderly manner, with\n> >> Oscar's patch advancing to `next` once it is done, and the other patches\n> >> following after that?\n> >\n> > That was what I was planning to do anyway.  Thanks.\n>\n> Eh, I should have made my intention clear.  I'll drop this one (as I\n> posted it primarily to fish out those who are interested in and more\n> capable than I am at clearing the deprecation warnings from the CI),\n> will mark Oscar's for 'next' (if I haven't done so already), wait for\n> your updates and queue them on a topic forked from Oscar's (or on\n> the same Oscar's topic), and cook them for the first or the second\n> batch of the next cycle.\n\nThank you for clarifying your intention, much appreciated.\n\nCiao,\nJohannes\n"}]}