{"thread":{"id":"5856","subject":"git-tar-tree & NEEDS_PREFIX","startedAt":"2006-10-08T13:10:42Z","lastAt":"2006-10-08T13:44:50Z","messageCount":3,"participants":["Jiri Slaby","Rene Scharfe"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"28419","messageId":"4528F8AD.2040307@gmail.com","threadId":"5856","inReplyTo":null,"subject":"git-tar-tree & NEEDS_PREFIX","fromName":"Jiri Slaby","fromEmail":"jirislaby@gmail.com","sentAt":"2006-10-08T13:10:42Z","receivedAt":"2006-10-08T13:10:42Z","isPatch":false,"sender":{"key":"jirislaby@gmail.com","avatar":null},"body":"Hi,\n\nis there any good reason to have NEEDS_PREFIX flag for git-tar-tree builtin?\n\nI can't do --remote= tar-ing, but when I remove this flag from git.c, it seems \nto work correctly (prefix seems not to be used in any way).\n\nregards,\n-- \nhttp://www.fi.muni.cz/~xslaby/            Jiri Slaby\nfaculty of informatics, masaryk university, brno, cz\ne-mail: jirislaby gmail com, gpg pubkey fingerprint:\nB674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E\n"},{"id":"28422","messageId":"452900C0.6090406@lsrfire.ath.cx","threadId":"5856","inReplyTo":"4528F8AD.2040307@gmail.com","subject":"Re: git-tar-tree & NEEDS_PREFIX","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-10-08T13:44:32Z","receivedAt":"2006-10-08T13:44:32Z","isPatch":false,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Jiri Slaby schrieb:\n> is there any good reason to have NEEDS_PREFIX flag for git-tar-tree\n> builtin?\n> \n> I can't do --remote= tar-ing, but when I remove this flag from git.c, it\n> seems to work correctly (prefix seems not to be used in any way).\n\nGood point.  However, git-tar-tree has been deprecated in favour of\ngit-archive.  And NEEDS_PREFIX has been renamed to RUN_SETUP two months\nago, so an update might be in order. ;-)\n\nRené\n"},{"id":"28423","messageId":"452900D2.3070707@lsrfire.ath.cx","threadId":"5856","inReplyTo":"4528F8AD.2040307@gmail.com","subject":"[PATCH] git-tar-tree: don't RUN_SETUP","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-10-08T13:44:50Z","receivedAt":"2006-10-08T13:44:50Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Noted by Jiri Slaby, git-tar-tree --remote doesn't need to be run\nfrom inside of a git archive.  Since git-tar-tree is now only a\nwrapper for git-archive, which calls setup_git_directory() as\nneeded, we should drop the flag RUN_SETUP.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n\ndiff --git a/git.c b/git.c\nindex b8e8622..d7103a4 100644\n--- a/git.c\n+++ b/git.c\n@@ -258,7 +258,7 @@ static void handle_internal_command(int \n \t\t{ \"show\", cmd_show, RUN_SETUP | USE_PAGER },\n \t\t{ \"stripspace\", cmd_stripspace },\n \t\t{ \"symbolic-ref\", cmd_symbolic_ref, RUN_SETUP },\n-\t\t{ \"tar-tree\", cmd_tar_tree, RUN_SETUP },\n+\t\t{ \"tar-tree\", cmd_tar_tree },\n \t\t{ \"unpack-objects\", cmd_unpack_objects, RUN_SETUP },\n \t\t{ \"update-index\", cmd_update_index, RUN_SETUP },\n \t\t{ \"update-ref\", cmd_update_ref, RUN_SETUP },\n"}]}