{"thread":{"id":"58509","subject":"[filter-repo PATCH] fix links to git-fast-import","startedAt":"2022-09-24T03:38:01Z","lastAt":"2022-09-25T00:08:51Z","messageCount":4,"participants":["Todd Zullinger","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"463563","messageId":"20220924033708.2409170-1-tmz@pobox.com","threadId":"58509","inReplyTo":null,"subject":"[filter-repo PATCH] fix links to git-fast-import","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-09-24T03:37:08Z","receivedAt":"2022-09-24T03:38:01Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"The name of the html and man page for `git-fast-import` is missing the\n`git-` prefix. Add it where appropriate.\n\nSigned-off-by: Todd Zullinger \n---\nHi Elijah,\n\nI noticed the link to git-fast-import.html in git-filter-repo.html was\nmissing the `git-` prefix. The man page similarly lacked it when\nreferencing it.\n\n html/git-filter-repo.html | 2 +-\n man1/git-filter-repo.1 | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/html/git-filter-repo.html b/html/git-filter-repo.html\nindex 3143fd9..5119fa2 100644\n--- a/html/git-filter-repo.html\n+++ b/html/git-filter-repo.html\n@@ -2167,7 +2167,7 @@ that filter-repo uses bytestrings (see\n instead of strings.

\n

There are four callbacks that allow you to operate directly on raw\n objects that contain data that’s easy to write in\n-fast-import(1) format:

\n+git-fast-import(1) format:

\n
\n
\n 
--blob-callback\ndiff --git a/man1/git-filter-repo.1 b/man1/git-filter-repo.1\nindex 188fd2a..9f9bbfc 100644\n--- a/man1/git-filter-repo.1\n+++ b/man1/git-filter-repo.1\n@@ -1512,7 +1512,7 @@ def foo_callback(foo):\n .sp\n Thus, you just need to make sure your \\fIBODY\\fR modifies and returns \\fIfoo\\fR appropriately\\&. One important thing to note for all callbacks is that filter\\-repo uses bytestrings (see \\m[blue]\\fBhttps://docs\\&.python\\&.org/3/library/stdtypes\\&.html#bytes\\fR\\m[]) everywhere instead of strings\\&.\n .sp\n-There are four callbacks that allow you to operate directly on raw objects that contain data that\\(cqs easy to write in \\fBfast-import\\fR(1) format:\n+There are four callbacks that allow you to operate directly on raw objects that contain data that\\(cqs easy to write in \\fBgit-fast-import\\fR(1) format:\n .sp\n .if n \\{\\\n .RS 4\n-- \n2.38.0.rc1\n\n"},{"id":"463585","messageId":"CABPp-BHPYa4Lzj0Kt-q+qyA+qpo3BLkoMoQOo7sPNoo-0RTxKA@mail.gmail.com","threadId":"58509","inReplyTo":"20220924033708.2409170-1-tmz@pobox.com","subject":"Re: [filter-repo PATCH] fix links to git-fast-import","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-09-24T22:06:02Z","receivedAt":"2022-09-24T22:06:19Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Fri, Sep 23, 2022 at 8:37 PM Todd Zullinger  wrote:\n>\n> The name of the html and man page for `git-fast-import` is missing the\n> `git-` prefix.  Add it where appropriate.\n\nThanks for noticing and reporting.\n\n> Signed-off-by: Todd Zullinger \n> ---\n> Hi Elijah,\n>\n> I noticed the link to git-fast-import.html in git-filter-repo.html was\n> missing the `git-` prefix.  The man page similarly lacked it when\n> referencing it.\n>\n>  html/git-filter-repo.html | 2 +-\n>  man1/git-filter-repo.1    | 2 +-\n\nNeither of these files are tracked; both are auto-generated.  I do\nstuff them into the \"docs\" branch so people can grab them...but\nthey'll just be wiped out and overwritten the next time I build the\ndocs.  So, either the documentation source file is wrong, or the build\nprocess is.\n\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/html/git-filter-repo.html b/html/git-filter-repo.html\n> index 3143fd9..5119fa2 100644\n> --- a/html/git-filter-repo.html\n> +++ b/html/git-filter-repo.html\n> @@ -2167,7 +2167,7 @@ that filter-repo uses bytestrings (see\n>  instead of strings.
\n>

There are four callbacks that allow you to operate directly on raw\n> objects that contain data that’s easy to write in\n> -fast-import(1) format:

\n> +git-fast-import(1) format:

\n>
\n>
\n> 
--blob-callback\n> diff --git a/man1/git-filter-repo.1 b/man1/git-filter-repo.1\n> index 188fd2a..9f9bbfc 100644\n> --- a/man1/git-filter-repo.1\n> +++ b/man1/git-filter-repo.1\n> @@ -1512,7 +1512,7 @@ def foo_callback(foo):\n>  .sp\n>  Thus, you just need to make sure your \\fIBODY\\fR modifies and returns \\fIfoo\\fR appropriately\\&. One important thing to note for all callbacks is that filter\\-repo uses bytestrings (see \\m[blue]\\fBhttps://docs\\&.python\\&.org/3/library/stdtypes\\&.html#bytes\\fR\\m[]) everywhere instead of strings\\&.\n>  .sp\n> -There are four callbacks that allow you to operate directly on raw objects that contain data that\\(cqs easy to write in \\fBfast-import\\fR(1) format:\n> +There are four callbacks that allow you to operate directly on raw objects that contain data that\\(cqs easy to write in \\fBgit-fast-import\\fR(1) format:\n>  .sp\n>  .if n \\{\\\n>  .RS 4\n> --\n> 2.38.0.rc1\n\nIs the real problem that in this text from Documentation/git-filter-repo.txt:\n\n    There are four callbacks that allow you to operate directly on raw\n    objects that contain data that's easy to write in\n    linkgit:fast-import[1] format:\n\nthat there should be a \"git-\" on the last line?\n"},{"id":"463587","messageId":"Yy+GzB0gTBHaJJw1@pobox.com","threadId":"58509","inReplyTo":"CABPp-BHPYa4Lzj0Kt-q+qyA+qpo3BLkoMoQOo7sPNoo-0RTxKA@mail.gmail.com","subject":"Re: [filter-repo PATCH] fix links to git-fast-import","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-09-24T22:38:04Z","receivedAt":"2022-09-24T22:42:49Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Hi,\n\nElijah Newren wrote:\n> On Fri, Sep 23, 2022 at 8:37 PM Todd Zullinger  wrote:\n>> I noticed the link to git-fast-import.html in git-filter-repo.html was\n>> missing the `git-` prefix.  The man page similarly lacked it when\n>> referencing it.\n>>\n>>  html/git-filter-repo.html | 2 +-\n>>  man1/git-filter-repo.1    | 2 +-\n> \n> Neither of these files are tracked; both are auto-generated.  I do\n> stuff them into the \"docs\" branch so people can grab them...but\n> they'll just be wiped out and overwritten the next time I build the\n> docs.  So, either the documentation source file is wrong, or the build\n> process is.\n\nD'oh! I should have looked closer at the build process.\nSomehow I saw the docs branch and just _assumed_ it was the\nsource.  And that required looking right past the asciidoc\nversion in Documentation/ on the main branch. ;)\n\nI was clearly a few too many tangents deep.\n\n> Is the real problem that in this text from Documentation/git-filter-repo.txt:\n> \n>     There are four callbacks that allow you to operate directly on raw\n>     objects that contain data that's easy to write in\n>     linkgit:fast-import[1] format:\n> \n> that there should be a \"git-\" on the last line?\n\nIndeed, thanks.\n\nThis should work (I tested by symlinking git-filter-repo.txt\nto git's Documentation, as the Makefile does):\n\n-- 8< --\nSubject: [PATCH] git-filter-repo.txt: add missing `git-` prefix to fast-import\n link\n\nSigned-off-by: Todd Zullinger \n---\n Documentation/git-filter-repo.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-filter-repo.txt b/Documentation/git-filter-repo.txt\nindex 9c00a78..09374a4 100644\n--- a/Documentation/git-filter-repo.txt\n+++ b/Documentation/git-filter-repo.txt\n@@ -1047,7 +1047,7 @@ instead of strings.\n \n There are four callbacks that allow you to operate directly on raw\n objects that contain data that's easy to write in\n-linkgit:fast-import[1] format:\n+linkgit:git-fast-import[1] format:\n \n --------------------------------------------------\n --blob-callback\n-- 8< --\n\n-- \nTodd\n"},{"id":"463590","messageId":"CABPp-BFwJr7xLhdbdbh+eFhaSF36cLEzKbzc7gpuit=iC2Eejg@mail.gmail.com","threadId":"58509","inReplyTo":"Yy+GzB0gTBHaJJw1@pobox.com","subject":"Re: [filter-repo PATCH] fix links to git-fast-import","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-09-25T00:08:32Z","receivedAt":"2022-09-25T00:08:51Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sat, Sep 24, 2022 at 3:38 PM Todd Zullinger  wrote:\n>\n> Hi,\n>\n> Elijah Newren wrote:\n> > On Fri, Sep 23, 2022 at 8:37 PM Todd Zullinger  wrote:\n> >> I noticed the link to git-fast-import.html in git-filter-repo.html was\n> >> missing the `git-` prefix.  The man page similarly lacked it when\n> >> referencing it.\n> >>\n> >>  html/git-filter-repo.html | 2 +-\n> >>  man1/git-filter-repo.1    | 2 +-\n> >\n> > Neither of these files are tracked; both are auto-generated.  I do\n> > stuff them into the \"docs\" branch so people can grab them...but\n> > they'll just be wiped out and overwritten the next time I build the\n> > docs.  So, either the documentation source file is wrong, or the build\n> > process is.\n>\n> D'oh! I should have looked closer at the build process.\n> Somehow I saw the docs branch and just _assumed_ it was the\n> source.  And that required looking right past the asciidoc\n> version in Documentation/ on the main branch. ;)\n>\n> I was clearly a few too many tangents deep.\n>\n> > Is the real problem that in this text from Documentation/git-filter-repo.txt:\n> >\n> >     There are four callbacks that allow you to operate directly on raw\n> >     objects that contain data that's easy to write in\n> >     linkgit:fast-import[1] format:\n> >\n> > that there should be a \"git-\" on the last line?\n>\n> Indeed, thanks.\n>\n> This should work (I tested by symlinking git-filter-repo.txt\n> to git's Documentation, as the Makefile does):\n>\n> -- 8< --\n> Subject: [PATCH] git-filter-repo.txt: add missing `git-` prefix to fast-import\n>  link\n>\n> Signed-off-by: Todd Zullinger \n> ---\n>  Documentation/git-filter-repo.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-filter-repo.txt b/Documentation/git-filter-repo.txt\n> index 9c00a78..09374a4 100644\n> --- a/Documentation/git-filter-repo.txt\n> +++ b/Documentation/git-filter-repo.txt\n> @@ -1047,7 +1047,7 @@ instead of strings.\n>\n>  There are four callbacks that allow you to operate directly on raw\n>  objects that contain data that's easy to write in\n> -linkgit:fast-import[1] format:\n> +linkgit:git-fast-import[1] format:\n>\n>  --------------------------------------------------\n>  --blob-callback\n> -- 8< --\n\nThanks, applied!\n"}]}