{"thread":{"id":"58468","subject":"[PATCH] gc: don't translate literal commands","startedAt":"2022-09-20T05:07:50Z","lastAt":"2022-09-21T17:35:22Z","messageCount":5,"participants":["Alex Henrie","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"463274","messageId":"20220920050725.326383-1-alexhenrie24@gmail.com","threadId":"58468","inReplyTo":null,"subject":"[PATCH] gc: don't translate literal commands","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2022-09-20T05:07:25Z","receivedAt":"2022-09-20T05:07:50Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"These commands have no placeholders to be translated.\n\nSigned-off-by: Alex Henrie \n---\n builtin/gc.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/gc.c b/builtin/gc.c\nindex 0accc02406..2753bd15a5 100644\n--- a/builtin/gc.c\n+++ b/builtin/gc.c\n@@ -1461,7 +1461,7 @@ static char *get_maintpath(void)\n }\n \n static char const * const builtin_maintenance_register_usage[] = {\n-\tN_(\"git maintenance register\"),\n+\t\"git maintenance register\",\n \tNULL\n };\n \n@@ -1519,7 +1519,7 @@ static int maintenance_register(int argc, const char **argv, const char *prefix)\n }\n \n static char const * const builtin_maintenance_unregister_usage[] = {\n-\tN_(\"git maintenance unregister\"),\n+\t\"git maintenance unregister\",\n \tNULL\n };\n \n@@ -2542,7 +2542,7 @@ static int maintenance_start(int argc, const char **argv, const char *prefix)\n }\n \n static const char *const builtin_maintenance_stop_usage[] = {\n-\tN_(\"git maintenance stop\"),\n+\t\"git maintenance stop\",\n \tNULL\n };\n \n-- \n2.37.3\n\n"},{"id":"463322","messageId":"YyoPXmNGAvl6p+C2@coredump.intra.peff.net","threadId":"58468","inReplyTo":"20220920050725.326383-1-alexhenrie24@gmail.com","subject":"Re: [PATCH] gc: don't translate literal commands","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2022-09-20T19:07:10Z","receivedAt":"2022-09-20T19:07:17Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:\n\n> These commands have no placeholders to be translated.\n\nI think this is the right thing to do, but your commit message made me\npause for a second. When you say \"placeholders\", I think you mean %s,\netc. And yes there aren't any here, but that is not the reason not to\ntranslate. The reason not to translate is that the strings are commands\nwhich are given to a machine.\n\nSo maybe something like:\n\n There are no human-readable parts of these strings; the command you\n type is still \"git maintenance\" even in other languages.\n\nRegardless, the patch looks good to me. Thanks for catching it.\n\n-Peff\n"},{"id":"463325","messageId":"CAMMLpeRCHbp0OgsXOoMhJcUjS=sUCDJmcA=S1_dbd6Vk31C3+w@mail.gmail.com","threadId":"58468","inReplyTo":"YyoPXmNGAvl6p+C2@coredump.intra.peff.net","subject":"Re: [PATCH] gc: don't translate literal commands","fromName":"Alex Henrie","fromEmail":"alexhenrie24@gmail.com","sentAt":"2022-09-20T19:43:56Z","receivedAt":"2022-09-20T19:44:13Z","isPatch":true,"sender":{"key":"alexhenrie24@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5951993?v=4"},"body":"On Tue, Sep 20, 2022 at 1:07 PM Jeff King wrote:\n>\n> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:\n>\n> > These commands have no placeholders to be translated.\n>\n> I think this is the right thing to do, but your commit message made me\n> pause for a second. When you say \"placeholders\", I think you mean %s,\n> etc. And yes there aren't any here, but that is not the reason not to\n> translate. The reason not to translate is that the strings are commands\n> which are given to a machine.\n>\n> So maybe something like:\n>\n> There are no human-readable parts of these strings; the command you\n> type is still \"git maintenance\" even in other languages.\n\nBy \"placeholders\" I mean \"things in angle brackets\", like some of the\nother usage strings in this file have. Maybe \"argument placeholders\"\nwould be more clear. I like that term a little better than the term\n\"human-readable parts\" because these strings are part of the user\ninterface, so humans have to read them. But I really don't care\nwhether there's any explanation in the commit message at all. Junio\ncould just drop the sentence altogether when he commits the patch.\n\n> Regardless, the patch looks good to me. Thanks for catching it.\n\nNo problem, and thanks for the feedback.\n\n-Alex\n"},{"id":"463328","messageId":"Yyoawl2UyU/kEX+j@coredump.intra.peff.net","threadId":"58468","inReplyTo":"CAMMLpeRCHbp0OgsXOoMhJcUjS=sUCDJmcA=S1_dbd6Vk31C3+w@mail.gmail.com","subject":"Re: [PATCH] gc: don't translate literal commands","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2022-09-20T19:55:46Z","receivedAt":"2022-09-20T19:55:51Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Sep 20, 2022 at 01:43:56PM -0600, Alex Henrie wrote:\n\n> > So maybe something like:\n> >\n> > There are no human-readable parts of these strings; the command you\n> > type is still \"git maintenance\" even in other languages.\n> \n> By \"placeholders\" I mean \"things in angle brackets\", like some of the\n> other usage strings in this file have. Maybe \"argument placeholders\"\n> would be more clear. I like that term a little better than the term\n> \"human-readable parts\" because these strings are part of the user\n> interface, so humans have to read them. But I really don't care\n> whether there's any explanation in the commit message at all. Junio\n> could just drop the sentence altogether when he commits the patch.\n\nYeah. It was mostly that the term actively misled me. ;) Just the\nsubject (with \"literal command\") would probably be enough in this case.\n\n-Peff\n"},{"id":"463378","messageId":"xmqqa66s4oml.fsf@gitster.g","threadId":"58468","inReplyTo":"YyoPXmNGAvl6p+C2@coredump.intra.peff.net","subject":"Re: [PATCH] gc: don't translate literal commands","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-21T17:35:14Z","receivedAt":"2022-09-21T17:35:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Mon, Sep 19, 2022 at 11:07:25PM -0600, Alex Henrie wrote:\n>\n>> These commands have no placeholders to be translated.\n>\n> I think this is the right thing to do, but your commit message made me\n> pause for a second. When you say \"placeholders\", I think you mean %s,\n> etc. And yes there aren't any here, but that is not the reason not to\n> translate. The reason not to translate is that the strings are commands\n> which are given to a machine.\n\nI had the same reaction. The strings shown in the choices need to\nbe given as spelled and there is no i18n there.\n\n\n> So maybe something like:\n>\n> There are no human-readable parts of these strings; the command you\n> type is still \"git maintenance\" even in other languages.\n\nI think calling that \"no human-readable\" would probably give another\nconfusion, though.\n\nThe title uses a good phrase: \"literal commands\", so the latter half\nof your rewrite should be sufficient.\n\n The command you type is still \"git maintenance\" even in other\n languages.\n\n> Regardless, the patch looks good to me. Thanks for catching it.\n\nYes. Good finding.\n\nWill apply.\n"}]}