{"thread":{"id":"5846","subject":"[PATCH 1/2] git-archive --format=zip: use default version ID","startedAt":"2006-10-06T23:47:24Z","lastAt":"2006-10-06T23:47:24Z","messageCount":1,"participants":["Rene Scharfe"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"28334","messageId":"4526EB0C.6000802@lsrfire.ath.cx","threadId":"5846","inReplyTo":null,"subject":"[PATCH 1/2] git-archive --format=zip: use default version ID","fromName":"Rene Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2006-10-06T23:47:24Z","receivedAt":"2006-10-06T23:47:24Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Use 10 for the \"version needed to extract\" field.  This is the\ndefault value, and we want to use it because we don't do anything\nspecial.  Info-ZIP's zip uses it, too.\n\nSigned-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n archive-zip.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/archive-zip.c b/archive-zip.c\nindex 3ffdad6..ae74623 100644\n--- a/archive-zip.c\n+++ b/archive-zip.c\n@@ -214,7 +214,7 @@ static int write_zip_entry(const unsigne\n \n \tcopy_le32(dirent.magic, 0x02014b50);\n \tcopy_le16(dirent.creator_version, 0);\n-\tcopy_le16(dirent.version, 20);\n+\tcopy_le16(dirent.version, 10);\n \tcopy_le16(dirent.flags, 0);\n \tcopy_le16(dirent.compression_method, method);\n \tcopy_le16(dirent.mtime, zip_time);\n@@ -236,7 +236,7 @@ static int write_zip_entry(const unsigne\n \tzip_dir_entries++;\n \n \tcopy_le32(header.magic, 0x04034b50);\n-\tcopy_le16(header.version, 20);\n+\tcopy_le16(header.version, 10);\n \tcopy_le16(header.flags, 0);\n \tcopy_le16(header.compression_method, method);\n \tcopy_le16(header.mtime, zip_time);\n-- \n1.4.2.3.gf59615\n"}]}