{"thread":{"id":"58445","subject":"[PATCH] help: reword explanation line for developer interfaces","startedAt":"2022-09-16T13:05:36Z","lastAt":"2022-09-16T16:19:24Z","messageCount":2,"participants":["Fangyi Zhou via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"463076","messageId":"pull.1330.git.git.1663333529294.gitgitgadget@gmail.com","threadId":"58445","inReplyTo":null,"subject":"[PATCH] help: reword explanation line for developer interfaces","fromName":"Fangyi Zhou via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-09-16T13:05:29Z","receivedAt":"2022-09-16T13:05:36Z","isPatch":true,"sender":{"key":"me@fangyi.io","avatar":"https://avatars.githubusercontent.com/u/7815439?v=4"},"body":"From: Fangyi Zhou <me@fangyi.io>\n\nSigned-off-by: Fangyi Zhou <me@fangyi.io>\n---\n    help: reword explanation line for developer interfaces\n    \n    Signed-off-by: Fangyi Zhou me@fangyi.io\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1330%2Ffangyi-zhou%2Fhelp-doc-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1330/fangyi-zhou/help-doc-fix-v1\nPull-Request: https://github.com/git/git/pull/1330\n\n help.c          | 2 +-\n t/t0012-help.sh | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/help.c b/help.c\nindex ec670d5f68b..d04542d8261 100644\n--- a/help.c\n+++ b/help.c\n@@ -39,7 +39,7 @@ static struct category_description main_categories[] = {\n \t{ CAT_synchingrepositories, N_(\"Low-level Commands / Syncing Repositories\") },\n \t{ CAT_purehelpers, N_(\"Low-level Commands / Internal Helpers\") },\n \t{ CAT_userinterfaces, N_(\"User-facing repository, command and file interfaces\") },\n-\t{ CAT_developerinterfaces, N_(\"Developer-facing file file formats, protocols and interfaces\") },\n+\t{ CAT_developerinterfaces, N_(\"Developer-facing file formats, protocols and other interfaces\") },\n \t{ 0, NULL }\n };\n \ndiff --git a/t/t0012-help.sh b/t/t0012-help.sh\nindex 4ed2f242eb2..dbfc5c82676 100755\n--- a/t/t0012-help.sh\n+++ b/t/t0012-help.sh\n@@ -231,7 +231,7 @@ test_expect_success \"'git help -a' section spacing\" '\n \n \tUser-facing repository, command and file interfaces\n \n-\tDeveloper-facing file file formats, protocols and interfaces\n+\tDeveloper-facing file formats, protocols and other interfaces\n \tEOF\n \ttest_cmp expect actual\n '\n\nbase-commit: d3fa443f97e3a8d75b51341e2d5bac380b7422df\n-- \ngitgitgadget\n"},{"id":"463088","messageId":"xmqqsfkri96i.fsf@gitster.g","threadId":"58445","inReplyTo":"pull.1330.git.git.1663333529294.gitgitgadget@gmail.com","subject":"Re: [PATCH] help: reword explanation line for developer interfaces","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-16T16:19:17Z","receivedAt":"2022-09-16T16:19:24Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Fangyi Zhou via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Fangyi Zhou <me@fangyi.io>\n>\n> Signed-off-by: Fangyi Zhou <me@fangyi.io>\n> ---\n>     help: reword explanation line for developer interfaces\n>     \n>     Signed-off-by: Fangyi Zhou me@fangyi.io\n\n> -\t{ CAT_developerinterfaces, N_(\"Developer-facing file file formats, protocols and interfaces\") },\n> +\t{ CAT_developerinterfaces, N_(\"Developer-facing file formats, protocols and other interfaces\") },\n\nYuck.  Thanks for catching this.\n\n>  \t{ 0, NULL }\n>  };\n>  \n> diff --git a/t/t0012-help.sh b/t/t0012-help.sh\n> index 4ed2f242eb2..dbfc5c82676 100755\n> --- a/t/t0012-help.sh\n> +++ b/t/t0012-help.sh\n> @@ -231,7 +231,7 @@ test_expect_success \"'git help -a' section spacing\" '\n>  \n>  \tUser-facing repository, command and file interfaces\n>  \n> -\tDeveloper-facing file file formats, protocols and interfaces\n> +\tDeveloper-facing file formats, protocols and other interfaces\n>  \tEOF\n\nApparently the writer of the test was not doing a good job; and of\ncourse the reviewers, too X-.\n\nThese all came from 844739ba (git docs: add a category for file\nformats, protocols and interfaces, 2022-08-04), as a part of a\nlarge series.\n\nWill queue.\n"}]}