{"thread":{"id":"58443","subject":"[PATCH] bugreport: add missing closing bracket in usage line","startedAt":"2022-09-16T11:13:53Z","lastAt":"2022-09-16T16:31:32Z","messageCount":3,"participants":["Fangyi Zhou via GitGitGadget","Junio C Hamano","Fangyi Zhou"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"463073","messageId":"pull.1329.git.git.1663326823401.gitgitgadget@gmail.com","threadId":"58443","inReplyTo":null,"subject":"[PATCH] bugreport: add missing closing bracket in usage line","fromName":"Fangyi Zhou via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-09-16T11:13:43Z","receivedAt":"2022-09-16T11:13:53Z","isPatch":true,"sender":{"key":"me@fangyi.io","avatar":"https://avatars.githubusercontent.com/u/7815439?v=4"},"body":"From: Fangyi Zhou \n\nSigned-off-by: Fangyi Zhou \n---\n bugreport: add missing closing bracket in usage line\n \n Signed-off-by: Fangyi Zhou me@fangyi.io\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1329%2Ffangyi-zhou%2Fbugreport-usage-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1329/fangyi-zhou/bugreport-usage-fix-v1\nPull-Request: https://github.com/git/git/pull/1329\n\n builtin/bugreport.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/bugreport.c b/builtin/bugreport.c\nindex 530895be55f..a4a5a88840d 100644\n--- a/builtin/bugreport.c\n+++ b/builtin/bugreport.c\n@@ -60,7 +60,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)\n }\n \n static const char * const bugreport_usage[] = {\n-\tN_(\"git bugreport [-o|--output-directory ] [-s|--suffix ] [--diagnose[=]\"),\n+\tN_(\"git bugreport [-o|--output-directory ] [-s|--suffix ] [--diagnose[=]]\"),\n \tNULL\n };\n \n\nbase-commit: d3fa443f97e3a8d75b51341e2d5bac380b7422df\n-- \ngitgitgadget\n"},{"id":"463085","messageId":"xmqq4jx7joez.fsf@gitster.g","threadId":"58443","inReplyTo":"pull.1329.git.git.1663326823401.gitgitgadget@gmail.com","subject":"Re: [PATCH] bugreport: add missing closing bracket in usage line","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-16T16:04:52Z","receivedAt":"2022-09-16T16:05:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Fangyi Zhou via GitGitGadget\" writes:\n\n> From: Fangyi Zhou \n>\n> Signed-off-by: Fangyi Zhou \n> ---\n> bugreport: add missing closing bracket in usage line\n> \n> Signed-off-by: Fangyi Zhou me@fangyi.io\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1329%2Ffangyi-zhou%2Fbugreport-usage-fix-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1329/fangyi-zhou/bugreport-usage-fix-v1\n> Pull-Request: https://github.com/git/git/pull/1329\n>\n> builtin/bugreport.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/builtin/bugreport.c b/builtin/bugreport.c\n> index 530895be55f..a4a5a88840d 100644\n> --- a/builtin/bugreport.c\n> +++ b/builtin/bugreport.c\n> @@ -60,7 +60,7 @@ static void get_populated_hooks(struct strbuf *hook_info, int nongit)\n> }\n> \n> static const char * const bugreport_usage[] = {\n> -\tN_(\"git bugreport [-o|--output-directory ] [-s|--suffix ] [--diagnose[=]\"),\n> +\tN_(\"git bugreport [-o|--output-directory ] [-s|--suffix ] [--diagnose[=]]\"),\n> \tNULL\n> };\n\nOK, this came from aac0e8ff (builtin/bugreport.c: create\n'--diagnose' option, 2022-08-12), which gets the SYNOPSIS\nin the documentation right but misses the usage text.\n\nAn identical fix already exists as 63407051 (doc txt & -h\nconsistency: add missing \"]\" to bugreport \"-h\", 2022-09-05).\n\nIt may help the project more to help move the topic that contains it\nforward by reviewing them, than independently coming up with an\nidentical fix. The topic with the existing fix appears at\n\n https://lore.kernel.org/git/cover-00.34-00000000000-20220902T092734Z-avarab@gmail.com/\n\nThanks.\n"},{"id":"463091","messageId":"CAEpW-9=o2nmanc6GyeRVhwZNsU-g0A=uSYvNJZQkFg9rvkJ2_g@mail.gmail.com","threadId":"58443","inReplyTo":"xmqq4jx7joez.fsf@gitster.g","subject":"Re: [PATCH] bugreport: add missing closing bracket in usage line","fromName":"Fangyi Zhou","fromEmail":"me@fangyi.io","sentAt":"2022-09-16T16:31:15Z","receivedAt":"2022-09-16T16:31:32Z","isPatch":true,"sender":{"key":"me@fangyi.io","avatar":"https://avatars.githubusercontent.com/u/7815439?v=4"},"body":"On Fri, 16 Sept 2022 at 17:04, Junio C Hamano wrote:\n>\n> An identical fix already exists as 63407051 (doc txt & -h\n> consistency: add missing \"]\" to bugreport \"-h\", 2022-09-05).\n>\n\nThanks for pointing this out. I'm sorry that I wasn't aware of the fix.\n\n> It may help the project more to help move the topic that contains it\n> forward by reviewing them, than independently coming up with an\n> identical fix. The topic with the existing fix appears at\n>\n> https://lore.kernel.org/git/cover-00.34-00000000000-20220902T092734Z-avarab@gmail.com/\n>\n> Thanks.\n\nI did a quick search on the mailing list webpage and didn't find\nanything immediately. Apologies for the noise.\nI only work with l10n every once a few months, and I hope that is not\ntoo unhelpful when I submit minor patches of i18n text when I find\nissues.\n\nBest and Have a nice weekend,\nFangyi\n"}]}