{"thread":{"id":"58440","subject":"[PATCH] docs: fix a few recently broken links","startedAt":"2022-09-16T06:23:34Z","lastAt":"2022-09-16T15:40:04Z","messageCount":4,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"463067","messageId":"20220916062303.3736166-1-tmz@pobox.com","threadId":"58440","inReplyTo":null,"subject":"[PATCH] docs: fix a few recently broken links","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-09-16T06:23:02Z","receivedAt":"2022-09-16T06:23:34Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Some links were broken in the recent move of various technical docs\nc0f6dd49f1 (Merge branch 'ab/tech-docs-to-help', 2022-08-14).\n\nFix them.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n Documentation/gitprotocol-capabilities.txt | 4 ++--\n Documentation/gitprotocol-v2.txt           | 4 ++--\n Documentation/technical/bundle-uri.txt     | 3 +--\n Documentation/user-manual.txt              | 2 +-\n 4 files changed, 6 insertions(+), 7 deletions(-)\n\ndiff --git a/Documentation/gitprotocol-capabilities.txt b/Documentation/gitprotocol-capabilities.txt\nindex c6dcc7d565..0fb5ea0c1c 100644\n--- a/Documentation/gitprotocol-capabilities.txt\n+++ b/Documentation/gitprotocol-capabilities.txt\n@@ -388,8 +388,8 @@ the server as well.\n Session IDs should be unique to a given process. They must fit within a\n packet-line, and must not contain non-printable or whitespace characters. The\n current implementation uses trace2 session IDs (see\n-link:api-trace2.html[api-trace2] for details), but this may change and users of\n-the session ID should not rely on this fact.\n+link:technical/api-trace2.html[api-trace2] for details), but this may change\n+and users of the session ID should not rely on this fact.\n \n GIT\n ---\ndiff --git a/Documentation/gitprotocol-v2.txt b/Documentation/gitprotocol-v2.txt\nindex c9c0f9160b..59bf41cefb 100644\n--- a/Documentation/gitprotocol-v2.txt\n+++ b/Documentation/gitprotocol-v2.txt\n@@ -544,8 +544,8 @@ the server as well.\n Session IDs should be unique to a given process. They must fit within a\n packet-line, and must not contain non-printable or whitespace characters. The\n current implementation uses trace2 session IDs (see\n-link:api-trace2.html[api-trace2] for details), but this may change and users of\n-the session ID should not rely on this fact.\n+link:technical/api-trace2.html[api-trace2] for details), but this may change\n+and users of the session ID should not rely on this fact.\n \n object-info\n ~~~~~~~~~~~\ndiff --git a/Documentation/technical/bundle-uri.txt b/Documentation/technical/bundle-uri.txt\nindex c25c42378a..85c6a7fc7c 100644\n--- a/Documentation/technical/bundle-uri.txt\n+++ b/Documentation/technical/bundle-uri.txt\n@@ -3,8 +3,7 @@ Bundle URIs\n \n Git bundles are files that store a pack-file along with some extra metadata,\n including a set of refs and a (possibly empty) set of necessary commits. See\n-linkgit:git-bundle[1] and link:bundle-format.txt[the bundle format] for more\n-information.\n+linkgit:git-bundle[1] and linkgit:gitformat-bundle[5] for more information.\n \n Bundle URIs are locations where Git can download one or more bundles in\n order to bootstrap the object database in advance of fetching the remaining\ndiff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\nindex ca9decdd95..dc9c6a663a 100644\n--- a/Documentation/user-manual.txt\n+++ b/Documentation/user-manual.txt\n@@ -3133,7 +3133,7 @@ those \"loose\" objects.\n You can save space and make Git faster by moving these loose objects in\n to a \"pack file\", which stores a group of objects in an efficient\n compressed format; the details of how pack files are formatted can be\n-found in link:gitformat-pack[5].\n+found in linkgit:gitformat-pack[5].\n \n To put the loose objects into a pack, just run git repack:\n \n"},{"id":"463068","messageId":"20220916062303.3736166-2-tmz@pobox.com","threadId":"58440","inReplyTo":"20220916062303.3736166-1-tmz@pobox.com","subject":"[PATCH] api docs: link to html version of api-trace2","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2022-09-16T06:23:03Z","receivedAt":"2022-09-16T06:23:45Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"In f6d25d7878 (api docs: document that BUG() emits a trace2 error event,\n2021-04-13), a link to the plain text version of api-trace2 was added in\n`technical/api-error-handling.txt`.\n\nAll of our other `link:`s point to the html versions.  Do the same here.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\nThis is minor, but I noticed it while working on the previous patch.  The\neffect can be see at [1] where we link to [2].\n\nSomewhat related, it also appears that the link to the API docs in the \"Further\ndocumentation\" section on git-scm.com is broken entirely[3].  I didn't try to\nchase down why that might be, but perhaps someone who knows the site build\nprocess can fix it up.\n\n[1] https://mirrors.edge.kernel.org/pub/software/scm/git/docs/technical/api-error-handling.html\n[2] https://mirrors.edge.kernel.org/pub/software/scm/git/docs/technical/api-trace2.txt\n[3] https://git-scm.com/docs/git#_further_documentation\n\n Documentation/technical/api-error-handling.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/technical/api-error-handling.txt b/Documentation/technical/api-error-handling.txt\nindex 70bf1d3e52..665c4960b4 100644\n--- a/Documentation/technical/api-error-handling.txt\n+++ b/Documentation/technical/api-error-handling.txt\n@@ -46,7 +46,7 @@ parse-options.c.\n   returns -1 after reporting the situation to the caller.\n \n These reports will be logged via the trace2 facility. See the \"error\"\n-event in link:api-trace2.txt[trace2 API].\n+event in link:api-trace2.html[trace2 API].\n \n Customizable error handlers\n ---------------------------\n"},{"id":"463079","messageId":"xmqqzgezjppd.fsf@gitster.g","threadId":"58440","inReplyTo":"20220916062303.3736166-1-tmz@pobox.com","subject":"Re: [PATCH] docs: fix a few recently broken links","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-16T15:37:02Z","receivedAt":"2022-09-16T15:37:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> Some links were broken in the recent move of various technical docs\n> c0f6dd49f1 (Merge branch 'ab/tech-docs-to-help', 2022-08-14).\n>\n> Fix them.\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n\nThanks.\n\nIt is a bit sad that the links can only be relative (with which, a\nmove like c0f6dd49f1 can easily break them) or absolute (with which,\nit is impossible to \"hang\" the entire documentation set under some\nhierarchy in a larger set of pages).  I suppose that use of base\nhref might help, but it would make the result more cumbersome to set\nup with than the fully relative collection of pages, which is what\nwe have.\n\n> diff --git a/Documentation/technical/bundle-uri.txt b/Documentation/technical/bundle-uri.txt\n> index c25c42378a..85c6a7fc7c 100644\n> --- a/Documentation/technical/bundle-uri.txt\n> +++ b/Documentation/technical/bundle-uri.txt\n> @@ -3,8 +3,7 @@ Bundle URIs\n>  \n>  Git bundles are files that store a pack-file along with some extra metadata,\n>  including a set of refs and a (possibly empty) set of necessary commits. See\n> -linkgit:git-bundle[1] and link:bundle-format.txt[the bundle format] for more\n> -information.\n> +linkgit:git-bundle[1] and linkgit:gitformat-bundle[5] for more information.\n\nGood.  Thanks for being careful.\n\n>  Bundle URIs are locations where Git can download one or more bundles in\n>  order to bootstrap the object database in advance of fetching the remaining\n> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt\n> index ca9decdd95..dc9c6a663a 100644\n> --- a/Documentation/user-manual.txt\n> +++ b/Documentation/user-manual.txt\n> @@ -3133,7 +3133,7 @@ those \"loose\" objects.\n>  You can save space and make Git faster by moving these loose objects in\n>  to a \"pack file\", which stores a group of objects in an efficient\n>  compressed format; the details of how pack files are formatted can be\n> -found in link:gitformat-pack[5].\n> +found in linkgit:gitformat-pack[5].\n\nThis, too.\n\nWill queue.\n"},{"id":"463081","messageId":"xmqqv8pnjpkm.fsf@gitster.g","threadId":"58440","inReplyTo":"20220916062303.3736166-2-tmz@pobox.com","subject":"Re: [PATCH] api docs: link to html version of api-trace2","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-16T15:39:53Z","receivedAt":"2022-09-16T15:40:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> In f6d25d7878 (api docs: document that BUG() emits a trace2 error event,\n> 2021-04-13), a link to the plain text version of api-trace2 was added in\n> `technical/api-error-handling.txt`.\n>\n> All of our other `link:`s point to the html versions.  Do the same here.\n>\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n> This is minor, but I noticed it while working on the previous patch.  The\n> effect can be see at [1] where we link to [2].\n\nThanks.\n"}]}