{"thread":{"id":"58416","subject":"[PATCH] ls-files: fix black space in error message","startedAt":"2022-09-11T14:03:27Z","lastAt":"2022-09-17T13:16:51Z","messageCount":3,"participants":["ZheNing Hu via GitGitGadget","Junio C Hamano","ZheNing Hu"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"462917","messageId":"pull.1350.git.1662904997760.gitgitgadget@gmail.com","threadId":"58416","inReplyTo":null,"subject":"[PATCH] ls-files: fix black space in error message","fromName":"ZheNing Hu via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-09-11T14:03:17Z","receivedAt":"2022-09-11T14:03:27Z","isPatch":true,"sender":{"key":"adlternative@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58138461?v=4"},"body":"From: ZheNing Hu <adlternative@gmail.com>\n\nce74de9(ls-files: introduce \"--format\" option) miss\na space between two words incorrectly, it leads to\nwrong i10n messages. So fix it by adding a space at\nthe end of the error message.\n\nSigned-off-by: ZheNing Hu <adlternative@gmail.com>\n---\n    ls-files: fix black space in error message\n    \n    This patch want fix a little typo error in builtin/ls-files.c, which\n    pointed out by Jiang Xin in [1].\n    \n    [1]:\n    https://lore.kernel.org/git/CANYiYbFGSfg+iFV1ovhCSxW0YQSpemKUN-sS+F0BHee7KD5arA@mail.gmail.com/.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1350%2Fadlternative%2Fzh%2Fls-file-format-error-mesage-fix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1350/adlternative/zh/ls-file-format-error-mesage-fix-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1350\n\n builtin/ls-files.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/ls-files.c b/builtin/ls-files.c\nindex 779dc18e59d..4cf8a236483 100644\n--- a/builtin/ls-files.c\n+++ b/builtin/ls-files.c\n@@ -257,7 +257,7 @@ static size_t expand_show_index(struct strbuf *sb, const char *start,\n \n \tend = strchr(start + 1, ')');\n \tif (!end)\n-\t\tdie(_(\"bad ls-files format: element '%s'\"\n+\t\tdie(_(\"bad ls-files format: element '%s' \"\n \t\t      \"does not end in ')'\"), start);\n \n \tlen = end - start + 1;\n\nbase-commit: dd3f6c4cae7e3b15ce984dce8593ff7569650e24\n-- \ngitgitgadget\n"},{"id":"462937","messageId":"xmqqwna8ftm5.fsf@gitster.g","threadId":"58416","inReplyTo":"pull.1350.git.1662904997760.gitgitgadget@gmail.com","subject":"Re: [PATCH] ls-files: fix black space in error message","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-09-12T16:24:50Z","receivedAt":"2022-09-12T16:24:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"ZheNing Hu via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: ZheNing Hu <adlternative@gmail.com>\n> Subject: Re: [PATCH] ls-files: fix black space in error message\n\n\"black\" -> \"missing\" perhaps?  I'll queue with the reword for now\nbut if you have a better alternative please holler.\n\n> ce74de9(ls-files: introduce \"--format\" option) miss a space\n> between two words incorrectly, it leads to wrong i10n messages. So\n> fix it by adding a space at the end of the error message.\n\nThanks.\n"},{"id":"463139","messageId":"CAOLTT8SJ_DoPrw7uu1wHnJTT5FukAJmHmWfjEAYYOY8BfSpuVQ@mail.gmail.com","threadId":"58416","inReplyTo":"xmqqwna8ftm5.fsf@gitster.g","subject":"Re: [PATCH] ls-files: fix black space in error message","fromName":"ZheNing Hu","fromEmail":"adlternative@gmail.com","sentAt":"2022-09-17T13:16:36Z","receivedAt":"2022-09-17T13:16:51Z","isPatch":true,"sender":{"key":"adlternative@gmail.com","avatar":"https://avatars.githubusercontent.com/u/58138461?v=4"},"body":"Junio C Hamano <gitster@pobox.com> 于2022年9月13日周二 00:24写道：\n>\n> \"ZheNing Hu via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n>\n> > From: ZheNing Hu <adlternative@gmail.com>\n> > Subject: Re: [PATCH] ls-files: fix black space in error message\n>\n> \"black\" -> \"missing\" perhaps?  I'll queue with the reword for now\n> but if you have a better alternative please holler.\n>\n\nUse the \"missing\" is ok, thanks,\n\n> > ce74de9(ls-files: introduce \"--format\" option) miss a space\n> > between two words incorrectly, it leads to wrong i10n messages. So\n> > fix it by adding a space at the end of the error message.\n>\n> Thanks.\n\nZheNing Hu\n"}]}