{"thread":{"id":"58330","subject":"[PATCH 1/2] p0004: fix prereq declaration","startedAt":"2022-08-19T20:49:40Z","lastAt":"2022-08-19T21:34:08Z","messageCount":4,"participants":["Victoria Dye via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"461613","messageId":"0e71792a718512089b94c0d5985db7fd8093c6a5.1660942149.git.gitgitgadget@gmail.com","threadId":"58330","inReplyTo":"pull.1330.git.1660942149.gitgitgadget@gmail.com","subject":"[PATCH 1/2] p0004: fix prereq declaration","fromName":"Victoria Dye via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-08-19T20:49:08Z","receivedAt":"2022-08-19T20:49:40Z","isPatch":true,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"From: Victoria Dye <vdye@github.com>\n\nFix multi-threaded 'p0004' test's use of the 'REPO_BIG_ENOUGH_FOR_MULTI'\nprerequisite. Unlike normal 't/' tests, 't/perf/' tests need to have their\nprerequisites declared with the '--prereq' flag.\n\nSigned-off-by: Victoria Dye <vdye@github.com>\n---\n t/perf/p0004-lazy-init-name-hash.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh\nindex 1afc08fe7f1..85be14e4ddb 100755\n--- a/t/perf/p0004-lazy-init-name-hash.sh\n+++ b/t/perf/p0004-lazy-init-name-hash.sh\n@@ -49,7 +49,7 @@ test_perf \"single-threaded, $desc\" \"\n \ttest-tool lazy-init-name-hash --single --count=$count\n \"\n \n-test_perf REPO_BIG_ENOUGH_FOR_MULTI \"multi-threaded, $desc\" \"\n+test_perf \"multi-threaded, $desc\" --prereq REPO_BIG_ENOUGH_FOR_MULTI \"\n \ttest-tool lazy-init-name-hash --multi --count=$count\n \"\n \n-- \ngitgitgadget\n\n"},{"id":"461614","messageId":"e79f23a66b28087b8690ff0f604b806babc49cd0.1660942149.git.gitgitgadget@gmail.com","threadId":"58330","inReplyTo":"pull.1330.git.1660942149.gitgitgadget@gmail.com","subject":"[PATCH 2/2] p0006: fix 'read-tree' argument ordering","fromName":"Victoria Dye via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-08-19T20:49:09Z","receivedAt":"2022-08-19T20:49:44Z","isPatch":true,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"From: Victoria Dye <vdye@github.com>\n\nIn the 'p0006' test \"read-tree br_base br_ballast\", move the '-n' flag used\nin 'git read-tree' ahead of its positional arguments.\n\nSigned-off-by: Victoria Dye <vdye@github.com>\n---\n t/perf/p0006-read-tree-checkout.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/perf/p0006-read-tree-checkout.sh b/t/perf/p0006-read-tree-checkout.sh\nindex 900b385c4bb..c481c012d2f 100755\n--- a/t/perf/p0006-read-tree-checkout.sh\n+++ b/t/perf/p0006-read-tree-checkout.sh\n@@ -46,7 +46,7 @@ test_expect_success \"setup repo\" '\n '\n \n test_perf \"read-tree br_base br_ballast ($nr_files)\" '\n-\tgit read-tree -m br_base br_ballast -n\n+\tgit read-tree -n -m br_base br_ballast\n '\n \n test_perf \"switch between br_base br_ballast ($nr_files)\" '\n-- \ngitgitgadget\n"},{"id":"461615","messageId":"pull.1330.git.1660942149.gitgitgadget@gmail.com","threadId":"58330","inReplyTo":null,"subject":"[PATCH 0/2] t/perf: fix broken tests","fromName":"Victoria Dye via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-08-19T20:49:07Z","receivedAt":"2022-08-19T20:49:47Z","isPatch":true,"sender":{"key":"vdye@github.com","avatar":"https://avatars.githubusercontent.com/u/3619353?v=4"},"body":"This series fixes two performance tests (p0004 & p0006) with syntax issues\npreventing them from running properly. Since these are pretty\nstraightforward syntax bugs, the fixes don't seem to change the intended\nbehavior of the tests.\n\nThanks!\n\n * Victoria\n\nVictoria Dye (2):\n  p0004: fix prereq declaration\n  p0006: fix 'read-tree' argument ordering\n\n t/perf/p0004-lazy-init-name-hash.sh | 2 +-\n t/perf/p0006-read-tree-checkout.sh  | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n\nbase-commit: 795ea8776befc95ea2becd8020c7a284677b4161\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1330%2Fvdye%2Fbugfix%2Fperf-test-bugs-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1330/vdye/bugfix/perf-test-bugs-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1330\n-- \ngitgitgadget\n"},{"id":"461631","messageId":"xmqqfshrkjeh.fsf@gitster.g","threadId":"58330","inReplyTo":"0e71792a718512089b94c0d5985db7fd8093c6a5.1660942149.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/2] p0004: fix prereq declaration","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-08-19T21:33:58Z","receivedAt":"2022-08-19T21:34:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Victoria Dye via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Victoria Dye <vdye@github.com>\n>\n> Fix multi-threaded 'p0004' test's use of the 'REPO_BIG_ENOUGH_FOR_MULTI'\n> prerequisite. Unlike normal 't/' tests, 't/perf/' tests need to have their\n> prerequisites declared with the '--prereq' flag.\n>\n> Signed-off-by: Victoria Dye <vdye@github.com>\n> ---\n>  t/perf/p0004-lazy-init-name-hash.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks.  It is unfortunate that we need to live with this seemingly\nunnecessary deviation.\n\n> diff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh\n> index 1afc08fe7f1..85be14e4ddb 100755\n> --- a/t/perf/p0004-lazy-init-name-hash.sh\n> +++ b/t/perf/p0004-lazy-init-name-hash.sh\n> @@ -49,7 +49,7 @@ test_perf \"single-threaded, $desc\" \"\n>  \ttest-tool lazy-init-name-hash --single --count=$count\n>  \"\n>  \n> -test_perf REPO_BIG_ENOUGH_FOR_MULTI \"multi-threaded, $desc\" \"\n> +test_perf \"multi-threaded, $desc\" --prereq REPO_BIG_ENOUGH_FOR_MULTI \"\n>  \ttest-tool lazy-init-name-hash --multi --count=$count\n>  \"\n"}]}