{"thread":{"id":"5832","subject":"[PATCH] Remove bashism from t3210-pack-refs.sh","startedAt":"2006-10-06T09:10:54Z","lastAt":"2006-10-06T16:33:59Z","messageCount":4,"participants":["Dennis Stosberg","Alex Riesen","Jakub Narebski","Linus Torvalds"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"28277","messageId":"20061006091054.15209.35068.stgit@leonov.stosberg.net","threadId":"5832","inReplyTo":null,"subject":"[PATCH] Remove bashism from t3210-pack-refs.sh","fromName":"Dennis Stosberg","fromEmail":"dennis@stosberg.net","sentAt":"2006-10-06T09:10:54Z","receivedAt":"2006-10-06T09:10:54Z","isPatch":true,"sender":{"key":"dennis@stosberg.net","avatar":null},"body":"This bashism makes the test fail if /bin/sh is not bash.\n\nSigned-off-by: Dennis Stosberg <dennis@stosberg.net>\n---\n\n t/t3210-pack-refs.sh |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/t/t3210-pack-refs.sh b/t/t3210-pack-refs.sh\nindex f31e79c..ca5bd49 100755\n--- a/t/t3210-pack-refs.sh\n+++ b/t/t3210-pack-refs.sh\n@@ -23,7 +23,7 @@ SHA1=\n test_expect_success \\\n     'see if git show-ref works as expected' \\\n     'git-branch a &&\n-     SHA1=$(< .git/refs/heads/a) &&\n+     SHA1=`cat .git/refs/heads/a` &&\n      echo \"$SHA1 refs/heads/a\" >expect &&\n      git-show-ref a >result &&\n      diff expect result'\n"},{"id":"28285","messageId":"81b0412b0610060635n51482e71wab02f9a11be4e619@mail.gmail.com","threadId":"5832","inReplyTo":"20061006091054.15209.35068.stgit@leonov.stosberg.net","subject":"Re: [PATCH] Remove bashism from t3210-pack-refs.sh","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-10-06T13:35:21Z","receivedAt":"2006-10-06T13:35:21Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"On 10/6/06, Dennis Stosberg <dennis@stosberg.net> wrote:\n> -     SHA1=$(< .git/refs/heads/a) &&\n> +     SHA1=`cat .git/refs/heads/a` &&\n\nOnly \"<\" (the redirection part) is bashism. The \"$()\" is POSIX.\n"},{"id":"28289","messageId":"eg5r9k$58c$1@sea.gmane.org","threadId":"5832","inReplyTo":"81b0412b0610060635n51482e71wab02f9a11be4e619@mail.gmail.com","subject":"Re: [PATCH] Remove bashism from t3210-pack-refs.sh","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-10-06T15:05:04Z","receivedAt":"2006-10-06T15:05:04Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Alex Riesen wrote:\n\n> On 10/6/06, Dennis Stosberg <dennis@stosberg.net> wrote:\n>> -     SHA1=$(< .git/refs/heads/a) &&\n>> +     SHA1=`cat .git/refs/heads/a` &&\n> \n> Only \"<\" (the redirection part) is bashism. The \"$()\" is POSIX.\n\nBTW. it is not packed-refs safe.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"28300","messageId":"Pine.LNX.4.64.0610060931160.3952@g5.osdl.org","threadId":"5832","inReplyTo":"eg5r9k$58c$1@sea.gmane.org","subject":"Re: [PATCH] Remove bashism from t3210-pack-refs.sh","fromName":"Linus Torvalds","fromEmail":"torvalds@osdl.org","sentAt":"2006-10-06T16:33:59Z","receivedAt":"2006-10-06T16:33:59Z","isPatch":true,"sender":{"key":"torvalds@linux-foundation.org","avatar":"https://avatars.githubusercontent.com/u/1024025?v=4"},"body":"\n\nOn Fri, 6 Oct 2006, Jakub Narebski wrote:\n> Alex Riesen wrote:\n> \n> > On 10/6/06, Dennis Stosberg <dennis@stosberg.net> wrote:\n> >> -     SHA1=$(< .git/refs/heads/a) &&\n> >> +     SHA1=`cat .git/refs/heads/a` &&\n> > \n> > Only \"<\" (the redirection part) is bashism. The \"$()\" is POSIX.\n> \n> BTW. it is not packed-refs safe.\n\nWell, since that seems to be a test-case for the packed-refs thing, that's \nprobably not a problem ;)\n\nIn a real-life git script you should do something like\n\n\tSHA1=$(git-rev-parse --verify \"refs/heads/$head^0\") && ...\n\nto get the SHA1 and verify that it's all good, but since that script is \nall about checking that packing does the right thing, I think it's fine to \ndo it by hand there..\n\n\t\tLinus\n"}]}