{"thread":{"id":"58228","subject":"[PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'","startedAt":"2022-07-27T08:02:15Z","lastAt":"2022-07-28T14:28:06Z","messageCount":4,"participants":["Jay Berry via GitGitGadget","Ævar Arnfjörð Bjarmason","Paul Smith","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"460009","messageId":"pull.1298.git.1658908927714.gitgitgadget@gmail.com","threadId":"58228","inReplyTo":null,"subject":"[PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'","fromName":"Jay Berry via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-07-27T08:02:07Z","receivedAt":"2022-07-27T08:02:15Z","isPatch":true,"sender":{"key":"name:Jay Berry","avatar":null},"body":"From: Jay Berry <jb2170@selfadjointoperator.com>\n\nThere are two hard-coded\n`fprintf(stderr, \"Everything up-to-date\\n\")`\nwhich I have changed to\n`fprintf(stderr, \"Everything up to date.\\n\")`\nsince most other strings used localised versions of `up to date.`\n\nBefore (stupidly inconsistent):\n```\n$ git pull\nAlready up to date.\n$ git push\nEverything up-to-date\n```\nAfter (consistent):\n```\n$ git pull\nAlready up to date.\n$ git push\nEverything up to date.\n```\nSigned-off-by: Jay Berry <jb2170@selfadjointoperator.com>\n---\n    Use 'Everything up to date.' instead of 'Everything up-to-date'\n    \n    There are two hard-coded fprintf(stderr, \"Everything up-to-date\\n\")\n    which I have changed to fprintf(stderr, \"Everything up to date.\\n\")\n    since most other strings used localised versions of up to date.\n    \n    Before (stupidly inconsistent):\n    \n    $ git pull\n    Already up to date.\n    $ git push\n    Everything up-to-date\n    \n    \n    After (consistent):\n    \n    $ git pull\n    Already up to date.\n    $ git push\n    Everything up to date.\n    \n    \n    Signed-off-by: Jay Berry jb2170@selfadjointoperator.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1298%2FSelfAdjointOperator%2Fup-to-date-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1298/SelfAdjointOperator/up-to-date-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1298\n\n builtin/send-pack.c | 2 +-\n transport.c         | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/send-pack.c b/builtin/send-pack.c\nindex 64962be0168..cb3c6ff8300 100644\n--- a/builtin/send-pack.c\n+++ b/builtin/send-pack.c\n@@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)\n \t}\n \n \tif (!ret && !transport_refs_pushed(remote_refs))\n-\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\tfprintf(stderr, \"Everything up to date.\\n\");\n \n \treturn ret;\n }\ndiff --git a/transport.c b/transport.c\nindex 52db7a3cb09..c40d15647ff 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -1416,7 +1416,7 @@ int transport_push(struct repository *r,\n \tif (porcelain && !push_ret)\n \t\tputs(\"Done\");\n \telse if (!quiet && !ret && !transport_refs_pushed(remote_refs))\n-\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n+\t\tfprintf(stderr, \"Everything up to date.\\n\");\n \n done:\n \tfree_refs(local_refs);\n\nbase-commit: e72d93e88cb20b06e88e6e7d81bd1dc4effe453f\n-- \ngitgitgadget\n"},{"id":"460014","messageId":"220727.86r126lxt0.gmgdl@evledraar.gmail.com","threadId":"58228","inReplyTo":"pull.1298.git.1658908927714.gitgitgadget@gmail.com","subject":"Re: [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-07-27T09:15:37Z","receivedAt":"2022-07-27T09:17:22Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Jul 27 2022, Jay Berry via GitGitGadget wrote:\n\n> From: Jay Berry <jb2170@selfadjointoperator.com>\n>\n> There are two hard-coded\n> `fprintf(stderr, \"Everything up-to-date\\n\")`\n> which I have changed to\n> `fprintf(stderr, \"Everything up to date.\\n\")`\n> since most other strings used localised versions of `up to date.`\n>\n> Before (stupidly inconsistent):\n> ```\n> $ git pull\n> Already up to date.\n> $ git push\n> Everything up-to-date\n> ```\n> After (consistent):\n> ```\n> $ git pull\n> Already up to date.\n> $ git push\n> Everything up to date.\n> ```\n> Signed-off-by: Jay Berry <jb2170@selfadjointoperator.com>\n> ---\n>     Use 'Everything up to date.' instead of 'Everything up-to-date'\n>     \n>     There are two hard-coded fprintf(stderr, \"Everything up-to-date\\n\")\n>     which I have changed to fprintf(stderr, \"Everything up to date.\\n\")\n>     since most other strings used localised versions of up to date.\n>     \n>     Before (stupidly inconsistent):\n>     \n>     $ git pull\n>     Already up to date.\n>     $ git push\n>     Everything up-to-date\n>     \n>     \n>     After (consistent):\n>     \n>     $ git pull\n>     Already up to date.\n>     $ git push\n>     Everything up to date.\n>     \n>     \n>     Signed-off-by: Jay Berry jb2170@selfadjointoperator.com\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1298%2FSelfAdjointOperator%2Fup-to-date-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1298/SelfAdjointOperator/up-to-date-v1\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1298\n>\n>  builtin/send-pack.c | 2 +-\n>  transport.c         | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/send-pack.c b/builtin/send-pack.c\n> index 64962be0168..cb3c6ff8300 100644\n> --- a/builtin/send-pack.c\n> +++ b/builtin/send-pack.c\n> @@ -338,7 +338,7 @@ int cmd_send_pack(int argc, const char **argv, const char *prefix)\n>  \t}\n>  \n>  \tif (!ret && !transport_refs_pushed(remote_refs))\n> -\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n> +\t\tfprintf(stderr, \"Everything up to date.\\n\");\n>  \n>  \treturn ret;\n>  }\n> diff --git a/transport.c b/transport.c\n> index 52db7a3cb09..c40d15647ff 100644\n> --- a/transport.c\n> +++ b/transport.c\n> @@ -1416,7 +1416,7 @@ int transport_push(struct repository *r,\n>  \tif (porcelain && !push_ret)\n>  \t\tputs(\"Done\");\n>  \telse if (!quiet && !ret && !transport_refs_pushed(remote_refs))\n> -\t\tfprintf(stderr, \"Everything up-to-date\\n\");\n> +\t\tfprintf(stderr, \"Everything up to date.\\n\");\n\nWe don't want to take this change for the reasons discussed previously here:\n\n\thttps://lore.kernel.org/git/CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com/\n\thttps://lore.kernel.org/git/20191122180433.GA57478@generichostname/\n\nThat \"don't\" is up for discussion, but a subsequent re-roll should argue\nit based on the points raised there.\n\nIf we *are* going to change this then:\n\n * We should mark this for translation with _()\n * Don't have the translation include the \\n\n"},{"id":"460021","messageId":"18f324b9934982d577c0d9b0631d33818574df00.camel@mad-scientist.net","threadId":"58228","inReplyTo":"220727.86r126lxt0.gmgdl@evledraar.gmail.com","subject":"Re: [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'","fromName":"Paul Smith","fromEmail":"paul@mad-scientist.net","sentAt":"2022-07-27T13:35:39Z","receivedAt":"2022-07-27T13:59:19Z","isPatch":true,"sender":{"key":"paul@mad-scientist.net","avatar":"https://avatars.githubusercontent.com/u/109636?v=4"},"body":"On Wed, 2022-07-27 at 11:15 +0200, Ævar Arnfjörð Bjarmason wrote:\n> That \"don't\" is up for discussion, but a subsequent re-roll should\n> argue it based on the points raised there.\n> \n> If we *are* going to change this then:\n> \n>  * We should mark this for translation with _()\n>  * Don't have the translation include the \\n\n\nIf no change to the text is wanted, then maybe a patch should be\napplied that adds a comment to the code saying that these strings are\nleft as-is and not localized intentionally, to avoid similar issues in\nthe future.\n"},{"id":"460071","messageId":"7n9r5q74-9qr1-29sr-p2n5-943n01s0p78r@tzk.qr","threadId":"58228","inReplyTo":"18f324b9934982d577c0d9b0631d33818574df00.camel@mad-scientist.net","subject":"Re: [PATCH] Use 'Everything up to date.' instead of 'Everything up-to-date'","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-07-28T14:27:53Z","receivedAt":"2022-07-28T14:28:06Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Paul,\n\nOn Wed, 27 Jul 2022, Paul Smith wrote:\n\n> On Wed, 2022-07-27 at 11:15 +0200, Ævar Arnfjörð Bjarmason wrote:\n> > That \"don't\" is up for discussion, but a subsequent re-roll should\n> > argue it based on the points raised there.\n> >\n> > If we *are* going to change this then:\n> >\n> >  * We should mark this for translation with _()\n> >  * Don't have the translation include the \\n\n>\n> If no change to the text is wanted, then maybe a patch should be\n> applied that adds a comment to the code saying that these strings are\n> left as-is and not localized intentionally, to avoid similar issues in\n> the future.\n\nMatthias Aßauer said it best at\nhttps://github.com/gitgitgadget/git/pull/1298#issuecomment-1196410927:\n\n\tThese two are plumbing messages that where intentionally left out\n\tof the last effort to correct uses of \"up-to-date\" to \"up to date\"\n\tfaf420e05a9 (treewide: correct several \"up-to-date\" to \"up to\n\tdate\", 2017-08-23), 7560f547e61 (treewide: correct several\n\t\"up-to-date\" to \"up to date\", 2017-08-23).\n\nThis makes it not only clear why they have not been changed, but also why\nthey are not translated: those messages are not intended for human eyes,\nbut for programs to parse.\n\nI like the suggestion very much to add comments above these two remaining\ndashed \"up-to-date\"s. Paul, would you mind coalescing the information you\nreceived into a commit message, adding the comments instead of changing\nthe messages, and submit the next iteration?\n\nThanks,\nDscho\n"}]}