{"thread":{"id":"58186","subject":"[PATCH v2] contrib/rerere-train: avoid useless gpg sign in training","startedAt":"2022-07-19T13:52:15Z","lastAt":"2022-07-19T16:26:46Z","messageCount":2,"participants":["Celeste Liu","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"459357","messageId":"PH7PR14MB5594BE1B100435DCD28C1E45CE8F9@PH7PR14MB5594.namprd14.prod.outlook.com","threadId":"58186","inReplyTo":null,"subject":"[PATCH v2] contrib/rerere-train: avoid useless gpg sign in training","fromName":"Celeste Liu","fromEmail":"coelacanthus@outlook.com","sentAt":"2022-07-19T13:03:58Z","receivedAt":"2022-07-19T13:52:15Z","isPatch":true,"sender":{"key":"coelacanthus@outlook.com","avatar":"https://avatars.githubusercontent.com/u/43064781?v=4"},"body":"The rerere-train script now signs all temporary commits,\nwhich is unnecessary and useless.\nThis commit turns off gpg signing.\n\nSigned-off-by: Celeste Liu <coelacanthus@outlook.com>\n---\n\nv2: add problem detail in commit message.\n\n contrib/rerere-train.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh\nindex 26b724c8c6..bd01e430ef 100755\n--- a/contrib/rerere-train.sh\n+++ b/contrib/rerere-train.sh\n@@ -75,7 +75,7 @@ do\n \t\tcontinue\n \tfi\n \tgit checkout -q \"$parent1^0\"\n-\tif git merge $other_parents >/dev/null 2>&1\n+\tif git merge --no-gpg-sign $other_parents >/dev/null 2>&1\n \tthen\n \t\t# Cleanly merges\n \t\tcontinue\n-- \n2.37.1\n\n"},{"id":"459383","messageId":"xmqqzgh5ax1d.fsf@gitster.g","threadId":"58186","inReplyTo":"PH7PR14MB5594BE1B100435DCD28C1E45CE8F9@PH7PR14MB5594.namprd14.prod.outlook.com","subject":"Re: [PATCH v2] contrib/rerere-train: avoid useless gpg sign in training","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-07-19T16:26:38Z","receivedAt":"2022-07-19T16:26:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Celeste Liu <coelacanthus@outlook.com> writes:\n\n> The rerere-train script now signs all temporary commits,\n> which is unnecessary and useless.\n\nNot for me ;-)  There must be something else that is forcing it to\nbehave that way.\n\n> This commit turns off gpg signing.\n\n\n>\n> Signed-off-by: Celeste Liu <coelacanthus@outlook.com>\n> ---\n>\n> v2: add problem detail in commit message.\n>\n>  contrib/rerere-train.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh\n> index 26b724c8c6..bd01e430ef 100755\n> --- a/contrib/rerere-train.sh\n> +++ b/contrib/rerere-train.sh\n> @@ -75,7 +75,7 @@ do\n>  \t\tcontinue\n>  \tfi\n>  \tgit checkout -q \"$parent1^0\"\n> -\tif git merge $other_parents >/dev/null 2>&1\n> +\tif git merge --no-gpg-sign $other_parents >/dev/null 2>&1\n>  \tthen\n>  \t\t# Cleanly merges\n>  \t\tcontinue\n"}]}