{"thread":{"id":"58179","subject":"[PATCH] config/core.txt: fix minor issues for `core.sparseCheckoutCone`","startedAt":"2022-07-18T10:05:57Z","lastAt":"2022-07-18T15:28:29Z","messageCount":3,"participants":["Martin Ågren","Derrick Stolee","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"459250","messageId":"20220718100530.2068354-1-martin.agren@gmail.com","threadId":"58179","inReplyTo":null,"subject":"[PATCH] config/core.txt: fix minor issues for `core.sparseCheckoutCone`","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2022-07-18T10:05:30Z","receivedAt":"2022-07-18T10:05:57Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"The sparse checkout feature can be used in \"cone mode\" or \"non-cone\nmode\". In this one instance in the documentation, we refer to the latter\nas \"non cone mode\" with whitespace rather than a hyphen. Align this with\nthe rest of our documentation.\n\nA few words later in the same paragraph, there's mention of \"a more\nflexible patterns\". Drop that leading \"a\" to fix the grammar.\n\nSigned-off-by: Martin Ågren \n---\n BTW, Elijah, it seems like you've recently started using different\n e-mail addresses, even within the same series [1]. Not sure if that's\n intentional or not? I decided to cc the one you've used by far the most\n rather than spamming all of your accounts.\n\n [1] https://lore.kernel.org/git/pull.1268.v4.git.1656984823.gitgitgadget@gmail.com/\n\n Documentation/config/core.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/config/core.txt b/Documentation/config/core.txt\nindex 3ea3124f7f..37afbaf5a4 100644\n--- a/Documentation/config/core.txt\n+++ b/Documentation/config/core.txt\n@@ -722,8 +722,8 @@ core.sparseCheckout::\n core.sparseCheckoutCone::\n \tEnables the \"cone mode\" of the sparse checkout feature. When the\n \tsparse-checkout file contains a limited set of patterns, this\n-\tmode provides significant performance advantages. The \"non\n-\tcone mode\" can be requested to allow specifying a more flexible\n+\tmode provides significant performance advantages. The \"non-cone\n+\tmode\" can be requested to allow specifying more flexible\n \tpatterns by setting this variable to 'false'. See\n \tlinkgit:git-sparse-checkout[1] for more information.\n \n-- \n2.37.1.373.g4dd4a117ec\n\n"},{"id":"459257","messageId":"192ffe9b-0676-2143-9032-673bc597d45e@github.com","threadId":"58179","inReplyTo":"20220718100530.2068354-1-martin.agren@gmail.com","subject":"Re: [PATCH] config/core.txt: fix minor issues for `core.sparseCheckoutCone`","fromName":"Derrick Stolee","fromEmail":"derrickstolee@github.com","sentAt":"2022-07-18T12:20:04Z","receivedAt":"2022-07-18T12:20:10Z","isPatch":true,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 7/18/22 6:05 AM, Martin Ågren wrote:\n> The sparse checkout feature can be used in \"cone mode\" or \"non-cone\n> mode\". In this one instance in the documentation, we refer to the latter\n> as \"non cone mode\" with whitespace rather than a hyphen. Align this with\n> the rest of our documentation.\n> \n> A few words later in the same paragraph, there's mention of \"a more\n> flexible patterns\". Drop that leading \"a\" to fix the grammar.\n\nThank you for your attention to detail. This is a good change.\n\nThanks,\n-Stolee\n"},{"id":"459279","messageId":"CABPp-BFGPbNNpoYRUogxQP7YvbEKJXyHcS13DEpG-tTr8RCzhA@mail.gmail.com","threadId":"58179","inReplyTo":"20220718100530.2068354-1-martin.agren@gmail.com","subject":"Re: [PATCH] config/core.txt: fix minor issues for `core.sparseCheckoutCone`","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-07-18T15:28:11Z","receivedAt":"2022-07-18T15:28:29Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Mon, Jul 18, 2022 at 3:05 AM Martin Ågren wrote:\n>\n> The sparse checkout feature can be used in \"cone mode\" or \"non-cone\n> mode\". In this one instance in the documentation, we refer to the latter\n> as \"non cone mode\" with whitespace rather than a hyphen. Align this with\n> the rest of our documentation.\n>\n> A few words later in the same paragraph, there's mention of \"a more\n> flexible patterns\". Drop that leading \"a\" to fix the grammar.\n\nOoh, sounds like a good catch.\n\n> Signed-off-by: Martin Ågren \n> ---\n> BTW, Elijah, it seems like you've recently started using different\n> e-mail addresses, even within the same series [1]. Not sure if that's\n> intentional or not? I decided to cc the one you've used by far the most\n> rather than spamming all of your accounts.\n\nNot intentional. Looks like it has already merged to next, though, or\nI'd reroll and correct. Maybe I should submit an entry for .mailmap.\n\n(Hard drive in my work computer died somewhat recently. There, I use\nmy work email for most things; almost everything other than git.git.\nWhen recloning git.git on my replacement computer, I forgot to set\nuser.email in my git.git clone to override the value found in the\nglobal ~/.gitconfig.)\n\n> [1] https://lore.kernel.org/git/pull.1268.v4.git.1656984823.gitgitgadget@gmail.com/\n>\n> Documentation/config/core.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/config/core.txt b/Documentation/config/core.txt\n> index 3ea3124f7f..37afbaf5a4 100644\n> --- a/Documentation/config/core.txt\n> +++ b/Documentation/config/core.txt\n> @@ -722,8 +722,8 @@ core.sparseCheckout::\n> core.sparseCheckoutCone::\n> Enables the \"cone mode\" of the sparse checkout feature. When the\n> sparse-checkout file contains a limited set of patterns, this\n> - mode provides significant performance advantages. The \"non\n> - cone mode\" can be requested to allow specifying a more flexible\n> + mode provides significant performance advantages. The \"non-cone\n> + mode\" can be requested to allow specifying more flexible\n> patterns by setting this variable to 'false'. See\n> linkgit:git-sparse-checkout[1] for more information.\n>\n> --\n> 2.37.1.373.g4dd4a117ec\n\nThis looks good, thanks.\n\nReviewed-by: Elijah Newren \n"}]}