{"thread":{"id":"5809","subject":"activestate perl: Makemaker generates broken Makefiles.","startedAt":"2006-10-04T11:25:56Z","lastAt":"2006-10-06T04:57:46Z","messageCount":2,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"28209","messageId":"81b0412b0610040425j60d0647dk1489d02657379c13@mail.gmail.com","threadId":"5809","inReplyTo":null,"subject":"activestate perl: Makemaker generates broken Makefiles.","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2006-10-04T11:25:56Z","receivedAt":"2006-10-04T11:25:56Z","isPatch":false,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Just a heads up. Makefile.PL can't be used. The attached patch removes\neverything perl (sorry, but it'd help someone to get going).\n\n\ncommit bb0ea66746c764f665fc2c5a0f0c289fbbc7eb03\nAuthor: Alex Riesen <raa.lkml@gmail.com>\nDate:   Wed Oct 4 11:51:51 2006 +0200\n\n    remove Git.xs\n\ndiff --git a/Makefile b/Makefile\nindex ee3bc72..93f93e1 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -590,8 +590,7 @@ ### Build rules\n \n all: $(ALL_PROGRAMS) $(BUILT_INS) git$X gitk gitweb/gitweb.cgi\n \n-all: perl/Makefile\n-\t$(MAKE) -C perl\n+all:\n \t$(MAKE) -C templates\n \n strip: $(PROGRAMS) git$X\n@@ -625,15 +624,11 @@ common-cmds.h: Documentation/git-*.txt\n \tchmod +x $@+\n \tmv $@+ $@\n \n-$(patsubst %.perl,%,$(SCRIPT_PERL)): perl/Makefile\n $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl\n \trm -f $@ $@+\n-\tINSTLIBDIR=`$(MAKE) -C perl -s --no-print-directory instlibdir` && \\\n \tsed -e '1{' \\\n \t    -e '\ts|#!.*perl|#!$(PERL_PATH_SQ)|' \\\n \t    -e '\th' \\\n-\t    -e '\ts=.*=use lib (split(/:/, $$ENV{GITPERLLIB} || \"@@INSTLIBDIR@@\"));=' \\\n-\t    -e '\tH' \\\n \t    -e '\tx' \\\n \t    -e '}' \\\n \t    -e 's|@@INSTLIBDIR@@|'\"$$INSTLIBDIR\"'|g' \\\n@@ -766,10 +761,6 @@ XDIFF_OBJS=xdiff/xdiffi.o xdiff/xprepare\n \trm -f $@ && $(AR) rcs $@ $(XDIFF_OBJS)\n \n \n-perl/Makefile: perl/Git.pm perl/Makefile.PL GIT-CFLAGS\n-\t(cd perl && $(PERL_PATH) Makefile.PL \\\n-\t\tPREFIX='$(prefix_SQ)')\n-\n doc:\n \t$(MAKE) -C Documentation all\n \n@@ -832,7 +823,6 @@ install: all\n \t$(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexecdir_SQ)'\n \t$(INSTALL) git$X gitk '$(DESTDIR_SQ)$(bindir_SQ)'\n \t$(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install\n-\t$(MAKE) -C perl install\n \t$(INSTALL) -d -m755 '$(DESTDIR_SQ)$(GIT_PYTHON_DIR_SQ)'\n \t$(INSTALL) $(PYMODULES) '$(DESTDIR_SQ)$(GIT_PYTHON_DIR_SQ)'\n \tif test 'z$(bindir_SQ)' != 'z$(gitexecdir_SQ)'; \\\n"},{"id":"28269","messageId":"7viriy2g8l.fsf@assigned-by-dhcp.cox.net","threadId":"5809","inReplyTo":"81b0412b0610040425j60d0647dk1489d02657379c13@mail.gmail.com","subject":"Re: activestate perl: Makemaker generates broken Makefiles.","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2006-10-06T04:57:46Z","receivedAt":"2006-10-06T04:57:46Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alex Riesen\" <raa.lkml@gmail.com> writes:\n\n> Just a heads up. Makefile.PL can't be used. The attached patch removes\n> everything perl (sorry, but it'd help someone to get going).\n\nSince we do not have Git.xs anymore, wouldn't it be possible for\nus to remove perl/Makefile.PL and have our own perl/Makefile\nwhich does:\n\n * install Git.pm to $(prefix)/share/git-core/perl (aka GIT_PERL_DIR)\n\n * see if Error.pm is available on the system, and if not install\n   private-Error.pm as Error.pm\n\nto make everybody happy???\n"}]}