{"thread":{"id":"5807","subject":"[PATCH 2/3] gitweb: blame: Mouse-over commit-8 shows author and date","startedAt":"2006-10-04T07:13:38Z","lastAt":"2006-10-04T07:13:38Z","messageCount":1,"participants":["Luben Tuikov"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"28202","messageId":"20061004071338.88148.qmail@web31812.mail.mud.yahoo.com","threadId":"5807","inReplyTo":null,"subject":"[PATCH 2/3] gitweb: blame: Mouse-over commit-8 shows author and date","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-04T07:13:38Z","receivedAt":"2006-10-04T07:13:38Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>\n---\n gitweb/gitweb.perl |   12 +++++++-----\n 1 files changed, 7 insertions(+), 5 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 9518086..cba0840 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2496,11 +2496,9 @@ sub git_blame2 {\n <tr><th>Commit</th><th>Line</th><th>Data</th></tr>\n HTML\n \twhile (<$fd>) {\n-\t\t/^([0-9a-fA-F]{40}).*?(\\d+)\\)\\s{1}(\\s*.*)/;\n-\t\tmy $full_rev = $1;\n+\t\tmy ($full_rev, $author, $date, $lineno, $data) =\n+\t\t\t/^([0-9a-f]{40}).*?\\s\\((.*?)\\s+([-\\d]+ [:\\d]+ [-+\\d]+)\\s+(\\d+)\\)\\s(.*)/;\n \t\tmy $rev = substr($full_rev, 0, 8);\n-\t\tmy $lineno = $2;\n-\t\tmy $data = $3;\n \t\tmy $print_c8 = 0;\n \n \t\tif (!defined $last_rev) {\n@@ -2512,7 +2510,11 @@ HTML\n \t\t\t$print_c8 = 1;\n \t\t}\n \t\tprint \"<tr class=\\\"$rev_color[$current_color]\\\">\\n\";\n-\t\tprint \"<td class=\\\"sha1\\\">\";\n+\t\tprint \"<td class=\\\"sha1\\\"\";\n+\t\tif ($print_c8 == 1) {\n+\t\t\tprint \" title=\\\"$author, $date\\\"\";\n+\t\t}\n+\t\tprint \">\";\n \t\tif ($print_c8 == 1) {\n \t\t\tprint $cgi->a({-href => href(action=>\"commit\", hash=>$full_rev, file_name=>$file_name)},\n \t\t\t\t      esc_html($rev));\n-- \n1.4.2.1.ga68d6\n\n"}]}