{"thread":{"id":"58056","subject":"[PATCH] revisions.txt: escape \"...\" to avoid asciidoc horizontal ellipsis","startedAt":"2022-06-22T23:33:10Z","lastAt":"2022-06-22T23:46:37Z","messageCount":2,"participants":["Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"457754","messageId":"YrOmsA04FZae89be@coredump.intra.peff.net","threadId":"58056","inReplyTo":null,"subject":"[PATCH] revisions.txt: escape \"...\" to avoid asciidoc horizontal ellipsis","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2022-06-22T23:33:04Z","receivedAt":"2022-06-22T23:33:10Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"In asciidoc's HTML output of the \"gitrevisions\" and \"git-rev-parse\"\ndocumentation, the header:\n\n  The ... (three-dot) Symmetric Difference Notation\n\nis rendered using \"&8230;\", a horizontal ellipsis. This is visually\nugly, but also hard to search for or cut-and-paste. We really mean three\nascii dots (0x2e) here, so let's make sure it renders as such.\n\nThe simplest way to do that is just escaping the leading dot, as the\ninstances in the rest of the section do. Arguably this should all be\nconverted to use backticks, which would let us drop the quoting here and\nelsewhere (e.g., {carat}). But that does change the rendering slightly.\nSo let's fix the bug first, and we can decide on migrating the whole\nsection separately.\n\nNote that this produces an empty doc-diff of the manpages. Curiously,\nasciidoc produces the same ellipsis entity in the XML file, but docbook\nthen converts it back into three literal dots for the roff output! So\nthe roff manpages have been correct all along (which may be a reason\nnobody noticed this until now).\n\nReported-by: Arthur Milchior\nSigned-off-by: Jeff King <peff@peff.net>\n---\nThis was originally reported via https://github.com/git/git-scm.com/issues/1700,\nhence no email address for the reporter. I'm not sure if that makes it\ntoo useless to keep, but I mostly wanted to give credit.\n\n Documentation/revisions.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/revisions.txt b/Documentation/revisions.txt\nindex f5f17b65a1..cef8c3c66f 100644\n--- a/Documentation/revisions.txt\n+++ b/Documentation/revisions.txt\n@@ -283,7 +283,7 @@ The '..' (two-dot) Range Notation::\n  for commits that are reachable from r2 excluding those that are reachable\n  from r1 by '{caret}r1 r2' and it can be written as 'r1..r2'.\n \n-The '...' (three-dot) Symmetric Difference Notation::\n+The '\\...' (three-dot) Symmetric Difference Notation::\n  A similar notation 'r1\\...r2' is called symmetric difference\n  of 'r1' and 'r2' and is defined as\n  'r1 r2 --not $(git merge-base --all r1 r2)'.\n-- \n2.37.0.rc1.390.g1f5e45eb84\n"},{"id":"457756","messageId":"xmqqfsjw2re1.fsf@gitster.g","threadId":"58056","inReplyTo":"YrOmsA04FZae89be@coredump.intra.peff.net","subject":"Re: [PATCH] revisions.txt: escape \"...\" to avoid asciidoc horizontal ellipsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-06-22T23:46:30Z","receivedAt":"2022-06-22T23:46:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> Note that this produces an empty doc-diff of the manpages. Curiously,\n> asciidoc produces the same ellipsis entity in the XML file, but docbook\n> then converts it back into three literal dots for the roff output! So\n> the roff manpages have been correct all along (which may be a reason\n> nobody noticed this until now).\n\nHilarious.\n\nI just checked with \"man -l -Tps\" and it does seem to throw literal\nthree dots in the PostScript.\n\n> Reported-by: Arthur Milchior\n> Signed-off-by: Jeff King <peff@peff.net>\n> ---\n> This was originally reported via https://github.com/git/git-scm.com/issues/1700,\n> hence no email address for the reporter. I'm not sure if that makes it\n> too useless to keep, but I mostly wanted to give credit.\n\nI wonder if it is the same person as\n<pull.1280.git.git.1655927444821.gitgitgadget@gmail.com>\n\nAnyway, thanks, both ;-)\n\n>\n>  Documentation/revisions.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/revisions.txt b/Documentation/revisions.txt\n> index f5f17b65a1..cef8c3c66f 100644\n> --- a/Documentation/revisions.txt\n> +++ b/Documentation/revisions.txt\n> @@ -283,7 +283,7 @@ The '..' (two-dot) Range Notation::\n>   for commits that are reachable from r2 excluding those that are reachable\n>   from r1 by '{caret}r1 r2' and it can be written as 'r1..r2'.\n>  \n> -The '...' (three-dot) Symmetric Difference Notation::\n> +The '\\...' (three-dot) Symmetric Difference Notation::\n>   A similar notation 'r1\\...r2' is called symmetric difference\n>   of 'r1' and 'r2' and is defined as\n>   'r1 r2 --not $(git merge-base --all r1 r2)'.\n"}]}