{"thread":{"id":"57998","subject":"[L10N] Kickoff for Git 2.37.0 round #1","startedAt":"2022-06-14T11:29:27Z","lastAt":"2022-06-23T01:12:47Z","messageCount":5,"participants":["Jiang Xin","Trần Ngọc Quân","Peter Krefting"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"457183","messageId":"20220614112858.16576-1-worldhello.net@gmail.com","threadId":"57998","inReplyTo":null,"subject":"[L10N] Kickoff for Git 2.37.0 round #1","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2022-06-14T11:28:58Z","receivedAt":"2022-06-14T11:29:27Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"Hi,\n\nGit v2.37.0-rc0 has been released, and it's time to start new round of\ngit l10n.  This time there are 92 updated messages need to be translated\nsince last release. Please send your pull request to the l10n coordinator's\nrepository below before this update window closes on Sun, June 26, 2022. \n\n    https://github.com/git-l10n/git-po/\n\nAs of git 2.37, we (git l10n contributors) have a new l10n workflow. The\nfollowing description of the new l10n workflow is from the \"po/README.md\"\nfile.\n\n\n## The \"po/git.pot\" file is a generated file, no longer in the repository\n\nThe l10n coordinator does not need to generate the \"po/git.pot\" file every\ntime to start a new l10n workflow, and there is no \"po/git.pot\" file at all.\n\nEveryone can generate the \"po/git.pot\" file with the command below:\n\n    make po/git.pot\n\nBut we can also forget about it. By updating our corresponding \"po/XX.po\"\nfile, the \"po/git.pot\" file is automatically generated.\n\n\n## Update the \"po/XX.po\" file, and start to translate\n\nBefore updating the \"po/XX.po\" file, l10n contributors should pull the latest\ncommits from the master branch of \"git.git\". E.g.:\n\n    git pull --rebase git@github.com:git/git.git master\n\nThen update the cooresponding \"po/XX.po\" file using the following command:\n\n    make po-update PO_FILE=po/XX.po\n\nTranslate the uptodate \"po/XX.po\" file, and create a new commit.\n\n\n## Refine your commits, send pull requests\n\nIn the \"po/XX.po\" file, there are location lines in comments like below:\n\n    #: add-interactive.c:535 add-interactive.c:836 reset.c:136 sequencer.c:3505\n    #: sequencer.c:3970 sequencer.c:4127 builtin/rebase.c:1261\n    #: builtin/rebase.c:1671\n\nThese comments with file locations are useful for l10n contributors to locate\nthe context easily during translation. But these file locations introduce a\nlot of noise and will consume a lot of repository storage. Therefore, we\nshould remove these file locations from the \"po/XX.po\" file.\n\nTo remove file locations in the \"po/XX.po\" file, you can use one of the\nfollowing two ways, but don't switch back and forth.\n\n * Keep the filenames, only remove locations (need gettext 0.19 and above):\n\n        msgcat --add-location=file po/XX.po >po/XX.po.new\n        mv po/XX.po.new po/XX.po\n\n * Remove both filenames and locations:\n\n        msgcat --no-location po/XX.po >po/XX.po.new\n        mv po/XX.po.new po/XX.po\n\nAfter squashing trivial commits and removing file locations in the \"po/XX.po\"\nfile, send pull request to the l10n coordinator's repository below:\n\n    https://github.com/git-l10n/git-po/\n\n\n## Resolve errors found by the l10n CI pipeline for the pull request\n\nA helper program hosted on \"https://github.com/git-l10n/git-po-helper\" can\nhelp git l10n coordinator and git l10n contributors to check the conventions\nof git l10n contributions, and it is also used in GitHub actions as l10n CI\npipeline to validate each pull request in the \"git-l10n/git-po\" repository.\nPlease fix the issues found by the helper program.\n\n\n** Please note: The update window will close on Sun, June 26, 2022. **\n\n\n--\nJiang Xin\n"},{"id":"457529","messageId":"CAPv0VGvKFEbVzZEdn+eb-4Bb9KfQWCa=pM3iC_Dyu-6AKGCcug@mail.gmail.com","threadId":"57998","inReplyTo":"20220614112858.16576-1-worldhello.net@gmail.com","subject":"Re: [L10N] Kickoff for Git 2.37.0 round #1","fromName":"Trần Ngọc Quân","fromEmail":"vnwildman@gmail.com","sentAt":"2022-06-19T08:02:20Z","receivedAt":"2022-06-19T08:02:53Z","isPatch":false,"sender":{"key":"vnwildman@gmail.com","avatar":"https://avatars.githubusercontent.com/u/508758?v=4"},"body":"On Tue, Jun 14, 2022 at 6:29 PM Jiang Xin <worldhello.net@gmail.com> wrote:\n>\n> Hi,\n>\n> Git v2.37.0-rc0 has been released, and it's time to start new round of\n> git l10n.  This time there are 92 updated messages need to be translated\n> since last release. Please send your pull request to the l10n coordinator's\n> repository below before this update window closes on Sun, June 26, 2022.\n>\n>     https://github.com/git-l10n/git-po/\n>\nDone, please pull!\n\n$ git log -n1 --stat\ncommit 22262d3c1947626e296418ffa3543d3584995653 (HEAD -> master, origin/master,\norigin/HEAD)\nAuthor: Trần Ngọc Quân <vnwildman@gmail.com>\nDate:   Sun Jun 19 07:48:40 2022 +0700\n\n    l10n: vi(5367t): Updated Vietnamese translation v2.37\n\n    Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>\n\n po/vi.po | 37548 +++++++++++++++++++++++++++++++------------------------------\n 1 file changed, 19003 insertions(+), 18545 deletions(-)\n\n\n\n-- \nRegards,\nTrần Ngọc Quân\n"},{"id":"457531","messageId":"CANYiYbGWoMpCOA43k=5a_kio2thf91BV69nfSySwhHZbbMOSkg@mail.gmail.com","threadId":"57998","inReplyTo":"CAPv0VGvKFEbVzZEdn+eb-4Bb9KfQWCa=pM3iC_Dyu-6AKGCcug@mail.gmail.com","subject":"Re: [L10N] Kickoff for Git 2.37.0 round #1","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2022-06-19T12:13:58Z","receivedAt":"2022-06-19T13:48:05Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Sun, Jun 19, 2022 at 4:02 PM Trần Ngọc Quân <vnwildman@gmail.com> wrote:\n>\n> On Tue, Jun 14, 2022 at 6:29 PM Jiang Xin <worldhello.net@gmail.com> wrote:\n> >\n> > Hi,\n> >\n> > Git v2.37.0-rc0 has been released, and it's time to start new round of\n> > git l10n.  This time there are 92 updated messages need to be translated\n> > since last release. Please send your pull request to the l10n coordinator's\n> > repository below before this update window closes on Sun, June 26, 2022.\n> >\n> >     https://github.com/git-l10n/git-po/\n> >\n> Done, please pull!\n>\n> $ git log -n1 --stat\n> commit 22262d3c1947626e296418ffa3543d3584995653 (HEAD -> master, origin/master,\n> origin/HEAD)\n> Author: Trần Ngọc Quân <vnwildman@gmail.com>\n> Date:   Sun Jun 19 07:48:40 2022 +0700\n>\n>     l10n: vi(5367t): Updated Vietnamese translation v2.37\n>\n>     Signed-off-by: Tran Ngoc Quan <vnwildman@gmail.com>\n>\n>  po/vi.po | 37548 +++++++++++++++++++++++++++++++------------------------------\n>  1 file changed, 19003 insertions(+), 18545 deletions(-)\n\nYou forgot to remove file-location comments in \"po/vi.po\".  If you\nsend me pull request on GitHub, a CI workflow will be triggered to\nexecute the command below,\n\n    $ git-po-helper check-commits --github-action-event=push <rev-list-args>\n\nand you will receive the following report:\n\n------------------------------------------------------------------------------\nINFO [po/vi.po@22262d3] 5367 条已翻译消息.\n------------------------------------------------------------------------------\nERROR [po/vi.po@22262d3]        Found file-location comments in po\nfile. By submitting a location-less\nERROR [po/vi.po@22262d3]        \"po/XX.po\" file, the size of the Git\nrepository can be greatly reduced.\nERROR [po/vi.po@22262d3]        See the discussion below:\nERROR [po/vi.po@22262d3]\nERROR [po/vi.po@22262d3]\nhttps://lore.kernel.org/git/20220504124121.12683-1-worldhello.net@gmail.com/\nERROR [po/vi.po@22262d3]\nERROR [po/vi.po@22262d3]        As how to commit a location-less\n\"po/XX.po\" file, See:\nERROR [po/vi.po@22262d3]\nERROR [po/vi.po@22262d3]            the [Updating a \"XX.po\" file]\nsection in \"po/README.md\"\n------------------------------------------------------------------------------\nWARNING commit 22262d3: subject length 53 > 50, about 63% commits have\na subject less than 50 characters\nINFO checking commits: 0 passed, 1 failed.\n------------------------------------------------------------------------------\nINFO update pot file by running: make pot\n\nERROR: fail to execute \"git-po-helper check-commits\"\n\nWill turn on the switch for file-location checking by default in\ngit-po-helper check-po, check-command, etc.\n\n--\nJiang Xin\n"},{"id":"457710","messageId":"7df7a2fe-386d-c996-b783-8c95fb78b0ea@softwolves.pp.se","threadId":"57998","inReplyTo":"CANYiYbGWoMpCOA43k=5a_kio2thf91BV69nfSySwhHZbbMOSkg@mail.gmail.com","subject":"Re: [L10N] Kickoff for Git 2.37.0 round #1","fromName":"Peter Krefting","fromEmail":"peter@softwolves.pp.se","sentAt":"2022-06-22T14:26:03Z","receivedAt":"2022-06-22T14:33:05Z","isPatch":false,"sender":{"key":"peter@softwolves.pp.se","avatar":"https://avatars.githubusercontent.com/u/990764?v=4"},"body":"On Sun, 19 Jun 2022, Jiang Xin wrote:\n\n> You forgot to remove file-location comments in \"po/vi.po\".  If you\n> send me pull request on GitHub, a CI workflow will be triggered to\n> execute the command below,\n\nIs that why the sv.po pull request is also standing still?\n\nRunning \"make po/git.pot\" generates the full location lines, so naturally\nthe PO file will also include it. If the makefile is fixed to remove them\nthey should go away.\n\nI modified my update script to run make first, as you removed git.pot from\nthe repo, and it generates it there.\n\n-- \n\\\\// Peter - http://www.softwolves.pp.se/\n"},{"id":"457758","messageId":"CANYiYbFnQLy3vsSiqYCxAb+Qqh5eUwKC7pdBQCa3d+EdbLy66Q@mail.gmail.com","threadId":"57998","inReplyTo":"7df7a2fe-386d-c996-b783-8c95fb78b0ea@softwolves.pp.se","subject":"Re: [L10N] Kickoff for Git 2.37.0 round #1","fromName":"Jiang Xin","fromEmail":"worldhello.net@gmail.com","sentAt":"2022-06-23T01:12:16Z","receivedAt":"2022-06-23T01:12:47Z","isPatch":false,"sender":{"key":"worldhello.net@gmail.com","avatar":"https://avatars.githubusercontent.com/u/183860?v=4"},"body":"On Wed, Jun 22, 2022 at 10:26 PM Peter Krefting <peter@softwolves.pp.se> wrote:\n>\n> On Sun, 19 Jun 2022, Jiang Xin wrote:\n>\n> > You forgot to remove file-location comments in \"po/vi.po\".  If you\n> > send me pull request on GitHub, a CI workflow will be triggered to\n> > execute the command below,\n>\n> Is that why the sv.po pull request is also standing still?\n\nYou may already notice the error report from the CI pipeline in the\nPR[1], you should:\n\n 1. remove file-location comments from \"po/sv.po\".\n 2. update your translation based on the master branch of\n     \"git/git\" or \"git-l10n/git-po\" repository.\n\nAfter you fix all the above errors , and there are no more l10n\nupdates upstream, like 2.37.0-rc2 is released, I'll merge your PR.\n\n[1]: https://github.com/git-l10n/git-po/pull/640\n\n--\nJiang Xin\n"}]}