{"thread":{"id":"57935","subject":"Bug: fsmonitor--daemon doesn't pick up submodule changes","startedAt":"2022-05-31T19:08:54Z","lastAt":"2022-06-06T10:46:46Z","messageCount":3,"participants":["Benedek Kozma","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"456422","messageId":"CAN8jHOhn+tNn2cR7X_fPyyLF-ADiScD2gymKY9H2ZFb+UdkJSw@mail.gmail.com","threadId":"57935","inReplyTo":null,"subject":"Bug: fsmonitor--daemon doesn't pick up submodule changes","fromName":"Benedek Kozma","fromEmail":"cyberbeni@gmail.com","sentAt":"2022-05-31T19:08:38Z","receivedAt":"2022-05-31T19:08:54Z","isPatch":false,"sender":{"key":"cyberbeni@gmail.com","avatar":null},"body":"Thank you for filling out a Git bug report!\nPlease answer the following questions to help us understand your issue.\n\nWhat did you do before the bug happened? (Steps to reproduce your issue)\ngit status\ncd submodule\ngit checkout origin/HEAD\ncd ..\ngit status\n\nWhat did you expect to happen? (Expected behavior)\nthe second git status showing that a submodule changed\n\nWhat happened instead? (Actual behavior)\nsecond git status also shows up to date\n\nWhat's different between what you expected and what actually happened?\n\nAnything else you want to add:\nI have core.fsmonitor set to true in ~/.gitconfig\nIf I run `git status` with git version 2.32.1 then 2.36.1 will also\ncorrectly report the submodule as changed after the next git status\n(because I don't have an fsmonitor script named true, using git 2.32.1\nwill reset my cache)\n\nPlease review the rest of the bug report below.\nYou can delete any lines you don't wish to share.\n\n\n[System Info]\ngit version:\ngit version 2.36.1\ncpu: arm64\nno commit associated with this build\nsizeof-long: 8\nsizeof-size_t: 8\nshell-path: /bin/sh\nfeature: fsmonitor--daemon\nuname: Darwin 21.5.0 Darwin Kernel Version 21.5.0: Tue Apr 26 21:08:37\nPDT 2022; root:xnu-8020.121.3~4/RELEASE_ARM64_T6000 arm64\ncompiler info: clang: 13.1.6 (clang-1316.0.21.2)\nlibc info: no libc information available\n$SHELL (typically, interactive shell): /bin/zsh\n\n\n[Enabled Hooks]\npre-commit\n"},{"id":"456507","messageId":"nycvar.QRO.7.76.6.2206021525430.349@tvgsbejvaqbjf.bet","threadId":"57935","inReplyTo":"CAN8jHOhn+tNn2cR7X_fPyyLF-ADiScD2gymKY9H2ZFb+UdkJSw@mail.gmail.com","subject":"Re: Bug: fsmonitor--daemon doesn't pick up submodule changes","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-06-02T13:28:29Z","receivedAt":"2022-06-02T13:28:39Z","isPatch":false,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Benedek,\n\nOn Tue, 31 May 2022, Benedek Kozma wrote:\n\n> What did you do before the bug happened? (Steps to reproduce your issue)\n> git status\n> cd submodule\n> git checkout origin/HEAD\n> cd ..\n> git status\n>\n> What did you expect to happen? (Expected behavior)\n> the second git status showing that a submodule changed\n>\n> What happened instead? (Actual behavior)\n> second git status also shows up to date\n\nI believe that this should be fixed by one of the active FSMonitor patches\nthat are lined up for getting merged into Git:\nhttps://lore.kernel.org/git/d0c8fecd1a0d622b1a6cce0aa79fdcdc2771db1d.1653601644.git.gitgitgadget@gmail.com/\n\nDo you have a setup where you could apply this patch and build Git so that\nyou can verify whether this fixes the bug you reported?\n\nThanks,\nJohannes\n"},{"id":"456709","messageId":"CAN8jHOiQZPxfPy2g5XfEOeayUqt345-Cosc3T_sT039KdgawRQ@mail.gmail.com","threadId":"57935","inReplyTo":"nycvar.QRO.7.76.6.2206021525430.349@tvgsbejvaqbjf.bet","subject":"Re: Bug: fsmonitor--daemon doesn't pick up submodule changes","fromName":"Benedek Kozma","fromEmail":"cyberbeni@gmail.com","sentAt":"2022-06-06T10:46:13Z","receivedAt":"2022-06-06T10:46:46Z","isPatch":false,"sender":{"key":"cyberbeni@gmail.com","avatar":null},"body":"I tested the patch and it fixes the bug.\n\nJohannes Schindelin <Johannes.Schindelin@gmx.de> ezt írta (időpont:\n2022. jún. 2., Cs, 15:28):\n>\n> Hi Benedek,\n>\n> On Tue, 31 May 2022, Benedek Kozma wrote:\n>\n> > What did you do before the bug happened? (Steps to reproduce your issue)\n> > git status\n> > cd submodule\n> > git checkout origin/HEAD\n> > cd ..\n> > git status\n> >\n> > What did you expect to happen? (Expected behavior)\n> > the second git status showing that a submodule changed\n> >\n> > What happened instead? (Actual behavior)\n> > second git status also shows up to date\n>\n> I believe that this should be fixed by one of the active FSMonitor patches\n> that are lined up for getting merged into Git:\n> https://lore.kernel.org/git/d0c8fecd1a0d622b1a6cce0aa79fdcdc2771db1d.1653601644.git.gitgitgadget@gmail.com/\n>\n> Do you have a setup where you could apply this patch and build Git so that\n> you can verify whether this fixes the bug you reported?\n>\n> Thanks,\n> Johannes\n"}]}