{"thread":{"id":"57759","subject":"[PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","startedAt":"2022-04-19T01:31:24Z","lastAt":"2022-04-25T09:46:17Z","messageCount":7,"participants":["Jack McGuinness via GitGitGadget","Bagas Sanjaya","Jack McGuinness","Christian Couder"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"453910","messageId":"pull.1220.git.1650331876.gitgitgadget@gmail.com","threadId":"57759","inReplyTo":null,"subject":"[PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","fromName":"Jack McGuinness via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-04-19T01:31:13Z","receivedAt":"2022-04-19T01:31:24Z","isPatch":true,"sender":{"key":"jmcguinness2@ucmerced.edu","avatar":null},"body":"I am using this thread to redo my previous attempt to modernize, where I\nmistakenly replaced spaces with tabs incorrectly, and to complete the rest\nof the modernization of t4202. I am really new to gitgitgadget, and\ncontributing to open source in general, so I expect I will mess up again,\nbut hopefully I can get manage to get through it when i do.\n\nThank you Derrick Stolee for reviewing my last patch, it's clear I still\nhave a lot of work to do on understanding style and bash scripting. Thanks\nfor checking this, -Jack McGuinness jmcguinness2@ucmerced.edu\n\nJack McGuinness (3):\n  [GSoC][Patch] area: t4202-log.sh, modernizing test script\n  [GSoC][Patch] area: t4202-log.sh, modernizing test script p2\n  [GSoC][Patch] area: t4202-log.sh, modernizing test script p3\n\n t/t4202-log.sh | 156 +++++++++++++++++++++++++------------------------\n 1 file changed, 80 insertions(+), 76 deletions(-)\n\n\nbase-commit: 6cd33dceed60949e2dbc32e3f0f5e67c4c882e1e\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1220%2FJackMcGu%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1220/JackMcGu/master-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1220\n-- \ngitgitgadget\n"},{"id":"453911","messageId":"0c6aa4e9103b301556437d35acefa535a90e6a1e.1650331876.git.gitgitgadget@gmail.com","threadId":"57759","inReplyTo":"pull.1220.git.1650331876.gitgitgadget@gmail.com","subject":"[PATCH 1/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","fromName":"Jack McGuinness via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-04-19T01:31:14Z","receivedAt":"2022-04-19T01:31:25Z","isPatch":true,"sender":{"key":"jmcguinness2@ucmerced.edu","avatar":null},"body":"From: Jack McGuinness <jmcguinness2@ucmerced.edu>\n\nReplace test body spaces with tabs where appropiate\nRemove blank lines at start and and of test bodies.\n\nSigned-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>\n---\n t/t4202-log.sh | 32 +++++---------------------------\n 1 file changed, 5 insertions(+), 27 deletions(-)\n\ndiff --git a/t/t4202-log.sh b/t/t4202-log.sh\nindex be07407f855..c5d191356f1 100755\n--- a/t/t4202-log.sh\n+++ b/t/t4202-log.sh\n@@ -15,7 +15,6 @@ test_cmp_graph () {\n }\n \n test_expect_success setup '\n-\n \techo one >one &&\n \tgit add one &&\n \ttest_tick &&\n@@ -44,31 +43,26 @@ test_expect_success setup '\n \tgit rm a/two &&\n \ttest_tick &&\n \tgit commit -m sixth\n-\n '\n \n printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\" > expect\n test_expect_success 'pretty' '\n-\n \tgit log --pretty=\"format:%s\" > actual &&\n \ttest_cmp expect actual\n '\n \n printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\\n\" > expect\n test_expect_success 'pretty (tformat)' '\n-\n \tgit log --pretty=\"tformat:%s\" > actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'pretty (shortcut)' '\n-\n \tgit log --pretty=\"%s\" > actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'format' '\n-\n \tgit log --format=\"%s\" > actual &&\n \ttest_cmp expect actual\n '\n@@ -83,13 +77,11 @@ cat > expect << EOF\n EOF\n \n test_expect_success 'format %w(11,1,2)' '\n-\n \tgit log -2 --format=\"%w(11,1,2)This is the %s commit.\" > actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'format %w(,1,2)' '\n-\n \tgit log -2 --format=\"%w(,1,2)This is%nthe %s%ncommit.\" > actual &&\n \ttest_cmp expect actual\n '\n@@ -103,47 +95,37 @@ $(git rev-parse --short :/second ) second\n $(git rev-parse --short :/initial) initial\n EOF\n test_expect_success 'oneline' '\n-\n \tgit log --oneline > actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'diff-filter=A' '\n-\n \tgit log --no-renames --pretty=\"format:%s\" --diff-filter=A HEAD > actual &&\n \tgit log --no-renames --pretty=\"format:%s\" --diff-filter A HEAD > actual-separate &&\n \tprintf \"fifth\\nfourth\\nthird\\ninitial\" > expect &&\n \ttest_cmp expect actual &&\n \ttest_cmp expect actual-separate\n-\n '\n \n test_expect_success 'diff-filter=M' '\n-\n \tgit log --pretty=\"format:%s\" --diff-filter=M HEAD >actual &&\n \tprintf \"second\" >expect &&\n \ttest_cmp expect actual\n-\n '\n \n test_expect_success 'diff-filter=D' '\n-\n \tgit log --no-renames --pretty=\"format:%s\" --diff-filter=D HEAD >actual &&\n \tprintf \"sixth\\nthird\" >expect &&\n \ttest_cmp expect actual\n-\n '\n \n test_expect_success 'diff-filter=R' '\n-\n \tgit log -M --pretty=\"format:%s\" --diff-filter=R HEAD >actual &&\n \tprintf \"third\" >expect &&\n \ttest_cmp expect actual\n-\n '\n \n test_expect_success 'multiple --diff-filter bits' '\n-\n \tgit log -M --pretty=\"format:%s\" --diff-filter=R HEAD >expect &&\n \tgit log -M --pretty=\"format:%s\" --diff-filter=Ra HEAD >actual &&\n \ttest_cmp expect actual &&\n@@ -152,19 +134,15 @@ test_expect_success 'multiple --diff-filter bits' '\n \tgit log -M --pretty=\"format:%s\" \\\n \t\t--diff-filter=a --diff-filter=R HEAD >actual &&\n \ttest_cmp expect actual\n-\n '\n \n test_expect_success 'diff-filter=C' '\n-\n \tgit log -C -C --pretty=\"format:%s\" --diff-filter=C HEAD >actual &&\n \tprintf \"fourth\" >expect &&\n \ttest_cmp expect actual\n-\n '\n \n test_expect_success 'git log --follow' '\n-\n \tgit log --follow --pretty=\"format:%s\" ichi >actual &&\n \tprintf \"third\\nsecond\\ninitial\" >expect &&\n \ttest_cmp expect actual\n@@ -879,7 +857,7 @@ test_expect_success 'multiple decorate-refs' '\n \tgit log -n6 --decorate=short --pretty=\"tformat:%f%d\" \\\n \t\t--decorate-refs=\"heads/octopus*\" \\\n \t\t--decorate-refs=\"tags/reach\" >actual &&\n-    test_cmp expect.decorate actual\n+\ttest_cmp expect.decorate actual\n '\n \n test_expect_success 'decorate-refs-exclude with glob' '\n@@ -2190,10 +2168,10 @@ test_expect_success 'log --decorate includes all levels of tag annotated tags' '\n '\n \n test_expect_success 'log --end-of-options' '\n-       git update-ref refs/heads/--source HEAD &&\n-       git log --end-of-options --source >actual &&\n-       git log >expect &&\n-       test_cmp expect actual\n+\tgit update-ref refs/heads/--source HEAD &&\n+\tgit log --end-of-options --source >actual &&\n+\tgit log >expect &&\n+\ttest_cmp expect actual\n '\n \n test_expect_success 'set up commits with different authors' '\n-- \ngitgitgadget\n\n"},{"id":"453912","messageId":"e5c29a12df61d0f587594664f50ec025b934fadf.1650331876.git.gitgitgadget@gmail.com","threadId":"57759","inReplyTo":"pull.1220.git.1650331876.gitgitgadget@gmail.com","subject":"[PATCH 2/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script p2","fromName":"Jack McGuinness via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-04-19T01:31:15Z","receivedAt":"2022-04-19T01:31:27Z","isPatch":true,"sender":{"key":"jmcguinness2@ucmerced.edu","avatar":null},"body":"From: Jack McGuinness <jmcguinness2@ucmerced.edu>\n\nRemove whitespace after redirect operator.\n\nSigned-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>\n---\n t/t4202-log.sh | 62 +++++++++++++++++++++++++-------------------------\n 1 file changed, 31 insertions(+), 31 deletions(-)\n\ndiff --git a/t/t4202-log.sh b/t/t4202-log.sh\nindex c5d191356f1..fe3976829bb 100755\n--- a/t/t4202-log.sh\n+++ b/t/t4202-log.sh\n@@ -45,29 +45,29 @@ test_expect_success setup '\n \tgit commit -m sixth\n '\n \n-printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\" > expect\n+printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\" >expect\n test_expect_success 'pretty' '\n-\tgit log --pretty=\"format:%s\" > actual &&\n+\tgit log --pretty=\"format:%s\" >actual &&\n \ttest_cmp expect actual\n '\n \n-printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\\n\" > expect\n+printf \"sixth\\nfifth\\nfourth\\nthird\\nsecond\\ninitial\\n\" >expect\n test_expect_success 'pretty (tformat)' '\n-\tgit log --pretty=\"tformat:%s\" > actual &&\n+\tgit log --pretty=\"tformat:%s\" >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'pretty (shortcut)' '\n-\tgit log --pretty=\"%s\" > actual &&\n+\tgit log --pretty=\"%s\" >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'format' '\n-\tgit log --format=\"%s\" > actual &&\n+\tgit log --format=\"%s\" >actual &&\n \ttest_cmp expect actual\n '\n \n-cat > expect << EOF\n+cat >expect << EOF\n  This is\n   the sixth\n   commit.\n@@ -77,16 +77,16 @@ cat > expect << EOF\n EOF\n \n test_expect_success 'format %w(11,1,2)' '\n-\tgit log -2 --format=\"%w(11,1,2)This is the %s commit.\" > actual &&\n+\tgit log -2 --format=\"%w(11,1,2)This is the %s commit.\" >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'format %w(,1,2)' '\n-\tgit log -2 --format=\"%w(,1,2)This is%nthe %s%ncommit.\" > actual &&\n+\tgit log -2 --format=\"%w(,1,2)This is%nthe %s%ncommit.\" >actual &&\n \ttest_cmp expect actual\n '\n \n-cat > expect << EOF\n+cat >expect << EOF\n $(git rev-parse --short :/sixth  ) sixth\n $(git rev-parse --short :/fifth  ) fifth\n $(git rev-parse --short :/fourth ) fourth\n@@ -95,14 +95,14 @@ $(git rev-parse --short :/second ) second\n $(git rev-parse --short :/initial) initial\n EOF\n test_expect_success 'oneline' '\n-\tgit log --oneline > actual &&\n+\tgit log --oneline >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'diff-filter=A' '\n-\tgit log --no-renames --pretty=\"format:%s\" --diff-filter=A HEAD > actual &&\n-\tgit log --no-renames --pretty=\"format:%s\" --diff-filter A HEAD > actual-separate &&\n-\tprintf \"fifth\\nfourth\\nthird\\ninitial\" > expect &&\n+\tgit log --no-renames --pretty=\"format:%s\" --diff-filter=A HEAD >actual &&\n+\tgit log --no-renames --pretty=\"format:%s\" --diff-filter A HEAD >actual-separate &&\n+\tprintf \"fifth\\nfourth\\nthird\\ninitial\" >expect &&\n \ttest_cmp expect actual &&\n \ttest_cmp expect actual-separate\n '\n@@ -174,43 +174,43 @@ test_expect_success 'git config log.follow is overridden by --no-follow' '\n \n # Note that these commits are intentionally listed out of order.\n last_three=\"$(git rev-parse :/fourth :/sixth :/fifth)\"\n-cat > expect << EOF\n+cat >expect << EOF\n $(git rev-parse --short :/sixth ) sixth\n $(git rev-parse --short :/fifth ) fifth\n $(git rev-parse --short :/fourth) fourth\n EOF\n test_expect_success 'git log --no-walk <commits> sorts by commit time' '\n-\tgit log --no-walk --oneline $last_three > actual &&\n+\tgit log --no-walk --oneline $last_three >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'git log --no-walk=sorted <commits> sorts by commit time' '\n-\tgit log --no-walk=sorted --oneline $last_three > actual &&\n+\tgit log --no-walk=sorted --oneline $last_three >actual &&\n \ttest_cmp expect actual\n '\n \n-cat > expect << EOF\n+cat >expect << EOF\n === $(git rev-parse --short :/sixth ) sixth\n === $(git rev-parse --short :/fifth ) fifth\n === $(git rev-parse --short :/fourth) fourth\n EOF\n test_expect_success 'git log --line-prefix=\"=== \" --no-walk <commits> sorts by commit time' '\n-\tgit log --line-prefix=\"=== \" --no-walk --oneline $last_three > actual &&\n+\tgit log --line-prefix=\"=== \" --no-walk --oneline $last_three >actual &&\n \ttest_cmp expect actual\n '\n \n-cat > expect << EOF\n+cat >expect << EOF\n $(git rev-parse --short :/fourth) fourth\n $(git rev-parse --short :/sixth ) sixth\n $(git rev-parse --short :/fifth ) fifth\n EOF\n test_expect_success 'git log --no-walk=unsorted <commits> leaves list of commits as given' '\n-\tgit log --no-walk=unsorted --oneline $last_three > actual &&\n+\tgit log --no-walk=unsorted --oneline $last_three >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success 'git show <commits> leaves list of commits as given' '\n-\tgit show --oneline -s $last_three > actual &&\n+\tgit show --oneline -s $last_three >actual &&\n \ttest_cmp expect actual\n '\n \n@@ -227,7 +227,7 @@ test_expect_success 'log --grep' '\n \ttest_cmp expect actual\n '\n \n-cat > expect << EOF\n+cat >expect << EOF\n second\n initial\n EOF\n@@ -514,7 +514,7 @@ test_expect_success '-c color.grep.matchSelected log --grep' '\n \ttest_cmp expect actual\n '\n \n-cat > expect <<EOF\n+cat >expect <<EOF\n * Second\n * sixth\n * fifth\n@@ -528,7 +528,7 @@ test_expect_success 'simple log --graph' '\n \ttest_cmp_graph\n '\n \n-cat > expect <<EOF\n+cat >expect <<EOF\n 123 * Second\n 123 * sixth\n 123 * fifth\n@@ -550,7 +550,7 @@ test_expect_success 'set up merge history' '\n \tgit merge side\n '\n \n-cat > expect <<\\EOF\n+cat >expect <<\\EOF\n *   Merge branch 'side'\n |\\\n | * side-2\n@@ -569,7 +569,7 @@ test_expect_success 'log --graph with merge' '\n \ttest_cmp_graph --date-order\n '\n \n-cat > expect <<\\EOF\n+cat >expect <<\\EOF\n | | | *   Merge branch 'side'\n | | | |\\\n | | | | * side-2\n@@ -588,7 +588,7 @@ test_expect_success 'log --graph --line-prefix=\"| | | \" with merge' '\n \ttest_cmp_graph --line-prefix=\"| | | \" --date-order\n '\n \n-cat > expect.colors <<\\EOF\n+cat >expect.colors <<\\EOF\n *   Merge branch 'side'\n <BLUE>|<RESET><CYAN>\\<RESET>\n <BLUE>|<RESET> * side-2\n@@ -618,7 +618,7 @@ test_expect_success 'diff-tree --graph' '\n \tgrep \"one\" actual\n '\n \n-cat > expect <<\\EOF\n+cat >expect <<\\EOF\n *   commit main\n |\\  Merge: A B\n | | Author: A U Thor <author@example.com>\n@@ -699,7 +699,7 @@ test_expect_success 'set up more tangled history' '\n \tgit merge reach\n '\n \n-cat > expect <<\\EOF\n+cat >expect <<\\EOF\n *   Merge tag 'reach'\n |\\\n | \\\n@@ -1822,7 +1822,7 @@ test_expect_success GPGSM 'log x509 fingerprint' '\n '\n \n test_expect_success GPGSM 'log OpenPGP fingerprint' '\n-\techo \"D4BE22311AD3131E5EDA29A461092E85B7227189\" > expect &&\n+\techo \"D4BE22311AD3131E5EDA29A461092E85B7227189\" >expect &&\n \tgit log -n1 --format=\"%GP\" signed-subkey >actual &&\n \ttest_cmp expect actual\n '\n-- \ngitgitgadget\n\n"},{"id":"453913","messageId":"4f0f4619806b383f280e8f0d0b9000c189a3b540.1650331876.git.gitgitgadget@gmail.com","threadId":"57759","inReplyTo":"pull.1220.git.1650331876.gitgitgadget@gmail.com","subject":"[PATCH 3/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script p3","fromName":"Jack McGuinness via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-04-19T01:31:16Z","receivedAt":"2022-04-19T01:31:28Z","isPatch":true,"sender":{"key":"jmcguinness2@ucmerced.edu","avatar":null},"body":"From: Jack McGuinness <jmcguinness2@ucmerced.edu>\n\nSplit up multiple lines on one line to multiple\nFix style of cd & echo in subshell\n\nSigned-off-by: Jack McGuinness <jmcguinness2@ucmerced.edu>\n---\n t/t4202-log.sh | 62 +++++++++++++++++++++++++++++++++++---------------\n 1 file changed, 44 insertions(+), 18 deletions(-)\n\ndiff --git a/t/t4202-log.sh b/t/t4202-log.sh\nindex fe3976829bb..604b275d6a8 100755\n--- a/t/t4202-log.sh\n+++ b/t/t4202-log.sh\n@@ -1756,13 +1756,20 @@ test_expect_success '--walk-reflogs --graph --no-graph works' '\n \n test_expect_success 'dotdot is a parent directory' '\n \tmkdir -p a/b &&\n-\t( echo sixth && echo fifth ) >expect &&\n-\t( cd a/b && git log --format=%s .. ) >actual &&\n+\t(\n+\t\techo sixth &&\n+\t\techo fifth\n+\t) >expect &&\n+\t(\n+\t\tcd a/b &&\n+\t\tgit log --format=%s ..\n+\t) >actual &&\n \ttest_cmp expect actual\n '\n \n test_expect_success GPG 'setup signed branch' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b signed main &&\n \techo foo >foo &&\n \tgit add foo &&\n@@ -1770,7 +1777,8 @@ test_expect_success GPG 'setup signed branch' '\n '\n \n test_expect_success GPG 'setup signed branch with subkey' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b signed-subkey main &&\n \techo foo >foo &&\n \tgit add foo &&\n@@ -1778,7 +1786,8 @@ test_expect_success GPG 'setup signed branch with subkey' '\n '\n \n test_expect_success GPGSM 'setup signed branch x509' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b signed-x509 main &&\n \techo foo >foo &&\n \tgit add foo &&\n@@ -1790,7 +1799,8 @@ test_expect_success GPGSM 'setup signed branch x509' '\n test_expect_success GPGSSH 'setup sshkey signed branch' '\n \ttest_config gpg.format ssh &&\n \ttest_config user.signingkey \"${GPGSSH_KEY_PRIMARY}\" &&\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b signed-ssh main &&\n \techo foo >foo &&\n \tgit add foo &&\n@@ -1802,16 +1812,24 @@ test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'create signed commits with keys ha\n \ttouch file &&\n \tgit add file &&\n \n-\techo expired >file && test_tick && git commit -a -m expired -S\"${GPGSSH_KEY_EXPIRED}\" &&\n+\techo expired >file &&\n+\ttest_tick &&\n+\tgit commit -a -m expired -S\"${GPGSSH_KEY_EXPIRED}\" &&\n \tgit tag expired-signed &&\n \n-\techo notyetvalid >file && test_tick && git commit -a -m notyetvalid -S\"${GPGSSH_KEY_NOTYETVALID}\" &&\n+\techo notyetvalid >file &&\n+\ttest_tick &&\n+\tgit commit -a -m notyetvalid -S\"${GPGSSH_KEY_NOTYETVALID}\" &&\n \tgit tag notyetvalid-signed &&\n \n-\techo timeboxedvalid >file && test_tick && git commit -a -m timeboxedvalid -S\"${GPGSSH_KEY_TIMEBOXEDVALID}\" &&\n+\techo timeboxedvalid >file &&\n+\ttest_tick &&\n+\tgit commit -a -m timeboxedvalid -S\"${GPGSSH_KEY_TIMEBOXEDVALID}\" &&\n \tgit tag timeboxedvalid-signed &&\n \n-\techo timeboxedinvalid >file && test_tick && git commit -a -m timeboxedinvalid -S\"${GPGSSH_KEY_TIMEBOXEDINVALID}\" &&\n+\techo timeboxedinvalid >file &&\n+\ttest_tick &&\n+\tgit commit -a -m timeboxedinvalid -S\"${GPGSSH_KEY_TIMEBOXEDINVALID}\" &&\n \tgit tag timeboxedinvalid-signed\n '\n \n@@ -1878,7 +1896,8 @@ test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'log shows failure with commit date\n '\n \n test_expect_success GPG 'log --graph --show-signature for merged tag' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b plain main &&\n \techo aaa >bar &&\n \tgit add bar &&\n@@ -1897,7 +1916,8 @@ test_expect_success GPG 'log --graph --show-signature for merged tag' '\n '\n \n test_expect_success GPG 'log --graph --show-signature for merged tag in shallow clone' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b plain-shallow main &&\n \techo aaa >bar &&\n \tgit add bar &&\n@@ -1917,7 +1937,8 @@ test_expect_success GPG 'log --graph --show-signature for merged tag in shallow\n '\n \n test_expect_success GPG 'log --graph --show-signature for merged tag with missing key' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b plain-nokey main &&\n \techo aaa >bar &&\n \tgit add bar &&\n@@ -1936,7 +1957,8 @@ test_expect_success GPG 'log --graph --show-signature for merged tag with missin\n '\n \n test_expect_success GPG 'log --graph --show-signature for merged tag with bad signature' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b plain-bad main &&\n \techo aaa >bar &&\n \tgit add bar &&\n@@ -1958,7 +1980,8 @@ test_expect_success GPG 'log --graph --show-signature for merged tag with bad si\n '\n \n test_expect_success GPG 'log --show-signature for merged tag with GPG failure' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \tgit checkout -b plain-fail main &&\n \techo aaa >bar &&\n \tgit add bar &&\n@@ -1977,7 +2000,8 @@ test_expect_success GPG 'log --show-signature for merged tag with GPG failure' '\n '\n \n test_expect_success GPGSM 'log --graph --show-signature for merged tag x509' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \ttest_config gpg.format x509 &&\n \ttest_config user.signingkey $GIT_COMMITTER_EMAIL &&\n \tgit checkout -b plain-x509 main &&\n@@ -1998,7 +2022,8 @@ test_expect_success GPGSM 'log --graph --show-signature for merged tag x509' '\n '\n \n test_expect_success GPGSM 'log --graph --show-signature for merged tag x509 missing key' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \ttest_config gpg.format x509 &&\n \ttest_config user.signingkey $GIT_COMMITTER_EMAIL &&\n \tgit checkout -b plain-x509-nokey main &&\n@@ -2019,7 +2044,8 @@ test_expect_success GPGSM 'log --graph --show-signature for merged tag x509 miss\n '\n \n test_expect_success GPGSM 'log --graph --show-signature for merged tag x509 bad signature' '\n-\ttest_when_finished \"git reset --hard && git checkout main\" &&\n+\ttest_when_finished \"git reset --hard &&\n+\tgit checkout main\" &&\n \ttest_config gpg.format x509 &&\n \ttest_config user.signingkey $GIT_COMMITTER_EMAIL &&\n \tgit checkout -b plain-x509-bad main &&\n-- \ngitgitgadget\n"},{"id":"453918","messageId":"5b90dfbf-b299-1388-f9b6-c610ce12bab7@gmail.com","threadId":"57759","inReplyTo":"pull.1220.git.1650331876.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2022-04-19T05:26:10Z","receivedAt":"2022-04-19T05:26:17Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:\n> Jack McGuinness (3):\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script p2\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script p3\n> \n>  t/t4202-log.sh | 156 +++++++++++++++++++++++++------------------------\n>  1 file changed, 80 insertions(+), 76 deletions(-)\n> \n\nI think the subject prefix of this patch series can be just\n[GSOC] [PATCH] instead.\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"453919","messageId":"BYAPR06MB4517BCBBA837AA3004B2137DE6F29@BYAPR06MB4517.namprd06.prod.outlook.com","threadId":"57759","inReplyTo":"5b90dfbf-b299-1388-f9b6-c610ce12bab7@gmail.com","subject":"Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","fromName":"Jack McGuinness","fromEmail":"jmcguinness2@ucmerced.edu","sentAt":"2022-04-19T05:34:55Z","receivedAt":"2022-04-19T05:35:05Z","isPatch":true,"sender":{"key":"jmcguinness2@ucmerced.edu","avatar":null},"body":"Hi, thank you for the advice. I wanted it to be that way myself, however I was using gitgitgadget to email it, and my PR was composed of three different commits, which caused it to automatically be formatted that way. I tried finding a way to remove it, but I had no luck, If you know how I would love to know!\n\nThanks for your time,\n-Jack McGuinness <jmcguinness2@ucmerced.edu>\n\n________________________________________\nFrom: Bagas Sanjaya <bagasdotme@gmail.com>\nSent: Monday, April 18, 2022 10:26 PM\nTo: Jack McGuinness via GitGitGadget; git@vger.kernel.org\nCc: Jack McGuinness\nSubject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script\n\nOn 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:\n> Jack McGuinness (3):\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script p2\n>   [GSoC][Patch] area: t4202-log.sh, modernizing test script p3\n>\n>  t/t4202-log.sh | 156 +++++++++++++++++++++++++------------------------\n>  1 file changed, 80 insertions(+), 76 deletions(-)\n>\n\nI think the subject prefix of this patch series can be just\n[GSOC] [PATCH] instead.\n\n--\nAn old man doll... just what I always wanted! - Clara\n"},{"id":"454376","messageId":"CAP8UFD1aAVCgEQvi4WjCiRUBWs6_u-7k-JWTz5b1N7xa=V8OdA@mail.gmail.com","threadId":"57759","inReplyTo":"BYAPR06MB4517BCBBA837AA3004B2137DE6F29@BYAPR06MB4517.namprd06.prod.outlook.com","subject":"Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2022-04-25T09:45:57Z","receivedAt":"2022-04-25T09:46:17Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Hi,\n\nOn Tue, Apr 19, 2022 at 8:33 AM Jack McGuinness\n<jmcguinness2@ucmerced.edu> wrote:\n>\n> Hi, thank you for the advice. I wanted it to be that way myself, however I was using gitgitgadget to email it, and my PR was composed of three different commits, which caused it to automatically be formatted that way. I tried finding a way to remove it, but I had no luck, If you know how I would love to know!\n\nI don't use gitgitgadget, so I cannot help you much on this. The\napproach I would take if I had to use it would be to find patches on\nthe mailing list that were sent using gitgitgadget by experienced\ndevelopers using it, then find and see how the corresponding PRs look\nlike on GitHub, and try to imitate those PRs.\n\nAnyway, it would be nice if you could try again taking into account\nJunio's suggestions in:\n\nhttps://lore.kernel.org/git/xmqqmtggs2nv.fsf@gitster.g/\n\nI also have some suggestions below.\n\n> To: Jack McGuinness via GitGitGadget; git@vger.kernel.org\n> Cc: Jack McGuinness\n> Subject: Re: [PATCH 0/3] [GSoC][Patch] area: t4202-log.sh, modernizing test script\n\nThis is your second attempt so it would be nice if it had a \"v2\"\nmarker in it like \"[PATCH v2 0/3] [GSoC]\" instead of \"[PATCH 0/3]\n[GSoC][Patch]\". (Your next attempt should use \"v3\".)\n\n> On 4/19/22 08:31, Jack McGuinness via GitGitGadget wrote:\n> > Jack McGuinness (3):\n> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script\n> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p2\n> >   [GSoC][Patch] area: t4202-log.sh, modernizing test script p3\n\nJunio already commented on the \"area: t4202-log.sh\" part of the\nsubject, so I won't repeat him.\n\nAbout the \"modernizing test script ...\" part, it would be nice if the\ndifferent patches would be a bit more specific about what each one is\ndoing and \"p2\" or \"p3\" is redundant with the \"2/3\" or \"3/3\" added by\nGitGitGadget. For example it could be replaced with \"remove whitespace\nafter redirect\" for the second patch.\n"}]}