{"thread":{"id":"57676","subject":"[BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","startedAt":"2022-04-06T13:48:01Z","lastAt":"2022-04-06T20:12:38Z","messageCount":6,"participants":["rsbecker@nexbridge.com","Ævar Arnfjörð Bjarmason","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"453171","messageId":"041601d849a8$1441ce60$3cc56b20$@nexbridge.com","threadId":"57676","inReplyTo":null,"subject":"[BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-04-06T11:18:39Z","receivedAt":"2022-04-06T13:48:01Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"t6200 makes assumptions that ssh-keygen to be used is located in\n/usr/local/bin. This causes problems when we have multiple OpenSSL\ninstallations - which we do - 3 of them. Our environment supplies OpenSSL\n1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a\ndifferent directory. There needs to be a mechanism to override the\nssh-keygen so that tests will work in this situation.\n\n*** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf\nin file /usr/local/bin/ssh-keygen.\n\n*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n/usr/local/bin/ssh-keygen.\n\n*** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n/usr/local/bin/ssh-keygen.\n\n*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n/usr/local/bin/ssh-keygen.\n\n*** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n/usr/local/bin/ssh-keygen.\n\nI do not know why the test is forcing SSH in /usr/local/bin - it is not\nsomething coming from our environment, which has PATH set correctly.\n\nThanks,\nRandall\n\n"},{"id":"453182","messageId":"220406.867d82e2sr.gmgdl@evledraar.gmail.com","threadId":"57676","inReplyTo":"041601d849a8$1441ce60$3cc56b20$@nexbridge.com","subject":"Re: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2022-04-06T13:51:54Z","receivedAt":"2022-04-06T16:33:25Z","isPatch":false,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:\n\n> t6200 makes assumptions that ssh-keygen to be used is located in\n> /usr/local/bin. This causes problems when we have multiple OpenSSL\n> installations - which we do - 3 of them. Our environment supplies OpenSSL\n> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a\n> different directory. There needs to be a mechanism to override the\n> ssh-keygen so that tests will work in this situation.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf\n> in file /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n> /usr/local/bin/ssh-keygen.\n>\n> I do not know why the test is forcing SSH in /usr/local/bin - it is not\n> something coming from our environment, which has PATH set correctly.\n\nIs it:\n\n\tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n\nIn the nonstop section in config.mak.uname along with:\n\t\n\tMakefile:ifdef SANE_TOOL_PATH\n\tMakefile:SANE_TOOL_PATH_SQ = $(subst ','\\'',$(SANE_TOOL_PATH))\n\tMakefile:BROKEN_PATH_FIX = 's|^\\# @@BROKEN_PATH_FIX@@$$|git_broken_path_fix \"$(SANE_TOOL_PATH_SQ)\"|'\n\tMakefile:PATH := $(SANE_TOOL_PATH):${PATH}\n\tMakefile-else\n\tMakefile-BROKEN_PATH_FIX = '/^\\# @@BROKEN_PATH_FIX@@$$/d'\n\tMakefile-endif\n\t\n?\n"},{"id":"453191","messageId":"044f01d849cb$93d3a720$bb7af560$@nexbridge.com","threadId":"57676","inReplyTo":"220406.867d82e2sr.gmgdl@evledraar.gmail.com","subject":"RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-04-06T15:32:46Z","receivedAt":"2022-04-06T17:28:18Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On April 6, 2022 9:52 AM, Ævar Arnfjörð Bjarmason wrote:\n>On Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:\n>\n>> t6200 makes assumptions that ssh-keygen to be used is located in\n>> /usr/local/bin. This causes problems when we have multiple OpenSSL\n>> installations - which we do - 3 of them. Our environment supplies\n>> OpenSSL\n>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in\n>> a different directory. There needs to be a mechanism to override the\n>> ssh-keygen so that tests will work in this situation.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol\n>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> I do not know why the test is forcing SSH in /usr/local/bin - it is\n>> not something coming from our environment, which has PATH set correctly.\n>\n>Is it:\n>\n>\tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n>\n>In the nonstop section in config.mak.uname along with:\n>\n>\tMakefile:ifdef SANE_TOOL_PATH\n>\tMakefile:SANE_TOOL_PATH_SQ = $(subst ','\\'',$(SANE_TOOL_PATH))\n>\tMakefile:BROKEN_PATH_FIX = 's|^\\#\n>@@BROKEN_PATH_FIX@@$$|git_broken_path_fix \"$(SANE_TOOL_PATH_SQ)\"|'\n>\tMakefile:PATH := $(SANE_TOOL_PATH):${PATH}\n>\tMakefile-else\n>\tMakefile-BROKEN_PATH_FIX = '/^\\# @@BROKEN_PATH_FIX@@$$/d'\n>\tMakefile-endif\n>\n>?\n\nOIC. Can I change the PATH value when running the tests without changing config.mak.uname?\n\n"},{"id":"453192","messageId":"045501d849cc$5e2c30a0$1a8491e0$@nexbridge.com","threadId":"57676","inReplyTo":"220406.867d82e2sr.gmgdl@evledraar.gmail.com","subject":"RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-04-06T15:38:25Z","receivedAt":"2022-04-06T17:31:36Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On April 6, 2022 9:52 AM, Ævar Arnfjörð Bjarmason wrote:\n>On Wed, Apr 06 2022, rsbecker@nexbridge.com wrote:\n>\n>> t6200 makes assumptions that ssh-keygen to be used is located in\n>> /usr/local/bin. This causes problems when we have multiple OpenSSL\n>> installations - which we do - 3 of them. Our environment supplies\n>> OpenSSL\n>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in\n>> a different directory. There needs to be a mechanism to override the\n>> ssh-keygen so that tests will work in this situation.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol\n>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> I do not know why the test is forcing SSH in /usr/local/bin - it is\n>> not something coming from our environment, which has PATH set correctly.\n>\n>Is it:\n>\n>\tSANE_TOOL_PATH = /usr/coreutils/bin:/usr/local/bin\n>\n>In the nonstop section in config.mak.uname along with:\n>\n>\tMakefile:ifdef SANE_TOOL_PATH\n>\tMakefile:SANE_TOOL_PATH_SQ = $(subst ','\\'',$(SANE_TOOL_PATH))\n>\tMakefile:BROKEN_PATH_FIX = 's|^\\#\n>@@BROKEN_PATH_FIX@@$$|git_broken_path_fix \"$(SANE_TOOL_PATH_SQ)\"|'\n>\tMakefile:PATH := $(SANE_TOOL_PATH):${PATH}\n>\tMakefile-else\n>\tMakefile-BROKEN_PATH_FIX = '/^\\# @@BROKEN_PATH_FIX@@$$/d'\n>\tMakefile-endif\n>\n>?\n\nI should also point out that we have not previously had path problems like this (2.35.1 and before going back years).\n\n"},{"id":"453206","messageId":"047101d849e1$d965b420$8c311c60$@nexbridge.com","threadId":"57676","inReplyTo":"xmqq35iqyuvb.fsf@gitster.g","subject":"RE: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"","fromEmail":"rsbecker@nexbridge.com","sentAt":"2022-04-06T18:12:11Z","receivedAt":"2022-04-06T19:02:40Z","isPatch":false,"sender":{"key":"randall.becker@nexbridge.ca","avatar":"https://avatars.githubusercontent.com/u/28956764?v=4"},"body":"On April 6, 2022 1:39 PM, Junio C Hamano wrote:\n><rsbecker@nexbridge.com> writes:\n>\n>> t6200 makes assumptions that ssh-keygen to be used is located in\n>> /usr/local/bin. This causes problems when we have multiple OpenSSL\n>> installations - which we do - 3 of them. Our environment supplies\n>> OpenSSL\n>> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in\n>> a different directory. There needs to be a mechanism to override the\n>> ssh-keygen so that tests will work in this situation.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol\n>> OPENSSL_add_all_algorithms_noconf in file /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n>> /usr/local/bin/ssh-keygen.\n>>\n>> I do not know why the test is forcing SSH in /usr/local/bin - it is\n>> not something coming from our environment, which has PATH set correctly.\n>\n>Indeed that is curious, as the only hits to usr/local in t/ is this one:\n>\n>    $ git grep usr/local t/\n>    t/test-lib.sh:test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-\n>/usr/local/bin/unzip}\n\nI think it's coming from the NonStop definition in config.mak.uname, but I\nneed to be able to override the PATH to pick up the correct OpenSSH for the\nOpenSSL build. We have 12 different OpenSSL builds at this point and 3\nOpenSSH builds - which will likely go to 6 within the year. The complexity\nis wacky but needed because we cannot set up a VM for NonStop with the\nhardware we have.\n\n"},{"id":"453214","messageId":"xmqq35iqyuvb.fsf@gitster.g","threadId":"57676","inReplyTo":"041601d849a8$1441ce60$3cc56b20$@nexbridge.com","subject":"Re: [BUG] git-2.36.0-rc0 - t6200 fails due to library/path issues","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-04-06T17:39:04Z","receivedAt":"2022-04-06T20:12:38Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"<rsbecker@nexbridge.com> writes:\n\n> t6200 makes assumptions that ssh-keygen to be used is located in\n> /usr/local/bin. This causes problems when we have multiple OpenSSL\n> installations - which we do - 3 of them. Our environment supplies OpenSSL\n> 1.1 in /usr/local-ssl1.1, with a corresponding version of ssh-agent in a\n> different directory. There needs to be a mechanism to override the\n> ssh-keygen so that tests will work in this situation.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol OPENSSL_add_all_algorithms_noconf\n> in file /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_cleanup in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol SSLeay in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_block_size in file\n> /usr/local/bin/ssh-keygen.\n>\n> *** RLD ERROR ***: Unresolved Text Symbol EVP_MD_CTX_init in file\n> /usr/local/bin/ssh-keygen.\n>\n> I do not know why the test is forcing SSH in /usr/local/bin - it is not\n> something coming from our environment, which has PATH set correctly.\n\nIndeed that is curious, as the only hits to usr/local in t/ is this one:\n\n    $ git grep usr/local t/\n    t/test-lib.sh:test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-/usr/local/bin/unzip}\n\n"}]}