{"thread":{"id":"57666","subject":"[PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition","startedAt":"2022-04-05T11:43:02Z","lastAt":"2022-04-06T18:00:08Z","messageCount":3,"participants":["Adam Dinwoodie","Neeraj Singh","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"453113","messageId":"20220405100020.48663-1-adam@dinwoodie.org","threadId":"57666","inReplyTo":null,"subject":"[PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition","fromName":"Adam Dinwoodie","fromEmail":"adam@dinwoodie.org","sentAt":"2022-04-05T10:00:20Z","receivedAt":"2022-04-05T11:43:02Z","isPatch":true,"sender":{"key":"adam@dinwoodie.org","avatar":"https://avatars.githubusercontent.com/u/1397507?v=4"},"body":"If sync_file_range is not available when building the configure script,\nthere is a cosmetic bug when running that script reporting\n\"HAVE_SYNC_FILE_RANGE: command not found\".  Remove that error message by\ndefining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating\na script where that appears as a bare command.\n\nSigned-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n---\n configure.ac | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/configure.ac b/configure.ac\nindex 6bd6bef1c4..316a31d231 100644\n--- a/configure.ac\n+++ b/configure.ac\n@@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])\n # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.\n GIT_CHECK_FUNC(sync_file_range,\n \t[HAVE_SYNC_FILE_RANGE=YesPlease],\n-\t[HAVE_SYNC_FILE_RANGE])\n+\t[HAVE_SYNC_FILE_RANGE=])\n GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])\n \n #\n-- \n2.35.1\n\n"},{"id":"453137","messageId":"20220405153159.GA22458@neerajsi-x1.localdomain","threadId":"57666","inReplyTo":"20220405100020.48663-1-adam@dinwoodie.org","subject":"Re: [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition","fromName":"Neeraj Singh","fromEmail":"nksingh85@gmail.com","sentAt":"2022-04-05T15:31:59Z","receivedAt":"2022-04-05T21:50:09Z","isPatch":true,"sender":{"key":"nksingh85@gmail.com","avatar":null},"body":"On Tue, Apr 05, 2022 at 11:00:20AM +0100, Adam Dinwoodie wrote:\n> If sync_file_range is not available when building the configure script,\n> there is a cosmetic bug when running that script reporting\n> \"HAVE_SYNC_FILE_RANGE: command not found\".  Remove that error message by\n> defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating\n> a script where that appears as a bare command.\n> \n> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n> ---\n>  configure.ac | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/configure.ac b/configure.ac\n> index 6bd6bef1c4..316a31d231 100644\n> --- a/configure.ac\n> +++ b/configure.ac\n> @@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])\n>  # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.\n>  GIT_CHECK_FUNC(sync_file_range,\n>  \t[HAVE_SYNC_FILE_RANGE=YesPlease],\n> -\t[HAVE_SYNC_FILE_RANGE])\n> +\t[HAVE_SYNC_FILE_RANGE=])\n>  GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])\n>  \n>  #\n> -- \n> 2.35.1\n> \n\nThanks for fixing this.  Looks good to me.\n\n-Neeraj\n"},{"id":"453199","messageId":"xmqqo81eyxtm.fsf@gitster.g","threadId":"57666","inReplyTo":"20220405153159.GA22458@neerajsi-x1.localdomain","subject":"Re: [PATCH] configure.ac: fix HAVE_SYNC_FILE_RANGE definition","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-04-06T16:35:17Z","receivedAt":"2022-04-06T18:00:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Neeraj Singh <nksingh85@gmail.com> writes:\n\n> On Tue, Apr 05, 2022 at 11:00:20AM +0100, Adam Dinwoodie wrote:\n>> If sync_file_range is not available when building the configure script,\n>> there is a cosmetic bug when running that script reporting\n>> \"HAVE_SYNC_FILE_RANGE: command not found\".  Remove that error message by\n>> defining HAVE_SYNC_FILE_RANGE to an empty string, rather than generating\n>> a script where that appears as a bare command.\n>> \n>> Signed-off-by: Adam Dinwoodie <adam@dinwoodie.org>\n>> ---\n>>  configure.ac | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/configure.ac b/configure.ac\n>> index 6bd6bef1c4..316a31d231 100644\n>> --- a/configure.ac\n>> +++ b/configure.ac\n>> @@ -1087,7 +1087,7 @@ GIT_CONF_SUBST([HAVE_CLOCK_MONOTONIC])\n>>  # Define HAVE_SYNC_FILE_RANGE=YesPlease if sync_file_range is available.\n>>  GIT_CHECK_FUNC(sync_file_range,\n>>  \t[HAVE_SYNC_FILE_RANGE=YesPlease],\n>> -\t[HAVE_SYNC_FILE_RANGE])\n>> +\t[HAVE_SYNC_FILE_RANGE=])\n>>  GIT_CONF_SUBST([HAVE_SYNC_FILE_RANGE])\n>>  \n>>  #\n>> -- \n>> 2.35.1\n>> \n>\n> Thanks for fixing this.  Looks good to me.\n\nThanks, both.\n\nWill apply.\n"}]}