{"thread":{"id":"57633","subject":"[PATCH] core.fsync: fix incorrect expression for default configuration","startedAt":"2022-03-29T21:42:00Z","lastAt":"2022-03-29T21:42:00Z","messageCount":1,"participants":["Neeraj K. Singh via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"452607","messageId":"pull.1191.git.1648590113062.gitgitgadget@gmail.com","threadId":"57633","inReplyTo":null,"subject":"[PATCH] core.fsync: fix incorrect expression for default configuration","fromName":"Neeraj K. Singh via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-03-29T21:41:52Z","receivedAt":"2022-03-29T21:42:00Z","isPatch":true,"sender":{"key":"name:Neeraj K. Singh","avatar":null},"body":"From: Neeraj Singh <neerajsi@microsoft.com>\n\nCommit b9f5d0358d2e882 introduced an incorrect value for\nFSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than\nOR-NOT.\n\nSigned-off-by: Neeraj Singh <neerajsi@microsoft.com>\n---\n    core.fsync: fix incorrect expression for default configuration\n    \n    Commit b9f5d0358d2e882 introduced an incorrect value for\n    FSYNC_COMPONENTS_DEFAULT. We need an AND-NOT rather than OR-NOT.\n    \n    Signed-off-by: Neeraj Singh neerajsi@microsoft.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1191%2Fneerajsi-msft%2Fns%2Ffix-fsync-default-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1191/neerajsi-msft/ns/fix-fsync-default-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1191\n\n cache.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/cache.h b/cache.h\nindex ef7d34b7a09..ee9549c4601 100644\n--- a/cache.h\n+++ b/cache.h\n@@ -1014,8 +1014,8 @@ enum fsync_component {\n #define FSYNC_COMPONENTS_DERIVED_METADATA (FSYNC_COMPONENT_PACK_METADATA | \\\n \t\t\t\t\t   FSYNC_COMPONENT_COMMIT_GRAPH)\n \n-#define FSYNC_COMPONENTS_DEFAULT (FSYNC_COMPONENTS_OBJECTS | \\\n-\t\t\t\t  FSYNC_COMPONENTS_DERIVED_METADATA | \\\n+#define FSYNC_COMPONENTS_DEFAULT ((FSYNC_COMPONENTS_OBJECTS | \\\n+\t\t\t\t   FSYNC_COMPONENTS_DERIVED_METADATA) & \\\n \t\t\t\t  ~FSYNC_COMPONENT_LOOSE_OBJECT)\n \n #define FSYNC_COMPONENTS_COMMITTED (FSYNC_COMPONENTS_OBJECTS | \\\n\nbase-commit: 1d4f13e63720fb8eae39afa215199f7d77662dba\n-- \ngitgitgadget\n"}]}