{"thread":{"id":"57560","subject":"Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory","startedAt":"2022-03-15T08:50:43Z","lastAt":"2022-03-15T20:00:23Z","messageCount":3,"participants":["Christian Couder","Jayati Shrivastava"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"451378","messageId":"CAP8UFD0GeGr3ARkYycHNYU0r5vTC-PDdbLYrkYSohbtWBt9HSQ@mail.gmail.com","threadId":"57560","inReplyTo":"20220313105031.1081110-1-gaurijove@gmail.com","subject":"Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2022-03-15T08:50:26Z","receivedAt":"2022-03-15T08:50:43Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Sun, Mar 13, 2022 at 11:50 AM JAYATI SHRIVASTAVA <gaurijove@gmail.com> wrote:\n>\n> From: JAYATI SHRIVASTAVA <gaurijove@gmail.com>\n\nThanks for this patch! I am curious what tool you used to prepare and\nsend it. This is not a big deal but when there is only one patch I\nthink [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From:\nJAYATI...' line is not nécessary if you are sending the patch using\nthe same email address as what's in the 'From: JAYATI...' line.\n\n> To check whether the given path is a directory, use\n> the helper function 'test_path_is_dir' defined in the\n> test harness library instead of passing the -d flag to the test command\n\nIt's nice to say why it's better to use functions like\ntest_path_is_dir() rather than `test -d`. Also it looks like the last\nline could be formatted to be around the same length as previous\nlines, instead of being significantly longer.\nThe sentence should end with a full stop.\n\n> Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@gmail.com>\n\nIt's also not a big deal, but, unless it's really a personal\npreference, you might not want to use only uppercase letters for your\nname, as it's not usual here.\n\n> ---\n>  t/t7403-submodule-sync.sh | 22 +++++++++++-----------\n>  1 file changed, 11 insertions(+), 11 deletions(-)\n\nThe code change looks good to me.\n"},{"id":"451398","messageId":"CANsrJQd-E9JcFD0jtK=kMexm0Oc4Vc2HSXJ7nM2u3g4cN0zstA@mail.gmail.com","threadId":"57560","inReplyTo":"CAP8UFD0GeGr3ARkYycHNYU0r5vTC-PDdbLYrkYSohbtWBt9HSQ@mail.gmail.com","subject":"Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory","fromName":"Jayati Shrivastava","fromEmail":"gaurijove@gmail.com","sentAt":"2022-03-15T16:11:36Z","receivedAt":"2022-03-15T16:11:54Z","isPatch":true,"sender":{"key":"gaurijove@gmail.com","avatar":"https://avatars.githubusercontent.com/u/48182195?v=4"},"body":"Hi Christian,\n\nThanks for reviewing.\n\n>On Tue, Mar 15, 2022 at 2:20 PM Christian Couder <christian.couder@gmail.com> wrote:\n\n> Thanks for this patch! I am curious what tool you used to prepare and\n> send it.This is not a big deal but when there is only one patch I\n> think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From:\n> JAYATI...' line is not nécessary if you are sending the patch using\n> the same email address as what's in the 'From: JAYATI...' line.\n\nI am using git format-patch and send-email but had previously made\nsome unnecessary modifications in the editor which I have now done\naway with.\n\n> It's nice to say why it's better to use functions like\n> test_path_is_dir() rather than `test -d`. Also it looks like the last\n> line could be formatted to be around the same length as previous\n> lines, instead of being significantly longer.\n> The sentence should end with a full stop.\n>\n> > Signed-off-by: JAYATI SHRIVASTAVA <gaurijove@gmail.com>\n>\n> It's also not a big deal, but, unless it's really a personal\n> preference, you might not want to use only uppercase letters for your\n> name, as it's not usual here.\n\nI have modified the commit message as per your reviews. However,\nI am not sure why my patches are still not showing up on the mailing\nlist despite passing the --to/--cc/--in-reply-to options correctly to\ngit send-email. What do you think might be the reason?\n"},{"id":"451425","messageId":"CAP8UFD2RhgrqxPzyTa+ak-c6hyHp+srnwKpgftz7ZScieXZL3Q@mail.gmail.com","threadId":"57560","inReplyTo":"CANsrJQd-E9JcFD0jtK=kMexm0Oc4Vc2HSXJ7nM2u3g4cN0zstA@mail.gmail.com","subject":"Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2022-03-15T20:00:08Z","receivedAt":"2022-03-15T20:00:23Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Tue, Mar 15, 2022 at 5:11 PM Jayati Shrivastava <gaurijove@gmail.com> wrote:\n\n> I have modified the commit message as per your reviews. However,\n> I am not sure why my patches are still not showing up on the mailing\n> list despite passing the --to/--cc/--in-reply-to options correctly to\n> git send-email. What do you think might be the reason?\n\nI might take a look later, but this one made it through:\n\nhttps://lore.kernel.org/git/pull.1177.git.1647373314457.gitgitgadget@gmail.com/\n"}]}