{"thread":{"id":"57555","subject":"[PATCH 6/6] attr.h: remove duplicate struct definition","startedAt":"2022-03-14T00:23:38Z","lastAt":"2022-03-14T21:45:17Z","messageCount":4,"participants":["Elia Pinto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":6},"messages":[{"id":"451278","messageId":"20220314002327.243915-1-gitter.spiros@gmail.com","threadId":"57555","inReplyTo":null,"subject":"[PATCH 6/6] attr.h: remove duplicate struct definition","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-14T00:23:27Z","receivedAt":"2022-03-14T00:23:38Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"struct index_state is declared more than once.\n\nSigned-off-by: Elia Pinto \n---\n attr.h | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/attr.h b/attr.h\nindex 3732505eda..3fb40cced0 100644\n--- a/attr.h\n+++ b/attr.h\n@@ -121,7 +121,6 @@ struct git_attr;\n /* opaque structures used internally for attribute collection */\n struct all_attrs_item;\n struct attr_stack;\n-struct index_state;\n \n /*\n * Given a string, return the gitattribute object that\n-- \n2.35.1\n\n"},{"id":"451279","messageId":"xmqqh781t7ks.fsf@gitster.g","threadId":"57555","inReplyTo":"20220314002327.243915-1-gitter.spiros@gmail.com","subject":"Re: [PATCH 6/6] attr.h: remove duplicate struct definition","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-03-14T05:40:51Z","receivedAt":"2022-03-14T05:40:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto writes:\n\n> Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition\n\nI do not see other 5 from 1/6 thru 5/6 on the list.\n\nIf this is a leftover bit follow-up to the 5-patch series whose\ncover letter was <20220313195536.224075-1-gitter.spiros@gmail.com>\nwe often see such a message\n\n - with subject numbered as [PATCH 6/5]\n - as follow-up to the same cover letter.\n\nThe patch text looks good, and we can see from the output of\n\n $ git grep '^struct .*;' \\*.h |\n sort | uniq -c | sort -n | grep -v '^ *1 '\n\nthat this is the only duplicated opaque struct declaration in the\nheader files.\n\nFor now, I'd assume that is the case and queue it on the same topic\nbranch as the other five. Thanks.\n\n> struct index_state is declared more than once.\n>\n> Signed-off-by: Elia Pinto \n> ---\n> attr.h | 1 -\n> 1 file changed, 1 deletion(-)\n>\n> diff --git a/attr.h b/attr.h\n> index 3732505eda..3fb40cced0 100644\n> --- a/attr.h\n> +++ b/attr.h\n> @@ -121,7 +121,6 @@ struct git_attr;\n> /* opaque structures used internally for attribute collection */\n> struct all_attrs_item;\n> struct attr_stack;\n> -struct index_state;\n> \n> /*\n> * Given a string, return the gitattribute object that\n"},{"id":"451300","messageId":"CA+EOSBkJtcvKJ1D1hMuWB0EkrGEfP7Dua6gP8MDHehto1r+E3A@mail.gmail.com","threadId":"57555","inReplyTo":"xmqqh781t7ks.fsf@gitster.g","subject":"Re: [PATCH 6/6] attr.h: remove duplicate struct definition","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-14T10:39:31Z","receivedAt":"2022-03-14T10:39:43Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"Il giorno lun 14 mar 2022 alle ore 06:40 Junio C Hamano\n ha scritto:\n>\n> Elia Pinto writes:\n>\n> > Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition\n>\n> I do not see other 5 from 1/6 thru 5/6 on the list.\nI'm sorry. It was my mistake in producing the patch. There are no\nother cases like this.\n\nThanks for your patience\n>\n> If this is a leftover bit follow-up to the 5-patch series whose\n> cover letter was <20220313195536.224075-1-gitter.spiros@gmail.com>\n> we often see such a message\n>\n> - with subject numbered as [PATCH 6/5]\n> - as follow-up to the same cover letter.\n>\n> The patch text looks good, and we can see from the output of\n>\n> $ git grep '^struct .*;' \\*.h |\n> sort | uniq -c | sort -n | grep -v '^ *1 '\n>\n> that this is the only duplicated opaque struct declaration in the\n> header files.\n>\n> For now, I'd assume that is the case and queue it on the same topic\n> branch as the other five. Thanks.\n>\n> > struct index_state is declared more than once.\n> >\n> > Signed-off-by: Elia Pinto \n> > ---\n> > attr.h | 1 -\n> > 1 file changed, 1 deletion(-)\n> >\n> > diff --git a/attr.h b/attr.h\n> > index 3732505eda..3fb40cced0 100644\n> > --- a/attr.h\n> > +++ b/attr.h\n> > @@ -121,7 +121,6 @@ struct git_attr;\n> > /* opaque structures used internally for attribute collection */\n> > struct all_attrs_item;\n> > struct attr_stack;\n> > -struct index_state;\n> >\n> > /*\n> > * Given a string, return the gitattribute object that\n"},{"id":"451351","messageId":"xmqqo828nr88.fsf@gitster.g","threadId":"57555","inReplyTo":"CA+EOSBkJtcvKJ1D1hMuWB0EkrGEfP7Dua6gP8MDHehto1r+E3A@mail.gmail.com","subject":"Re: [PATCH 6/6] attr.h: remove duplicate struct definition","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-03-14T21:45:11Z","receivedAt":"2022-03-14T21:45:17Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto writes:\n\n> Il giorno lun 14 mar 2022 alle ore 06:40 Junio C Hamano\n> ha scritto:\n>>\n>> Elia Pinto writes:\n>>\n>> > Subject: Re: [PATCH 6/6] attr.h: remove duplicate struct definition\n>>\n>> I do not see other 5 from 1/6 thru 5/6 on the list.\n> I'm sorry. It was my mistake in producing the patch. There are no\n> other cases like this.\n>\n> Thanks for your patience\n\nNo need to say sorry! I just wanted to make sure I have all pieces\nnecessary.\n\nThanks.\n"}]}