{"thread":{"id":"57553","subject":"[PATCH 0/5] Remove. duplicate include directives","startedAt":"2022-03-13T19:55:47Z","lastAt":"2022-03-13T22:22:25Z","messageCount":7,"participants":["Elia Pinto","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"451261","messageId":"20220313195536.224075-1-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":null,"subject":"[PATCH 0/5] Remove. duplicate include directives","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:31Z","receivedAt":"2022-03-13T19:55:47Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"This series of patches does not solve any particular problems but\nonly eliminates unnecessary duplicate include directives\nfrom git sources\n\nElia Pinto (5):\n attr.c: delete duplicate include\n builtin/gc.c: delete duplicate include\n builtin/sparse-checkout.c: delete duplicate include\n builtin/stash.c: delete duplicate include\n t/helper/test-run-command.c: delete duplicate include\n\n attr.c | 1 -\n builtin/gc.c | 1 -\n builtin/sparse-checkout.c | 1 -\n builtin/stash.c | 1 -\n t/helper/test-run-command.c | 1 -\n 5 files changed, 5 deletions(-)\n\n-- \n2.35.1\n\n"},{"id":"451262","messageId":"20220313195536.224075-2-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"[PATCH 1/5] attr.c: delete duplicate include","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:32Z","receivedAt":"2022-03-13T19:55:49Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"dir.h is included more than once\n\nSigned-off-by: Elia Pinto \n---\n attr.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/attr.c b/attr.c\nindex 79adaa50ea..1626cade8b 100644\n--- a/attr.c\n+++ b/attr.c\n@@ -14,7 +14,6 @@\n #include \"utf8.h\"\n #include \"quote.h\"\n #include \"thread-utils.h\"\n-#include \"dir.h\"\n \n const char git_attr__true[] = \"(builtin)true\";\n const char git_attr__false[] = \"\\0(builtin)false\";\n-- \n2.35.1\n\n"},{"id":"451263","messageId":"20220313195536.224075-3-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"[PATCH 2/5] builtin/gc.c: delete duplicate include","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:33Z","receivedAt":"2022-03-13T19:55:54Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"object-store.h is included more than once.\n\nSigned-off-by: Elia Pinto \n---\n builtin/gc.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/gc.c b/builtin/gc.c\nindex ffaf0daf5d..b335cffa33 100644\n--- a/builtin/gc.c\n+++ b/builtin/gc.c\n@@ -30,7 +30,6 @@\n #include \"promisor-remote.h\"\n #include \"refs.h\"\n #include \"remote.h\"\n-#include \"object-store.h\"\n #include \"exec-cmd.h\"\n #include \"hook.h\"\n \n-- \n2.35.1\n\n"},{"id":"451264","messageId":"20220313195536.224075-4-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"[PATCH 3/5] builtin/sparse-checkout.c: delete duplicate include","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:34Z","receivedAt":"2022-03-13T19:55:55Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"cache.h is included more than once.\n\nSigned-off-by: Elia Pinto \n---\n builtin/sparse-checkout.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/sparse-checkout.c b/builtin/sparse-checkout.c\nindex 5518ed47f6..d88d141076 100644\n--- a/builtin/sparse-checkout.c\n+++ b/builtin/sparse-checkout.c\n@@ -8,7 +8,6 @@\n #include \"run-command.h\"\n #include \"strbuf.h\"\n #include \"string-list.h\"\n-#include \"cache.h\"\n #include \"cache-tree.h\"\n #include \"lockfile.h\"\n #include \"resolve-undo.h\"\n-- \n2.35.1\n\n"},{"id":"451265","messageId":"20220313195536.224075-5-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"[PATCH 4/5] builtin/stash.c: delete duplicate include","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:35Z","receivedAt":"2022-03-13T19:55:57Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":" entry.h is included more than once.\n\nSigned-off-by: Elia Pinto \n---\n builtin/stash.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/builtin/stash.c b/builtin/stash.c\nindex 3e8af210fd..548048f444 100644\n--- a/builtin/stash.c\n+++ b/builtin/stash.c\n@@ -16,7 +16,6 @@\n #include \"log-tree.h\"\n #include \"diffcore.h\"\n #include \"exec-cmd.h\"\n-#include \"entry.h\"\n \n #define INCLUDE_ALL_FILES 2\n \n-- \n2.35.1\n\n"},{"id":"451266","messageId":"20220313195536.224075-6-gitter.spiros@gmail.com","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"[PATCH 5/5] t/helper/test-run-command.c: delete duplicate include","fromName":"Elia Pinto","fromEmail":"gitter.spiros@gmail.com","sentAt":"2022-03-13T19:55:36Z","receivedAt":"2022-03-13T19:55:58Z","isPatch":true,"sender":{"key":"gitter.spiros@gmail.com","avatar":"https://avatars.githubusercontent.com/u/158490?v=4"},"body":"parse-options.h is included more than once.\n\nSigned-off-by: Elia Pinto \n---\n t/helper/test-run-command.c | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/helper/test-run-command.c b/t/helper/test-run-command.c\nindex 8f370cd89f..1b35a143c1 100644\n--- a/t/helper/test-run-command.c\n+++ b/t/helper/test-run-command.c\n@@ -19,7 +19,6 @@\n #include \"thread-utils.h\"\n #include \"wildmatch.h\"\n #include \"gettext.h\"\n-#include \"parse-options.h\"\n \n static int number_callbacks;\n static int parallel_next(struct child_process *cp,\n-- \n2.35.1\n\n"},{"id":"451271","messageId":"xmqqzglttrvr.fsf@gitster.g","threadId":"57553","inReplyTo":"20220313195536.224075-1-gitter.spiros@gmail.com","subject":"Re: [PATCH 0/5] Remove. duplicate include directives","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-03-13T22:22:16Z","receivedAt":"2022-03-13T22:22:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elia Pinto writes:\n\n> This series of patches does not solve any particular problems but\n> only eliminates unnecessary duplicate include directives\n> from git sources\n>\n> Elia Pinto (5):\n> attr.c: delete duplicate include\n> builtin/gc.c: delete duplicate include\n> builtin/sparse-checkout.c: delete duplicate include\n> builtin/stash.c: delete duplicate include\n> t/helper/test-run-command.c: delete duplicate include\n\nThanks.\n\nIt matches the output from the pipeline:\n\n$ git grep '^#include' \\*.c |\n sort | uniq -c | sort -n | sed -e '/^ *1 /d'\n"}]}