{"thread":{"id":"5750","subject":"[PATCH] gitweb: Remove redundant \"commit\" link from shortlog","startedAt":"2006-09-28T23:48:40Z","lastAt":"2006-10-06T18:27:20Z","messageCount":5,"participants":["Luben Tuikov","Petr Baudis","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"27953","messageId":"20060928234840.25950.qmail@web31809.mail.mud.yahoo.com","threadId":"5750","inReplyTo":null,"subject":"[PATCH] gitweb: Remove redundant \"commit\" link from shortlog","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-09-28T23:48:40Z","receivedAt":"2006-09-28T23:48:40Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"Remove the redundant \"commit\" link from shortlog.\nIt can be had by simply clicking on the entry title\nof the row.\n\nSigned-off-by: Luben Tuikov \n---\n gitweb/gitweb.perl | 1 -\n 1 files changed, 0 insertions(+), 1 deletions(-)\n\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 79c8052..f3f22c2 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2013,7 +2013,6 @@ sub git_shortlog_body {\n \t\t href(action=>\"commit\", hash=>$commit), $ref);\n \t\tprint \"\\n\" .\n \t\t \"\" .\n-\t\t $cgi->a({-href => href(action=>\"commit\", hash=>$commit)}, \"commit\") . \" | \" .\n \t\t $cgi->a({-href => href(action=>\"commitdiff\", hash=>$commit)}, \"commitdiff\") . \" | \" .\n \t\t $cgi->a({-href => href(action=>\"tree\", hash=>$commit, hash_base=>$commit)}, \"tree\");\n \t\tprint \"\\n\" .\n-- \n1.4.2.1.g05f0f\n\n"},{"id":"28287","messageId":"20061006135508.GO20017@pasky.or.cz","threadId":"5750","inReplyTo":"20060928234840.25950.qmail@web31809.mail.mud.yahoo.com","subject":"Re: [PATCH] gitweb: Remove redundant \"commit\" link from shortlog","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-06T13:55:08Z","receivedAt":"2006-10-06T13:55:08Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter\nwhere Luben Tuikov said that...\n> Remove the redundant \"commit\" link from shortlog.\n> It can be had by simply clicking on the entry title\n> of the row.\n> \n> Signed-off-by: Luben Tuikov \n\nAnd what if the commit message is empty?\n\nWitness at http://repo.or.cz/?p=test;a=summary\n\n-- \n\t\t\t\tPetr \"Pasky\" Baudis\nStuff: http://pasky.or.cz/\n#!/bin/perl -sp0777i Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter\n> where Luben Tuikov said that...\n>> Remove the redundant \"commit\" link from shortlog.\n>> It can be had by simply clicking on the entry title\n>> of the row.\n>> \n>> Signed-off-by: Luben Tuikov \n> \n> And what if the commit message is empty?\n> \n> Witness at http://repo.or.cz/?p=test;a=summary\n\nBy the way, commitdiff view in this case also looks strange.\nI think that simplyfying the git_difftree_body went too far,\nLuben.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"28304","messageId":"20061006165504.3934.97392.stgit@rover","threadId":"5750","inReplyTo":"20061006135508.GO20017@pasky.or.cz","subject":"[PATCH] gitweb: Handle commits with empty commit messages more reasonably","fromName":"Petr Baudis","fromEmail":"pasky@suse.cz","sentAt":"2006-10-06T16:55:04Z","receivedAt":"2006-10-06T16:55:04Z","isPatch":true,"sender":{"key":"pasky@ucw.cz","avatar":"https://avatars.githubusercontent.com/u/18439?v=4"},"body":"Currently those look very weird, you can't get easily at the commit view\netc. This patch makes their title '(no commit message)'.\n\nSigned-off-by: Petr Baudis \n---\n\n gitweb/gitweb.perl | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex ea159e9..56e5231 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -1115,6 +1115,9 @@ sub parse_commit {\n \t\t\tlast;\n \t\t}\n \t}\n+\tif ($co{'title'} eq \"\") {\n+\t\t$co{'title'} = $co{'title_short'} = '(no commit message)';\n+\t}\n \t# remove added spaces\n \tforeach my $line (@commit_lines) {\n \t\t$line =~ s/^ //;\n"},{"id":"28311","messageId":"20061006182720.88733.qmail@web31812.mail.mud.yahoo.com","threadId":"5750","inReplyTo":"20061006135508.GO20017@pasky.or.cz","subject":"Re: [PATCH] gitweb: Remove redundant \"commit\" link from shortlog","fromName":"Luben Tuikov","fromEmail":"ltuikov@yahoo.com","sentAt":"2006-10-06T18:27:20Z","receivedAt":"2006-10-06T18:27:20Z","isPatch":true,"sender":{"key":"ltuikov@yahoo.com","avatar":null},"body":"--- Petr Baudis wrote:\n> Dear diary, on Fri, Sep 29, 2006 at 01:48:40AM CEST, I got a letter\n> where Luben Tuikov said that...\n> > Remove the redundant \"commit\" link from shortlog.\n> > It can be had by simply clicking on the entry title\n> > of the row.\n> > \n> > Signed-off-by: Luben Tuikov \n> \n> And what if the commit message is empty?\n> \n> Witness at http://repo.or.cz/?p=test;a=summary\n\nClearly a pathological case. Who or why would anyone do this?\nI don't think we should worry about such pathological cases.\n\nCommits without commit messages do not question GIT. They\nquestion the committer... (that's the morning chuckle)\n\n Luben\n\n\n> \n> -- \n> \t\t\t\tPetr \"Pasky\" Baudis\n> Stuff: http://pasky.or.cz/\n> #!/bin/perl -sp0777i $/=unpack('H*',$_);$_=`echo 16dio\\U$k\"SK$/SM$n\\EsN0p[lN*1\n> lK[d2%Sa2/d0$^Ixp\"|dc`;s/\\W//g;$_=pack('H*',/((..)*)$/)\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n"}]}