{"thread":{"id":"57417","subject":"[PATCH] name-rev: replace --stdin with --annotate-stdin in synopsis","startedAt":"2022-02-15T20:52:15Z","lastAt":"2022-02-16T01:40:12Z","messageCount":2,"participants":["John Cai via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"448475","messageId":"pull.1216.git.git.1644958327302.gitgitgadget@gmail.com","threadId":"57417","inReplyTo":null,"subject":"[PATCH] name-rev: replace --stdin with --annotate-stdin in synopsis","fromName":"John Cai via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-02-15T20:52:07Z","receivedAt":"2022-02-15T20:52:15Z","isPatch":true,"sender":{"key":"johncai86@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2354211?v=4"},"body":"From: John Cai <johncai86@gmail.com>\n\nd9976b184596 added --annotate-stdin to replace --stdin as a clearer flag\nname. Since --stdin is to be deprecated, we should replace --stdin in\nthe synopsis.\n\nSigned-off-by: John Cai <johncai86@gmail.com>\n---\n    name-rev: replace --stdin with --annotate-stdin in synopsis\n    \n    There was an oversight when we added --annotate-stdin to\n    git-name-rev(1). This patch corrects it by making the appropriate change\n    in the synopsis of git-name-rev(1)\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1216%2Fjohn-cai%2Fjc-update-name-rev-synopsis-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1216/john-cai/jc-update-name-rev-synopsis-v1\nPull-Request: https://github.com/git/git/pull/1216\n\n builtin/name-rev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/name-rev.c b/builtin/name-rev.c\nindex 138e3c30a2b..929591269dd 100644\n--- a/builtin/name-rev.c\n+++ b/builtin/name-rev.c\n@@ -473,7 +473,7 @@ static void show_name(const struct object *obj,\n static char const * const name_rev_usage[] = {\n \tN_(\"git name-rev [<options>] <commit>...\"),\n \tN_(\"git name-rev [<options>] --all\"),\n-\tN_(\"git name-rev [<options>] --stdin\"),\n+\tN_(\"git name-rev [<options>] --annotate-stdin\"),\n \tNULL\n };\n \n\nbase-commit: b80121027d1247a0754b3cc46897fee75c050b44\n-- \ngitgitgadget\n"},{"id":"448524","messageId":"xmqqbkz7y4ga.fsf@gitster.g","threadId":"57417","inReplyTo":"pull.1216.git.git.1644958327302.gitgitgadget@gmail.com","subject":"Re: [PATCH] name-rev: replace --stdin with --annotate-stdin in synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-02-16T01:40:05Z","receivedAt":"2022-02-16T01:40:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"John Cai via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: John Cai <johncai86@gmail.com>\n>\n> d9976b184596 added --annotate-stdin to replace --stdin as a clearer flag\n> name. Since --stdin is to be deprecated, we should replace --stdin in\n> the synopsis.\n\nThanks for a careful reading.  d9976b184596 was what merged the\nwhole series; let's blame the particular step instead.\n\nHere is what I'll queue.\n\n----- >8 --------- >8 --------- >8 --------- >8 --------- >8 -----\nFrom: John Cai <johncai86@gmail.com>\nDate: Tue, 15 Feb 2022 20:52:07 +0000\nSubject: [PATCH] name-rev: replace --stdin with --annotate-stdin in synopsis\n\n34ae3b70 (name-rev: deprecate --stdin in favor of --annotate-stdin,\n2022-01-05) added --annotate-stdin to replace --stdin as a clearer\nflag name. Since --stdin is to be deprecated, we should replace\n--stdin in the output from \"git name-rev -h\".\n\nSigned-off-by: John Cai <johncai86@gmail.com>\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n builtin/name-rev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/name-rev.c b/builtin/name-rev.c\nindex 138e3c30a2..929591269d 100644\n--- a/builtin/name-rev.c\n+++ b/builtin/name-rev.c\n@@ -473,7 +473,7 @@ static void show_name(const struct object *obj,\n static char const * const name_rev_usage[] = {\n \tN_(\"git name-rev [<options>] <commit>...\"),\n \tN_(\"git name-rev [<options>] --all\"),\n-\tN_(\"git name-rev [<options>] --stdin\"),\n+\tN_(\"git name-rev [<options>] --annotate-stdin\"),\n \tNULL\n };\n \n-- \n2.35.1-129-gb80121027d\n\n"}]}