{"thread":{"id":"57398","subject":"[PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd","startedAt":"2022-02-10T02:42:06Z","lastAt":"2022-02-14T17:23:57Z","messageCount":4,"participants":["Bagas Sanjaya","Patrick Marlier","Elijah Newren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"448084","messageId":"20220210024138.157327-1-bagasdotme@gmail.com","threadId":"57398","inReplyTo":null,"subject":"[PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2022-02-10T02:41:38Z","receivedAt":"2022-02-10T02:42:06Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"Use past tense form of \"to remove\" and \"to skip\". This is especially\ntrue when we had already removed an entry.\n\nLink:\nhttps://lore.kernel.org/git/CAKQMxzSQRL-Q5daxETF+gYhVScmq_n=r2LJAeEuxpM7=jPajZQ@mail.gmail.com/T/#u\nReported-by: Patrick Marlier \nSigned-off-by: Bagas Sanjaya \n---\n builtin/clean.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/builtin/clean.c b/builtin/clean.c\nindex 3ff02bbbff..f1cd114ee2 100644\n--- a/builtin/clean.c\n+++ b/builtin/clean.c\n@@ -30,13 +30,13 @@ static const char *const builtin_clean_usage[] = {\n \tNULL\n };\n \n-static const char *msg_remove = N_(\"Removing %s\\n\");\n+static const char *msg_remove = N_(\"Removed %s\\n\");\n static const char *msg_would_remove = N_(\"Would remove %s\\n\");\n-static const char *msg_skip_git_dir = N_(\"Skipping repository %s\\n\");\n+static const char *msg_skip_git_dir = N_(\"Skipped repository %s\\n\");\n static const char *msg_would_skip_git_dir = N_(\"Would skip repository %s\\n\");\n static const char *msg_warn_remove_failed = N_(\"failed to remove %s\");\n static const char *msg_warn_lstat_failed = N_(\"could not lstat %s\\n\");\n-static const char *msg_skip_cwd = N_(\"Refusing to remove current working directory\\n\");\n+static const char *msg_skip_cwd = N_(\"Refused to remove current working directory\\n\");\n static const char *msg_would_skip_cwd = N_(\"Would refuse to remove current working directory\\n\");\n \n enum color_clean {\n\nbase-commit: 2b9c1209706bc2ef0ab09fb0bdc7d405e225ce8b\n-- \nAn old man doll... just what I always wanted! - Clara\n\n"},{"id":"448295","messageId":"CAKQMxzRE515dAu5a=g6pLMEf3EWu7XUX41XkyAca+1ewCzXNGw@mail.gmail.com","threadId":"57398","inReplyTo":"20220210024138.157327-1-bagasdotme@gmail.com","subject":"Re: [PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd","fromName":"Patrick Marlier","fromEmail":"patrick.marlier@gmail.com","sentAt":"2022-02-12T09:14:00Z","receivedAt":"2022-02-12T09:14:14Z","isPatch":true,"sender":{"key":"patrick.marlier@gmail.com","avatar":null},"body":"On Thu, Feb 10, 2022 at 3:42 AM Bagas Sanjaya wrote:\n> Use past tense form of \"to remove\" and \"to skip\". This is especially\n> true when we had already removed an entry.\n\nLooks good to me.\nThanks Bagas!\n--\nPatrick Marlier\n"},{"id":"448323","messageId":"CABPp-BEguZQMTjDxEpMqKwKpDdPj9yWbL5T_wRJhD3KDJK5=UQ@mail.gmail.com","threadId":"57398","inReplyTo":"20220210024138.157327-1-bagasdotme@gmail.com","subject":"Re: [PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-02-12T22:29:35Z","receivedAt":"2022-02-12T22:29:50Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Wed, Feb 9, 2022 at 6:42 PM Bagas Sanjaya wrote:\n>\n> Use past tense form of \"to remove\" and \"to skip\". This is especially\n> true when we had already removed an entry.\n\nThis strikes me as an unnecessary or at least insufficiently motivated\npatch. The difference between \"Removing \" and \"Removed \"\nis lost in the noise when there is no user-input or other behavior\nslowing these down, and they are removed at the speed the machine can\nremove. The only time the user will be able to tell the difference is\nif they are using strace or a debugger, and I really don't like the\nidea of changing the UI and making translators do more work just for\nthose users. Besides, we could just print the messages earlier.\n\nA bigger question to me, is what tense do other commands in git use?\nIf one command prints:\n\n Removed \n\nbut another prints\n\n Patching \n\nthen that's a minor inconsistency that users may actually notice. I\nhave no idea what tense git tends to use for all its different\ncommands, but before changing some strings and incurring more work for\ntranslators, I'd think we'd want to make sure we are at least\nincreasing consistency in this area rather than decreasing it.\n\nAnyway, it may not be a big deal, but that's just my random thoughts\non the patch.\n"},{"id":"448370","messageId":"xmqq8rud4b17.fsf@gitster.g","threadId":"57398","inReplyTo":"CABPp-BEguZQMTjDxEpMqKwKpDdPj9yWbL5T_wRJhD3KDJK5=UQ@mail.gmail.com","subject":"Re: [PATCH] clean: Use past tense for msg_remove, msg_skip_git_dir, and msg_skip_cwd","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-02-14T17:23:48Z","receivedAt":"2022-02-14T17:23:57Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Elijah Newren writes:\n\n> This strikes me as an unnecessary or at least insufficiently motivated\n> patch. The difference between \"Removing \" and \"Removed \"\n> is lost in the noise when there is no user-input or other behavior\n> slowing these down, and they are removed at the speed the machine can\n> remove.\n\nTrue.\n"}]}