{"thread":{"id":"57378","subject":"[bug] forcing build settings on rhel7 without specific checks is not appropriate","startedAt":"2022-02-07T12:04:58Z","lastAt":"2022-02-07T12:04:58Z","messageCount":1,"participants":["Alexander Kanavin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"447879","messageId":"CANNYZj8L_-hhKGNvNfiSU4T2W0g8ZRJ-gJJ30PgRo=ycCGSObQ@mail.gmail.com","threadId":"57378","inReplyTo":null,"subject":"[bug] forcing build settings on rhel7 without specific checks is not appropriate","fromName":"Alexander Kanavin","fromEmail":"alex.kanavin@gmail.com","sentAt":"2022-02-07T11:13:59Z","receivedAt":"2022-02-07T12:04:58Z","isPatch":false,"sender":{"key":"alex.kanavin@gmail.com","avatar":null},"body":"Hello,\n\nthere was a recent change where a couple of compiler settings are\nforced on rhel7:\n\n# centos7/rhel7 provides gcc 4.8.5 and zlib 1.2.7.\nifneq ($(findstring .el7.,$(uname_R)),)\n    BASIC_CFLAGS += -std=c99\n    NO_UNCOMPRESS2 = YesPlease\nendif\n\nI believe this is not the right way to do it: the makefile should\ncheck for the actual compiler and zstd versions and make the decision\nbased on that. Yocto project uses a much newer (cross)compiler and\nzlib for cross-builds, and those settings are not only unnecessary,\nbut actively harm reproducibility, as cross-binaries built on\nrhel7/centos7 are then not the same as binaries built on other\ndistributions. So we ended up reverting the change:\nhttps://lists.openembedded.org/g/openembedded-core/message/161456\n\nThanks,\nAlex\n"}]}