{"thread":{"id":"57362","subject":"[PATCH v2] doc: check-ignore: code-quote an exclamation mark","startedAt":"2022-02-03T10:16:54Z","lastAt":"2022-02-03T22:37:58Z","messageCount":3,"participants":["Philip Oakley","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"447600","messageId":"20220203101643.1987-1-philipoakley@iee.email","threadId":"57362","inReplyTo":null,"subject":"[PATCH v2] doc: check-ignore: code-quote an exclamation mark","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-02-03T10:16:43Z","receivedAt":"2022-02-03T10:16:54Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"The plain quoted exclamation mark renders as italics in the\nWindows pdf help manual.\n\nFix this with back-tick quoting and surrounding double quotes\nas exemplified by the gitignore.txt guide.\n\nWhile at it, fix the surrounding double quotes for the other\nspecial characters usages.\n\nSigned-off-by: Philip Oakley \n---\n\nSince V1:\nCorrected finger trouble with special character when copy-pasting.\n\n Documentation/git-check-ignore.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-check-ignore.txt b/Documentation/git-check-ignore.txt\nindex 0c3924a63d..2892799e32 100644\n--- a/Documentation/git-check-ignore.txt\n+++ b/Documentation/git-check-ignore.txt\n@@ -33,7 +33,7 @@ OPTIONS\n \tInstead of printing the paths that are excluded, for each path\n \tthat matches an exclude pattern, print the exclude pattern\n \ttogether with the path. (Matching an exclude pattern usually\n-\tmeans the path is excluded, but if the pattern begins with '!'\n+\tmeans the path is excluded, but if the pattern begins with \"`!`\"\n \tthen it is a negated pattern and matching it means the path is\n \tNOT excluded.)\n +\n@@ -77,7 +77,7 @@ If `--verbose` is specified, the output is a series of lines of the form:\n is the path of a file being queried, is the\n matching pattern, is the pattern's source file, and \n is the line number of the pattern within that source. If the pattern\n-contained a `!` prefix or `/` suffix, it will be preserved in the\n+contained a \"`!`\" prefix or \"`/`\" suffix, it will be preserved in the\n output. will be an absolute path when referring to the file\n configured by `core.excludesFile`, or relative to the repository root\n when referring to `.git/info/exclude` or a per-directory exclude file.\n-- \n2.35.1.windows.2\n\n"},{"id":"447643","messageId":"xmqqy22ru5k8.fsf@gitster.g","threadId":"57362","inReplyTo":"20220203101643.1987-1-philipoakley@iee.email","subject":"Re: [PATCH v2] doc: check-ignore: code-quote an exclamation mark","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-02-03T19:13:27Z","receivedAt":"2022-02-03T19:13:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Philip Oakley writes:\n\n> The plain quoted exclamation mark renders as italics in the\n> Windows pdf help manual.\n\nHTML rendered version shows ! and depending on the\nstylesheet it would become italic, too. It can be seen in the\npre-rendered versions I ship at [1].\n\n> Fix this with back-tick quoting and surrounding double quotes\n> as exemplified by the gitignore.txt guide.\n\nThis becomes \"!\" (with surrounding double-quotes) [2],\nand making these two pages consistent makes sense.\n\n> While at it, fix the surrounding double quotes for the other\n> special characters usages.\n\nThis changes also sounds good, too.\n\nWill apply. Thanks.\n\n\n[References]\n\n*1* https://github.com/gitster/git-htmldocs/blob/master/git-check-ignore.html\n*2* https://github.com/gitster/git-htmldocs/blob/master/gitignore.html\n\n\n>\n> Signed-off-by: Philip Oakley \n> ---\n>\n> Since V1:\n> Corrected finger trouble with special character when copy-pasting.\n>\n> Documentation/git-check-ignore.txt | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-check-ignore.txt b/Documentation/git-check-ignore.txt\n> index 0c3924a63d..2892799e32 100644\n> --- a/Documentation/git-check-ignore.txt\n> +++ b/Documentation/git-check-ignore.txt\n> @@ -33,7 +33,7 @@ OPTIONS\n> \tInstead of printing the paths that are excluded, for each path\n> \tthat matches an exclude pattern, print the exclude pattern\n> \ttogether with the path. (Matching an exclude pattern usually\n> -\tmeans the path is excluded, but if the pattern begins with '!'\n> +\tmeans the path is excluded, but if the pattern begins with \"`!`\"\n> \tthen it is a negated pattern and matching it means the path is\n> \tNOT excluded.)\n> +\n> @@ -77,7 +77,7 @@ If `--verbose` is specified, the output is a series of lines of the form:\n> is the path of a file being queried, is the\n> matching pattern, is the pattern's source file, and \n> is the line number of the pattern within that source. If the pattern\n> -contained a `!` prefix or `/` suffix, it will be preserved in the\n> +contained a \"`!`\" prefix or \"`/`\" suffix, it will be preserved in the\n> output. will be an absolute path when referring to the file\n> configured by `core.excludesFile`, or relative to the repository root\n> when referring to `.git/info/exclude` or a per-directory exclude file.\n"},{"id":"447678","messageId":"eead790e-7bc7-17a8-68ad-3abc1607447f@iee.email","threadId":"57362","inReplyTo":"xmqqy22ru5k8.fsf@gitster.g","subject":"Re: [PATCH v2] doc: check-ignore: code-quote an exclamation mark","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-02-03T22:37:53Z","receivedAt":"2022-02-03T22:37:58Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 03/02/2022 19:13, Junio C Hamano wrote:\n> Will apply. Thanks.\nThank you.\nPhilip\n"}]}