{"thread":{"id":"57246","subject":"[PATCH] README.md: add CodingGuidelines and a link for Translators","startedAt":"2022-01-14T17:50:19Z","lastAt":"2022-01-17T18:49:40Z","messageCount":11,"participants":["Philip Oakley via GitGitGadget","Junio C Hamano","Philip Oakley","Bagas Sanjaya"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"446230","messageId":"pull.1115.git.1642182615339.gitgitgadget@gmail.com","threadId":"57246","inReplyTo":null,"subject":"[PATCH] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-01-14T17:50:15Z","receivedAt":"2022-01-14T17:50:19Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: Philip Oakley \n\nAlso space out the list joining instructions and clarify the subscription\nvia the majordomo address.\n\nSigned-off-by: Philip Oakley \n---\n README.md: add CodingGuidelines and a link for Translators\n \n Also space out the list joining instructions and clarify the\n subscription via the majordomo address.\n \n Signed-off-by: Philip Oakley philipoakley@iee.email\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1115%2FPhilipOakley%2FReadme-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1115/PhilipOakley/Readme-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1115\n\n README.md | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)\n\ndiff --git a/README.md b/README.md\nindex f6f43e78deb..5c956dea6e0 100644\n--- a/README.md\n+++ b/README.md\n@@ -32,10 +32,16 @@ installed).\n The user discussion and development of Git take place on the Git\n mailing list -- everyone is welcome to post bug reports, feature\n requests, comments and patches to git@vger.kernel.org (read\n-[Documentation/SubmittingPatches][] for instructions on patch submission).\n+[Documentation/SubmittingPatches][] for instructions on patch submission\n+and [Documentation/CodingGuidelines]() ).\n+\n+Those wishing to help with error message translation (localization L10)\n+should see [po/README.md]()\n+(a `po` file is a portable object file for the translations).\n+\n To subscribe to the list, send an email with just \"subscribe git\" in\n-the body to majordomo@vger.kernel.org. The mailing list archives are\n-available at ,\n+the body to majordomo@vger.kernel.org (not the list). The mailing list\n+archives are available at ,\n and other archival sites.\n \n Issues which are security relevant should be disclosed privately to\n\nbase-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n-- \ngitgitgadget\n"},{"id":"446250","messageId":"xmqq7db2avij.fsf@gitster.g","threadId":"57246","inReplyTo":"pull.1115.git.1642182615339.gitgitgadget@gmail.com","subject":"Re: [PATCH] README.md: add CodingGuidelines and a link for Translators","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-14T20:54:12Z","receivedAt":"2022-01-14T20:54:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Philip Oakley via GitGitGadget\" writes:\n\n> From: Philip Oakley \n>\n> Also space out the list joining instructions and clarify the subscription\n\nthe instructions to join the list?\n\n> requests, comments and patches to git@vger.kernel.org (read\n> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n> +[Documentation/SubmittingPatches][] for instructions on patch submission\n> +and [Documentation/CodingGuidelines]() ).\n\nRemind me the significance of using [] and () after [File Reference]?\n\n> +Those wishing to help with error message translation (localization L10)\n> +should see [po/README.md]()\n\nSame here.\n\nhttps://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n\nseems to indicate () is to enclose URL the text goes to, and if\nthere is no URL to go to, perhaps it does the right thing, but the\ncurrent page (which has \"[Documentation/SubmittingPatches][]\" and\nall other reference into in-tree files with that format) seems to\nrender correctly with links that work, so...\n\n> +(a `po` file is a portable object file for the translations).\n> +\n> To subscribe to the list, send an email with just \"subscribe git\" in\n> -the body to majordomo@vger.kernel.org. The mailing list archives are\n> -available at ,\n> +the body to majordomo@vger.kernel.org (not the list). The mailing list\n> +archives are available at ,\n> and other archival sites.\n> \n> Issues which are security relevant should be disclosed privately to\n>\n> base-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n"},{"id":"446269","messageId":"6b626f9d-05d6-1903-0b38-e3566e357472@iee.email","threadId":"57246","inReplyTo":"xmqq7db2avij.fsf@gitster.g","subject":"Re: [PATCH] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-01-15T00:08:05Z","receivedAt":"2022-01-15T00:08:10Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 14/01/2022 20:54, Junio C Hamano wrote:\n> \"Philip Oakley via GitGitGadget\" writes:\n>\n>> From: Philip Oakley \n>>\n>> Also space out the list joining instructions and clarify the subscription\n> the instructions to join the list?\nCorrect.\n>\n>> requests, comments and patches to git@vger.kernel.org (read\n>> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n>> +[Documentation/SubmittingPatches][] for instructions on patch submission\n>> +and [Documentation/CodingGuidelines]() ).\n> Remind me the significance of using [] and () after [File Reference]?\nThe [] is the original method used by the unchanged text, while the ()\nappears to be the method required now.\n \n>\n>> +Those wishing to help with error message translation (localization L10)\n>> +should see [po/README.md]()\n> Same here.\n>\n> https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n>\n> seems to indicate () is to enclose URL the text goes to, and if\n> there is no URL to go to, perhaps it does the right thing, but the\n> current page (which has \"[Documentation/SubmittingPatches][]\" and\n> all other reference into in-tree files with that format) seems to\n> render correctly with links that work, so...\n\nUnfortunately it `[]` is not working for me for the new additions.\nGitHub magic?\n>\n>> +(a `po` file is a portable object file for the translations).\n>> +\n>> To subscribe to the list, send an email with just \"subscribe git\" in\n>> -the body to majordomo@vger.kernel.org. The mailing list archives are\n>> -available at ,\n>> +the body to majordomo@vger.kernel.org (not the list). The mailing list\n>> +archives are available at ,\n>> and other archival sites.\n>> \n>> Issues which are security relevant should be disclosed privately to\n>>\n>> base-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n\n"},{"id":"446274","messageId":"xmqqv8yl6d0f.fsf@gitster.g","threadId":"57246","inReplyTo":"6b626f9d-05d6-1903-0b38-e3566e357472@iee.email","subject":"Re: [PATCH] README.md: add CodingGuidelines and a link for Translators","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-15T00:47:28Z","receivedAt":"2022-01-15T00:47:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Philip Oakley writes:\n\n> Unfortunately it `[]` is not working for me for the new additions.\n> GitHub magic?\n\nLet's step back a bit.\n\nIs there somebody reading README.md as a more generic MarkDown? I\ndo not think our build procedure creates any rendered document from\nit.\n\nMy recollection was that we moved from README.txt to README.md for\nthe sole purpose of showing it https://github.com/git/git/ as more\nthan just a plain text, so it is a hard requirement that GitHub\nflavored MarkDown renderer is happy with whatever we write in the\nfile.\n\nIf GitHub flavored MarkDown only supports [] and breaks with (),\nthen there is no need for further discussion. We must stick to []\nthat has been working for us in the file.\n\nOn the other hand, if both () and [] work well at GitHub, I am OK to\nreplace [] to (), so that it shows well at GitHub and also it can be\nused with other MarkDown renderers.\n\nI prefer, from the organizational point of view, to see two patches,\nin this order, if we were to go that way.\n\n [PATCH 1/2] README: link to more contributor documents\n\nwhich uses [] (not ()). After this, README.md uses only [],\nincluding the two links you add in this step. And then\n\n [PATCH 2/2] README: use \"()\", not \"[]\", to please more MarkDown processors\n\nwhich replaces all uses of [] with ().\n\nThat would allow us to queue both, try them out, and we can back out\n[2/2] if GitHub's renderer does not like the result.\n\n"},{"id":"446327","messageId":"pull.1115.v2.git.1642349490723.gitgitgadget@gmail.com","threadId":"57246","inReplyTo":"pull.1115.git.1642182615339.gitgitgadget@gmail.com","subject":"[PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-01-16T16:11:30Z","receivedAt":"2022-01-16T16:11:36Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: Philip Oakley \n\nThe README.md does not use the GitHub Markdown URL links [1] of\n[txt](url), rather the reference method [2] of trailing empty square\nbrackets. The references themselves are listed at the foot of the\ndocument. Those footers are not shown by GitHub/GitLab rendering.\n\nAlso space out the list joining instructions and clarify that\nsubscription is via the majordomo address.\n\n[1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n[2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n\nSigned-off-by: Philip Oakley \n---\n README.md: add CodingGuidelines and a link for Translators\n \n Also space out the list joining instructions and clarify the\n subscription via the majordomo address.\n \n \n Signed-off-by: Philip Oakley philipoakley@iee.email\n ===================================================\n \n cc: Philip Oakley philipoakley@iee.email cc: Junio C Hamano\n gitster@pobox.com cc: Jiang Xin worldhello.net@gmail.com\n \n changes since v1:\n \n * Used reference style links, rather than lnk [url] style.\n \n * added Jianf as L10 coordinator.\n \n * note: Patch is a response to a user question on the \"Git for Human\n Beings\" git-users list\n https://groups.google.com/d/msgid/git-users/aa68b9c8-4cf4-4193-8af3-79d7e3feafbbn%40googlegroups.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1115%2FPhilipOakley%2FReadme-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1115/PhilipOakley/Readme-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/1115\n\nRange-diff vs v1:\n\n 1: ac6d0abbdde ! 1: 48cc30b7cc8 README.md: add CodingGuidelines and a link for Translators\n @@ Metadata\n ## Commit message ##\n README.md: add CodingGuidelines and a link for Translators\n \n - Also space out the list joining instructions and clarify the subscription\n - via the majordomo address.\n + The README.md does not use the GitHub Markdown URL links [1] of\n + [txt](url), rather the reference method [2] of trailing empty square\n + brackets. The references themselves are listed at the foot of the\n + document. Those footers are not shown by GitHub/GitLab rendering.\n +\n + Also space out the list joining instructions and clarify that\n + subscription is via the majordomo address.\n +\n + [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n + [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n \n Signed-off-by: Philip Oakley \n \n @@ README.md: installed).\n requests, comments and patches to git@vger.kernel.org (read\n -[Documentation/SubmittingPatches][] for instructions on patch submission).\n +[Documentation/SubmittingPatches][] for instructions on patch submission\n -+and [Documentation/CodingGuidelines]() ).\n ++and [Documentation/CodingGuidelines][]).\n +\n +Those wishing to help with error message translation (localization L10)\n -+should see [po/README.md]()\n -+(a `po` file is a portable object file for the translations).\n ++should see [po/README.md][] (a `po` file is a Portable Object file that\n ++holds the translations).\n +\n To subscribe to the list, send an email with just \"subscribe git\" in\n -the body to majordomo@vger.kernel.org. The mailing list archives are\n -available at ,\n -+the body to majordomo@vger.kernel.org (not the list). The mailing list\n -+archives are available at ,\n ++the body to majordomo@vger.kernel.org (not the Git list). The mailing\n ++list archives are available at ,\n and other archival sites.\n \n Issues which are security relevant should be disclosed privately to\n +@@ README.md: and the name as (depending on your mood):\n + [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n + [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n + [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n ++[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n ++[po/README.md]: po/README.md\n + \\ No newline at end of file\n\n\n README.md | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)\n\ndiff --git a/README.md b/README.md\nindex f6f43e78deb..d2b061e3998 100644\n--- a/README.md\n+++ b/README.md\n@@ -32,10 +32,16 @@ installed).\n The user discussion and development of Git take place on the Git\n mailing list -- everyone is welcome to post bug reports, feature\n requests, comments and patches to git@vger.kernel.org (read\n-[Documentation/SubmittingPatches][] for instructions on patch submission).\n+[Documentation/SubmittingPatches][] for instructions on patch submission\n+and [Documentation/CodingGuidelines][]).\n+\n+Those wishing to help with error message translation (localization L10)\n+should see [po/README.md][] (a `po` file is a Portable Object file that\n+holds the translations).\n+\n To subscribe to the list, send an email with just \"subscribe git\" in\n-the body to majordomo@vger.kernel.org. The mailing list archives are\n-available at ,\n+the body to majordomo@vger.kernel.org (not the Git list). The mailing\n+list archives are available at ,\n and other archival sites.\n \n Issues which are security relevant should be disclosed privately to\n@@ -64,3 +70,5 @@ and the name as (depending on your mood):\n [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n+[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n+[po/README.md]: po/README.md\n\\ No newline at end of file\n\nbase-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n-- \ngitgitgadget\n"},{"id":"446331","messageId":"xmqq5yqjz4a6.fsf@gitster.g","threadId":"57246","inReplyTo":"pull.1115.v2.git.1642349490723.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-16T22:47:45Z","receivedAt":"2022-01-16T22:47:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Philip Oakley via GitGitGadget\" writes:\n\n> From: Philip Oakley \n>\n> The README.md does not use the GitHub Markdown URL links [1] of\n> [txt](url), rather the reference method [2] of trailing empty square\n> brackets. The references themselves are listed at the foot of the\n> document. Those footers are not shown by GitHub/GitLab rendering.\n\nThanks for tracking down the differences.\n\nThe above only describes what we could do (i.e. use links instead of\nreference), and how the current document is rendered (i.e. footers\nare not shown). No changes come from the above description.\n\n> Also space out the list joining instructions and clarify that\n> subscription is via the majordomo address.\n\nSo, seeing \"Also\" immediately after a paragraph that explains the\nstatus quo confused me a lot.\n\n\"Spell out the instructions to join the list, and clarify that the\nsubscription is via the majordomo address\" is indeed a part of what\nthis patch does. Perhaps we need a separate paragraph _before_ this\n\"Also\".\n\nSo taking all together\n\n Before being told how to submit patches, new contributors need\n to be told how to code for, or how to contribute translation to,\n the project. Add references to the CodingGuidelines and the\n README document on localization.\n\n Also, spell out the instructions to join the list and ...\n \n We use GitHub Markdown reference [2] with trailing empty square\n brackets, to match existing text in the file. On GitHub/GitLab\n pages, these references are not shown on the page, but it is OK\n because they are empty. We could switch to using [text](url)\n form [1] if we wanted to, but that is not done as part of this\n patch.\n\nwould be the presentation order that I would expect to be the most\nreadable. I moved the discussion between URL link and reference, as\nit is merely a hint for future and not the core thing that needs to\nbe explained to understand the changes in this commit.\n\nThanks.\n\n\n> [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n> [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n>\n> Signed-off-by: Philip Oakley \n> ---\n> README.md: add CodingGuidelines and a link for Translators\n> \n> Also space out the list joining instructions and clarify the\n> subscription via the majordomo address.\n> \n> \n> Signed-off-by: Philip Oakley philipoakley@iee.email\n> ===================================================\n> \n> cc: Philip Oakley philipoakley@iee.email cc: Junio C Hamano\n> gitster@pobox.com cc: Jiang Xin worldhello.net@gmail.com\n> \n> changes since v1:\n> \n> * Used reference style links, rather than lnk [url] style.\n> \n> * added Jianf as L10 coordinator.\n> \n> * note: Patch is a response to a user question on the \"Git for Human\n> Beings\" git-users list\n> https://groups.google.com/d/msgid/git-users/aa68b9c8-4cf4-4193-8af3-79d7e3feafbbn%40googlegroups.com\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1115%2FPhilipOakley%2FReadme-v2\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1115/PhilipOakley/Readme-v2\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1115\n>\n> Range-diff vs v1:\n>\n> 1: ac6d0abbdde ! 1: 48cc30b7cc8 README.md: add CodingGuidelines and a link for Translators\n> @@ Metadata\n> ## Commit message ##\n> README.md: add CodingGuidelines and a link for Translators\n> \n> - Also space out the list joining instructions and clarify the subscription\n> - via the majordomo address.\n> + The README.md does not use the GitHub Markdown URL links [1] of\n> + [txt](url), rather the reference method [2] of trailing empty square\n> + brackets. The references themselves are listed at the foot of the\n> + document. Those footers are not shown by GitHub/GitLab rendering.\n> +\n> + Also space out the list joining instructions and clarify that\n> + subscription is via the majordomo address.\n> +\n> + [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n> + [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n> \n> Signed-off-by: Philip Oakley \n> \n> @@ README.md: installed).\n> requests, comments and patches to git@vger.kernel.org (read\n> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n> +[Documentation/SubmittingPatches][] for instructions on patch submission\n> -+and [Documentation/CodingGuidelines]() ).\n> ++and [Documentation/CodingGuidelines][]).\n> +\n> +Those wishing to help with error message translation (localization L10)\n> -+should see [po/README.md]()\n> -+(a `po` file is a portable object file for the translations).\n> ++should see [po/README.md][] (a `po` file is a Portable Object file that\n> ++holds the translations).\n> +\n> To subscribe to the list, send an email with just \"subscribe git\" in\n> -the body to majordomo@vger.kernel.org. The mailing list archives are\n> -available at ,\n> -+the body to majordomo@vger.kernel.org (not the list). The mailing list\n> -+archives are available at ,\n> ++the body to majordomo@vger.kernel.org (not the Git list). The mailing\n> ++list archives are available at ,\n> and other archival sites.\n> \n> Issues which are security relevant should be disclosed privately to\n> +@@ README.md: and the name as (depending on your mood):\n> + [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n> + [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n> + [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n> ++[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n> ++[po/README.md]: po/README.md\n> + \\ No newline at end of file\n>\n>\n> README.md | 14 +++++++++++---\n> 1 file changed, 11 insertions(+), 3 deletions(-)\n>\n> diff --git a/README.md b/README.md\n> index f6f43e78deb..d2b061e3998 100644\n> --- a/README.md\n> +++ b/README.md\n> @@ -32,10 +32,16 @@ installed).\n> The user discussion and development of Git take place on the Git\n> mailing list -- everyone is welcome to post bug reports, feature\n> requests, comments and patches to git@vger.kernel.org (read\n> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n> +[Documentation/SubmittingPatches][] for instructions on patch submission\n> +and [Documentation/CodingGuidelines][]).\n> +\n> +Those wishing to help with error message translation (localization L10)\n> +should see [po/README.md][] (a `po` file is a Portable Object file that\n> +holds the translations).\n> +\n> To subscribe to the list, send an email with just \"subscribe git\" in\n> -the body to majordomo@vger.kernel.org. The mailing list archives are\n> -available at ,\n> +the body to majordomo@vger.kernel.org (not the Git list). The mailing\n> +list archives are available at ,\n> and other archival sites.\n> \n> Issues which are security relevant should be disclosed privately to\n> @@ -64,3 +70,5 @@ and the name as (depending on your mood):\n> [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n> [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n> [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n> +[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n> +[po/README.md]: po/README.md\n> \\ No newline at end of file\n>\n> base-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n"},{"id":"446354","messageId":"6271ff4b-1821-0086-167c-b273ab252eb9@gmail.com","threadId":"57246","inReplyTo":"pull.1115.v2.git.1642349490723.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2022-01-17T09:00:32Z","receivedAt":"2022-01-17T09:00:38Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 16/01/22 23.11, Philip Oakley via GitGitGadget wrote:\n> +Those wishing to help with error message translation (localization L10)\n> +should see [po/README.md][] (a `po` file is a Portable Object file that\n> +holds the translations).\n> +\n\nI mean not just error messages are in po/*.po, but also usage and informational\nstrings. We can say \"Those wishing to help translating message strings\n(localization or l10n)...\".\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"446364","messageId":"cd22f664-a930-1850-3c62-a03f158298cc@iee.email","threadId":"57246","inReplyTo":"6271ff4b-1821-0086-167c-b273ab252eb9@gmail.com","subject":"Re: [PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-01-17T17:52:07Z","receivedAt":"2022-01-17T17:52:10Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 17/01/2022 09:00, Bagas Sanjaya wrote:\n> On 16/01/22 23.11, Philip Oakley via GitGitGadget wrote:\n>> +Those wishing to help with error message translation (localization L10)\n>> +should see [po/README.md][] (a `po` file is a Portable Object file that\n>> +holds the translations).\n>> +\n>\n> I mean not just error messages are in po/*.po, but also usage and\n> informational\n> strings. We can say \"Those wishing to help translating message strings\n> (localization or l10n)...\".\n>\nThanks, I've expended the README description.\n\nPhilip\n"},{"id":"446365","messageId":"a3f3eb72-5671-71c0-a6fb-89aa901632a7@iee.email","threadId":"57246","inReplyTo":"xmqq5yqjz4a6.fsf@gitster.g","subject":"Re: [PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley","fromEmail":"philipoakley@iee.email","sentAt":"2022-01-17T18:08:47Z","receivedAt":"2022-01-17T18:08:50Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"On 16/01/2022 22:47, Junio C Hamano wrote:\n> \"Philip Oakley via GitGitGadget\" writes:\n>\n>> From: Philip Oakley \n>>\n>> The README.md does not use the GitHub Markdown URL links [1] of\n>> [txt](url), rather the reference method [2] of trailing empty square\n>> brackets. The references themselves are listed at the foot of the\n>> document. Those footers are not shown by GitHub/GitLab rendering.\n> Thanks for tracking down the differences.\nI found an additional GitHub link for the reference method (not easy to\nfind), which I have added.\n>\n> The above only describes what we could do (i.e. use links instead of\n> reference), and how the current document is rendered (i.e. footers\n> are not shown). No changes come from the above description.\n>\n>> Also space out the list joining instructions and clarify that\n>> subscription is via the majordomo address.\n> So, seeing \"Also\" immediately after a paragraph that explains the\n> status quo confused me a lot.\n>\n> \"Spell out the instructions to join the list, and clarify that the\n> subscription is via the majordomo address\" is indeed a part of what\n> this patch does. Perhaps we need a separate paragraph _before_ this\n> \"Also\".\n>\n> So taking all together\n>\n> Before being told how to submit patches, new contributors need\n> to be told how to code for, or how to contribute translation to,\n> the project. Add references to the CodingGuidelines and the\n> README document on localization.\n>\n> Also, spell out the instructions to join the list and ...\n> \n> We use GitHub Markdown reference [2] with trailing empty square\n> brackets, to match existing text in the file. On GitHub/GitLab\n> pages, these references are not shown on the page, but it is OK\n> because they are empty. We could switch to using [text](url)\n> form [1] if we wanted to, but that is not done as part of this\n> patch.\n>\n> would be the presentation order that I would expect to be the most\n> readable. I moved the discussion between URL link and reference, as\n> it is merely a hint for future and not the core thing that needs to\n> be explained to understand the changes in this commit.\nI've taken your suggestions and added a small clarification about the\nawkward empty square bracket links, which are repeated in the README's\nfooter, but not shown on the Github rendered web page.. I also took\nBagas' text changes for the readme itself\n\nGGG V3 to follow,...\n\nThank you\n>\n> Thanks.\n>\n>\n>> [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n>> [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n>>\n>> Signed-off-by: Philip Oakley \n>> ---\n>> README.md: add CodingGuidelines and a link for Translators\n>> \n>> Also space out the list joining instructions and clarify the\n>> subscription via the majordomo address.\n>> \n>> \n>> Signed-off-by: Philip Oakley philipoakley@iee.email\n>> ===================================================\n>> \n>> cc: Philip Oakley philipoakley@iee.email cc: Junio C Hamano\n>> gitster@pobox.com cc: Jiang Xin worldhello.net@gmail.com\n>> \n>> changes since v1:\n>> \n>> * Used reference style links, rather than lnk [url] style.\n>> \n>> * added Jianf as L10 coordinator.\n>> \n>> * note: Patch is a response to a user question on the \"Git for Human\n>> Beings\" git-users list\n>> https://groups.google.com/d/msgid/git-users/aa68b9c8-4cf4-4193-8af3-79d7e3feafbbn%40googlegroups.com\n>>\n>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1115%2FPhilipOakley%2FReadme-v2\n>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1115/PhilipOakley/Readme-v2\n>> Pull-Request: https://github.com/gitgitgadget/git/pull/1115\n>>\n>> Range-diff vs v1:\n>>\n>> 1: ac6d0abbdde ! 1: 48cc30b7cc8 README.md: add CodingGuidelines and a link for Translators\n>> @@ Metadata\n>> ## Commit message ##\n>> README.md: add CodingGuidelines and a link for Translators\n>> \n>> - Also space out the list joining instructions and clarify the subscription\n>> - via the majordomo address.\n>> + The README.md does not use the GitHub Markdown URL links [1] of\n>> + [txt](url), rather the reference method [2] of trailing empty square\n>> + brackets. The references themselves are listed at the foot of the\n>> + document. Those footers are not shown by GitHub/GitLab rendering.\n>> +\n>> + Also space out the list joining instructions and clarify that\n>> + subscription is via the majordomo address.\n>> +\n>> + [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n>> + [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n>> \n>> Signed-off-by: Philip Oakley \n>> \n>> @@ README.md: installed).\n>> requests, comments and patches to git@vger.kernel.org (read\n>> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n>> +[Documentation/SubmittingPatches][] for instructions on patch submission\n>> -+and [Documentation/CodingGuidelines]() ).\n>> ++and [Documentation/CodingGuidelines][]).\n>> +\n>> +Those wishing to help with error message translation (localization L10)\n>> -+should see [po/README.md]()\n>> -+(a `po` file is a portable object file for the translations).\n>> ++should see [po/README.md][] (a `po` file is a Portable Object file that\n>> ++holds the translations).\n>> +\n>> To subscribe to the list, send an email with just \"subscribe git\" in\n>> -the body to majordomo@vger.kernel.org. The mailing list archives are\n>> -available at ,\n>> -+the body to majordomo@vger.kernel.org (not the list). The mailing list\n>> -+archives are available at ,\n>> ++the body to majordomo@vger.kernel.org (not the Git list). The mailing\n>> ++list archives are available at ,\n>> and other archival sites.\n>> \n>> Issues which are security relevant should be disclosed privately to\n>> +@@ README.md: and the name as (depending on your mood):\n>> + [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n>> + [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n>> + [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n>> ++[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n>> ++[po/README.md]: po/README.md\n>> + \\ No newline at end of file\n>>\n>>\n>> README.md | 14 +++++++++++---\n>> 1 file changed, 11 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/README.md b/README.md\n>> index f6f43e78deb..d2b061e3998 100644\n>> --- a/README.md\n>> +++ b/README.md\n>> @@ -32,10 +32,16 @@ installed).\n>> The user discussion and development of Git take place on the Git\n>> mailing list -- everyone is welcome to post bug reports, feature\n>> requests, comments and patches to git@vger.kernel.org (read\n>> -[Documentation/SubmittingPatches][] for instructions on patch submission).\n>> +[Documentation/SubmittingPatches][] for instructions on patch submission\n>> +and [Documentation/CodingGuidelines][]).\n>> +\n>> +Those wishing to help with error message translation (localization L10)\n>> +should see [po/README.md][] (a `po` file is a Portable Object file that\n>> +holds the translations).\n>> +\n>> To subscribe to the list, send an email with just \"subscribe git\" in\n>> -the body to majordomo@vger.kernel.org. The mailing list archives are\n>> -available at ,\n>> +the body to majordomo@vger.kernel.org (not the Git list). The mailing\n>> +list archives are available at ,\n>> and other archival sites.\n>> \n>> Issues which are security relevant should be disclosed privately to\n>> @@ -64,3 +70,5 @@ and the name as (depending on your mood):\n>> [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n>> [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n>> [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n>> +[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n>> +[po/README.md]: po/README.md\n>> \\ No newline at end of file\n>>\n>> base-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n\n"},{"id":"446367","messageId":"pull.1115.v3.git.1642443491609.gitgitgadget@gmail.com","threadId":"57246","inReplyTo":"pull.1115.v2.git.1642349490723.gitgitgadget@gmail.com","subject":"[PATCH v3] README.md: add CodingGuidelines and a link for Translators","fromName":"Philip Oakley via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-01-17T18:18:11Z","receivedAt":"2022-01-17T18:18:17Z","isPatch":true,"sender":{"key":"philipoakley@iee.email","avatar":"https://avatars.githubusercontent.com/u/914343?v=4"},"body":"From: Philip Oakley \n\nBefore being told how to submit patches, new contributors need\nto be told how to code for, or how to contribute translation to,\nthe project. Add references to the CodingGuidelines and the\nREADME document on localization.\n\nAlso, split out the instructions to join the list and clarify\nthat subscription is via the majordomo address.\n\nWe use GitHub Markdown reference [2,3] with trailing empty square\nbrackets, to match existing text in the file. On GitHub/GitLab\npages, the footer references matching the empty [] are not shown\non the web page. We could switch to using [text](url) form [1]\nif we wanted to, but that is not done as part of this patch.\n\n[1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n[2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n[3] https://github.github.com/gfm/#example-561 (and the para aboveit)\n\nSigned-off-by: Philip Oakley \n---\n README.md: add CodingGuidelines and a link for Translators\n \n Also space out the list joining instructions and clarify the\n subscription via the majordomo address.\n \n Signed-off-by: Philip Oakley philipoakley@iee.email\n \n cc: Philip Oakley philipoakley@iee.email cc: Junio C Hamano\n gitster@pobox.com cc: Jiang Xin worldhello.net@gmail.com cc: Bagas\n Sanjaya bagasdotme@gmail.com\n \n changes since V2:\n \n * extended the translation 'messages' description\n * updated commit message based on Junio's suggestion\n \n changes since v1:\n \n * Used reference style links, rather than lnk [url] style.\n \n * added Jiang as L10 coordinator.\n \n * note: Patch is a response to a user question on the \"Git for Human\n Beings\" git-users list\n https://groups.google.com/d/msgid/git-users/aa68b9c8-4cf4-4193-8af3-79d7e3feafbbn%40googlegroups.com\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1115%2FPhilipOakley%2FReadme-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1115/PhilipOakley/Readme-v3\nPull-Request: https://github.com/gitgitgadget/git/pull/1115\n\nRange-diff vs v2:\n\n 1: 48cc30b7cc8 ! 1: 953a38091ac README.md: add CodingGuidelines and a link for Translators\n @@ Metadata\n ## Commit message ##\n README.md: add CodingGuidelines and a link for Translators\n \n - The README.md does not use the GitHub Markdown URL links [1] of\n - [txt](url), rather the reference method [2] of trailing empty square\n - brackets. The references themselves are listed at the foot of the\n - document. Those footers are not shown by GitHub/GitLab rendering.\n + Before being told how to submit patches, new contributors need\n + to be told how to code for, or how to contribute translation to,\n + the project. Add references to the CodingGuidelines and the\n + README document on localization.\n \n - Also space out the list joining instructions and clarify that\n - subscription is via the majordomo address.\n + Also, split out the instructions to join the list and clarify\n + that subscription is via the majordomo address.\n +\n + We use GitHub Markdown reference [2,3] with trailing empty square\n + brackets, to match existing text in the file. On GitHub/GitLab\n + pages, the footer references matching the empty [] are not shown\n + on the web page. We could switch to using [text](url) form [1]\n + if we wanted to, but that is not done as part of this patch.\n \n [1] https://docs.github.com/en/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links\n [2] https://gist.github.com/ChrisTollefson/a3af6d902a74a0afd1c2d79aadc9bb3f#reference-links\n + [3] https://github.github.com/gfm/#example-561 (and the para aboveit)\n \n Signed-off-by: Philip Oakley \n \n @@ README.md: installed).\n +[Documentation/SubmittingPatches][] for instructions on patch submission\n +and [Documentation/CodingGuidelines][]).\n +\n -+Those wishing to help with error message translation (localization L10)\n -+should see [po/README.md][] (a `po` file is a Portable Object file that\n -+holds the translations).\n ++Those wishing to help with error message, usage and informational message\n ++string translations (localization l10) should see [po/README.md][]\n ++(a `po` file is a Portable Object file that holds the translations).\n +\n To subscribe to the list, send an email with just \"subscribe git\" in\n -the body to majordomo@vger.kernel.org. The mailing list archives are\n @@ README.md: and the name as (depending on your mood):\n [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n +[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n +[po/README.md]: po/README.md\n - \\ No newline at end of file\n\n\n README.md | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)\n\ndiff --git a/README.md b/README.md\nindex f6f43e78deb..7ce4f05bae8 100644\n--- a/README.md\n+++ b/README.md\n@@ -32,10 +32,16 @@ installed).\n The user discussion and development of Git take place on the Git\n mailing list -- everyone is welcome to post bug reports, feature\n requests, comments and patches to git@vger.kernel.org (read\n-[Documentation/SubmittingPatches][] for instructions on patch submission).\n+[Documentation/SubmittingPatches][] for instructions on patch submission\n+and [Documentation/CodingGuidelines][]).\n+\n+Those wishing to help with error message, usage and informational message\n+string translations (localization l10) should see [po/README.md][]\n+(a `po` file is a Portable Object file that holds the translations).\n+\n To subscribe to the list, send an email with just \"subscribe git\" in\n-the body to majordomo@vger.kernel.org. The mailing list archives are\n-available at ,\n+the body to majordomo@vger.kernel.org (not the Git list). The mailing\n+list archives are available at ,\n and other archival sites.\n \n Issues which are security relevant should be disclosed privately to\n@@ -64,3 +70,5 @@ and the name as (depending on your mood):\n [Documentation/giteveryday.txt]: Documentation/giteveryday.txt\n [Documentation/gitcvs-migration.txt]: Documentation/gitcvs-migration.txt\n [Documentation/SubmittingPatches]: Documentation/SubmittingPatches\n+[Documentation/CodingGuidelines]: Documentation/CodingGuidelines\n+[po/README.md]: po/README.md\n\nbase-commit: 1ffcbaa1a5f10c9f706314d77f88de20a4a498c2\n-- \ngitgitgadget\n"},{"id":"446374","messageId":"xmqqtue2uri8.fsf@gitster.g","threadId":"57246","inReplyTo":"6271ff4b-1821-0086-167c-b273ab252eb9@gmail.com","subject":"Re: [PATCH v2] README.md: add CodingGuidelines and a link for Translators","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-17T18:49:35Z","receivedAt":"2022-01-17T18:49:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bagas Sanjaya writes:\n\n> On 16/01/22 23.11, Philip Oakley via GitGitGadget wrote:\n>> +Those wishing to help with error message translation (localization L10)\n>> +should see [po/README.md][] (a `po` file is a Portable Object file that\n>> +holds the translations).\n>> +\n>\n> I mean not just error messages are in po/*.po, but also usage and informational\n> strings. We can say \"Those wishing to help translating message strings\n> (localization or l10n)...\".\n\nYup, that sounds more correct.\n\nThanks.\n"}]}