{"thread":{"id":"57245","subject":"[PATCH] leak tests: ignore some new leaks in a few tests","startedAt":"2022-01-14T16:07:16Z","lastAt":"2022-01-18T16:50:00Z","messageCount":2,"participants":["Elijah Newren via GitGitGadget","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"446228","messageId":"pull.1192.git.git.1642176433017.gitgitgadget@gmail.com","threadId":"57245","inReplyTo":null,"subject":"[PATCH] leak tests: ignore some new leaks in a few tests","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2022-01-14T16:07:12Z","receivedAt":"2022-01-14T16:07:16Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren <newren@gmail.com>\n\nThese test scripts have not changed at all recently, but topics in seen\nhave caused these to trigger the linux-leaks test.  It has been reported\non list, so let's fix the claim that these are leak free and when\nsomeone investigates and fixes the problem, they can turn it back on.\n\nSigned-off-by: Elijah Newren <newren@gmail.com>\n---\n    leak tests: ignore some new leaks in a few tests\n    \n    linux-leaks passes when 'seen' is merged with this topic. A better fix\n    is probably to bisect to determine which topic caused the memory leak\n    and plug the leak in that topic (because these test scripts did not have\n    any changes since the version when they previously passed), but a couple\n    of quotes:\n    \n    \"\"\" This is sort of water under the bridge, as the other topic is\n    already in 'master', but come to think of it, the strategy we used with\n    TEST_PASSES_SANITIZE_LEAK variable was misguided.\n    ... I am tempted to drop the \"TEST_PASSES\" bit from this script for now,\n    \"\"\" (from https://lore.kernel.org/git/xmqqee6dz5s9.fsf@gitster.g/)\n    \n    \"\"\" But as to the \"roadblock\" I don't mind the\n    TEST_PASSES_SANITIZE_LEAK=true being removed from the script at the\n    slightest sign of trouble. Nobody should have to shift gears and chase\n    down some memory leak... \"\"\" (from\n    https://lore.kernel.org/git/211217.86a6gyyihr.gmgdl@evledraar.gmail.com/)\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1192%2Fnewren%2Fignore-leaks-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1192/newren/ignore-leaks-v1\nPull-Request: https://github.com/git/git/pull/1192\n\n t/t1430-bad-ref-name.sh                | 1 -\n t/t3211-peel-ref.sh                    | 1 -\n t/t6102-rev-list-unexpected-objects.sh | 1 -\n 3 files changed, 3 deletions(-)\n\ndiff --git a/t/t1430-bad-ref-name.sh b/t/t1430-bad-ref-name.sh\nindex ff1c967d550..a3c689819fa 100755\n--- a/t/t1430-bad-ref-name.sh\n+++ b/t/t1430-bad-ref-name.sh\n@@ -4,7 +4,6 @@ test_description='Test handling of ref names that check-ref-format rejects'\n GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main\n export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n \n-TEST_PASSES_SANITIZE_LEAK=true\n . ./test-lib.sh\n \n test_expect_success setup '\ndiff --git a/t/t3211-peel-ref.sh b/t/t3211-peel-ref.sh\nindex 9cbc34fc583..37b9d26f4b6 100755\n--- a/t/t3211-peel-ref.sh\n+++ b/t/t3211-peel-ref.sh\n@@ -4,7 +4,6 @@ test_description='tests for the peel_ref optimization of packed-refs'\n GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main\n export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n \n-TEST_PASSES_SANITIZE_LEAK=true\n . ./test-lib.sh\n \n test_expect_success 'create annotated tag in refs/tags' '\ndiff --git a/t/t6102-rev-list-unexpected-objects.sh b/t/t6102-rev-list-unexpected-objects.sh\nindex 6f0902b8638..52cde097dd5 100755\n--- a/t/t6102-rev-list-unexpected-objects.sh\n+++ b/t/t6102-rev-list-unexpected-objects.sh\n@@ -2,7 +2,6 @@\n \n test_description='git rev-list should handle unexpected object types'\n \n-TEST_PASSES_SANITIZE_LEAK=true\n . ./test-lib.sh\n \n test_expect_success 'setup well-formed objects' '\n\nbase-commit: 5ae4b10f85c8c2c00910cc805458c5c5464841e3\n-- \ngitgitgadget\n"},{"id":"446430","messageId":"YebvtSsivC9vGAbX@nand.local","threadId":"57245","inReplyTo":"pull.1192.git.git.1642176433017.gitgitgadget@gmail.com","subject":"Re: [PATCH] leak tests: ignore some new leaks in a few tests","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2022-01-18T16:49:57Z","receivedAt":"2022-01-18T16:50:00Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Jan 14, 2022 at 04:07:12PM +0000, Elijah Newren via GitGitGadget wrote:\n> From: Elijah Newren <newren@gmail.com>\n>\n> These test scripts have not changed at all recently, but topics in seen\n> have caused these to trigger the linux-leaks test.  It has been reported\n> on list, so let's fix the claim that these are leak free and when\n> someone investigates and fixes the problem, they can turn it back on.\n\nI think this problem was likely introduced by a faulty patch in\nc2dbe00466 (Merge branch\n'ps/avoid-unnecessary-hook-invocation-with-packed-refs' into seen,\n2022-01-12), specifically 2e6b34bb1b (refs: open-code deletion of packed\nrefs, 2022-01-07).\n\nBut the newer version 69840cc0f7 of the same patch (merged via\n17d1824959) fixes the leak. As a result, all three of those once-failing\ntests now pass on 'seen' even when built with SANITIZE=leak.\n\nWe should be able to discard this patch as a result.\n\nThanks,\nTaylor\n"}]}