{"thread":{"id":"57170","subject":"[PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does","startedAt":"2021-12-31T05:15:08Z","lastAt":"2022-01-04T01:48:21Z","messageCount":4,"participants":["Elijah Newren via GitGitGadget","Johannes Schindelin","Junio C Hamano","Elijah Newren"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"445278","messageId":"pull.1177.git.git.1640927702745.gitgitgadget@gmail.com","threadId":"57170","inReplyTo":null,"subject":"[PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does","fromName":"Elijah Newren via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-31T05:15:02Z","receivedAt":"2021-12-31T05:15:08Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"From: Elijah Newren \n\nSigned-off-by: Elijah Newren \n---\n t4126: this test does not pass SANITIZE_LEAK; quit claiming it does\n \n My builds in several different topics keep running into this, and I'm\n sure it's a false positive -- I didn't change anything affecting this\n test. I've just been ignoring it and submitting anyway, and I suspect\n others are too.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1177%2Fnewren%2Ft4126-apply-empty-is-not-leak-free-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1177/newren/t4126-apply-empty-is-not-leak-free-v1\nPull-Request: https://github.com/git/git/pull/1177\n\n t/t4126-apply-empty.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/t/t4126-apply-empty.sh b/t/t4126-apply-empty.sh\nindex 82284d2f45d..ebbac79f20e 100755\n--- a/t/t4126-apply-empty.sh\n+++ b/t/t4126-apply-empty.sh\n@@ -3,7 +3,6 @@\n test_description='apply empty'\n \n \n-TEST_PASSES_SANITIZE_LEAK=true\n . ./test-lib.sh\n \n test_expect_success setup '\n\nbase-commit: 2ae0a9cb8298185a94e5998086f380a355dd8907\n-- \ngitgitgadget\n"},{"id":"445322","messageId":"nycvar.QRO.7.76.6.2201020012010.7076@tvgsbejvaqbjf.bet","threadId":"57170","inReplyTo":"pull.1177.git.git.1640927702745.gitgitgadget@gmail.com","subject":"Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2022-01-01T23:17:40Z","receivedAt":"2022-01-01T23:17:45Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Elijah,\n\nOn Fri, 31 Dec 2021, Elijah Newren via GitGitGadget wrote:\n\n> From: Elijah Newren \n>\n> Signed-off-by: Elijah Newren \n> ---\n> t4126: this test does not pass SANITIZE_LEAK; quit claiming it does\n>\n> My builds in several different topics keep running into this, and I'm\n> sure it's a false positive -- I didn't change anything affecting this\n> test. I've just been ignoring it and submitting anyway, and I suspect\n> others are too.\n\nSo that's what is causing this. Thank you for chasing it down, it has been\non my TO-DO list e.g. due to\nhttps://github.com/git-for-windows/git/runs/4622790431?check_suite_focus=true#step:5:146\n\nGiven that it points to a leak in `cmd_format_patch()` (oh no, we're\n_LEAKING_ some _MEMORY_ in a built-in, how did that ever happen, we must\nfree it before... *checks notes* ... wait, we're quitting immediately\nafter this function anyway? ) I wonder whether the disruption\ncaused by `linux-leaks` should really be considered worth the benefit.\n\nAnyway. Thank you for the patch!\n\nCiao,\nDscho\n"},{"id":"445323","messageId":"xmqqtuenkk4k.fsf@gitster.g","threadId":"57170","inReplyTo":"pull.1177.git.git.1640927702745.gitgitgadget@gmail.com","subject":"Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2022-01-02T01:21:31Z","receivedAt":"2022-01-02T01:21:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Elijah Newren via GitGitGadget\" writes:\n\n> From: Elijah Newren \n>\n> Signed-off-by: Elijah Newren \n> ---\n> t4126: this test does not pass SANITIZE_LEAK; quit claiming it does\n\nIs this continuation of [*1*]?\n\nI think it will go away when dee839a2 (format-patch: mark\nrev_info with UNLEAK, 2021-12-16) is merged.\n\n\n[Reference]\n\n*1* https://lore.kernel.org/git/xmqqee6dz5s9.fsf@gitster.g/\n"},{"id":"445375","messageId":"CABPp-BF9XpxE2wLgAzZe0CR3NAAw0R9im4HBBm=BgirpNZOpAA@mail.gmail.com","threadId":"57170","inReplyTo":"xmqqtuenkk4k.fsf@gitster.g","subject":"Re: [PATCH] t4126: this test does not pass SANITIZE_LEAK; quit claiming it does","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2022-01-04T01:48:07Z","receivedAt":"2022-01-04T01:48:21Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sat, Jan 1, 2022 at 5:21 PM Junio C Hamano wrote:\n>\n> \"Elijah Newren via GitGitGadget\" writes:\n>\n> > From: Elijah Newren \n> >\n> > Signed-off-by: Elijah Newren \n> > ---\n> > t4126: this test does not pass SANITIZE_LEAK; quit claiming it does\n>\n> Is this continuation of [*1*]?\n\nAh, yes it is.\n\n> I think it will go away when dee839a2 (format-patch: mark\n> rev_info with UNLEAK, 2021-12-16) is merged.\n\nCan we fast track that patch? The patch looks good to me. In\ngeneral, though, I would think the simpler fix of just removing the\nTEST_PASSES_SANITIZE_LEAK=true would be safer and could be fast\ntracked.\n\nI'm sorry I missed these potential problems cropping up when I\nreviewed the earlier series (which added these flags to a bunch of\nscripts). I just didn't foresee these consequences.\n"}]}