{"thread":{"id":"57138","subject":"[PATCH 0/4] Reftable test fixes 20211221","startedAt":"2021-12-22T10:59:48Z","lastAt":"2022-01-10T18:29:54Z","messageCount":9,"participants":["Han-Wen Nienhuys via GitGitGadget","Junio C Hamano","Bagas Sanjaya","Han-Wen Nienhuys"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"444759","messageId":"pull.1168.git.git.1640170784.gitgitgadget@gmail.com","threadId":"57138","inReplyTo":null,"subject":"[PATCH 0/4] Reftable test fixes 20211221","fromName":"Han-Wen Nienhuys via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-22T10:59:40Z","receivedAt":"2021-12-22T10:59:48Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"this is an assorted set of fixes to make some tests pass with reftable.\n\nHan-Wen Nienhuys (4):\n  t5540: require REFFILES\n  t5550: require REFFILES\n  t7004: create separate tags for different tests\n  t7004: use \"test-tool ref-store\" for reflog inspection\n\n t/t5540-http-push-webdav.sh |  6 ++++++\n t/t5550-http-fetch-dumb.sh  |  7 +++++++\n t/t7004-tag.sh              | 22 +++++++++++-----------\n 3 files changed, 24 insertions(+), 11 deletions(-)\n\n\nbase-commit: 69a9c10c95e28df457e33b3c7400b16caf2e2962\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1168%2Fhanwen%2Freftable-test-fixes-20211221-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1168/hanwen/reftable-test-fixes-20211221-v1\nPull-Request: https://github.com/git/git/pull/1168\n-- \ngitgitgadget\n"},{"id":"444760","messageId":"e0d7dbf8b552381a9b7854f2bb9eff41508aac04.1640170784.git.gitgitgadget@gmail.com","threadId":"57138","inReplyTo":"pull.1168.git.git.1640170784.gitgitgadget@gmail.com","subject":"[PATCH 1/4] t5540: require REFFILES","fromName":"Han-Wen Nienhuys via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-22T10:59:41Z","receivedAt":"2021-12-22T10:59:50Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"From: Han-Wen Nienhuys <hanwen@google.com>\n\nThe dumb HTTP protocol exposes ref storage details as part of the protocol,\nso it only works with the FILES refstorage backend\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@google.com>\n---\n t/t5540-http-push-webdav.sh | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/t/t5540-http-push-webdav.sh b/t/t5540-http-push-webdav.sh\nindex 8b68bb38a44..b0dbacf0b9b 100755\n--- a/t/t5540-http-push-webdav.sh\n+++ b/t/t5540-http-push-webdav.sh\n@@ -18,6 +18,12 @@ then\n \ttest_done\n fi\n \n+if test_have_prereq !REFFILES\n+then\n+\tskip_all='skipping test; dumb HTTP protocol not supported with reftable.'\n+\ttest_done\n+fi\n+\n LIB_HTTPD_DAV=t\n . \"$TEST_DIRECTORY\"/lib-httpd.sh\n ROOT_PATH=\"$PWD\"\n-- \ngitgitgadget\n\n"},{"id":"444761","messageId":"36758f8cda3da4a53cbdff3af2eac3a60aadd692.1640170784.git.gitgitgadget@gmail.com","threadId":"57138","inReplyTo":"pull.1168.git.git.1640170784.gitgitgadget@gmail.com","subject":"[PATCH 2/4] t5550: require REFFILES","fromName":"Han-Wen Nienhuys via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-22T10:59:42Z","receivedAt":"2021-12-22T10:59:53Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"From: Han-Wen Nienhuys <hanwen@google.com>\n\nThe dumb HTTP protocol exposes ref storage details as part of the protocol,\nso it only works with the FILES refstorage backend\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@google.com>\n---\n t/t5550-http-fetch-dumb.sh | 7 +++++++\n 1 file changed, 7 insertions(+)\n\ndiff --git a/t/t5550-http-fetch-dumb.sh b/t/t5550-http-fetch-dumb.sh\nindex 6d9142afc3b..259203926a9 100755\n--- a/t/t5550-http-fetch-dumb.sh\n+++ b/t/t5550-http-fetch-dumb.sh\n@@ -5,6 +5,13 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main\n export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME\n \n . ./test-lib.sh\n+\n+if test_have_prereq !REFFILES\n+then\n+\tskip_all='skipping test; dumb HTTP protocol not supported with reftable.'\n+\ttest_done\n+fi\n+\n . \"$TEST_DIRECTORY\"/lib-httpd.sh\n start_httpd\n \n-- \ngitgitgadget\n\n"},{"id":"444762","messageId":"854bd15787618978b2da3941b5b749dadc1a186f.1640170784.git.gitgitgadget@gmail.com","threadId":"57138","inReplyTo":"pull.1168.git.git.1640170784.gitgitgadget@gmail.com","subject":"[PATCH 3/4] t7004: create separate tags for different tests","fromName":"Han-Wen Nienhuys via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-22T10:59:43Z","receivedAt":"2021-12-22T10:59:54Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"From: Han-Wen Nienhuys <hanwen@google.com>\n\nReftable intentionally keeps reflog data for deleted refs.\n\nThis breaks tests that delete and recreate \"refs/tags/tag_with_reflog\" as traces\nof the deletion are left in reflog. To resolve this, use a differently named ref\nfor each test case.\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@google.com>\n---\n t/t7004-tag.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\nindex 082be85dffc..301d1190482 100755\n--- a/t/t7004-tag.sh\n+++ b/t/t7004-tag.sh\n@@ -94,10 +94,10 @@ test_expect_success 'creating a tag with --create-reflog should create reflog' '\n \tgit log -1 \\\n \t\t--format=\"format:tag: tagging %h (%s, %cd)%n\" \\\n \t\t--date=format:%Y-%m-%d >expected &&\n-\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n-\tgit tag --create-reflog tag_with_reflog &&\n-\tgit reflog exists refs/tags/tag_with_reflog &&\n-\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog >actual &&\n+\ttest_when_finished \"git tag -d tag_with_reflog1\" &&\n+\tgit tag --create-reflog tag_with_reflog1 &&\n+\tgit reflog exists refs/tags/tag_with_reflog1 &&\n+\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog1 >actual &&\n \ttest_cmp expected actual\n '\n \n@@ -105,10 +105,10 @@ test_expect_success 'annotated tag with --create-reflog has correct message' '\n \tgit log -1 \\\n \t\t--format=\"format:tag: tagging %h (%s, %cd)%n\" \\\n \t\t--date=format:%Y-%m-%d >expected &&\n-\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n-\tgit tag -m \"annotated tag\" --create-reflog tag_with_reflog &&\n-\tgit reflog exists refs/tags/tag_with_reflog &&\n-\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog >actual &&\n+\ttest_when_finished \"git tag -d tag_with_reflog2\" &&\n+\tgit tag -m \"annotated tag\" --create-reflog tag_with_reflog2 &&\n+\tgit reflog exists refs/tags/tag_with_reflog2 &&\n+\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog2 >actual &&\n \ttest_cmp expected actual\n '\n \n@@ -118,10 +118,10 @@ test_expect_success '--create-reflog does not create reflog on failure' '\n '\n \n test_expect_success 'option core.logAllRefUpdates=always creates reflog' '\n-\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n+\ttest_when_finished \"git tag -d tag_with_reflog3\" &&\n \ttest_config core.logAllRefUpdates always &&\n-\tgit tag tag_with_reflog &&\n-\tgit reflog exists refs/tags/tag_with_reflog\n+\tgit tag tag_with_reflog3 &&\n+\tgit reflog exists refs/tags/tag_with_reflog3\n '\n \n test_expect_success 'listing all tags if one exists should succeed' '\n-- \ngitgitgadget\n\n"},{"id":"444763","messageId":"5d693273e5852ae9b302cb79e8dd986b6ffa10da.1640170784.git.gitgitgadget@gmail.com","threadId":"57138","inReplyTo":"pull.1168.git.git.1640170784.gitgitgadget@gmail.com","subject":"[PATCH 4/4] t7004: use \"test-tool ref-store\" for reflog inspection","fromName":"Han-Wen Nienhuys via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2021-12-22T10:59:44Z","receivedAt":"2021-12-22T10:59:56Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"From: Han-Wen Nienhuys <hanwen@google.com>\n\nThis makes the test work with reftable.\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@google.com>\n---\n t/t7004-tag.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\nindex 301d1190482..bc8a221b2c7 100755\n--- a/t/t7004-tag.sh\n+++ b/t/t7004-tag.sh\n@@ -97,7 +97,7 @@ test_expect_success 'creating a tag with --create-reflog should create reflog' '\n \ttest_when_finished \"git tag -d tag_with_reflog1\" &&\n \tgit tag --create-reflog tag_with_reflog1 &&\n \tgit reflog exists refs/tags/tag_with_reflog1 &&\n-\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog1 >actual &&\n+\ttest-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog1 | sed -e \"s/^.*\t//\" >actual &&\n \ttest_cmp expected actual\n '\n \n@@ -108,7 +108,7 @@ test_expect_success 'annotated tag with --create-reflog has correct message' '\n \ttest_when_finished \"git tag -d tag_with_reflog2\" &&\n \tgit tag -m \"annotated tag\" --create-reflog tag_with_reflog2 &&\n \tgit reflog exists refs/tags/tag_with_reflog2 &&\n-\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog2 >actual &&\n+\ttest-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog2 | sed -e \"s/^.*\t//\" >actual &&\n \ttest_cmp expected actual\n '\n \n-- \ngitgitgadget\n"},{"id":"444821","messageId":"xmqqo858ien8.fsf@gitster.g","threadId":"57138","inReplyTo":"854bd15787618978b2da3941b5b749dadc1a186f.1640170784.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 3/4] t7004: create separate tags for different tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-22T20:11:07Z","receivedAt":"2021-12-22T20:11:13Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Han-Wen Nienhuys via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Han-Wen Nienhuys <hanwen@google.com>\n>\n> Reftable intentionally keeps reflog data for deleted refs.\n>\n> This breaks tests that delete and recreate \"refs/tags/tag_with_reflog\" as traces\n> of the deletion are left in reflog. To resolve this, use a differently named ref\n> for each test case.\n>\n> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>\n> ---\n\nMakes sense.  \n\nThese tests are *not* trying to see if a ref is recreated, its logs\nwill reflect only the events after the last such recreation event.\n\nThe only thing they care about is that the logs record the events\nafter the ref was created the last time.\n\nHmmm, is it?  After spelling it out like the above to make sure I\nunderstand the argument, I am not so sure.  If these tests are\nsurprised to see reflog entries from the previous life, it will\ncertainly surprise users and their tools if we suddenly start\nshowing them without being told.  Their expectation is that a\ndeletion and recreation is a life resetting event for a ref.\n\nIt feels as if we would need a new option in reflog traversal to\ntake advantage of the new capability reftable offers (i.e. \"git\nreflog --show-previous-life\"), which, use of it is an error if the\nbackend does not support it.  An alternative is to document it, when\nreftable integration happens, as a limitation of files-backend that\nit cannot store or show the logs of the ref from its previous life.\n\nI do not care too deeply about it either way right now, because this\npatch allows us sidestep the design issue altogether in this test\nscript.  But we need to think about it when integrating the reftable\nbackend into refs API.\n\nThanks.\n\n>  t/t7004-tag.sh | 22 +++++++++++-----------\n>  1 file changed, 11 insertions(+), 11 deletions(-)\n>\n> diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh\n> index 082be85dffc..301d1190482 100755\n> --- a/t/t7004-tag.sh\n> +++ b/t/t7004-tag.sh\n> @@ -94,10 +94,10 @@ test_expect_success 'creating a tag with --create-reflog should create reflog' '\n>  \tgit log -1 \\\n>  \t\t--format=\"format:tag: tagging %h (%s, %cd)%n\" \\\n>  \t\t--date=format:%Y-%m-%d >expected &&\n> -\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n> -\tgit tag --create-reflog tag_with_reflog &&\n> -\tgit reflog exists refs/tags/tag_with_reflog &&\n> -\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog >actual &&\n> +\ttest_when_finished \"git tag -d tag_with_reflog1\" &&\n> +\tgit tag --create-reflog tag_with_reflog1 &&\n> +\tgit reflog exists refs/tags/tag_with_reflog1 &&\n> +\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog1 >actual &&\n>  \ttest_cmp expected actual\n>  '\n>  \n> @@ -105,10 +105,10 @@ test_expect_success 'annotated tag with --create-reflog has correct message' '\n>  \tgit log -1 \\\n>  \t\t--format=\"format:tag: tagging %h (%s, %cd)%n\" \\\n>  \t\t--date=format:%Y-%m-%d >expected &&\n> -\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n> -\tgit tag -m \"annotated tag\" --create-reflog tag_with_reflog &&\n> -\tgit reflog exists refs/tags/tag_with_reflog &&\n> -\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog >actual &&\n> +\ttest_when_finished \"git tag -d tag_with_reflog2\" &&\n> +\tgit tag -m \"annotated tag\" --create-reflog tag_with_reflog2 &&\n> +\tgit reflog exists refs/tags/tag_with_reflog2 &&\n> +\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog2 >actual &&\n>  \ttest_cmp expected actual\n>  '\n>  \n> @@ -118,10 +118,10 @@ test_expect_success '--create-reflog does not create reflog on failure' '\n>  '\n>  \n>  test_expect_success 'option core.logAllRefUpdates=always creates reflog' '\n> -\ttest_when_finished \"git tag -d tag_with_reflog\" &&\n> +\ttest_when_finished \"git tag -d tag_with_reflog3\" &&\n>  \ttest_config core.logAllRefUpdates always &&\n> -\tgit tag tag_with_reflog &&\n> -\tgit reflog exists refs/tags/tag_with_reflog\n> +\tgit tag tag_with_reflog3 &&\n> +\tgit reflog exists refs/tags/tag_with_reflog3\n>  '\n>  \n>  test_expect_success 'listing all tags if one exists should succeed' '\n"},{"id":"444822","messageId":"xmqqfsqkied9.fsf@gitster.g","threadId":"57138","inReplyTo":"5d693273e5852ae9b302cb79e8dd986b6ffa10da.1640170784.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 4/4] t7004: use \"test-tool ref-store\" for reflog inspection","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2021-12-22T20:17:06Z","receivedAt":"2021-12-22T20:17:10Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Han-Wen Nienhuys via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Han-Wen Nienhuys <hanwen@google.com>\n>\n> This makes the test work with reftable.\n>\n> Signed-off-by: Han-Wen Nienhuys <hanwen@google.com>\n> ...\n> -\tsed -e \"s/^.*\t//\" .git/logs/refs/tags/tag_with_reflog2 >actual &&\n> +\ttest-tool ref-store main for-each-reflog-ent refs/tags/tag_with_reflog2 | sed -e \"s/^.*\t//\" >actual &&\n>  \ttest_cmp expected actual\n>  '\n\nYup, this makes perfect sense.  Purists may be bothered by having\nanything _we_ write, like \"test-tool\" on the upstream of a pipe to\nhide its exit code, though.\n\nAfter applying these four patches on top of 'master', I still see\nsome mention of logs/refs in the t/ directory.  Some of them may\nbe a low-hanging fruit other people can take a look at and convert\nto the test-helper calls to help us move the reftable topic forward\nwithout stepping on your toes, hopefully?\n\nThanks.\n\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/bisect/foo     .git/logs/refs/bisect/foo\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs                bar/logs/refs\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/               bar/logs/refs/\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/bisec/foo      bar/logs/refs/bisec/foo\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/bisec          bar/logs/refs/bisec\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/bisectfoo      bar/logs/refs/bisectfoo\nt/t0060-path-utils.sh:test_git_path GIT_COMMON_DIR=bar logs/refs/heads/main     bar/logs/refs/heads/main\nt/t1301-shared-repo.sh:\tactual=\"$(ls -l .git/logs/refs/heads/main)\" &&\nt/t1301-shared-repo.sh:\t\techo Ooops, .git/logs/refs/heads/main is not 066x [$actual]\nt/t1400-update-ref.sh:rm -f .git/logs/refs/heads/main\nt/t1400-update-ref.sh:\ttest_path_is_file .git/logs/refs/heads/d1/d2/r1 &&\nt/t1400-update-ref.sh:\ttest_must_fail git show-ref --verify -q logs/refs/heads/d1/d2 &&\nt/t1400-update-ref.sh:\ttest_path_is_file .git/logs/refs/heads/d1/r2\nt/t1400-update-ref.sh:\ttest_path_is_file .git/logs/refs/heads/e1/e2/r1 &&\nt/t1400-update-ref.sh:\ttest_must_fail git show-ref --verify -q logs/refs/heads/e1/e2 &&\nt/t1400-update-ref.sh:\ttest_path_is_file .git/logs/refs/heads/e1/r2 &&\nt/t1407-worktree-ref-store.sh:\tmkdir -p     .git/logs/refs/bisect &&\nt/t1407-worktree-ref-store.sh:\techo $ZERO_OID > .git/logs/refs/bisect/random &&\nt/t1407-worktree-ref-store.sh:\tmkdir -p     .git/worktrees/wt/logs/refs/bisect &&\nt/t1407-worktree-ref-store.sh:\techo $ZERO_OID > .git/worktrees/wt/logs/refs/bisect/wt-random &&\nt/t1410-reflog.sh:\t# now logs/refs/heads/one is a stale directory, but\nt/t1410-reflog.sh:\tdone >.git/logs/refs/heads/reflogskip &&\nt/t3200-branch.sh:\ttest_path_is_file .git/logs/refs/heads/d/e/f &&\nt/t3200-branch.sh:\ttest_cmp expect .git/logs/refs/heads/d/e/f\nt/t3200-branch.sh:\tmv .git/logs/refs/heads/u real-u &&\nt/t3200-branch.sh:\tln -s real-u .git/logs/refs/heads/u &&\nt/t3200-branch.sh:\ttest_path_is_file .git/logs/refs/heads/g/h/i &&\nt/t3200-branch.sh:\ttest_cmp expect .git/logs/refs/heads/g/h/i\n"},{"id":"444898","messageId":"42bde83d-65fb-d326-ec3d-4ef4121c35dc@gmail.com","threadId":"57138","inReplyTo":"e0d7dbf8b552381a9b7854f2bb9eff41508aac04.1640170784.git.gitgitgadget@gmail.com","subject":"Re: [PATCH 1/4] t5540: require REFFILES","fromName":"Bagas Sanjaya","fromEmail":"bagasdotme@gmail.com","sentAt":"2021-12-24T05:14:05Z","receivedAt":"2021-12-24T05:14:12Z","isPatch":true,"sender":{"key":"bagasdotme@gmail.com","avatar":"https://avatars.githubusercontent.com/u/40219486?v=4"},"body":"On 22/12/21 17.59, Han-Wen Nienhuys via GitGitGadget wrote:\n> +if test_have_prereq !REFFILES\n> +then\n> +\tskip_all='skipping test; dumb HTTP protocol not supported with reftable.'\n> +\ttest_done\n> +fi\n> +\n\nDid you mean reftable doesn't support dumb HTTP protocol or vice versa?\n\n-- \nAn old man doll... just what I always wanted! - Clara\n"},{"id":"445853","messageId":"CAFQ2z_MccXoZqxCJJ1Fi093mQWrt1T5FyWfG2KznO0PoxVOQFw@mail.gmail.com","threadId":"57138","inReplyTo":"42bde83d-65fb-d326-ec3d-4ef4121c35dc@gmail.com","subject":"Re: [PATCH 1/4] t5540: require REFFILES","fromName":"Han-Wen Nienhuys","fromEmail":"hanwen@google.com","sentAt":"2022-01-10T18:29:38Z","receivedAt":"2022-01-10T18:29:54Z","isPatch":true,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"On Fri, Dec 24, 2021 at 6:14 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:\n>\n> On 22/12/21 17.59, Han-Wen Nienhuys via GitGitGadget wrote:\n> > +if test_have_prereq !REFFILES\n> > +then\n> > +     skip_all='skipping test; dumb HTTP protocol not supported with reftable.'\n> > +     test_done\n> > +fi\n> > +\n>\n> Did you mean reftable doesn't support dumb HTTP protocol or vice versa?\n\nAFAIK, the 'dumb protocol' isn't really a protocol, but is simply\nexposing the file system over HTTP.\n\nI suppose we could expose the reftable files over HTTP, but that means\nwe have to rewrite the client to understand reftable files if they are\nserved. However, I get the impression that nobody really uses the dumb\nprotocol anymore, so is it worth trying to make this work for\nreftable?\n\n-- \nHan-Wen Nienhuys - Google Munich\nI work 80%. Don't expect answers from me on Fridays.\n--\n\nGoogle Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich\n\nRegistergericht und -nummer: Hamburg, HRB 86891\n\nSitz der Gesellschaft: Hamburg\n\nGeschäftsführer: Paul Manicle, Halimah DeLaine Prado\n"}]}