{"thread":{"id":"57098","subject":"[PATCH] Makefile: correct the dependency graph of hook-list.h","startedAt":"2021-12-17T00:13:07Z","lastAt":"2021-12-17T00:13:07Z","messageCount":1,"participants":["Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"444290","messageId":"patch-1.1-1fafa6c643b-20211217T001137Z-avarab@gmail.com","threadId":"57098","inReplyTo":null,"subject":"[PATCH] Makefile: correct the dependency graph of hook-list.h","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2021-12-17T00:13:01Z","receivedAt":"2021-12-17T00:13:07Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"Fix an issue in my cfe853e66be (hook-list.h: add a generated list of\nhooks, like config-list.h, 2021-09-26), the builtin/help.c was\ninadvertently made to depend on hook-list.h, but it's used by\nbuiltin/bugreport.c.\n\nThe hook.c also does not depend on hook-list.h. It did in an earlier\nversion of the greater series cfe853e66be was extracted from, but not\nanymore. We might end up needing that line again, but let's remove it\nfor now.\n\nReported-by: Mike Hommey <mh@glandium.org>\nSigned-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>\n---\n\nAs noted in [1] this is the first of smaller topics that split-up and\nreplace the ab/make-dependency topic. Range-to the previous start of\nthe series below. The v4 of the old series is at [2].\n\nFor this commit there were no changes or outstanding comments, except\nthat in [3] it was suggested that this more isolated fix by split-up\nfrom the rest.\n\n1. https://lore.kernel.org/git/211217.86a6h09km9.gmgdl@evledraar.gmail.com/\n2. https://lore.kernel.org/git/cover-v4-00.23-00000000000-20211117T101807Z-avarab@gmail.com/\n3. https://lore.kernel.org/git/0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com/\n\nRange-diff:\n 1:  1621ca72c1d <  -:  ----------- Makefile: don't invoke msgfmt with --statistics\n 2:  b7c36c9fea0 <  -:  ----------- Makefile: don't set up \"perl/build\" rules under NO_PERL=Y\n 3:  29b000eb0f1 <  -:  ----------- Makefile: use \"=\" not \":=\" for po/* and perl/*\n 4:  daead5ec293 <  -:  ----------- Makefile: clean perl/build/ even with NO_PERL=Y\n 5:  3c987590740 <  -:  ----------- Makefile: remove \"mv $@ $@+\" dance redundant to .DELETE_ON_ERROR\n 6:  b57f582ccd3 <  -:  ----------- Makefile: guard Perl-only variable assignments\n 7:  fcdee92f64c <  -:  ----------- Makefile: change \"ifndef NO_PERL\" to \"ifdef NO_PERL\"\n 8:  1e25b532ca2 <  -:  ----------- Makefile: adjust Perl-related comments & whitespace\n 9:  77d9855bfcf <  -:  ----------- Makefile: correct \"GIT-PERL-{DEFINES,HEADER}\" dependency graph\n10:  6004cdcd8d9 <  -:  ----------- Makefile: create a GIT-PYTHON-DEFINES, like \"PERL\"\n11:  17b30e96057 <  -:  ----------- Makefile: stop needing @@GIT_VERSION@@ in *.perl scripts\n12:  30ddf7da2c8 <  -:  ----------- Makefiles: add \"shared.mak\", move \".DELETE_ON_ERROR\" to it\n13:  f378a7dc35e <  -:  ----------- Makefile: move $(comma), $(empty) and $(space) to shared.mak\n14:  13cbb851d32 <  -:  ----------- Makefile: re-add and use the \"shellquote\" macros\n15:  337953e4994 <  -:  ----------- Makefile: add a \"TRACK_template\" for GIT-*{FLAGS,DEFINES,...}\n16:  5bb597c1993 <  -:  ----------- Makefile: add \"$(QUIET)\" boilerplate to shared.mak\n17:  3c4d0589667 <  -:  ----------- Makefile: use $(wspfx) for $(QUIET...) in shared.mak\n18:  be5882b2c99 <  -:  ----------- Makefiles: add and use wildcard \"mkdir -p\" template\n19:  2710f8af6cd =  1:  1fafa6c643b Makefile: correct the dependency graph of hook-list.h\n20:  59f22a0269a <  -:  ----------- Makefile: use $(file) I/O instead of \"FORCE\" when possible\n21:  dd569a59c74 <  -:  ----------- Makefile: disable GNU make built-in wildcard rules\n22:  4168a7e3b30 <  -:  ----------- Makefile: define $(LIB_H) in terms of $(FIND_SOURCE_FILES)\n23:  48a3927d972 <  -:  ----------- Makefile: move \".SUFFIXES\" rule to shared.mak\n\n Makefile | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex 9c00a793e47..710e7db89bf 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2222,9 +2222,9 @@ git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS)\n \t\t$(filter %.o,$^) $(LIBS)\n \n help.sp help.s help.o: command-list.h\n-hook.sp hook.s hook.o: hook-list.h\n+builtin/bugreport.sp builtin/bugreport.s builtin/bugreport.o: hook-list.h\n \n-builtin/help.sp builtin/help.s builtin/help.o: config-list.h hook-list.h GIT-PREFIX\n+builtin/help.sp builtin/help.s builtin/help.o: config-list.h GIT-PREFIX\n builtin/help.sp builtin/help.s builtin/help.o: EXTRA_CPPFLAGS = \\\n \t'-DGIT_HTML_PATH=\"$(htmldir_relative_SQ)\"' \\\n \t'-DGIT_MAN_PATH=\"$(mandir_relative_SQ)\"' \\\n-- \n2.34.1.1119.g7a3fc8778ee\n\n"}]}